[00:58:56] (03CR) 10Krinkle: [C: 03+2] Parse messages in string context [extensions/Echo] - 10https://gerrit.wikimedia.org/r/602881 (owner: 10Umherirrender) [01:19:02] (03Merged) 10jenkins-bot: Parse messages in string context [extensions/Echo] - 10https://gerrit.wikimedia.org/r/602881 (owner: 10Umherirrender) [06:45:37] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605486 (owner: 10L10n-bot) [07:38:31] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605486 (owner: 10L10n-bot) [07:44:18] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: When deleting StructuredDiscussion content, deleted content is misattributed to the sysop that deleted it - https://phabricator.wikimedia.org/T118024 (10Base) @MMiller_WMF , @Etonkovidova is there any progress with this task? [09:50:32] 10Growth-Team, 10GrowthExperiments, 10Performance Issue: Prevent OOUI from loading on the critical path - https://phabricator.wikimedia.org/T218591 (10kostajh) I'm looking at this now as part of a larger refactoring. The help panel CTA shows: 1. in read mode on selected namespaces (usually the user and user... [09:53:55] 10Growth-Team, 10GrowthExperiments, 10Performance Issue: Prevent unnecessary OOUI process dialog code from loading on the critical path - https://phabricator.wikimedia.org/T218591 (10kostajh) [11:05:03] (03CR) 10Jforrester: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/565045 (owner: 10Jack Phoenix) [11:27:09] (03CR) 10MSantos: [C: 03+2] Push: Check that the event type is enabled before scheduling job [extensions/Echo] - 10https://gerrit.wikimedia.org/r/605313 (owner: 10Mholloway) [11:29:00] (03CR) 10Kosta Harlan: [C: 03+1] "I've asked Marshall and Rita to look at it as well, but makes sense to me." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605399 (owner: 10Amire80) [11:30:48] (03PS3) 10Kosta Harlan: Fix help panel height [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604794 (https://phabricator.wikimedia.org/T250310) (owner: 10Gergő Tisza) [11:31:04] (03CR) 10Kosta Harlan: [C: 03+2] Fix help panel height [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604794 (https://phabricator.wikimedia.org/T250310) (owner: 10Gergő Tisza) [11:34:13] (03CR) 10Kosta Harlan: Auto-advance suggested edits guidance tabs (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604177 (https://phabricator.wikimedia.org/T253009) (owner: 10Gergő Tisza) [11:35:53] (03CR) 10Rho: [C: 03+1] Change "language" to "text" in the help panel [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605399 (owner: 10Amire80) [11:36:26] (03CR) 10Kosta Harlan: [C: 03+2] Change "language" to "text" in the help panel [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605399 (owner: 10Amire80) [11:42:42] (03CR) 10Kosta Harlan: [C: 03+2] UI fixes to suggested edit guidance screen panel header [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605283 (https://phabricator.wikimedia.org/T254514) (owner: 10Gergő Tisza) [11:48:07] (03Merged) 10jenkins-bot: Push: Check that the event type is enabled before scheduling job [extensions/Echo] - 10https://gerrit.wikimedia.org/r/605313 (owner: 10Mholloway) [11:48:09] (03Merged) 10jenkins-bot: Fix help panel height [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604794 (https://phabricator.wikimedia.org/T250310) (owner: 10Gergő Tisza) [11:59:27] (03Merged) 10jenkins-bot: Change "language" to "text" in the help panel [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605399 (owner: 10Amire80) [11:59:29] (03Merged) 10jenkins-bot: UI fixes to suggested edit guidance screen panel header [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605283 (https://phabricator.wikimedia.org/T254514) (owner: 10Gergő Tisza) [12:13:49] 10Growth-Team, 10GrowthExperiments-Help panel: Refactor help panel code - https://phabricator.wikimedia.org/T255425 (10kostajh) [12:21:24] (03PS3) 10Kosta Harlan: Help panel guidance behavior rule updates [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604659 (https://phabricator.wikimedia.org/T244431) [12:21:31] (03PS5) 10Kosta Harlan: Help panel: Refactor mode tracking & remove question poster dialog [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604704 (https://phabricator.wikimedia.org/T250235) [12:27:28] (03PS1) 10Kosta Harlan: Remove QuestionPoster module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605576 [12:29:23] (03CR) 10Kosta Harlan: "Closing the ask mentor dialog on Special:Homepage results in a duplicate "close" action, so that needs to be fixed." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605576 (owner: 10Kosta Harlan) [13:08:17] (03PS1) 10Kosta Harlan: Help panel UI fixes [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605587 (https://phabricator.wikimedia.org/T254527) [13:17:17] (03CR) 10jerkins-bot: [V: 04-1] Help panel UI fixes [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605587 (https://phabricator.wikimedia.org/T254527) (owner: 10Kosta Harlan) [13:29:42] 10Growth-Team: Deploy Growth features on Hebrew Wikipedia - https://phabricator.wikimedia.org/T255020 (10Trizek-WMF) >>! In T255020#6221842, @Amire80 wrote: > Can someone please be very kind and make the "Privacy statement" translatable like the other pages? I can even do it myself, if the team can commit to usi... [13:39:24] 10Growth-Team: Deploy Growth features on Italian Wikipedia - https://phabricator.wikimedia.org/T255037 (10Trizek-WMF) >>! In T255037#6221879, @Sakretsu wrote: > These features need a consensus to be deployed. Local discussion is now ongoing. @Sakretsu, where the discussion is happening? I may be useful there to... [13:40:14] 10Growth-Team, 10Growth-Scaling: Scale: Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, zh, he Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) [13:40:20] 10Growth-Team, 10Growth-Scaling: Scale: Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, he Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) [13:41:30] 10Growth-Team, 10Growth-Scaling: Scale: Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, he Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) Despite translations being almost done, we can't deploy on Chinese Wikipédia at the moment, since this wiki doesn't ha... [13:43:51] 10Growth-Team, 10Growth-Scaling: Scale: Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, he Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) [13:44:37] 10Growth-Team, 10Growth-Scaling: Scale: Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, he Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) [13:55:51] 10Growth-Team: Deploy Growth features on Italian Wikipedia - https://phabricator.wikimedia.org/T255037 (10ValeJappo) >>! In T255037#6224027, @Trizek-WMF wrote: > @Sakretsu, where the discussion is happening? I may be useful there to reply to some questions. https://it.wikipedia.org/wiki/Wikipedia:Bar/Discussion... [14:01:12] 10Growth-Team: Deploy Growth features on Italian Wikipedia - https://phabricator.wikimedia.org/T255037 (10Trizek-WMF) >>! In T255037#6224086, @ValeJappo wrote: >>>! In T255037#6224027, @Trizek-WMF wrote: >> @Sakretsu, where the discussion is happening? I may be useful there to reply to some questions. > > https... [15:17:15] 10Growth-Team: Deploy Growth features on Hebrew Wikipedia - https://phabricator.wikimedia.org/T255020 (10Amire80) >>! In T255020#6224010, @Trizek-WMF wrote: >>>! In T255020#6221842, @Amire80 wrote: >> Can someone please be very kind and make the "Privacy statement" translatable like the other pages? I can even d... [15:18:29] (03CR) 10Esanders: build: Update eslint-config-wikimedia to 0.16.1 (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/605331 (owner: 10Esanders) [15:20:32] (03CR) 10Esanders: "Looks like jsduck has been failing in Echo for a while (not least it tries to document ES6 files). I don't think it needs to be fixed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/605331 (owner: 10Esanders) [15:21:04] (03PS4) 10Esanders: build: Update eslint-config-wikimedia to 0.16.1 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/605331 [15:30:09] (03PS1) 10Esanders: isIPAddress: Remove unnecessary argument (default is already false) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/605613 [15:46:30] 10Growth-Team: Deploy Growth features on Hebrew Wikipedia - https://phabricator.wikimedia.org/T255020 (10Trizek-WMF) Good point. Let me ask Legal about it. [15:53:19] 10Growth-Team, 10Notifications, 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Implement Action API for equivalent of checkboxes for notification types - https://phabricator.wikimedia.org/T251462 (10Mholloway) Hi @Catrope, I'm wondering if you can help me out with some difficu... [16:10:43] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/605331 (owner: 10Esanders) [16:59:20] (03CR) 10Ammarpad: [C: 03+1] Enable thanks from pagelang and upload log [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/501522 (https://phabricator.wikimedia.org/T254992) (owner: 10Matěj Suchánek) [17:06:08] (03CR) 10Ammarpad: [C: 03+1] "I am not sure about the Page language change log, but there's no harm in adding it. For Upload, there's clear need. It's a primary action " [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/501522 (https://phabricator.wikimedia.org/T254992) (owner: 10Matěj Suchánek) [17:20:02] (03PS1) 10Esanders: Documentation whitespace fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/605626 [17:38:10] (03CR) 10DannyS712: [C: 03+2] "Thanks for splitting this out from the subsequent enforcement. Should be a no-op. LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/605626 (owner: 10Esanders) [17:58:40] (03Merged) 10jenkins-bot: Documentation whitespace fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/605626 (owner: 10Esanders) [18:53:08] (03PS2) 10Kosta Harlan: Help panel UI fixes [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605587 (https://phabricator.wikimedia.org/T254527) [19:52:57] 10Growth-Team, 10Notifications, 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Implement Action API for equivalent of checkboxes for notification types - https://phabricator.wikimedia.org/T251462 (10Mholloway) Okay, I haven't verified in the debugger but I think I see what's g... [19:55:05] (03CR) 10Kosta Harlan: [C: 04-1] "> Patch Set 4: Code-Review-1" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604177 (https://phabricator.wikimedia.org/T253009) (owner: 10Gergő Tisza) [20:19:32] (03CR) 10Gergő Tisza: [C: 03+1] "After opening and closing the help panel in read mode, it's not locked anymore. With the child patch that behavior goes away so it should " [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604659 (https://phabricator.wikimedia.org/T244431) (owner: 10Kosta Harlan) [20:28:50] (03CR) 10Gergő Tisza: "> > Loading the homepage results in TypeError: "this.taskTypeData is undefined"" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604177 (https://phabricator.wikimedia.org/T253009) (owner: 10Gergő Tisza) [20:31:00] (03CR) 10Kosta Harlan: [C: 04-1] Auto-advance suggested edits guidance tabs (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604177 (https://phabricator.wikimedia.org/T253009) (owner: 10Gergő Tisza) [20:31:34] (03PS6) 10Gergő Tisza: Auto-advance suggested edits guidance tabs [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604177 (https://phabricator.wikimedia.org/T253009) [20:32:35] (03CR) 10Gergő Tisza: [C: 04-1] "Manual rebase, not fixed yet." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604177 (https://phabricator.wikimedia.org/T253009) (owner: 10Gergő Tisza) [20:42:24] (03PS1) 10Esanders: WIP Upgrade eslint-config-wikimedia [extensions/Flow] - 10https://gerrit.wikimedia.org/r/605660 [20:56:35] (03CR) 10Gergő Tisza: [C: 04-1] "> Loading the homepage results in TypeError: "this.taskTypeData is undefined"" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604177 (https://phabricator.wikimedia.org/T253009) (owner: 10Gergő Tisza) [20:56:46] (03PS7) 10Gergő Tisza: Auto-advance suggested edits guidance tabs [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/604177 (https://phabricator.wikimedia.org/T253009) [21:33:21] 10Growth-Team, 10Thanks, 10MediaWiki-Revision-backend, 10Core Platform Team Workboards (External Code Reviews), and 3 others: Replace `HistoryRevisionTools` hook with `HistoryTools` - https://phabricator.wikimedia.org/T255494 (10DannyS712) In deployed code, only used in the Thanks extension [21:33:33] 10Growth-Team, 10Thanks, 10MediaWiki-Revision-backend, 10Core Platform Team Workboards (External Code Reviews), and 3 others: Replace `DiffRevisionTools` hook with `DiffTools` - https://phabricator.wikimedia.org/T255495 (10DannyS712) In deployed code, only used in the Thanks extension [21:35:18] (03CR) 10Ppchelko: [C: 03+2] Hooks: Update to use `PageMoveComplete` and `PageSaveComplete` [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/604509 (https://phabricator.wikimedia.org/T250023) (owner: 10DannyS712) [21:35:46] (03PS1) 10DannyS712: Use new `HistoryTools` and `DiffTools` hooks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/605674 (https://phabricator.wikimedia.org/T255494) [21:39:03] (03PS2) 10DannyS712: Use new `HistoryTools` and `DiffTools` hooks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/605674 (https://phabricator.wikimedia.org/T255494) [21:39:27] 10Growth-Team, 10Analytics, 10Product-Analytics: Newcomer tasks: update schema whitelist for Guidance - https://phabricator.wikimedia.org/T255501 (10nettrom_WMF) [21:39:55] 10Growth-Team, 10Analytics, 10Product-Analytics: Newcomer tasks: update schema whitelist for Guidance - https://phabricator.wikimedia.org/T255501 (10nettrom_WMF) [21:43:13] (03Merged) 10jenkins-bot: Hooks: Update to use `PageMoveComplete` and `PageSaveComplete` [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/604509 (https://phabricator.wikimedia.org/T250023) (owner: 10DannyS712) [22:00:03] (03CR) 10jerkins-bot: [V: 04-1] Use new `HistoryTools` and `DiffTools` hooks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/605674 (https://phabricator.wikimedia.org/T255494) (owner: 10DannyS712) [22:00:34] (03CR) 10DannyS712: "Recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/605674 (https://phabricator.wikimedia.org/T255494) (owner: 10DannyS712) [22:00:44] (03CR) 10DannyS712: "Failure was:" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/605674 (https://phabricator.wikimedia.org/T255494) (owner: 10DannyS712) [23:07:02] (03PS1) 10Gergő Tisza: Fix NewcomerTask schema field names [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605696 (https://phabricator.wikimedia.org/T251526) [23:13:28] (03CR) 10Catrope: [C: 03+2] Fix NewcomerTask schema field names [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605696 (https://phabricator.wikimedia.org/T251526) (owner: 10Gergő Tisza) [23:23:46] (03Merged) 10jenkins-bot: Fix NewcomerTask schema field names [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/605696 (https://phabricator.wikimedia.org/T251526) (owner: 10Gergő Tisza) [23:28:14] 10Growth-Team, 10Notifications, 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Manage push notifications via the web special preferences page - https://phabricator.wikimedia.org/T253656 (10Mholloway) 05Open→03Declined Per our meeting last week, I'm going to decline this to... [23:28:16] 10Growth-Team, 10Notifications, 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Implement Action API for equivalent of checkboxes for notification types - https://phabricator.wikimedia.org/T251462 (10Mholloway)