[00:01:07] (03PS1) 10Art-Baltai: Use correct contract of ArticleConfirmDelete hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/594332 [00:03:25] (03CR) 10jerkins-bot: [V: 04-1] Use correct contract of ArticleConfirmDelete hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/594332 (owner: 10Art-Baltai) [00:13:15] (03PS2) 10Art-Baltai: Use correct contract of ArticleConfirmDelete hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/594332 [00:15:56] (03PS3) 10Art-Baltai: Use correct contract of ArticleConfirmDelete hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/594332 [00:18:49] (03CR) 10Art-Baltai: "This change is ready for review." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/594332 (owner: 10Art-Baltai) [00:31:46] 10Growth-Team, 10StructuredDiscussions, 10Core Platform Team Workboards (Contractor Workboard), 10Patch-For-Review: \Flow\Hooks::onArticleConfirmDelete Use Article argument instead of WikiPage - https://phabricator.wikimedia.org/T251843 (10Reedy) [02:58:52] (03CR) 10Catrope: [C: 03+2] Help panel: Re-add outline to dialog window head [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/594241 (https://phabricator.wikimedia.org/T248065) (owner: 10Kosta Harlan) [03:13:35] (03Merged) 10jenkins-bot: Help panel: Re-add outline to dialog window head [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/594241 (https://phabricator.wikimedia.org/T248065) (owner: 10Kosta Harlan) [04:12:19] (03CR) 10Catrope: [C: 04-1] "a" (035 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/593972 (https://phabricator.wikimedia.org/T246919) (owner: 10Gergő Tisza) [04:41:55] (03PS1) 10Tim Starling: Don't put a whole User object in extra[mentioned-users] [extensions/Echo] - 10https://gerrit.wikimedia.org/r/594355 [05:19:45] (03PS2) 10Ammarpad: Echo: Add gender support for Mute user label [extensions/Echo] - 10https://gerrit.wikimedia.org/r/594158 (https://phabricator.wikimedia.org/T251687) [06:08:56] (03Abandoned) 10Ashuro07: Upgrade tests to WebdriverIO v-5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/585880 (https://phabricator.wikimedia.org/T248223) (owner: 10Ashuro07) [07:47:52] (03CR) 10Kosta Harlan: [C: 03+2] Don't put a whole User object in extra[mentioned-users] [extensions/Echo] - 10https://gerrit.wikimedia.org/r/594355 (owner: 10Tim Starling) [08:02:50] (03Merged) 10jenkins-bot: Don't put a whole User object in extra[mentioned-users] [extensions/Echo] - 10https://gerrit.wikimedia.org/r/594355 (owner: 10Tim Starling) [09:09:38] 10Growth-Team, 10Thanks, 10Cognate, 10MediaWiki-Revision-backend, and 6 others: Hard deprecate Revision::getPrevious - https://phabricator.wikimedia.org/T251073 (10DannyS712) a:03DannyS712 [11:51:55] 10Growth-Team, 10MediaWiki-Recent-changes, 10DBA, 10Schema-change: recentchanges table indexes: tmp1, tmp2 and tmp3 - https://phabricator.wikimedia.org/T206103 (10Marostegui) @Ladsgroup to make this even more interesting, I just realised that db1105:3311 doesn't have any of the `tmp_` indexes. I am going... [11:53:06] 10Growth-Team, 10MediaWiki-Recent-changes, 10DBA, 10Schema-change: recentchanges table indexes: tmp1, tmp2 and tmp3 - https://phabricator.wikimedia.org/T206103 (10Ladsgroup) >>! In T206103#6108179, @Marostegui wrote: > @Ladsgroup to make this even more interesting, I just realised that db1105:3311 doesn't... [11:54:45] (03PS4) 10Art-Baltai: Use correct contract of ArticleConfirmDelete hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/594332 (https://phabricator.wikimedia.org/T251843) [12:02:17] (03PS1) 10Hashar: doxygen: normalize output directory to 'docs' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/594464 (https://phabricator.wikimedia.org/T27978) [12:11:13] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10Continuous-Integration-Config, 10Documentation: Generate Doxygen documentation for Flow PHP classes to doc.wikimedia.org - https://phabricator.wikimedia.org/T93107 (10hashar) [12:11:18] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications, 10Continuous-Integration-Config, 10Documentation: Generate doxygen for Echo on doc.wm.o - https://phabricator.wikimedia.org/T117025 (10hashar) [12:46:59] 10Growth-Team, 10MediaWiki-Recent-changes, 10DBA, 10Schema-change: recentchanges table indexes: tmp1, tmp2 and tmp3 - https://phabricator.wikimedia.org/T206103 (10Marostegui) I found a few queries only, and the query plans are very similar. The query time with and without the index almost doesn't change, o... [13:11:42] 10Growth-Team, 10MediaWiki-Recent-changes, 10DBA, 10MediaWiki-Special-pages: Optimize recentchanges queries - https://phabricator.wikimedia.org/T251885 (10Marostegui) [13:12:01] 10Growth-Team, 10MediaWiki-Recent-changes, 10DBA, 10MediaWiki-Special-pages: Optimize recentchanges queries - https://phabricator.wikimedia.org/T251885 (10Marostegui) 05Open→03Stalled Stalling as we might get help with this in a few weeks. [13:12:05] 10Growth-Team, 10MediaWiki-Recent-changes, 10DBA, 10Schema-change: recentchanges table indexes: tmp1, tmp2 and tmp3 - https://phabricator.wikimedia.org/T206103 (10Marostegui) [13:12:13] 10Growth-Team, 10MediaWiki-Recent-changes, 10DBA, 10MediaWiki-Special-pages: Optimize recentchanges queries - https://phabricator.wikimedia.org/T251885 (10Marostegui) p:05Triage→03Medium [13:18:19] 10Growth-Team, 10MediaWiki-Recent-changes, 10DBA, 10Schema-change: recentchanges table indexes: tmp1, tmp2 and tmp3 - https://phabricator.wikimedia.org/T206103 (10Marostegui) @Ladsgroup right now this is the situation with both recentchanges hosts on `enwiki`. db1099 only has `tmp_3` index db1105 has neith... [13:38:37] 10Growth-Team, 10Notifications: mw-echo-notifications-badge icons look cut off in Chinese lang wikis - https://phabricator.wikimedia.org/T251824 (10Aklapper) Cannot reproduce on any of the given wikis in Firefox 75... Which font is being used in which browser? [14:42:38] (03CR) 10Jforrester: "Ha, docs is already in .gitignore (but we should remove doc)." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/594464 (https://phabricator.wikimedia.org/T27978) (owner: 10Hashar) [14:43:26] (03PS2) 10Jforrester: doxygen: normalize output directory to 'docs' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/594464 (https://phabricator.wikimedia.org/T27978) (owner: 10Hashar) [14:43:42] (03CR) 10Jforrester: [C: 03+2] doxygen: normalize output directory to 'docs' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/594464 (https://phabricator.wikimedia.org/T27978) (owner: 10Hashar) [14:58:35] (03Merged) 10jenkins-bot: doxygen: normalize output directory to 'docs' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/594464 (https://phabricator.wikimedia.org/T27978) (owner: 10Hashar) [15:41:05] (03PS6) 10Gergő Tisza: Instrumentation schema changes [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/593972 (https://phabricator.wikimedia.org/T246919) [15:42:45] (03CR) 10Gergő Tisza: Instrumentation schema changes (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/593972 (https://phabricator.wikimedia.org/T246919) (owner: 10Gergő Tisza) [15:45:44] 10Growth-Team, 10Notifications, 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Implement Action API for equivalent of checkboxes for notification types - https://phabricator.wikimedia.org/T251462 (10dr0ptp4kt) @dr0ptp4kt TODO: add acceptance criteria. [15:47:10] 10Growth-Team, 10CommRel-Specialists-Support (Apr-Jun-2020), 10Goal, 10User-Johan: Interim management of the Growth ambassadors - https://phabricator.wikimedia.org/T190311 (10Elitre) (it's a reminder I want to add a column to our board.) [15:53:36] (03PS7) 10Aaron Schulz: Convert $wgMemc use to WANObjectCache in getValidTags() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/585679 (https://phabricator.wikimedia.org/T160813) [15:53:44] (03CR) 10jerkins-bot: [V: 04-1] Convert $wgMemc use to WANObjectCache in getValidTags() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/585679 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [16:16:19] 10Growth-Team, 10Turkish-Sites: Deploy Growth features on Turkish Wikipedia - https://phabricator.wikimedia.org/T243445 (10FriedrickMILBarbarossa) [16:19:15] (03CR) 10Gergő Tisza: "Is this a good thing? If this runs before ext.visualEditor.desktopArticleTarget.init starts loading, the help panel will not be loaded. As" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/593870 (owner: 10Catrope) [16:27:54] (03CR) 10Gergő Tisza: "Same question as https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/593870/1#message-a4f2947ab3986a1311976e11490246" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589462 (https://phabricator.wikimedia.org/T235566) (owner: 10Catrope) [16:37:28] (03PS8) 10Aaron Schulz: Convert $wgMemc use to WANObjectCache in getValidTags() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/585679 (https://phabricator.wikimedia.org/T160813) [16:41:25] (03CR) 10jerkins-bot: [V: 04-1] Convert $wgMemc use to WANObjectCache in getValidTags() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/585679 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [16:52:39] (03CR) 10Gergő Tisza: Add dynamic secondary action to mute/unmute page-linked notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/592806 (https://phabricator.wikimedia.org/T46787) (owner: 10Catrope) [16:59:16] (03CR) 10Gergő Tisza: "This is a cool feature, thanks! I think it will eventually run into performance issues, though: over time, people can rack up a lot of mut" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591154 (https://phabricator.wikimedia.org/T46787) (owner: 10Kosta Harlan) [18:00:18] 10Growth-Team, 10Turkish-Sites: Deploy Growth features on Turkish Wikipedia - https://phabricator.wikimedia.org/T243445 (10Trizek-WMF) This task is still open, and we can deploy the Growth features to your wiki if you complete it. [18:02:36] 10Growth-Team, 10Turkish-Sites: Deploy Growth features on Turkish Wikipedia - https://phabricator.wikimedia.org/T243445 (10Trizek-WMF) [19:53:29] 10Growth-Team, 10Notifications: mw-echo-notifications-badge icons look cut off in Chinese lang wikis - https://phabricator.wikimedia.org/T251824 (10Etonkovidova) >>! In T251824#6108667, @Aklapper wrote: > Cannot reproduce on any of the given wikis in Firefox 75... Which font is being used in which browser? In... [19:54:10] 10Growth-Team, 10Notifications: mw-echo-notifications-badge icons look cut off in Chinese lang wikis on Mac OS X Yosemite - https://phabricator.wikimedia.org/T251824 (10Etonkovidova) [22:37:34] 10Growth-Team, 10Thanks, 10Cognate, 10MediaWiki-Revision-backend, and 6 others: Hard deprecate Revision::getPrevious - https://phabricator.wikimedia.org/T251073 (10daniel) >>! In T251073#6091127, @DannyS712 wrote: >>>! In T251073#6088524, @daniel wrote: >> There is nothing to review here, all subtasks are... [22:44:02] (03CR) 10Ppchelko: [C: 04-1] Replace use of `ArticleRollbackComplete` hook with `RollbackComplete` (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591215 (https://phabricator.wikimedia.org/T250543) (owner: 10DannyS712) [22:44:45] (03PS5) 10DannyS712: Replace use of `ArticleRollbackComplete` hook with `RollbackComplete` [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591215 (https://phabricator.wikimedia.org/T250543) [22:44:48] (03CR) 10DannyS712: Replace use of `ArticleRollbackComplete` hook with `RollbackComplete` (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591215 (https://phabricator.wikimedia.org/T250543) (owner: 10DannyS712) [22:52:20] 10Growth-Team, 10Community-Tech, 10Desktop Improvements, 10GrowthExperiments, and 3 others: Special:GlobalPreferences does not deal well with "conditional preferences" (using hide-if) - https://phabricator.wikimedia.org/T246491 (10Jdlrobson) @ovasileva I don't think this needs to be a priority right now.... [22:58:37] (03CR) 10jerkins-bot: [V: 04-1] Replace use of `ArticleRollbackComplete` hook with `RollbackComplete` [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591215 (https://phabricator.wikimedia.org/T250543) (owner: 10DannyS712) [23:16:21] 10Growth-Team, 10Notifications: mw-echo-notifications-badge icons look cut off in Chinese lang wikis on Mac OS X Yosemite - https://phabricator.wikimedia.org/T251824 (10Volker_E) Ran in this too recently on Firefox/Mojave. Will try to find again and share screenshot here. [23:33:53] (03CR) 10Ppchelko: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591215 (https://phabricator.wikimedia.org/T250543) (owner: 10DannyS712)