[00:00:40] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Disable PSR12.Properties.ConstantVisibility.NotFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589753 (owner: 10Reedy) [00:03:35] (03PS2) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589753 [00:04:24] (03PS2) 10Reedy: Update to use Flow\Notitifcations\FlowPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/589719 [00:05:35] (03PS2) 10DannyS712: Remove use of Article:: and WikiPage::getRevision() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589755 (https://phabricator.wikimedia.org/T250532) [00:14:11] 10Growth-Team, 10Notifications, 10MediaWiki-Revision-backend, 10MediaWiki-extensions-WikibaseRepository, and 8 others: Hard deprecate Article::getRevision and WikiPage::getRevision - https://phabricator.wikimedia.org/T250532 (10DannyS712) Patches pending for all extensions that need to be updated; core rep... [00:14:34] (03CR) 10jerkins-bot: [V: 04-1] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589753 (owner: 10Reedy) [00:16:26] (03PS3) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589753 [00:20:03] (03CR) 10jerkins-bot: [V: 04-1] Remove use of Article:: and WikiPage::getRevision() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589755 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [00:20:06] (03PS3) 10Reedy: Update to use Flow\Notifications\FlowPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/589719 [00:23:46] (03Abandoned) 10Reedy: WIP: Move up FlowUpdateWorkflowPageId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260800 (https://phabricator.wikimedia.org/T122329) (owner: 10Mattflaschen) [00:24:16] (03Abandoned) 10Reedy: Hooks::getSchemaUpdates: Don't require_once maintainance scripts, add to autoloader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373613 (https://phabricator.wikimedia.org/T174048) (owner: 10Jforrester) [00:25:06] (03Abandoned) 10Reedy: Rename Flow\Block\Block to Flow\Block\Blocker [extensions/Flow] - 10https://gerrit.wikimedia.org/r/414651 (owner: 10Gopavasanth) [00:25:52] (03PS2) 10Reedy: Fix "unreachable code after return statement" warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/408992 (https://phabricator.wikimedia.org/T165682) (owner: 10Aklapper) [00:26:17] (03CR) 10Reedy: [C: 03+2] "recheck" [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560434 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [00:26:22] (03CR) 10Reedy: [C: 03+2] "recheck" [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/564154 (owner: 10Paladox) [00:26:41] (03Abandoned) 10Reedy: Check [extensions/Flow] - 10https://gerrit.wikimedia.org/r/584682 (owner: 10DannyS712) [00:28:27] (03CR) 10jerkins-bot: [V: 04-1] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589753 (owner: 10Reedy) [00:29:56] (03PS4) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589753 [00:33:34] (03CR) 10jerkins-bot: [V: 04-1] Increase flow_ext_ref.ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/564154 (owner: 10Paladox) [00:33:37] (03CR) 10jerkins-bot: [V: 04-1] Increase ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560434 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [00:36:56] (03CR) 10Reedy: [C: 03+2] Prefer DOM building to parsing HTML literals [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560438 (owner: 10Paladox) [00:37:59] (03PS4) 10Paladox: Increase ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560434 (https://phabricator.wikimedia.org/T232351) [00:38:39] (03PS2) 10Paladox: Increase flow_ext_ref.ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/564154 [00:41:02] (03CR) 10jerkins-bot: [V: 04-1] Fix "unreachable code after return statement" warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/408992 (https://phabricator.wikimedia.org/T165682) (owner: 10Aklapper) [00:44:04] (03Merged) 10jenkins-bot: Prefer DOM building to parsing HTML literals [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560438 (owner: 10Paladox) [00:45:12] (03CR) 10Reedy: "Do we have a task for fixing this? Can we just remove the broken code, tag it against that task for easy reverting to fix it?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/408992 (https://phabricator.wikimedia.org/T165682) (owner: 10Aklapper) [00:46:13] (03CR) 10Reedy: [C: 03+2] Increase ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560434 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [00:47:03] (03CR) 10Reedy: [C: 03+2] Increase flow_ext_ref.ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/564154 (owner: 10Paladox) [00:49:28] (03PS3) 10DannyS712: Remove use of Article:: and WikiPage::getRevision() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589755 (https://phabricator.wikimedia.org/T250532) [00:54:09] (03Merged) 10jenkins-bot: Increase ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560434 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [00:54:26] (03Merged) 10jenkins-bot: Increase flow_ext_ref.ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/564154 (owner: 10Paladox) [00:59:03] 10Growth-Team, 10StructuredDiscussions: Fix _createRevPagination in flow-board-loadmore.js - https://phabricator.wikimedia.org/T250542 (10Reedy) [00:59:40] (03PS3) 10Reedy: Fix "unreachable code after return statement" warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/408992 (https://phabricator.wikimedia.org/T165682) (owner: 10Aklapper) [01:09:44] (03PS9) 10Reedy: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (https://phabricator.wikimedia.org/T187154) [01:10:02] (03CR) 10Krinkle: [C: 03+2] Rename some PHP files to match the underlying class name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589740 (owner: 10Reedy) [01:10:08] (03CR) 10Krinkle: [C: 03+2] Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [01:11:51] (03PS1) 10Aaron Schulz: Avoid use of deprecated CdnCacheUpdate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589771 [01:14:28] (03CR) 10jerkins-bot: [V: 04-1] Fix "unreachable code after return statement" warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/408992 (https://phabricator.wikimedia.org/T165682) (owner: 10Aklapper) [01:26:15] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of deprecated CdnCacheUpdate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589771 (owner: 10Aaron Schulz) [01:26:41] (03Merged) 10jenkins-bot: Rename some PHP files to match the underlying class name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589740 (owner: 10Reedy) [01:26:44] (03Merged) 10jenkins-bot: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [01:42:43] (03PS1) 10Reedy: Remove FlowPresentationModel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589781 [01:43:04] (03CR) 10Reedy: [C: 04-2] "Patch to Thanks needs merging first" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589781 (owner: 10Reedy) [01:43:27] (03PS1) 10Reedy: Bump version to 1.2.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589782 [01:50:38] (03CR) 10Ppchelko: [C: 04-1] Remove use of Article:: and WikiPage::getRevision() (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589755 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [01:50:42] 10Growth-Team, 10Notifications, 10MachineVision, 10MediaWiki-Revision-backend, and 7 others: Replace `ArticleRollbackComplete` hook - https://phabricator.wikimedia.org/T250543 (10DannyS712) [01:52:14] (03CR) 10Ppchelko: [C: 03+2] Remove use of Article:: and WikiPage::getRevision() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589712 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [01:52:18] 10Growth-Team, 10Notifications, 10MachineVision, 10MediaWiki-Revision-backend, and 7 others: Replace `ArticleRollbackComplete` hook - https://phabricator.wikimedia.org/T250543 (10DannyS712) p:05Triage→03Medium [01:54:07] (03CR) 10jerkins-bot: [V: 04-1] Remove FlowPresentationModel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589781 (owner: 10Reedy) [01:57:40] (03PS4) 10DannyS712: Remove use of Article:: and WikiPage::getRevision() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589755 (https://phabricator.wikimedia.org/T250532) [01:57:43] (03CR) 10DannyS712: Remove use of Article:: and WikiPage::getRevision() (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589755 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [02:07:31] (03Merged) 10jenkins-bot: Remove use of Article:: and WikiPage::getRevision() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589712 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [02:11:25] (03PS1) 10DannyS712: Remove rollback from generateSampleNotifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589792 (https://phabricator.wikimedia.org/T249393) [02:12:01] (03PS2) 10DannyS712: Remove rollback from generateSampleNotifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589792 (https://phabricator.wikimedia.org/T249393) [02:16:53] (03PS1) 10VolkerE: Use '.text-overflow()' mixin from 'mediawiki.mixins' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589793 [02:21:35] (03CR) 10jerkins-bot: [V: 04-1] Use '.text-overflow()' mixin from 'mediawiki.mixins' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589793 (owner: 10VolkerE) [02:38:51] (03CR) 10Ppchelko: [C: 03+2] Remove use of Article:: and WikiPage::getRevision() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589755 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [02:52:29] (03Merged) 10jenkins-bot: Remove use of Article:: and WikiPage::getRevision() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589755 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [05:12:53] (03PS18) 10Ashuro07: Upgrade tests to WebdriverIO v-5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/585880 (https://phabricator.wikimedia.org/T248223) [05:27:24] (03CR) 10jerkins-bot: [V: 04-1] Upgrade tests to WebdriverIO v-5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/585880 (https://phabricator.wikimedia.org/T248223) (owner: 10Ashuro07) [05:46:06] 10Growth-Team, 10Notifications, 10MediaWiki-Revision-backend, 10MediaWiki-extensions-WikibaseRepository, and 9 others: Hard deprecate Article::getRevision and WikiPage::getRevision - https://phabricator.wikimedia.org/T250532 (10DannyS712) a:03DannyS712 [06:19:09] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-Revision-deletion: Watchlist display issue with log entry when protection edit is revdel'd - https://phabricator.wikimedia.org/T206430 (10Ammarpad) [06:19:12] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Revision-deletion: RecentChanges incorrectly shows log entries as deleted - https://phabricator.wikimedia.org/T182537 (10Ammarpad) [06:21:41] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Revision-deletion: RecentChanges incorrectly shows log entries as deleted - https://phabricator.wikimedia.org/T182537 (10Ammarpad) [06:39:59] (03CR) 10Ashuro07: "Yes, I need help with this, I have pushed many changes to the patch but still getting the same error." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/585880 (https://phabricator.wikimedia.org/T248223) (owner: 10Ashuro07) [08:50:59] (03PS1) 10Shirayuki: Add Special:MyLanguage for better user experience [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/589839 [17:27:33] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-Page-editing: Un-checking "Watch this page" boxes and hitting 'save' deletes previous revisions. - https://phabricator.wikimedia.org/T245918 (10Ammarpad) >>! In T245918#6025133, @Etonkovidova wrote: > For a logged-in user there should be 'Edit source' not j... [17:58:52] (03CR) 10Krinkle: [C: 03+2] "Confirmed via Codesearch that all the constants this makes non-public are only used within the same file or in files that declare the same" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589753 (owner: 10Reedy) [17:59:06] (03PS2) 10Krinkle: Bump version to 1.2.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589782 (owner: 10Reedy) [17:59:33] (03CR) 10Krinkle: [C: 03+2] ".. or we can remove the property?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589782 (owner: 10Reedy) [18:00:08] (03CR) 10Reedy: "Probably, yeah. Most don't actually use them" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589782 (owner: 10Reedy) [18:03:41] (03CR) 10Krinkle: [C: 03+2] Update to use Flow\Notifications\FlowPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/589719 (owner: 10Reedy) [18:04:09] (03CR) 10Krinkle: "For reference: I419af406f86c495d1448d2be07f8e891bdd7e47a (mwext/Thanks)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589781 (owner: 10Reedy) [18:04:12] (03CR) 10Krinkle: [C: 03+1] Remove FlowPresentationModel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589781 (owner: 10Reedy) [18:15:05] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589753 (owner: 10Reedy) [18:15:08] (03CR) 10jerkins-bot: [V: 04-1] Bump version to 1.2.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589782 (owner: 10Reedy) [18:17:56] (03Merged) 10jenkins-bot: Update to use Flow\Notifications\FlowPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/589719 (owner: 10Reedy) [18:25:23] (03PS2) 10Reedy: Remove FlowPresentationModel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589781 [18:25:32] (03CR) 10Krinkle: [C: 03+2] "Gerrit 502, T246763" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589782 (owner: 10Reedy) [18:25:59] (03CR) 10Krinkle: [C: 03+2] Remove FlowPresentationModel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589781 (owner: 10Reedy) [18:52:41] (03Merged) 10jenkins-bot: Bump version to 1.2.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589782 (owner: 10Reedy) [18:52:44] (03Merged) 10jenkins-bot: Remove FlowPresentationModel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589781 (owner: 10Reedy) [20:12:09] (03PS6) 10Krinkle: Remove unused "memcache" service from container.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/585118 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [20:12:46] (03CR) 10Krinkle: "@Kosta Could you take a look? I'm not sure what's going on here, but if it's safe to remove, then this would unblock removing the initiali" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/585118 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [22:53:48] 10Growth-Team, 10StructuredDiscussions, 10ci-test-error (WMF-deployed Build Failure): Random test failure for Flow\Tests\Api\ApiFlowEditTitleTest::testEditTitle on gate-and-submit - https://phabricator.wikimedia.org/T208607 (10Krinkle) [22:53:54] 10Growth-Team, 10StructuredDiscussions, 10ci-test-error (WMF-deployed Build Failure): Flaky unit test Flow RevisionCollectionPermissionsTest::testPermissions - https://phabricator.wikimedia.org/T206929 (10Krinkle) [22:54:24] 10Growth-Team, 10StructuredDiscussions, 10User-kostajh, 10ci-test-error (WMF-deployed Build Failure): Random test failure in ApiFlowEditPostTest::testEditPost & ApiFlowLockTopicTest::testLockTopic - https://phabricator.wikimedia.org/T210921 (10Krinkle) [23:43:51] (03PS1) 10Reedy: Move one class to AutoloadNamespaces [extensions/Echo] - 10https://gerrit.wikimedia.org/r/590009 (https://phabricator.wikimedia.org/T187154)