[00:00:16] (03PS1) 10Reedy: Remove .arcconfig from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589452 [00:05:14] (03CR) 10markahershberger: Introduce dependency injection to replace calls to wfWikiID() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger) [00:08:10] (03CR) 10jerkins-bot: [V: 04-1] Introduce dependency injection to replace calls to wfWikiID() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger) [00:14:56] (03CR) 10markahershberger: "Although, I could see an argument for keeping some of the ones I've added so that if you want to use PSR-4 autoloading here, it would requ" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger) [00:19:57] (03PS3) 10markahershberger: Introduce dependency injection to replace calls to wfWikiID() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) [00:29:14] (03CR) 10Jforrester: [C: 03+2] Don't use deprecated Parser::Options() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589352 (owner: 10C. Scott Ananian) [00:31:00] 10Growth-Team, 10StructuredDiscussions, 10Patch-For-Review: Flow should use dependency injection instead of wfWikiID() - https://phabricator.wikimedia.org/T250454 (10MarkAHershberger) Adding @Daniel since I hear he knows a thing or two about DI. [00:31:19] (03CR) 10jerkins-bot: [V: 04-1] Introduce dependency injection to replace calls to wfWikiID() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger) [00:47:49] (03Merged) 10jenkins-bot: Don't use deprecated Parser::Options() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589352 (owner: 10C. Scott Ananian) [04:09:42] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589452 (owner: 10Reedy) [04:40:35] (03PS2) 10VolkerE: Remove .arcconfig [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589452 (owner: 10Reedy) [04:40:41] (03CR) 10VolkerE: [C: 03+2] Remove .arcconfig [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589452 (owner: 10Reedy) [04:41:12] (03PS1) 10Catrope: Suggested edits: Suppress VE dialogs for suggested edit page views [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589462 (https://phabricator.wikimedia.org/T235566) [04:42:12] 10Growth-Team, 10MediaWiki-extensions-GuidedTour, 10VisualEditor, 10Patch-For-Review: Allow hiding VE onboarding experience programmatically to avoid sidetracking users using a different onboarding experience - https://phabricator.wikimedia.org/T122623 (10Catrope) [04:56:33] (03Merged) 10jenkins-bot: Remove .arcconfig [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589452 (owner: 10Reedy) [07:27:34] (03PS1) 10Aaron Schulz: Avoid use of wfForeignMemcKey() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589536 [07:37:43] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of wfForeignMemcKey() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589536 (owner: 10Aaron Schulz) [09:58:15] (03PS2) 10Aaron Schulz: Avoid use of wfForeignMemcKey() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589536 (https://phabricator.wikimedia.org/T250407) [10:11:16] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of wfForeignMemcKey() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589536 (https://phabricator.wikimedia.org/T250407) (owner: 10Aaron Schulz) [11:14:09] 10Growth-Team, 10MediaWiki-Watchlist, 10CPT Initiatives (Decoupling (CDP2)): Implement access restrictions in WatchedItemStore - https://phabricator.wikimedia.org/T223165 (10Aklapper) @Vedmaka: Could you please answer the last comment? Thanks! :) [12:21:58] 10Growth-Team, 10MediaWiki-Watchlist, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), and 5 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10kostajh) A quick update for those watchi... [12:46:06] (03CR) 10Kosta Harlan: [C: 04-1] "Hi, thanks for the patch! A few questions/comments:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger) [12:51:47] (03PS1) 10Reedy: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 [12:51:50] (03PS1) 10Reedy: Remove PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589578 [12:51:53] (03PS1) 10Reedy: [WIP] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 [12:52:34] (03PS2) 10Reedy: Remove PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589578 [12:52:57] (03PS2) 10Reedy: [WIP] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 [12:55:03] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 (owner: 10Reedy) [12:55:06] (03CR) 10jerkins-bot: [V: 04-1] Remove PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589578 (owner: 10Reedy) [12:55:19] (03CR) 10jerkins-bot: [V: 04-1] Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (owner: 10Reedy) [12:56:03] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 (owner: 10Reedy) [12:56:28] (03PS1) 10Reedy: [WIP] Disable Generic.Files.OneObjectStructurePerFile.MultipleFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [13:06:25] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Disable Generic.Files.OneObjectStructurePerFile.MultipleFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 (owner: 10Reedy) [13:07:31] 10Growth-Team, 10MediaWiki-Maintenance-system, 10Wikidata, 10Core Platform Team Workboards (Clinic Duty Team), and 3 others: DatabaseUpdater: protect methods for direct database modification - https://phabricator.wikimedia.org/T249603 (10daniel) [13:07:39] 10Growth-Team, 10Growth-Scaling: [Growth scaling] Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, zh Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) [13:09:29] 10Growth-Team, 10Growth-Scaling, 10Chinese-Sites: [Growth scaling] Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, zh Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) [13:10:19] (03PS2) 10Reedy: [WIP] Narrow and fix Generic.Files.OneObjectStructurePerFile.MultipleFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [13:12:09] 10Growth-Team, 10Growth-Scaling, 10CommRel-Specialists-Support (Jan-Mar-2020): Scale: refine the process to avoid a huge amount of work for communities getting the features - https://phabricator.wikimedia.org/T234846 (10Trizek-WMF) 05Open→03Resolved Everything communities need to know has been grouped on... [13:20:31] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Narrow and fix Generic.Files.OneObjectStructurePerFile.MultipleFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 (owner: 10Reedy) [13:25:40] 10Growth-Team, 10Growth-Scaling, 10Chinese-Sites: [Growth scaling] Group 1: community engagement for deployment on fr, pt, pl, fa, sv, da, it, id, zh Wikipedias - https://phabricator.wikimedia.org/T250481 (10Trizek-WMF) [13:31:14] (03CR) 10markahershberger: "> 1. Does this fix the problem that you noted in T250454? I would be kind of surprised if so." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger) [13:33:49] (03PS1) 10Kosta Harlan: (wip) Help panel: Add footer for suggested edits guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589590 (https://phabricator.wikimedia.org/T244541) [13:44:31] (03CR) 10jerkins-bot: [V: 04-1] (wip) Help panel: Add footer for suggested edits guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589590 (https://phabricator.wikimedia.org/T244541) (owner: 10Kosta Harlan) [13:52:45] (03PS2) 10Kosta Harlan: Help panel: Add footer for suggested edits guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589590 (https://phabricator.wikimedia.org/T244541) [13:54:28] (03PS3) 10Kosta Harlan: Help panel: Add footer for suggested edits guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589590 (https://phabricator.wikimedia.org/T244541) [14:12:58] (03PS4) 10Kosta Harlan: Help panel: Add footer for suggested edits guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589590 (https://phabricator.wikimedia.org/T244541) [14:15:00] (03PS5) 10Kosta Harlan: Help panel: Add footer for suggested edits guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589590 (https://phabricator.wikimedia.org/T244541) [14:20:37] 10MediaWiki-Watchlist, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), and 4 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10kostajh) [14:31:08] (03PS3) 10Reedy: [WIP] Narrow and fix Generic.Files.OneObjectStructurePerFile.MultipleFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [14:32:21] (03PS4) 10Reedy: [WIP] Narrow and fix Generic.Files.OneObjectStructurePerFile.MultipleFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [14:41:55] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Narrow and fix Generic.Files.OneObjectStructurePerFile.MultipleFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 (owner: 10Reedy) [14:42:37] (03PS5) 10Reedy: [WIP] Narrow and fix Generic.Files.OneObjectStructurePerFile.MultipleFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [14:46:00] (03PS6) 10Reedy: [WIP] Narrow and fix Generic.Files.OneObjectStructurePerFile.MultipleFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [14:49:31] (03PS7) 10Reedy: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [14:51:17] (03PS2) 10Reedy: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 [14:51:20] (03PS3) 10Reedy: Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 [14:54:09] (03PS4) 10Reedy: Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 [14:54:38] (03CR) 10jerkins-bot: [V: 04-1] Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (owner: 10Reedy) [14:54:41] (03CR) 10jerkins-bot: [V: 04-1] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 (owner: 10Reedy) [14:56:31] (03CR) 10jerkins-bot: [V: 04-1] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 (owner: 10Reedy) [15:03:58] (03CR) 10jerkins-bot: [V: 04-1] Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 (owner: 10Reedy) [15:05:05] (03PS8) 10Reedy: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [15:11:08] (03PS9) 10Reedy: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [15:18:24] (03PS10) 10Reedy: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [15:22:32] (03PS11) 10Reedy: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [15:34:07] (03CR) 10jerkins-bot: [V: 04-1] Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 (owner: 10Reedy) [15:37:23] (03PS12) 10Reedy: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [15:41:26] 10MediaWiki-Watchlist, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), and 4 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Izno) >>! In T218511#60... [15:43:09] (03PS13) 10Reedy: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [15:47:09] (03PS14) 10Reedy: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [15:47:12] (03PS3) 10Reedy: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 [15:47:15] (03PS5) 10Reedy: Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 [15:49:51] (03CR) 10jerkins-bot: [V: 04-1] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 (owner: 10Reedy) [15:50:04] (03CR) 10jerkins-bot: [V: 04-1] Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (owner: 10Reedy) [15:55:08] (03CR) 10Reedy: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (owner: 10Reedy) [16:27:51] (03PS15) 10Reedy: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 [16:27:54] (03PS6) 10Reedy: Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 [16:30:21] (03CR) 10jerkins-bot: [V: 04-1] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 (owner: 10Reedy) [16:30:35] 10Growth-Team, 10StructuredDiscussions: FlowHooks::onGetUserPermissionsErrors inconsistent returns - https://phabricator.wikimedia.org/T250503 (10Reedy) [16:31:47] (03PS7) 10Reedy: Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 [16:34:56] (03CR) 10jerkins-bot: [V: 04-1] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 (owner: 10Reedy) [16:39:26] (03PS8) 10Reedy: Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 [16:42:36] (03PS9) 10Reedy: Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 [16:56:07] (03PS4) 10Reedy: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 [16:58:58] (03CR) 10jerkins-bot: [V: 04-1] Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (owner: 10Reedy) [16:59:55] (03PS5) 10Reedy: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 [17:02:50] (03CR) 10jerkins-bot: [V: 04-1] Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (owner: 10Reedy) [17:06:50] (03PS1) 10Reedy: Add maintenance scripts used in getSchemaUpdates to AutoloadClasses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 [17:09:39] (03CR) 10Reedy: "Failure mentioned at https://phabricator.wikimedia.org/T240307#6065997 as I think it's related to MW core... Possibly hooks changes, else " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (owner: 10Reedy) [17:21:28] (03CR) 10jerkins-bot: [V: 04-1] Add maintenance scripts used in getSchemaUpdates to AutoloadClasses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 (owner: 10Reedy) [17:24:33] 10Growth-Team, 10GrowthExperiments: Variants tests: C vs. D analysis - https://phabricator.wikimedia.org/T250455 (10RHo) @MMiller_WMF - similar to setting topics, should we also add **setting task types** as part of the analysis? Other things //for your consideration//: * Views of optional onboarding screens... [17:24:36] (03PS2) 10Reedy: Add maintenance scripts used in getSchemaUpdates to AutoloadClasses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 [18:51:58] (03PS6) 10Kosta Harlan: Help panel: Add footer for suggested edits guidance [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589590 (https://phabricator.wikimedia.org/T244541) [19:05:14] 10Growth-Team, 10MinervaNeue, 10StructuredDiscussions, 10Design, and 4 others: Consolidate MinervaNeue and Flow on one WikimediaUI icon for ToC - https://phabricator.wikimedia.org/T232383 (10Jdlrobson) [19:23:04] 10Growth-Team, 10Thanks, 10Continuous-Integration-Config: Thanks REL1_30 and REL1_27 failing with session token errors - https://phabricator.wikimedia.org/T202669 (10hashar) 05Open→03Declined We are a few release ahead of this bug report. I am assuming either it is no more relevant or that got fixed at s... [19:23:26] 10Growth-Team, 10Thanks, 10ci-test-error: Thanks REL1_30 and REL1_27 failing with session token errors - https://phabricator.wikimedia.org/T202669 (10hashar) [21:01:52] (03PS1) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [21:03:52] (03CR) 10jerkins-bot: [V: 04-1] Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 (owner: 10Reedy) [21:07:53] (03PS2) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [21:10:12] 10Growth-Team, 10Notifications, 10MediaWiki-Revision-backend, 10MediaWiki-extensions-WikibaseRepository, and 7 others: Hard deprecate Article::getRevision and WikiPage::getRevision - https://phabricator.wikimedia.org/T250532 (10DannyS712) Codesearch for use of `getRevision`: https://codesearch.wmflabs.org/... [21:10:17] (03CR) 10jerkins-bot: [V: 04-1] Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 (owner: 10Reedy) [21:11:43] (03PS3) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [21:14:11] (03CR) 10jerkins-bot: [V: 04-1] Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 (owner: 10Reedy) [21:14:50] 10Growth-Team, 10Notifications, 10MediaWiki-Revision-backend, 10MediaWiki-extensions-WikibaseRepository, and 7 others: Hard deprecate Article::getRevision and WikiPage::getRevision - https://phabricator.wikimedia.org/T250532 (10DannyS712) Uses of Article can also be replaced with WikiPage at the same time,... [21:17:12] (03PS4) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [21:19:33] (03PS5) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [21:19:36] (03CR) 10jerkins-bot: [V: 04-1] Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 (owner: 10Reedy) [21:24:25] (03PS1) 10DannyS712: Remove use of Article:: and WikiPage::getRevision() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589712 (https://phabricator.wikimedia.org/T250532) [21:27:20] (03PS2) 10DannyS712: Remove use of Article:: and WikiPage::getRevision() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589712 (https://phabricator.wikimedia.org/T250532) [21:30:39] (03CR) 10jerkins-bot: [V: 04-1] Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 (owner: 10Reedy) [21:35:51] (03CR) 10Reedy: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 (owner: 10Reedy) [21:40:53] (03PS6) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [21:42:40] (03CR) 10jerkins-bot: [V: 04-1] Remove use of Article:: and WikiPage::getRevision() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589712 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [21:43:14] Soooo. Who wants to help review my NS fixup patches? :P [21:43:40] Not it. [21:43:49] Heh [21:43:50] Reedy: I'd be more in favour if they were using PSR autoloading. ;-) [21:43:56] * James_F whistles. [21:43:58] James_F: That's the intention [21:44:03] James_F: Fixing the shit so it can be done [21:44:10] ala https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/589577/ [21:44:26] (03CR) 10DannyS712: [V: 03+1] "Recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589712 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [21:45:10] Hmm. [21:45:24] If 589707 passes... 589577 can go ontop of it [21:45:36] (03PS1) 10Gergő Tisza: Move rest of API code into GrowthTasksApi [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589714 [21:45:38] (03PS1) 10Gergő Tisza: [WIP] Tests for GrowthTasksApi [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589715 [21:45:50] (03CR) 10Jforrester: [C: 03+2] Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 (owner: 10Reedy) [21:47:01] Reedy: Are you going to namespace them as MediaWiki\Extensions\StructuredDiscussions eventually? ;-) [21:47:10] Haha [21:48:38] (03PS7) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [21:49:01] Reedy: I'm not entirely enthused about having a class called "Hooks" that isn't https://doc.wikimedia.org/mediawiki-core/master/php/classHooks.html [21:49:08] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Tests for GrowthTasksApi [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589715 (owner: 10Gergő Tisza) [21:49:20] I mean, I know the whole point of namespaces is to avoid accidental clashes, but… [21:49:30] Lol [21:49:36] It's done in other extensions... [21:49:54] But for a common name, I kinda know what you mean [21:49:55] And if other extensions told you to run off a cliff? ;-) [21:50:07] * James_F shrugs. [21:50:08] I'd be worried they could speak [21:50:20] I'll get some coffee and have a think. [21:50:25] It's something we should document if so [21:50:29] And add a MW core structure test too? [21:50:32] structure/whatever [21:50:44] The new HookContainer thing changes everything more, of course. [21:50:47] I certainly don't have strong feelings either way [21:50:48] Not quite worked out how, yet. [21:56:59] (03CR) 10jerkins-bot: [V: 04-1] Move rest of API code into GrowthTasksApi [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/589714 (owner: 10Gergő Tisza) [22:00:39] (03CR) 10jerkins-bot: [V: 04-1] Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 (owner: 10Reedy) [22:01:27] (03Merged) 10jenkins-bot: Move PHP objects to one per file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589581 (owner: 10Reedy) [22:01:34] Reedy: Not seeing much of our production code having a class just called Hooks: https://codesearch.wmflabs.org/deployed/?q=%5CbHooks%5Cb&i=nope&files=&repos= but not none, as you say. [22:02:02] But how many are NS'd etc? [22:02:12] All of them. [22:02:26] (03CR) 10Jforrester: [C: 03+2] Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 (owner: 10Reedy) [22:03:08] (03CR) 10Jforrester: [C: 03+2] Remove PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589578 (owner: 10Reedy) [22:03:30] (03PS8) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [22:05:06] (03PS1) 10Reedy: Update to use Flow\Notitifcations\FlowPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/589719 [22:06:24] (03PS9) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [22:06:30] (03CR) 10jerkins-bot: [V: 04-1] Update to use Flow\Notitifcations\FlowPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/589719 (owner: 10Reedy) [22:06:54] (03CR) 10Reedy: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/589719 (owner: 10Reedy) [22:07:53] (03CR) 10Jforrester: "Should these be namespaced first?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 (owner: 10Reedy) [22:08:54] (03CR) 10Reedy: "I think we'd need to split out the multiple objects per PHP file etc first, but that's not a major thing if we wanted to do it" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 (owner: 10Reedy) [22:09:21] (03CR) 10Jforrester: [C: 03+2] Add maintenance scripts used in getSchemaUpdates to AutoloadClasses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 (owner: 10Reedy) [22:10:25] (03PS10) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [22:15:02] (03CR) 10Zfilipin: Upgrade tests to webdriverio 5 (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/585880 (https://phabricator.wikimedia.org/T248223) (owner: 10Ashuro07) [22:17:31] (03CR) 10Zfilipin: "> Patch Set 17: Verified-1" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/585880 (https://phabricator.wikimedia.org/T248223) (owner: 10Ashuro07) [22:18:38] (03Merged) 10jenkins-bot: Move FlowHooks class into Flow namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589579 (owner: 10Reedy) [22:18:41] (03Merged) 10jenkins-bot: Remove PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589578 (owner: 10Reedy) [22:22:42] (03PS11) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [22:22:45] (03PS6) 10Reedy: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 [22:23:40] (03CR) 10jerkins-bot: [V: 04-1] Add maintenance scripts used in getSchemaUpdates to AutoloadClasses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 (owner: 10Reedy) [22:23:53] (03CR) 10Reedy: "silly gerrit" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 (owner: 10Reedy) [22:25:57] (03PS12) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [22:29:13] (03CR) 10Reedy: "check gate" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 (owner: 10Reedy) [22:34:03] (03PS13) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [22:34:48] (03CR) 10jerkins-bot: [V: 04-1] Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (owner: 10Reedy) [22:35:00] (03CR) 10Reedy: [C: 03+2] "Re-apply C+2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 (owner: 10Reedy) [22:37:24] (03PS14) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [22:43:45] (03PS15) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [22:49:06] (03Merged) 10jenkins-bot: Add maintenance scripts used in getSchemaUpdates to AutoloadClasses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589647 (owner: 10Reedy) [22:58:54] (03PS16) 10Reedy: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 [22:58:57] (03PS7) 10Reedy: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 [23:00:07] (03PS1) 10Reedy: [WIP] Disable "MediaWiki.Files.ClassMatchesFilename.NotMatch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589740 [23:00:29] (03CR) 10Reedy: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/589719 (owner: 10Reedy) [23:00:37] Getting there :) [23:10:09] (03CR) 10jerkins-bot: [V: 04-1] Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 (owner: 10Reedy) [23:11:34] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Disable "MediaWiki.Files.ClassMatchesFilename.NotMatch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589740 (owner: 10Reedy) [23:18:19] (03PS2) 10Reedy: Rename some PHP files to match the underlying class name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589740 [23:18:38] (03CR) 10Jforrester: [C: 03+2] Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 (owner: 10Reedy) [23:18:48] <3 James_F|Away [23:28:35] (03CR) 10jerkins-bot: [V: 04-1] Rename some PHP files to match the underlying class name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589740 (owner: 10Reedy) [23:33:52] 10Growth-Team, 10Thanks, 10MediaWiki-Partial-blocks, 10MediaWiki-User-management: Allow a user to be blocked from sending thanks - https://phabricator.wikimedia.org/T242785 (10ARamirez_WMF) [23:33:55] (03Merged) 10jenkins-bot: Move includes/Notifications files into correct namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589707 (owner: 10Reedy) [23:35:26] (03PS3) 10Reedy: Rename some PHP files to match the underlying class name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589740 [23:35:29] (03PS8) 10Reedy: Move most Flow files to AutoloadNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589577 [23:44:20] (03CR) 10Reedy: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/589719 (owner: 10Reedy) [23:50:16] (03PS1) 10Reedy: [WIP] Disable PSR12.Properties.ConstantVisibility.NotFound [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589753 [23:54:08] (03CR) 10DannyS712: "Recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589712 (https://phabricator.wikimedia.org/T250532) (owner: 10DannyS712) [23:56:32] (03PS1) 10DannyS712: Remove use of Article:: and WikiPage::getRevision() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589755 (https://phabricator.wikimedia.org/T250532)