[00:01:35] 10Growth-Team, 10GrowthExperiments: Variant tests: C-desktop - https://phabricator.wikimedia.org/T250331 (10MMiller_WMF) [00:09:10] 10Growth-Team, 10GrowthExperiments: Variant tests: C-desktop - https://phabricator.wikimedia.org/T250331 (10MMiller_WMF) [01:03:55] (03PS1) 10VolkerE: Amend Base10 color, add and amend WikimediaUI Base variables notation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589167 (https://phabricator.wikimedia.org/T248393) [01:13:13] (03PS1) 10VolkerE: Replace static border radius value with var [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589168 [01:15:32] 10Growth-Team, 10GrowthExperiments, 10Quality-and-Test-Engineering-Team (QTE), 10Accessibility, and 2 others: Add accessibility check for Homepage - https://phabricator.wikimedia.org/T232638 (10Volker_E) [01:36:09] (03PS1) 10VolkerE: Add appropriate icon dependencies for mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589169 (https://phabricator.wikimedia.org/T250323) [01:47:41] (03PS1) 10VolkerE: Remove outdated '@textareaPadding' variable and the calculation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589170 [01:51:38] 10Growth-Team, 10MediaWiki-Revision-backend, 10MediaWiki-extensions-FlaggedRevs, 10MediaWiki-extensions-WikibaseRepository, and 6 others: Replace `NewRevisionFromEditComplete` with a new hook - https://phabricator.wikimedia.org/T250338 (10DannyS712) [01:51:47] 10Growth-Team, 10MediaWiki-Revision-backend, 10MediaWiki-extensions-FlaggedRevs, 10MediaWiki-extensions-WikibaseRepository, and 6 others: Replace `NewRevisionFromEditComplete` with a new hook - https://phabricator.wikimedia.org/T250338 (10DannyS712) p:05Triage→03Medium [04:15:23] (03CR) 10Jforrester: [C: 03+2] Amend Base10 color, add and amend WikimediaUI Base variables notation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589167 (https://phabricator.wikimedia.org/T248393) (owner: 10VolkerE) [04:28:33] (03Merged) 10jenkins-bot: Amend Base10 color, add and amend WikimediaUI Base variables notation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589167 (https://phabricator.wikimedia.org/T248393) (owner: 10VolkerE) [04:42:55] 10Growth-Team, 10MediaWiki-Watchlist, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Performance-Team (Radar), and 3 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Catrope) `$current` is the value stored in the cache key,... [05:41:54] 10Growth-Team, 10GrowthExperiments: Variant tests: C-desktop - https://phabricator.wikimedia.org/T250331 (10MMiller_WMF) [05:48:19] 10Growth-Team, 10GrowthExperiments: Variant tests: D-desktop - https://phabricator.wikimedia.org/T250343 (10MMiller_WMF) [05:49:32] 10Growth-Team, 10GrowthExperiments: Variant tests: C-desktop - https://phabricator.wikimedia.org/T250331 (10MMiller_WMF) [05:53:11] 10Growth-Team, 10GrowthExperiments: Variant tests: C-desktop - https://phabricator.wikimedia.org/T250331 (10MMiller_WMF) @RHo -- please have a read over this to make sure I got the specifications right and didn't miss anything. I have one open question. On the first onboarding overlay [[ https://wikimedia.in... [05:54:24] 10Growth-Team, 10GrowthExperiments: Variant tests: D-desktop - https://phabricator.wikimedia.org/T250343 (10MMiller_WMF) @RHo -- please have a read over this to make sure I got the specifications right and didn't miss anything. I have one question. On the second screen of the onboarding, there is no option t... [05:56:12] 10Growth-Team, 10GrowthExperiments: Variant tests: "initiation part 2" test (C vs. D) - https://phabricator.wikimedia.org/T246533 (10MMiller_WMF) [06:08:23] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Page-History: Improve [rollback] logic when it encounters null edits - https://phabricator.wikimedia.org/T175437 (10Ammarpad) [09:00:53] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Page-History: Improve [rollback] logic when it encounters dummy revisions - https://phabricator.wikimedia.org/T175437 (10daniel) [09:03:39] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Page-History: Improve [rollback] logic when it encounters dummy revisions - https://phabricator.wikimedia.org/T175437 (10daniel) Changed the wording from "null edit" to "dummy revision" (aka "null revision"). "Null edits" are a different thing, it's when... [09:32:37] (03CR) 10Kosta Harlan: [C: 03+2] Add appropriate icon dependencies for mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589169 (https://phabricator.wikimedia.org/T250323) (owner: 10VolkerE) [09:44:18] (03Merged) 10jenkins-bot: Add appropriate icon dependencies for mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589169 (https://phabricator.wikimedia.org/T250323) (owner: 10VolkerE) [16:40:39] (03PS1) 10C. Scott Ananian: Don't use deprecated Parser::Options() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589352 [16:56:08] (03CR) 10jerkins-bot: [V: 04-1] Don't use deprecated Parser::Options() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589352 (owner: 10C. Scott Ananian) [19:02:30] (03CR) 10Jforrester: [C: 03+2] Replace static border radius value with var [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589168 (owner: 10VolkerE) [19:15:59] (03Merged) 10jenkins-bot: Replace static border radius value with var [extensions/Echo] - 10https://gerrit.wikimedia.org/r/589168 (owner: 10VolkerE) [19:35:39] (03CR) 10VolkerE: [C: 03+1] SpecialHelpMenuWidget: Use ButtonMenuSelectWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/588983 (https://phabricator.wikimedia.org/T178387) (owner: 10Esanders) [19:37:15] 10Growth-Team, 10Notifications: Large number of English Wikinews notifications refuse to be purged - https://phabricator.wikimedia.org/T250432 (10Harej) [19:51:46] (03CR) 10Ppchelko: [C: 03+2] BeforeSpecialMobileDiffDisplay hook: Prepare to accept RevisionRecord [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/588830 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [20:06:29] (03Merged) 10jenkins-bot: BeforeSpecialMobileDiffDisplay hook: Prepare to accept RevisionRecord [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/588830 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [20:46:54] 10Growth-Team, 10GrowthExperiments: Variant tests: C-mobile - https://phabricator.wikimedia.org/T250440 (10MMiller_WMF) [20:51:22] 10Growth-Team, 10GrowthExperiments: Variant tests: C-mobile - https://phabricator.wikimedia.org/T250440 (10MMiller_WMF) @RHo -- please have a read over this to make sure I got the specifications right and didn't miss anything. I have two open questions: * The miniature suggested edit card looks a lot like the... [21:05:32] (03CR) 10C. Scott Ananian: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589352 (owner: 10C. Scott Ananian) [22:40:55] 10Growth-Team, 10GrowthExperiments: Variant tests: D-mobile - https://phabricator.wikimedia.org/T250451 (10MMiller_WMF) [22:45:54] 10Growth-Team, 10GrowthExperiments: Variant tests: D-mobile - https://phabricator.wikimedia.org/T250451 (10MMiller_WMF) @RHo -- please have a read over this to make sure I got the specifications right and didn't miss anything. I have one question. Are you sure we should have that explanatory banner at the top... [23:11:05] 10Growth-Team, 10GrowthExperiments: Variants tests: C vs. D analysis - https://phabricator.wikimedia.org/T250455 (10MMiller_WMF) [23:13:43] (03PS1) 10markahershberger: Introduce dependency injection to replace calls to wfWikiID() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) [23:14:49] 10Growth-Team, 10StructuredDiscussions, 10Patch-For-Review: Flow should use dependency injection instead of wfWikiID() - https://phabricator.wikimedia.org/T250454 (10Reedy) [23:16:42] 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Mobile: Deletion summary in Special:RecentChanges is shown incorrectly - https://phabricator.wikimedia.org/T250308 (10Etonkovidova) I did some additional testing - enabling AMC does not have any effect on the display of super lo... [23:16:48] (03CR) 10Reedy: [C: 04-1] "You don't seem to have committed changes to all files, see the ones with only 1 line change; adding a use statement, but not actually usin" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger) [23:23:45] (03CR) 10jerkins-bot: [V: 04-1] Introduce dependency injection to replace calls to wfWikiID() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger) [23:32:17] 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Mobile: Deletion summary in Special:RecentChanges is shown incorrectly - https://phabricator.wikimedia.org/T250308 (10Zoranzoki21) Thanks @Etonkovidova for testing this. You done it much better than me. I can tell you only to I a... [23:49:27] (03CR) 10markahershberger: "I found some places where Container was used without being qualified like in RevisionActionPermissions.php or UserLocator.php. Maybe it wo" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger) [23:57:49] (03PS2) 10markahershberger: Introduce dependency injection to replace calls to wfWikiID() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) [23:59:36] (03CR) 10Reedy: [C: 04-1] Introduce dependency injection to replace calls to wfWikiID() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589444 (https://phabricator.wikimedia.org/T250454) (owner: 10markahershberger)