[00:10:49] (03CR) 10Catrope: [C: 03+2] Don't attempt to render pageviews if no data is loaded [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/579921 (owner: 10Kosta Harlan) [00:24:07] (03Merged) 10jenkins-bot: Don't attempt to render pageviews if no data is loaded [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/579921 (owner: 10Kosta Harlan) [02:30:57] (03CR) 10DannyS712: [C: 04-1] Replace usage of deprecated Page in favor of WikiPage/Article (039 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/573682 (https://phabricator.wikimedia.org/T239975) (owner: 10Art-Baltai) [08:57:17] (03PS1) 10Legoktm: Clean up container entries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580186 [13:52:16] (03CR) 10Gergő Tisza: [C: 04-1] "> Could you post a screenshot please? I don't see this" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/577247 (https://phabricator.wikimedia.org/T246982) (owner: 10Kosta Harlan) [16:08:32] (03CR) 10Jforrester: [C: 03+2] "Nice." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580186 (owner: 10Legoktm) [16:45:01] (03Merged) 10jenkins-bot: Clean up container entries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580186 (owner: 10Legoktm) [18:05:44] (03Abandoned) 10Zfilipin: Selenium: record videos of all tests [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574779 (https://phabricator.wikimedia.org/T210726) (owner: 10Zfilipin) [18:17:07] (03PS16) 10Zfilipin: selenium: Upgrade from webdriverio v4 to v5 [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/578370 (https://phabricator.wikimedia.org/T244763) [18:17:46] (03CR) 10Zfilipin: "PS16 fixed the final failure." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/578370 (https://phabricator.wikimedia.org/T244763) (owner: 10Zfilipin) [18:54:37] 10Growth-Team, 10Notifications, 10MachineVision, 10Structured-Data-Backlog: Echo email notifications not bundling properly - https://phabricator.wikimedia.org/T240878 (10JJMC89) [19:22:29] 10Growth-Team, 10MediaWiki-Watchlist, 10Core Platform Team, 10MediaWiki-API, 10User-DannyS712: API: Provide parsedtags information - https://phabricator.wikimedia.org/T239410 (10Anomie) In general in MediaWiki over the past few years we've been trying to move towards separation of concerns. Separating fe... [19:23:28] (03PS5) 10DannyS712: Pass 'canonical' for creating ParserOptions instead of using on $wgUser [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/579113 (https://phabricator.wikimedia.org/T246861) [19:23:34] (03CR) 10DannyS712: "> > that is the same as newFromAnon" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/579113 (https://phabricator.wikimedia.org/T246861) (owner: 10DannyS712) [19:38:34] (03CR) 10Gergő Tisza: [C: 03+2] Pass 'canonical' for creating ParserOptions instead of using on $wgUser [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/579113 (https://phabricator.wikimedia.org/T246861) (owner: 10DannyS712) [19:41:34] 10Growth-Team: Growth: technical work to streamline deployment process - https://phabricator.wikimedia.org/T246939 (10kostajh) The way I think about it is, deploying GrowthExperiments to a new community involves a one line configuration update that flips the extension to be on. Then, there would be a protected... [19:57:51] (03Merged) 10jenkins-bot: Pass 'canonical' for creating ParserOptions instead of using on $wgUser [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/579113 (https://phabricator.wikimedia.org/T246861) (owner: 10DannyS712) [20:05:44] (03CR) 10Kosta Harlan: "> Patch Set 9:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/577247 (https://phabricator.wikimedia.org/T246982) (owner: 10Kosta Harlan) [20:16:03] (03PS1) 10Legoktm: Use $wgFlowCacheVersion directly everywhere [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580429 [20:16:06] (03PS1) 10Legoktm: Move history index limits into constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580430 [20:16:12] (03PS1) 10Legoktm: Hardcode handlebars directory in one other place it's used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580431 [20:16:15] (03PS1) 10Legoktm: De-containerify various db related fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580432 [20:21:47] (03CR) 10Jforrester: [C: 03+2] Move history index limits into constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580430 (owner: 10Legoktm) [20:21:52] (03CR) 10Jforrester: [C: 03+2] Use $wgFlowCacheVersion directly everywhere [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580429 (owner: 10Legoktm) [20:22:38] (03CR) 10Jforrester: [C: 03+2] Hardcode handlebars directory in one other place it's used (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580431 (owner: 10Legoktm) [20:26:44] 10Growth-Team, 10StructuredDiscussions: Port Flow to new core dependency injection container - https://phabricator.wikimedia.org/T150350 (10Legoktm) a:03Legoktm I started working on this last week because it'll let us get rid of the pimple dependency. [20:27:21] James_F: I promise if someone chooses to update the directory path, I will adjust the path in the two places it is used for them ;) [20:27:35] legoktm: Well, the test suite will immediately break, so… [20:27:36] (03CR) 10jerkins-bot: [V: 04-1] Use $wgFlowCacheVersion directly everywhere [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580429 (owner: 10Legoktm) [20:27:44] Eurgh. [20:28:05] that's what I get for not running PHPCS locally >.< [20:28:08] 3x Unused use statement [20:28:12] (03CR) 10jerkins-bot: [V: 04-1] Hardcode handlebars directory in one other place it's used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580431 (owner: 10Legoktm) [20:28:19] I'll fix once CI runs over everything [20:28:22] Yeah yeah, the whole stack is poisoned. [20:28:23] Cool. [20:29:32] (03CR) 10jerkins-bot: [V: 04-1] De-containerify various db related fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580432 (owner: 10Legoktm) [20:29:45] (03CR) 10jerkins-bot: [V: 04-1] Move history index limits into constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580430 (owner: 10Legoktm) [20:59:18] (03PS2) 10Legoktm: Use $wgFlowCacheVersion directly everywhere [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580429 [20:59:25] (03PS2) 10Legoktm: Move history index limits into constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580430 [20:59:28] (03PS2) 10Legoktm: Hardcode handlebars directory in one other place it's used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580431 [20:59:31] (03PS2) 10Legoktm: De-containerify various db related fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580432 [21:11:14] (03CR) 10jerkins-bot: [V: 04-1] Hardcode handlebars directory in one other place it's used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580431 (owner: 10Legoktm) [21:11:20] (03CR) 10jerkins-bot: [V: 04-1] Move history index limits into constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580430 (owner: 10Legoktm) [21:13:48] (03CR) 10jerkins-bot: [V: 04-1] De-containerify various db related fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580432 (owner: 10Legoktm) [21:14:35] (03PS3) 10Legoktm: Move history index limits into constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580430 [21:14:38] (03PS3) 10Legoktm: Hardcode handlebars directory in one other place it's used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580431 [21:14:41] (03PS3) 10Legoktm: De-containerify various db related fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580432 [21:14:46] think I got it now [21:29:49] (03CR) 10Jforrester: [C: 03+2] Use $wgFlowCacheVersion directly everywhere [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580429 (owner: 10Legoktm) [21:37:58] (03CR) 10Jforrester: [C: 03+2] Move history index limits into constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580430 (owner: 10Legoktm) [21:38:13] (03CR) 10Jforrester: [C: 03+2] De-containerify various db related fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580432 (owner: 10Legoktm) [21:43:47] (03Merged) 10jenkins-bot: Use $wgFlowCacheVersion directly everywhere [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580429 (owner: 10Legoktm) [21:52:42] (03Merged) 10jenkins-bot: Move history index limits into constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580430 (owner: 10Legoktm) [21:52:45] (03Merged) 10jenkins-bot: Hardcode handlebars directory in one other place it's used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580431 (owner: 10Legoktm) [21:52:48] (03Merged) 10jenkins-bot: De-containerify various db related fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580432 (owner: 10Legoktm) [22:30:19] (03PS1) 10Legoktm: Don't use pimple's factory function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580500 [22:43:46] (03CR) 10jerkins-bot: [V: 04-1] Don't use pimple's factory function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580500 (owner: 10Legoktm) [22:45:16] (03PS2) 10Legoktm: Don't use pimple's factory function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580500 [23:09:30] 10Growth-Team, 10MediaWiki-Watchlist, 10Core Platform Team, 10MediaWiki-API, 10User-DannyS712: API: Provide parsedtags information - https://phabricator.wikimedia.org/T239410 (10kaldari) >Producing HTML brings dependency on the parser, and on the current user's preferences. It also potentially brings a n... [23:26:34] (03PS1) 10Legoktm: Don't unnecessarily wrap MediaWikiServices for Parser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580511 [23:29:44] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580511 (owner: 10Legoktm) [23:50:56] (03PS1) 10Legoktm: Make Container::get() non-static [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580526 [23:52:21] (03CR) 10Legoktm: [C: 04-1] Make Container::get() non-static [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580526 (owner: 10Legoktm) [23:54:41] (03PS2) 10Legoktm: Make Container::get() non-static [extensions/Flow] - 10https://gerrit.wikimedia.org/r/580526