[00:48:33] 10Growth-Team, 10MediaWiki-Configuration, 10Wikimedia-Site-requests, 10Patch-For-Review, and 2 others: Site request: Enable lead paragraph on user namespace for Dutch Wikipedia - https://phabricator.wikimedia.org/T242030 (10Jdlrobson) 05Open→03Resolved a:03Jdlrobson Tested on nl.wiki User:Jdlrobson/d... [01:08:49] (03CR) 10Gergő Tisza: Fix Invocation PHPUnit version incompatibility (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575473 (owner: 10Gergő Tisza) [01:15:09] 10Growth-Team, 10MediaWiki-Watchlist, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Performance-Team (Radar), and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Joeyconnick) Yes, it's become more prominent again in the... [02:13:41] 10Growth-Team, 10MediaWiki-Recent-changes, 10good first task: Function applyDiffStyle uses regexes which do not detect CSS classes appropriately - https://phabricator.wikimedia.org/T36801 (10subins2000) How shall I write the testcase ? I looked in `phpunit/includes`, but couldn't find any similar ones. Any p... [05:33:44] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications, 10Epic, 10Patch-Needs-Improvement: Provide access to Notifications for anonymous users - https://phabricator.wikimedia.org/T58828 (10Aklapper) [05:42:53] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications, 10MediaWiki-Email, 10Patch-Needs-Improvement: Send a notification when someone else edits your userpage - https://phabricator.wikimedia.org/T3876 (10Aklapper) [06:43:48] (03CR) 10Gergő Tisza: [C: 04-1] "Visually this looks fine, but it does not seem possible to dismiss it: if I click on the overlay, I still get the help panel." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575508 (https://phabricator.wikimedia.org/T244434) (owner: 10Kosta Harlan) [06:50:01] (03CR) 10Kosta Harlan: "> Patch Set 8: Code-Review-1" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575508 (https://phabricator.wikimedia.org/T244434) (owner: 10Kosta Harlan) [07:04:53] (03CR) 10Gergő Tisza: "Uhh... probably, but let's leave it to another patch as it seems complicated. If I read it correctly, the one POST code path that leads to" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575673 (https://phabricator.wikimedia.org/T217774) (owner: 10Gergő Tisza) [07:11:58] (03CR) 10Gergő Tisza: [C: 04-1] "> Tapping outside of the drawer should cause it to disappear. Tapping in the drawer should open the help panel. Are you seeing something d" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575508 (https://phabricator.wikimedia.org/T244434) (owner: 10Kosta Harlan) [07:16:41] (03CR) 10DannyS712: [C: 03+1] "LGTM, not sure why L10n-bot doesn't +2" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/576260 (owner: 10L10n-bot) [08:20:02] (03CR) 10Kosta Harlan: [C: 03+2] Assert the current user during all write operations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575673 (https://phabricator.wikimedia.org/T217774) (owner: 10Gergő Tisza) [08:32:11] (03CR) 10Kosta Harlan: [C: 03+2] "I’ll merge this so the patch on top of it can get merged but I think we should try to figure out why the older version of phpunit is used " [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575473 (owner: 10Gergő Tisza) [08:33:17] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Bot edits on Wikidata should be hidden in other project's recent changes - https://phabricator.wikimedia.org/T246746 (10Strainu) [08:38:29] (03Merged) 10jenkins-bot: Assert the current user during all write operations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575673 (https://phabricator.wikimedia.org/T217774) (owner: 10Gergő Tisza) [08:43:42] (03Merged) 10jenkins-bot: Fix Invocation PHPUnit version incompatibility [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575473 (owner: 10Gergő Tisza) [08:43:44] (03CR) 10jerkins-bot: [V: 04-1] Make TaskSuggesterFactory a real factory [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574977 (owner: 10Gergő Tisza) [08:46:04] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Ability to filter by label language in Wikidata RC in other projects - https://phabricator.wikimedia.org/T246749 (10Strainu) [08:46:36] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Bot edits on Wikidata should be hidden in other project's recent changes - https://phabricator.wikimedia.org/T246746 (10Strainu) [09:25:01] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Bot edits on Wikidata should be hidden in other project's recent changes - https://phabricator.wikimedia.org/T246746 (10matej_suchanek) Actually, the bot does not use bot flag... [09:49:26] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, and 2 others: [Epic] Wikidata watchlist improvements (client) - https://phabricator.wikimedia.org/T90435 (10Lydia_Pintscher) [09:49:30] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Bot edits on Wikidata should be hidden in other project's recent changes - https://phabricator.wikimedia.org/T246746 (10Lydia_Pintscher) [09:57:38] 10Growth-Team, 10Parsoid, 10StructuredDiscussions: Exception caught: Request to parsoid for "wikitext" to "html" conversion of content connected to title ... failed: (curl error: 28) Timeout was reached - https://phabricator.wikimedia.org/T245953 (10EAFM) It looks like there's an issue with the wiki being pr... [10:45:01] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Ability to filter by label language in Wikidata RC in other projects - https://phabricator.wikimedia.org/T246749 (10Strainu) [11:13:48] (03PS5) 10Kosta Harlan: Make TaskSuggesterFactory a real factory [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574977 (owner: 10Gergő Tisza) [11:15:16] (03CR) 10jerkins-bot: [V: 04-1] Make TaskSuggesterFactory a real factory [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574977 (owner: 10Gergő Tisza) [11:27:18] (03PS9) 10Kosta Harlan: Guidance: Implement mobile peek [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575508 (https://phabricator.wikimedia.org/T244434) [11:39:04] (03CR) 10Kosta Harlan: "> Patch Set 8:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575508 (https://phabricator.wikimedia.org/T244434) (owner: 10Kosta Harlan) [11:44:43] (03CR) 10Kosta Harlan: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/570730 (https://phabricator.wikimedia.org/T244543) (owner: 10Akinwale-microsoft) [12:23:38] 10Growth-Team, 10MediaWiki-Recent-changes, 10good first task: Function applyDiffStyle uses regexes which do not detect CSS classes appropriately - https://phabricator.wikimedia.org/T36801 (10kostajh) @subins2000 you can create a file in `tests/phpunit/unit/includes/FeedUtilsTest.php` Then you'd want somethi... [13:30:23] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team: Provide a finer level of filtering concerning time - https://phabricator.wikimedia.org/T246768 (10Trizek-WMF) [13:53:00] 10Growth-Team, 10MediaWiki-Watchlist, 10Accessibility, 10Patch-For-Review: Watchlist_Namespaces: Namespaces & tags ButtonSelect must have a label - https://phabricator.wikimedia.org/T246179 (10Volker_E) [14:25:44] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Accessibility, 10Patch-For-Review: RCFilters, Watchlist: Namespaces & tags ButtonSelect must have a label - https://phabricator.wikimedia.org/T246179 (10Volker_E) [14:25:58] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Accessibility, 10Patch-For-Review: RCFilters, Watchlist: Namespaces & tags ButtonSelect must have a label - https://phabricator.wikimedia.org/T246179 (10Volker_E) 05Open→03Resolved p:05Triage→03Medium [14:31:41] (03PS1) 10Kosta Harlan: Newcomer tasks: Set search sort to random for ORES based topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/576347 (https://phabricator.wikimedia.org/T242476) [14:44:08] (03CR) 10jerkins-bot: [V: 04-1] Newcomer tasks: Set search sort to random for ORES based topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/576347 (https://phabricator.wikimedia.org/T242476) (owner: 10Kosta Harlan) [15:13:04] 10Growth-Team, 10Parsoid, 10StructuredDiscussions: Exception caught: Request to parsoid for "wikitext" to "html" conversion of content connected to title ... failed: (curl error: 28) Timeout was reached - https://phabricator.wikimedia.org/T245953 (10Arlolra) Various options at, https://www.mediawiki.org/wiki... [16:01:36] 10Growth-Team, 10PageCuration, 10Patch-For-Review, 10User-DannyS712: Api: Don't log (un)reviewing or tagging as copyvio if state doesn't change - https://phabricator.wikimedia.org/T234074 (10MMiller_WMF) @DannyS712 -- thanks for filing and working on this. I think you're in touch with @kostajh about this... [16:43:47] 10Growth-Team, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-DonationInterface, 10PageCuration, and 2 others: assertArraySubset() will be removed in PHPUnit 9 - https://phabricator.wikimedia.org/T244095 (10aaron) This warnings are fairly spammy, so it would be nice to have a replacement method. [17:32:30] 10Growth-Team, 10PageCuration, 10Patch-For-Review, 10User-DannyS712: Api: Don't log (un)reviewing or tagging as copyvio if state doesn't change - https://phabricator.wikimedia.org/T234074 (10DannyS712) I responded to the concerns @kostajh raised on the patch [17:35:28] 10Growth-Team, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-DonationInterface, 10PageCuration, and 2 others: assertArraySubset() will be removed in PHPUnit 9 - https://phabricator.wikimedia.org/T244095 (10Jdforrester-WMF) Adding a replacement method to `…IntegrationTest` is probably the simplest way fo... [17:38:38] 10Growth-Team, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-DonationInterface, 10PageCuration, and 2 others: assertArraySubset() will be removed in PHPUnit 9 - https://phabricator.wikimedia.org/T244095 (10Mholloway) [17:41:58] 10Growth-Team, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-DonationInterface, 10PageCuration, and 2 others: assertArraySubset() will be removed in PHPUnit 9 - https://phabricator.wikimedia.org/T244095 (10Daimona) >>! In T244095#5937899, @Jdforrester-WMF wrote: > Adding a replacement method to `…Integr... [17:45:17] 10Growth-Team, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-DonationInterface, 10PageCuration, and 2 others: assertArraySubset() will be removed in PHPUnit 9 - https://phabricator.wikimedia.org/T244095 (10Jdforrester-WMF) >>! In T244095#5937930, @Daimona wrote: >>>! In T244095#5937899, @Jdforrester-WMF... [18:20:06] (03PS1) 10Rho: commit summary [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/576407 [18:20:08] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/576407 (owner: 10Rho) [18:31:01] (03CR) 10jerkins-bot: [V: 04-1] commit summary [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/576407 (owner: 10Rho) [20:08:17] (03CR) 10Urbanecm: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574977 (owner: 10Gergő Tisza) [20:24:06] (03CR) 10Gergő Tisza: "These are genuine errors. One of them is from tightening up the phpdoc param rules in I96877aa90, the other is fallout from I0c8fe834da79c" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574977 (owner: 10Gergő Tisza) [21:45:28] (03CR) 10Kosta Harlan: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/576347 (https://phabricator.wikimedia.org/T242476) (owner: 10Kosta Harlan) [21:46:25] (03CR) 10Gergő Tisza: "> It does not seem to follow the blue dot logic for me either (if by that you mean showing once per task type), it shows up on every page " [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575508 (https://phabricator.wikimedia.org/T244434) (owner: 10Kosta Harlan) [22:02:29] (03CR) 10Gergő Tisza: "I was thinking of using an URL parameter to control the behavior so it's easy to test the effect on match quality. (The other thing we mig" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/576347 (https://phabricator.wikimedia.org/T242476) (owner: 10Kosta Harlan) [22:03:47] (03CR) 10Gergő Tisza: [C: 03+2] Guidance: Implement mobile peek [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575508 (https://phabricator.wikimedia.org/T244434) (owner: 10Kosta Harlan) [22:16:34] (03CR) 10jerkins-bot: [V: 04-1] Guidance: Implement mobile peek [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575508 (https://phabricator.wikimedia.org/T244434) (owner: 10Kosta Harlan) [22:16:40] (03PS1) 10Gergő Tisza: Replace loadRevisionFromId which has been removed in I0c8fe834da79c [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/576456 [22:25:29] (03PS6) 10Gergő Tisza: Make TaskSuggesterFactory a real factory [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574977 [22:36:49] (03CR) 10jerkins-bot: [V: 04-1] Make TaskSuggesterFactory a real factory [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574977 (owner: 10Gergő Tisza) [22:37:26] (03CR) 10Akinwale-microsoft: "> Patch Set 5:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/570730 (https://phabricator.wikimedia.org/T244543) (owner: 10Akinwale-microsoft) [23:07:50] (03CR) 10DannyS712: "Should have been done before the removal, sorry" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/576456 (owner: 10Gergő Tisza)