[01:28:57] (03CR) 10Gergő Tisza: [C: 03+2] Guidance: Add pulsing blue dot on desktop and mobile (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574744 (https://phabricator.wikimedia.org/T244435) (owner: 10Kosta Harlan) [01:40:18] (03Merged) 10jenkins-bot: Guidance: Add pulsing blue dot on desktop and mobile [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574744 (https://phabricator.wikimedia.org/T244435) (owner: 10Kosta Harlan) [02:04:14] 10Growth-Team, 10GrowthExperiments, 10Accessibility, 10OOUI (OOUI-0.37.0): Labels of GrowthExperiments dialog FieldLayout's are not connected and widgets inaccessible - https://phabricator.wikimedia.org/T235585 (10Volker_E) [02:04:21] 10Growth-Team, 10GrowthExperiments, 10Accessibility, 10OOUI (OOUI-0.37.0): Labels of GrowthExperiments dialog FieldLayout's are not connected and widgets inaccessible - https://phabricator.wikimedia.org/T235585 (10Volker_E) p:05Triage→03High [03:18:14] (03CR) 10Gergő Tisza: Allow autoconfirmed to execute Special:ClaimMentee (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/573331 (https://phabricator.wikimedia.org/T245639) (owner: 10Urbanecm) [03:49:12] (03CR) 10DannyS712: Allow autoconfirmed to execute Special:ClaimMentee (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/573331 (https://phabricator.wikimedia.org/T245639) (owner: 10Urbanecm) [04:58:30] (03PS1) 10Gergő Tisza: Avoid extra URL parameter when guidance is disabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575128 [04:59:04] (03CR) 10Gergő Tisza: Guidance: Add pulsing blue dot on desktop and mobile (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574744 (https://phabricator.wikimedia.org/T244435) (owner: 10Kosta Harlan) [05:08:03] (03PS2) 10Gergő Tisza: Avoid extra URL parameter when guidance is disabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575128 [05:08:57] (03CR) 10Gergő Tisza: Avoid extra URL parameter when guidance is disabled (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575128 (owner: 10Gergő Tisza) [05:19:50] (03CR) 10jerkins-bot: [V: 04-1] Avoid extra URL parameter when guidance is disabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575128 (owner: 10Gergő Tisza) [05:29:49] (03PS3) 10Gergő Tisza: Avoid extra URL parameter when guidance is disabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575128 [06:02:39] 10Pywikibot-Flow, 10MediaWiki-Vagrant: Cannot read property 'session' of undefined - https://phabricator.wikimedia.org/T246312 (10Tgr) [06:05:58] 10Growth-Team, 10MediaWiki-Vagrant, 10StructuredDiscussions: Vagrant flow role: SELECT command denied to user 'wikiadmin'@'localhost' for table 'flow_revision' - https://phabricator.wikimedia.org/T246313 (10Tgr) [06:06:51] 10Pywikibot-Flow, 10MediaWiki-Vagrant: Cannot read property 'session' of undefined - https://phabricator.wikimedia.org/T246312 (10Tgr) This was right after {T246313} so maybe some kind of secondary error, although the wiki seems to have recovered from that problem just fine. [06:10:01] 10Pywikibot-Flow, 10MediaWiki-Vagrant: Cannot read property 'session' of undefined - https://phabricator.wikimedia.org/T246312 (10Tgr) The error refers to `mw.storage` which is indeed undefined. I wonder if it's an undeclared dependency which has now disappeared due to {2290afb}... [06:54:24] (03CR) 10Urbanecm: Allow autoconfirmed to execute Special:ClaimMentee (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/573331 (https://phabricator.wikimedia.org/T245639) (owner: 10Urbanecm) [09:30:08] 10Growth-Team, 10GrowthExperiments, 10Accessibility, 10OOUI (OOUI-0.37.0): Labels of GrowthExperiments dialog FieldLayout's are not connected and widgets inaccessible - https://phabricator.wikimedia.org/T235585 (10Volker_E) 05Open→03Resolved [10:20:34] 10Growth-Team, 10NewcomerTasks 1.2: Newcomer tasks: opt out of guidance - https://phabricator.wikimedia.org/T246015 (10RHo) [10:59:55] (03CR) 10Kosta Harlan: Avoid extra URL parameter when guidance is disabled (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575128 (owner: 10Gergő Tisza) [11:14:54] 10Growth-Team, 10MediaWiki-Recent-changes, 10good first task: Function applyDiffStyle uses regexes which do not detect CSS classes appropriately - https://phabricator.wikimedia.org/T36801 (10matej_suchanek) [12:19:38] (03CR) 10Kosta Harlan: [WIP] ORES topics UI (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574908 (https://phabricator.wikimedia.org/T244421) (owner: 10Catrope) [12:40:54] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage mobile: Align edit count in start module account submodule - https://phabricator.wikimedia.org/T245971 (10RHo) [12:45:39] (03PS1) 10Kosta Harlan: [developer] Update default reading mode namespaces & help desk title [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575234 [12:46:56] 10Growth-Team, 10GrowthExperiments: Homepage: Adjust highlight box shadow for completed modules - https://phabricator.wikimedia.org/T245970 (10RHo) [13:02:12] 10Growth-Team, 10GrowthExperiments: Mobile Homepage: Remove extra left and right padding on the start module - https://phabricator.wikimedia.org/T245970 (10RHo) [13:24:29] (03PS1) 10Kosta Harlan: Declare missing dependency on mediawiki.storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) [13:24:56] 10Pywikibot-Flow, 10MediaWiki-Vagrant, 10Growth-Team (Current Sprint), 10Patch-For-Review: Cannot read property 'session' of undefined - https://phabricator.wikimedia.org/T246312 (10kostajh) [13:46:21] 10Growth-Team, 10GrowthExperiments: Mobile homepage: Start preview style issues - https://phabricator.wikimedia.org/T246340 (10RHo) [13:47:19] 10Growth-Team, 10GrowthExperiments: Mobile homepage: Start preview style issues - https://phabricator.wikimedia.org/T246340 (10RHo) [13:47:47] 10Growth-Team, 10GrowthExperiments: Mobile homepage: Start preview style issues - https://phabricator.wikimedia.org/T246340 (10RHo) [13:50:35] 10Growth-Team, 10GrowthExperiments: Mobile homepage: Mentor preview background color should be `#F8F9FA` (Base90) - https://phabricator.wikimedia.org/T246341 (10RHo) [13:56:43] 10Growth-Team, 10GrowthExperiments: Mobile homepage: Mentor module style fixes - https://phabricator.wikimedia.org/T246342 (10RHo) [16:46:26] (03CR) 10Esanders: [C: 04-1] "We also use mw.storage in mw.flow.initializer.js which is ext.flow, so should there be a dependency there?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) (owner: 10Kosta Harlan) [16:50:16] (03CR) 10Anomie: [C: 03+1] "Seems ok, haven't tested beyond running update.php on PG to verify it doesn't error out." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/563579 (owner: 10Jack Phoenix) [18:12:39] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Regression: [regression wmf.20 ] RC filters - 'How do these work ?' label is misaligned (again) - https://phabricator.wikimedia.org/T246297 (10Etonkovidova) [19:32:05] (03PS2) 10Catrope: TopicSelectionWidget: UI changes for ORES topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574908 (https://phabricator.wikimedia.org/T244421) [19:37:16] (03PS3) 10Catrope: TopicSelectionWidget: UI changes for ORES topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574908 (https://phabricator.wikimedia.org/T244421) [19:51:27] (03PS4) 10Catrope: TopicSelectionWidget: UI changes for ORES topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574908 (https://phabricator.wikimedia.org/T244421) [19:53:55] (03Abandoned) 10MusikAnimal: [WIP] Index articles-from-redirects by article revision, not redirect [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/521403 (https://phabricator.wikimedia.org/T157048) (owner: 10MusikAnimal) [21:44:07] (03CR) 10Kosta Harlan: "> Patch Set 1: Code-Review-1" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) (owner: 10Kosta Harlan) [21:55:47] (03CR) 10Gergő Tisza: [developer] Update default reading mode namespaces & help desk title (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/575234 (owner: 10Kosta Harlan) [22:02:02] 10Growth-Team, 10GrowthExperiments: Create file with development settings, provide way to load in CI - https://phabricator.wikimedia.org/T246391 (10kostajh) [22:29:38] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage mobile: Align edit count in start module account submodule - https://phabricator.wikimedia.org/T245971 (10MMiller_WMF) [22:30:28] 10Growth-Team, 10GrowthExperiments: Mobile Homepage: Remove extra left and right padding on the start module - https://phabricator.wikimedia.org/T245970 (10MMiller_WMF) [22:30:53] 10Growth-Team, 10GrowthExperiments: Mobile homepage: Start preview style issues - https://phabricator.wikimedia.org/T246340 (10MMiller_WMF) [22:31:47] 10Growth-Team, 10GrowthExperiments: Mobile homepage: Mentor preview background color should be `#F8F9FA` (Base90) - https://phabricator.wikimedia.org/T246341 (10MMiller_WMF) [22:32:19] 10Growth-Team, 10GrowthExperiments: Mobile homepage: Mentor module style fixes - https://phabricator.wikimedia.org/T246342 (10MMiller_WMF) [22:40:28] (03PS15) 10Art-Baltai: Replace usage of deprecated Page in favor of WikiPage/Article [x] Remove all type hints of the Page interface from core, replacing them with Article or WikiPage as appropriate. According to PHPStorm, there are only 7, all apparently quite feasible. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/573688 (https://phabricator.wikimedia.org/T239975) [22:41:03] (03CR) 10Art-Baltai: Replace usage of deprecated Page in favor of WikiPage/Article [x] Remove all type hints of the Page interface from core, replacing them wit (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/573688 (https://phabricator.wikimedia.org/T239975) (owner: 10Art-Baltai) [22:44:35] 10Growth-Team, 10NewcomerTasks 1.2: Newcomer tasks: opt out of guidance - https://phabricator.wikimedia.org/T246015 (10MMiller_WMF) Thanks for the comments, @Trizek-WMF. I agree with some and not with others. Right now, we are not saving any state of the help panel. Every time a user loads the editor, the p... [22:46:11] (03CR) 10Art-Baltai: Replace usage of deprecated Page in favor of WikiPage/Article [x] Remove all type hints of the Page interface from core, replacing them wit (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/573688 (https://phabricator.wikimedia.org/T239975) (owner: 10Art-Baltai) [22:48:44] (03PS16) 10Art-Baltai: Replace usage of deprecated Page in favor of WikiPage/Article [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/573688 (https://phabricator.wikimedia.org/T239975) [22:57:21] (03CR) 10Esanders: [C: 04-1] "ResourceLoader will de-duplicate the dependencies, yes, but for anything other than really basic core dependencies it's often helpful to l" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) (owner: 10Kosta Harlan) [22:58:32] (03CR) 10Esanders: [C: 04-1] "If you'd really prefer just one dependency, then ext.flow would probably be more appropriate as you suggest." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) (owner: 10Kosta Harlan) [23:03:00] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Regression: [regression wmf.20 ] RC filters - 'How do these work ?' label is misaligned (again) - https://phabricator.wikimedia.org/T246297 (10Etonkovidova) [23:07:46] 10Notifications, 10Growth-Team (Current Sprint): Ghost notification count that can't be seen or marked as read - https://phabricator.wikimedia.org/T236488 (10MMiller_WMF) @kostajh -- if you were able to eliminate the ghost notices, does that mean that this task should be resolved? [23:12:51] (03PS17) 10Art-Baltai: Replace usage of deprecated Page in favor of WikiPage/Article [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/573688 (https://phabricator.wikimedia.org/T239975) [23:27:14] (03PS2) 10Gergő Tisza: Make TaskSuggesterFactory a real factory [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574977 [23:29:24] (03CR) 10jerkins-bot: [V: 04-1] Make TaskSuggesterFactory a real factory [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/574977 (owner: 10Gergő Tisza)