[08:34:01] (03CR) 10DannyS712: [C: 04-1] Enable MediaWiki.Usage.ForbiddenFunctions.isset and make pass (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571048 (owner: 10Umherirrender) [08:34:14] (03CR) 10DannyS712: [C: 03+1] "Looks good to go" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/571043 (owner: 10Umherirrender) [09:00:15] (03CR) 10Matěj Suchánek: [C: 03+2] Enable MediaWiki.Usage.ForbiddenFunctions.isset and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/571043 (owner: 10Umherirrender) [09:10:14] (03PS1) 10Matěj Suchánek: Add help link to Special:ClaimMentee [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571249 [09:16:19] (03Merged) 10jenkins-bot: Enable MediaWiki.Usage.ForbiddenFunctions.isset and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/571043 (owner: 10Umherirrender) [10:21:53] (03CR) 10MarcoAurelio: [C: 03+1] Add help link to Special:ClaimMentee [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571249 (owner: 10Matěj Suchánek) [10:25:17] 10Growth-Team, 10GrowthExperiments-MentorshipModule: Add a button to reply to user to mentorship questions - https://phabricator.wikimedia.org/T244651 (10Urbanecm) >>! In T244651#5862527, @matej_suchanek wrote: > Perhaps #discussiontools have something for us? Looks good. For anyone who wants to try it out: h... [11:21:12] 10Growth-Team, 10MW-1.35-notes (1.35.0-wmf.15; 2020-01-14): Deploy Growth experiments at Ukrainian Wikipedia - https://phabricator.wikimedia.org/T231720 (10Trizek-WMF) >>! In T231720#5856485, @Piramidion wrote: > > I've corrected the user link. Thank you! >Do I need to add a sentence about the user page r... [12:08:47] 10Growth-Team, 10GrowthExperiments: Reassign mentees after mentor removal from list - https://phabricator.wikimedia.org/T244728 (10Dyolf77_WMF) [12:34:00] (03CR) 10Kosta Harlan: [C: 03+2] Add help link to Special:ClaimMentee [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571249 (owner: 10Matěj Suchánek) [12:34:57] (03PS5) 10Kosta Harlan: (wip) Homepage mobile style updates [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/570877 (https://phabricator.wikimedia.org/T239442) [12:38:17] (03CR) 10Kosta Harlan: Allow mentors to identify as away (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530436 (https://phabricator.wikimedia.org/T227876) (owner: 10Urbanecm) [12:46:47] (03CR) 10jerkins-bot: [V: 04-1] (wip) Homepage mobile style updates [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/570877 (https://phabricator.wikimedia.org/T239442) (owner: 10Kosta Harlan) [12:46:54] (03Merged) 10jenkins-bot: Add help link to Special:ClaimMentee [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571249 (owner: 10Matěj Suchánek) [12:52:49] 10Growth-Team, 10GrowthExperiments: Reassign mentees after their mentor removed from list - https://phabricator.wikimedia.org/T244728 (10Dyolf77_WMF) [13:30:41] 10Growth-Team, 10GrowthExperiments-Homepage: PHP Notice: Undefined index: label - https://phabricator.wikimedia.org/T244735 (10kostajh) [13:42:45] 10Growth-Team, 10Notifications, 10GrowthExperiments-MentorshipModule, 10User-Urbanecm: Missing text in button in ClaimMentee e-mail notification - https://phabricator.wikimedia.org/T244649 (10Urbanecm) Exactly. [13:42:57] 10Growth-Team, 10GrowthExperiments-Homepage: PHP Notice: Undefined index: label - https://phabricator.wikimedia.org/T244735 (10Urbanecm) [13:42:59] 10Growth-Team, 10Notifications, 10GrowthExperiments-MentorshipModule, 10User-Urbanecm: Missing text in button in ClaimMentee e-mail notification - https://phabricator.wikimedia.org/T244649 (10Urbanecm) [13:43:14] 10Growth-Team, 10Notifications, 10GrowthExperiments-MentorshipModule, 10User-Urbanecm: Missing text in button in ClaimMentee e-mail notification - https://phabricator.wikimedia.org/T244649 (10Urbanecm) [13:51:46] (03PS4) 10Ammarpad: Replace deprecated IP class with IP Utilities [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571035 (https://phabricator.wikimedia.org/T242556) [14:26:27] (03PS1) 10Urbanecm: Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) [14:27:36] (03CR) 10jerkins-bot: [V: 04-1] Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) (owner: 10Urbanecm) [14:28:59] 10Growth-Team, 10GrowthExperiments-Homepage: Mentor selection is error prone - https://phabricator.wikimedia.org/T240451 (10Urbanecm) Proposal: Validate usernames in `Mentor::getMentors()`. What do you think, Kosta? [14:36:07] (03PS2) 10Urbanecm: Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) [14:37:41] (03CR) 10jerkins-bot: [V: 04-1] Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) (owner: 10Urbanecm) [14:38:17] (03CR) 10Kosta Harlan: Add API for changing mentor (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) (owner: 10Urbanecm) [14:52:09] (03PS3) 10Urbanecm: Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) [14:52:20] (03CR) 10Urbanecm: Add API for changing mentor (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) (owner: 10Urbanecm) [14:55:45] (03PS4) 10Urbanecm: Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) [14:56:44] 10Growth-Team, 10GrowthExperiments-Homepage: Mentor selection is error prone - https://phabricator.wikimedia.org/T240451 (10kostajh) Yep, sounds good to me! [14:56:54] (03CR) 10jerkins-bot: [V: 04-1] Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) (owner: 10Urbanecm) [14:59:30] (03PS5) 10Urbanecm: Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) [15:00:59] (03CR) 10jerkins-bot: [V: 04-1] Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) (owner: 10Urbanecm) [15:04:44] (03PS6) 10Urbanecm: Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) [15:09:08] (03CR) 10jerkins-bot: [V: 04-1] Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) (owner: 10Urbanecm) [15:10:34] (03PS7) 10Urbanecm: Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) [15:14:38] (03CR) 10jerkins-bot: [V: 04-1] Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) (owner: 10Urbanecm) [15:16:47] (03PS8) 10Urbanecm: Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) [15:22:47] (03PS6) 10Kosta Harlan: (wip) Homepage mobile style updates [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/570877 (https://phabricator.wikimedia.org/T239442) [15:28:36] (03CR) 10jerkins-bot: [V: 04-1] Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) (owner: 10Urbanecm) [15:33:53] (03CR) 10jerkins-bot: [V: 04-1] (wip) Homepage mobile style updates [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/570877 (https://phabricator.wikimedia.org/T239442) (owner: 10Kosta Harlan) [15:44:44] 10Growth-Team, 10GrowthExperiments-Homepage, 10User-Urbanecm: Mentor selection is error prone - https://phabricator.wikimedia.org/T240451 (10Urbanecm) a:03Urbanecm I'll implement that then! I'll also remove the exception, given it wouldn't be possible to raise it. [15:45:22] 10Growth-Team, 10GrowthExperiments: Reassign mentees after their mentor removed from list - https://phabricator.wikimedia.org/T244728 (10Dyolf77_WMF) What could be the message for the mentees when they are redirected to the new mentors? Something like: `Your mentor [old_mentor_name] is not available now. We in... [16:23:11] 10Growth-Team, 10GrowthExperiments: Reassign mentees after their mentor removed from list - https://phabricator.wikimedia.org/T244728 (10Trizek-WMF) Should we message them? It could it be a source of confusion? Maybe a notification would be better instead? [16:25:01] 10Growth-Team, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): Deploy GrowthExperiments on Serbian Wikipedia - https://phabricator.wikimedia.org/T241181 (10Trizek-WMF) @Zoranzoki21, we are indeed missing the Privacy policy translation. When done, we will plan the deployment, probably at the end of this month. [16:25:41] 10Growth-Team, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): Deploy GrowthExperiments on Serbian Wikipedia - https://phabricator.wikimedia.org/T241181 (10Trizek-WMF) [16:27:33] 10Growth-Team, 10GrowthExperiments: Reassign mentees after their mentor removed from list - https://phabricator.wikimedia.org/T244728 (10Dyolf77_WMF) >>! In T244728#5865488, @Trizek-WMF wrote: > Should we message them? It could it be a source of confusion? Maybe a notification would be better instead? Yes, a... [16:34:55] 10Growth-Team, 10GrowthExperiments, 10User-zeljkofilipin: Upgrade webdriverio to version 5 for GrowthExperiments - https://phabricator.wikimedia.org/T244763 (10zeljkofilipin) [16:35:17] 10Growth-Team, 10GrowthExperiments, 10User-zeljkofilipin: Upgrade webdriverio to version 5 for GrowthExperiments - https://phabricator.wikimedia.org/T244763 (10zeljkofilipin) p:05Triage→03Medium [16:35:35] 10Growth-Team, 10GrowthExperiments, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Upgrade webdriverio to version 5 for GrowthExperiments - https://phabricator.wikimedia.org/T244763 (10zeljkofilipin) [16:38:08] 10Growth-Team, 10GrowthExperiments, 10Quality-and-Test-Engineering-Team (QTE), 10Patch-For-Review, 10User-zeljkofilipin: Add accessibility check for Homepage - https://phabricator.wikimedia.org/T232638 (10zeljkofilipin) [16:38:21] 10Growth-Team, 10GrowthExperiments, 10Quality-and-Test-Engineering-Team (QTE), 10Patch-For-Review, 10User-zeljkofilipin: Add accessibility check for Homepage - https://phabricator.wikimedia.org/T232638 (10zeljkofilipin) a:05Ephemeralwaves→03zeljkofilipin [16:57:22] 10Growth-Team, 10GrowthExperiments: Reassign mentees after their mentor removed from list - https://phabricator.wikimedia.org/T244728 (10Trizek-WMF) I don't think that we should notify people who have never contacted their mentor. [17:06:14] 10Growth-Team, 10MediaWiki-Watchlist, 10Core Platform Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Chaddy) For weeks I had no problems. But today again the error... [17:07:59] 10Growth-Team, 10MediaWiki-Watchlist, 10Core Platform Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) No, I'm seeing it constantly. [18:02:38] (03PS9) 10Urbanecm: Add API for changing mentor [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/571293 (https://phabricator.wikimedia.org/T244744) [19:07:06] (03CR) 10Umherirrender: [C: 04-1] Replace deprecated IP class with IP Utilities (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571035 (https://phabricator.wikimedia.org/T242556) (owner: 10Ammarpad) [19:07:54] (03CR) 10Umherirrender: [C: 04-1] Replace deprecated IP class with IP Utilities (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571035 (https://phabricator.wikimedia.org/T242556) (owner: 10Ammarpad) [19:14:35] (03PS2) 10Umherirrender: Enable MediaWiki.Usage.ForbiddenFunctions.isset and make pass [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571048 [20:23:39] (03CR) 10Anomie: "Seems ok other that one more TEXT→VARCHAR. Works locally in a quick test (talk page notification)." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/565045 (owner: 10Jack Phoenix) [20:23:45] (03PS1) 10Esanders: Revert "Style improvements to Echo OOUI dialog in desktop Minerva" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/571351 (https://phabricator.wikimedia.org/T241090) [20:24:22] (03PS2) 10Esanders: Revert "Style improvements to Echo OOUI dialog in desktop Minerva" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/571351 (https://phabricator.wikimedia.org/T241090) [20:38:32] (03CR) 10Kosta Harlan: [C: 03+2] Revert "Style improvements to Echo OOUI dialog in desktop Minerva" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/571351 (https://phabricator.wikimedia.org/T241090) (owner: 10Esanders) [20:38:47] 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10MinervaNeue (Desktop), 10Patch-For-Review: Echo on desktop Minerva - https://phabricator.wikimedia.org/T241090 (10kostajh) 05Resolved→03Open [20:54:27] (03Merged) 10jenkins-bot: Revert "Style improvements to Echo OOUI dialog in desktop Minerva" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/571351 (https://phabricator.wikimedia.org/T241090) (owner: 10Esanders) [21:52:00] 10Growth-Team, 10StructuredDiscussions: Mention User Edit field and (input[placeholder="Start\ a\ new\ topic"]) field do not have accessibility label. - https://phabricator.wikimedia.org/T244793 (10Akinwale-microsoft) [21:52:27] 10Growth-Team, 10StructuredDiscussions: Mention User Edit field and (input[placeholder="Start\ a\ new\ topic"]) field do not have accessibility label. - https://phabricator.wikimedia.org/T244793 (10Akinwale-microsoft) [21:53:52] 10Growth-Team, 10StructuredDiscussions: Mention User Edit field and (input[placeholder="Start\ a\ new\ topic"]) field do not have accessibility label. - https://phabricator.wikimedia.org/T244793 (10Akinwale-microsoft) [21:54:06] 10Growth-Team, 10StructuredDiscussions: Mention User Edit field and (input[placeholder="Start\ a\ new\ topic"]) field do not have accessibility label. - https://phabricator.wikimedia.org/T244793 (10Akinwale-microsoft) [22:20:05] 10Growth-Team, 10StructuredDiscussions, 10Accessibility: Mention User Edit field and (input[placeholder="Start\ a\ new\ topic"]) field do not have accessibility label. - https://phabricator.wikimedia.org/T244793 (10Aklapper) [22:56:55] (03PS1) 10Akinwale-microsoft: Fix: Text input label [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571376 [23:17:12] 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10MinervaNeue (Desktop): Echo rendering issues on desktop Minerva, not usable on mobile - https://phabricator.wikimedia.org/T241090 (10Jdlrobson) [23:28:33] (03PS1) 10VolkerE: Add `aria-label` to 'Start a new topic' input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571385 (https://phabricator.wikimedia.org/T244793) [23:41:36] (03PS1) 10Jdlrobson: Properly scoped style improvements to Echo OOUI dialog in desktop Minerva [extensions/Echo] - 10https://gerrit.wikimedia.org/r/571389 (https://phabricator.wikimedia.org/T241090) [23:42:04] (03CR) 10jerkins-bot: [V: 04-1] Add `aria-label` to 'Start a new topic' input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571385 (https://phabricator.wikimedia.org/T244793) (owner: 10VolkerE) [23:46:28] 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10MinervaNeue (Desktop), 10Patch-For-Review: Echo rendering issues on desktop Minerva, not usable on mobile - https://phabricator.wikimedia.org/T241090 (10Jdlrobson) I've resubmitted the fix with CSS scoping. C...