[01:36:16] 10Growth-Team, 10DBA, 10PageCuration, 10User-DannyS712: pagetriage_page_tags table missing rows - https://phabricator.wikimedia.org/T243731 (10DannyS712) [01:51:57] 10Growth-Team, 10Notifications, 10Technical-Debt, 10User-DannyS712: Echo needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T243732 (10DannyS712) p:05Triage→03Normal [01:52:29] (03PS1) 10DannyS712: Remove use of global $wgUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/567374 (https://phabricator.wikimedia.org/T243732) [01:52:54] (03PS2) 10DannyS712: Remove use of global $wgUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/567374 (https://phabricator.wikimedia.org/T243732) [01:53:34] (03CR) 10DannyS712: "Partial revert created at I22c4918fc7e8b3d1364a95de3958c055059971b8, please see T243732" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299673 (https://phabricator.wikimedia.org/T139665) (owner: 10Catrope) [01:55:43] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/567374 (https://phabricator.wikimedia.org/T243732) (owner: 10DannyS712) [03:27:55] 10Growth-Team, 10DBA, 10PageCuration, 10User-DannyS712: pagetriage_page_tags table missing rows - https://phabricator.wikimedia.org/T243731 (10DannyS712) ...now I got the notifications that they were patrolled. How long is it supposed to take for the data to be populated? [03:28:00] 10Growth-Team, 10PageCuration, 10User-DannyS712: pagetriage_page_tags table missing rows - https://phabricator.wikimedia.org/T243731 (10Marostegui) From what I can see, the rows are, at least, consistent in all enwiki hosts, as in, the data is the same, so we have no drifts. I guess this is something on the... [03:45:37] (03PS1) 10DannyS712: [WIP] PK [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 [03:48:46] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (owner: 10DannyS712) [03:54:38] (03PS2) 10DannyS712: [WIP] PK [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 [03:55:52] (03CR) 10jerkins-bot: [V: 04-1] [WIP] PK [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (owner: 10DannyS712) [03:57:45] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (owner: 10DannyS712) [03:59:35] (03PS3) 10DannyS712: [WIP] PK [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 [04:00:48] (03CR) 10jerkins-bot: [V: 04-1] [WIP] PK [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (owner: 10DannyS712) [04:02:42] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (owner: 10DannyS712) [04:10:19] (03PS4) 10DannyS712: Convert ptrpt_page_tag_id from unique index to primary key [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (https://phabricator.wikimedia.org/T243073) [04:11:39] (03CR) 10jerkins-bot: [V: 04-1] Convert ptrpt_page_tag_id from unique index to primary key [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (https://phabricator.wikimedia.org/T243073) (owner: 10DannyS712) [04:13:04] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (https://phabricator.wikimedia.org/T243073) (owner: 10DannyS712) [08:53:22] (03CR) 10Kosta Harlan: [C: 04-1] "Thanks for the patch. But won't we be reintroducing the problem in T139665 if this is merged? It seems like we need to pursue one of the f" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/567374 (https://phabricator.wikimedia.org/T243732) (owner: 10DannyS712) [08:54:35] (03CR) 10Kosta Harlan: [C: 03+2] Update list of special pages GrowthExperiments.alias.php has aliases for [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567259 (owner: 10Urbanecm) [09:07:21] (03Merged) 10jenkins-bot: Update list of special pages GrowthExperiments.alias.php has aliases for [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567259 (owner: 10Urbanecm) [11:59:09] (03PS1) 10Urbanecm: QuestionPoster: Use newsectionsummary for posting questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567433 (https://phabricator.wikimedia.org/T243179) [12:00:33] (03CR) 10jerkins-bot: [V: 04-1] QuestionPoster: Use newsectionsummary for posting questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567433 (https://phabricator.wikimedia.org/T243179) (owner: 10Urbanecm) [12:04:09] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567433 (https://phabricator.wikimedia.org/T243179) (owner: 10Urbanecm) [12:11:28] (03PS2) 10Urbanecm: QuestionPoster: Use newsectionsummary for posting questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567433 (https://phabricator.wikimedia.org/T243179) [12:12:43] (03CR) 10jerkins-bot: [V: 04-1] QuestionPoster: Use newsectionsummary for posting questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567433 (https://phabricator.wikimedia.org/T243179) (owner: 10Urbanecm) [12:12:51] 10Growth-Team, 10GrowthExperiments-Help panel, 10GrowthExperiments-MentorshipModule, 10Patch-For-Review, 10User-Urbanecm: Make new question summaries clickable - https://phabricator.wikimedia.org/T243179 (10Urbanecm) I feel there has to be something simpler to accomplish this, but...I was unable to find... [12:16:21] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567433 (https://phabricator.wikimedia.org/T243179) (owner: 10Urbanecm) [12:18:29] (03PS3) 10Urbanecm: QuestionPoster: Use newsectionsummary for posting questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567433 (https://phabricator.wikimedia.org/T243179) [12:22:15] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567433 (https://phabricator.wikimedia.org/T243179) (owner: 10Urbanecm) [13:15:23] (03PS1) 10Kosta Harlan: Help Panel: Reword placeholder text [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567443 (https://phabricator.wikimedia.org/T243694) [13:19:40] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567443 (https://phabricator.wikimedia.org/T243694) (owner: 10Kosta Harlan) [13:31:59] (03CR) 10Kosta Harlan: [C: 03+1] "Looks good, thanks for working on this. A bunch of small nitpicks follow :)" (034 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567433 (https://phabricator.wikimedia.org/T243179) (owner: 10Urbanecm) [14:59:11] (03PS1) 10Kosta Harlan: StartEditing: Handle configuration errors more gracefully [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567464 [15:03:30] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567464 (owner: 10Kosta Harlan) [15:10:58] (03CR) 10jerkins-bot: [V: 04-1] StartEditing: Handle configuration errors more gracefully [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567464 (owner: 10Kosta Harlan) [15:20:04] (03PS2) 10Kosta Harlan: StartEditing: Handle configuration errors more gracefully [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567464 [15:24:18] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567464 (owner: 10Kosta Harlan) [15:42:48] 10Growth-Team, 10User-Dyolf77, 10User-PPham, 10User-Urbanecm, 10User-revi: Growth team - Mentor audit - https://phabricator.wikimedia.org/T243172 (10revi) === kowiki === * [[https://ko.wikipedia.org/w/index.php?title=%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EC%83%88_%EC%82%AC%EC%9A%A9%EC%9E%90_%EA%B2%BD%ED... [15:47:26] 10Growth-Team, 10MediaWiki-Watchlist, 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Please clear my watchlist on commons - https://phabricator.wikimedia.org/T243449 (10Zoranzoki21) >>! In T243449#5825951, @Urbanecm wrote: > There's not really a maintenance script we can use on this one, bu... [15:53:19] (03CR) 10TheSandDoctor: [C: 03+1] "Looks good to me." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/565045 (https://phabricator.wikimedia.org/T191738) (owner: 10Jack Phoenix) [18:42:09] 10Growth-Team, 10MediaWiki-Watchlist, 10Wikimedia-Site-requests, 10Patch-For-Review, and 2 others: Please clear my watchlist on commons - https://phabricator.wikimedia.org/T243449 (10Addshore) a:03Addshore I can see what needs to be fixed for the special page as I'll take a look at this. [18:45:03] (03CR) 10DannyS712: "> Thanks for the patch. But won't we be reintroducing the problem in" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/567374 (https://phabricator.wikimedia.org/T243732) (owner: 10DannyS712) [19:45:46] 10Growth-Team, 10MediaWiki-Watchlist, 10Wikimedia-Site-requests, 10Patch-For-Review, and 2 others: Please clear my watchlist on commons - https://phabricator.wikimedia.org/T243449 (10Urbanecm) Thanks @addshore. Guessing getWatchlist() is the bottleneck here? [20:28:07] (03PS1) 10Kosta Harlan: ChangeMentor: Remove check if mentee was false [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567503 [20:28:09] (03PS1) 10Kosta Harlan: ChangeMentor: Typehint utility functions and add log pager mock helper [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567504 [20:28:11] (03PS1) 10Kosta Harlan: ChangeMentor: Add tests for validate() method [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567505 [20:32:11] (03PS2) 10Kosta Harlan: ChangeMentor: Add tests for validate() method [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567505 [20:33:39] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567504 (owner: 10Kosta Harlan) [20:33:46] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567505 (owner: 10Kosta Harlan) [20:33:47] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567503 (owner: 10Kosta Harlan) [20:35:51] (03PS1) 10Kosta Harlan: ChangeMentor: Test for execute() method [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567506 [20:37:34] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567505 (owner: 10Kosta Harlan) [20:40:45] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567506 (owner: 10Kosta Harlan) [20:42:57] (03PS1) 10Kosta Harlan: Hygiene: Fix eslint warnings [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567508 [20:48:02] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567508 (owner: 10Kosta Harlan) [20:49:30] (03CR) 10jerkins-bot: [V: 04-1] ChangeMentor: Test for execute() method [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/567506 (owner: 10Kosta Harlan) [21:00:22] 10Growth-Team, 10GrowthExperiments, 10LibUp, 10MediaWiki-extensions-General, and 2 others: Upgrade nyc to latest version - https://phabricator.wikimedia.org/T243790 (10Umherirrender) [21:06:30] 10Growth-Team, 10GrowthExperiments, 10LibUp, 10MediaWiki-extensions-General, and 2 others: Upgrade nyc to latest version - https://phabricator.wikimedia.org/T243790 (10Legoktm) > Could be done using the libup / config file instead. I don't know if it's safe to upgrade, but doing it via the libup/config r... [21:22:00] 10Growth-Team, 10GrowthExperiments, 10LibUp, 10MediaWiki-extensions-General, and 2 others: Upgrade nyc to latest version - https://phabricator.wikimedia.org/T243790 (10Umherirrender) [21:22:02] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Tracking-Neverending: Watchlist and recent changes usability issues (tracking) - https://phabricator.wikimedia.org/T53942 (10thiemowmde) [21:56:11] (03CR) 10Reedy: [C: 04-1] "So the reason this breaks, is CI will create the table as per the new definition, it will then unconditionally try to run your modificatio" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (https://phabricator.wikimedia.org/T243073) (owner: 10DannyS712) [22:03:55] 10Growth-Team, 10MediaWiki-Watchlist, 10Wikimedia-Site-requests, 10Patch-For-Review, and 2 others: Please clear my watchlist on commons - https://phabricator.wikimedia.org/T243449 (10Reedy) I imagine it's trying to count 1M+ rows from the watchlist table `lang=php /** * @since 1.31 * @param UserIdent... [22:27:40] (03PS5) 10DannyS712: Convert ptrpt_page_tag_id from unique index to primary key [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (https://phabricator.wikimedia.org/T243073) [22:28:57] (03CR) 10jerkins-bot: [V: 04-1] Convert ptrpt_page_tag_id from unique index to primary key [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (https://phabricator.wikimedia.org/T243073) (owner: 10DannyS712) [22:31:34] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (https://phabricator.wikimedia.org/T243073) (owner: 10DannyS712) [23:08:33] (03CR) 10Reedy: [C: 04-1] Convert ptrpt_page_tag_id from unique index to primary key (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (https://phabricator.wikimedia.org/T243073) (owner: 10DannyS712) [23:57:08] (03PS6) 10DannyS712: Convert ptrpt_page_tag_id from unique index to primary key [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/567390 (https://phabricator.wikimedia.org/T243073)