[01:27:08] (03CR) 10Catrope: StartEditingDialog: Add topics (0311 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [01:27:15] (03PS8) 10Catrope: StartEditingDialog: Add topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) [01:32:31] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [01:33:16] (03CR) 10Catrope: [C: 03+2] Suggested Edits: Add topic filter button [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/562516 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [01:35:08] (03PS9) 10Catrope: StartEditingDialog: Add topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) [01:35:38] (03CR) 10Catrope: "PS9: rebase onto https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/562516 , only trivial conflicts in en.json and " [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [01:41:56] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [01:45:53] (03Merged) 10jenkins-bot: Suggested Edits: Add topic filter button [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/562516 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [01:46:31] (03PS10) 10Catrope: StartEditingDialog: Add topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) [01:46:52] (03CR) 10jerkins-bot: [V: 04-1] StartEditingDialog: Add topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [01:46:54] (03CR) 10Catrope: "PS10: Cleanup from the rebase" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [04:41:44] 10Growth-Team, 10Notifications: Ghost notification count that can't be seen or marked as read - https://phabricator.wikimedia.org/T236488 (10Krinkle) Might be related: T220762. Note that as of writing I still have a ghost badge on every page every day with "3 notifications" that I can't seem to shake off :) [06:59:30] (03PS1) 10DannyS712: Remove some extra whitespace from ApiPageTriageTagging [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/563044 [07:00:10] (03PS2) 10DannyS712: Remove some extra whitespace from ApiPageTriageTagging [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/563044 [07:01:48] (03CR) 10Legoktm: [C: 03+2] Remove some extra whitespace from ApiPageTriageTagging [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/563044 (owner: 10DannyS712) [07:05:33] (03CR) 10DannyS712: "> Patch Set 2: Code-Review+2" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/563044 (owner: 10DannyS712) [07:06:38] (03Merged) 10jenkins-bot: Remove some extra whitespace from ApiPageTriageTagging [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/563044 (owner: 10DannyS712) [08:09:16] (03CR) 10Kosta Harlan: Newcomer tasks: pass topic matching enabled flag to "no results" cards [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/562664 (https://phabricator.wikimedia.org/T238613) (owner: 10Gergő Tisza) [08:09:25] (03PS4) 10Kosta Harlan: Newcomer tasks: pass topic matching enabled flag to "no results" cards [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/562664 (https://phabricator.wikimedia.org/T238613) (owner: 10Gergő Tisza) [08:09:46] (03CR) 10Kosta Harlan: [C: 03+2] Newcomer tasks: pass topic matching enabled flag to "no results" cards [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/562664 (https://phabricator.wikimedia.org/T238613) (owner: 10Gergő Tisza) [08:20:29] (03Merged) 10jenkins-bot: Newcomer tasks: pass topic matching enabled flag to "no results" cards [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/562664 (https://phabricator.wikimedia.org/T238613) (owner: 10Gergő Tisza) [08:24:56] (03PS11) 10Kosta Harlan: StartEditingDialog: Add topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [08:30:22] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [08:39:57] 10Growth-Team, 10Notifications, 10Thanks, 10User-DannyS712: EchoEvent::create should allow returning a status object - https://phabricator.wikimedia.org/T242153 (10matej_suchanek) {T169834} seems duplicate and even has a pending patch. [09:09:16] 10Growth-Team, 10PageCuration: Page Curation: Swap the order of reviewer and author in message recipient menu - https://phabricator.wikimedia.org/T242324 (10Ammarpad) [10:14:29] (03PS1) 10Thiemo Kreuz (WMDE): Remove unused code from RevisionFormatterTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563142 [10:21:08] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563142 (owner: 10Thiemo Kreuz (WMDE)) [10:23:25] (03PS1) 10Thiemo Kreuz (WMDE): Reduce nesting by utilizing guard clauses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563143 [10:28:29] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563143 (owner: 10Thiemo Kreuz (WMDE)) [10:29:16] (03PS1) 10Thiemo Kreuz (WMDE): Replace lax assertEquals with more strict assertions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563145 [10:30:16] (03PS1) 10Thiemo Kreuz (WMDE): No need to use a MockBuilder on an interface [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563146 [10:31:26] (03PS1) 10Thiemo Kreuz (WMDE): Replace "fromdbmaster" string with WikiPage::READ_LATEST const [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563147 [10:34:57] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563145 (owner: 10Thiemo Kreuz (WMDE)) [10:36:16] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563146 (owner: 10Thiemo Kreuz (WMDE)) [10:36:46] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/563147 (owner: 10Thiemo Kreuz (WMDE)) [10:40:55] (03PS2) 10Thiemo Kreuz (WMDE): Replace calls to deprecated MWTimestamp::getHumanTimestamp() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/514319 [10:46:19] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/514319 (owner: 10Thiemo Kreuz (WMDE)) [11:42:26] (03CR) 10Kosta Harlan: [C: 03+2] "The styles on mobile still seem a little off (the "we'll suggest..." text should be a bit bigger) but merging this as it works well overal" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [11:55:52] (03Merged) 10jenkins-bot: StartEditingDialog: Add topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/559916 (https://phabricator.wikimedia.org/T238610) (owner: 10Catrope) [11:57:01] 10Growth-Team, 10Notifications: Ghost notification count that can't be seen or marked as read - https://phabricator.wikimedia.org/T236488 (10kostajh) @Krinkle do you see this with Minerva or another skin? [11:58:46] (03PS1) 10Kosta Harlan: Suggested Edits: Only interact with topic filter button if defined [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563164 (https://phabricator.wikimedia.org/T238611) [12:55:49] 10Growth-Team, 10Notifications: Notifications "mark as unread" - https://phabricator.wikimedia.org/T242214 (10Ciell) Hi Masumrezarock100, Yes, it does exist for "alerts" but not for "notices". I don't know the distinction between the two, but sometimes the one lights up, and with other notification the other... [15:02:37] (03PS1) 10Kosta Harlan: Suggested Edits: Add pulsing blue dot if user never set topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563187 (https://phabricator.wikimedia.org/T238611) [15:56:05] (03PS3) 10Simkawaii: Selenium tests for verifying default page when click on username link [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/557098 (https://phabricator.wikimedia.org/T233469) [15:56:05] (03CR) 10Simkawaii: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/557098 (https://phabricator.wikimedia.org/T233469) (owner: 10Simkawaii) [16:05:42] (03PS2) 10Simkawaii: Selenium tests for verifying the sections of Start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/560421 (https://phabricator.wikimedia.org/T233469) [16:12:07] (03CR) 10Simkawaii: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/560421 (https://phabricator.wikimedia.org/T233469) (owner: 10Simkawaii) [17:17:11] 10Growth-Team, 10MediaWiki-extensions-FlaggedRevs: Flagged revs Special:ValidationStatistics update doesn't work - https://phabricator.wikimedia.org/T163107 (10Tufor) anyone? [18:13:59] 10Growth-Team, 10Notifications, 10Thanks, 10User-DannyS712: EchoEvent::create should allow returning a status object - https://phabricator.wikimedia.org/T242153 (10DannyS712) >>! In T242153#5789029, @matej_suchanek wrote: > {T169834} seems duplicate and even has a pending patch. Didn't see that [18:14:08] 10Growth-Team, 10Notifications, 10Thanks, 10User-DannyS712: EchoEvent::create should allow returning a status object - https://phabricator.wikimedia.org/T242153 (10DannyS712) [18:14:12] 10Growth-Team, 10Notifications, 10Patch-For-Review, 10good first task: Change EchoEvent->create to return Status or throw exceptions, never false - https://phabricator.wikimedia.org/T169834 (10DannyS712) [18:14:28] 10Growth-Team, 10Notifications, 10Thanks, 10User-DannyS712: EchoEvent::create should allow returning a status object - https://phabricator.wikimedia.org/T242153 (10DannyS712) [18:14:32] 10Growth-Team, 10Notifications, 10Patch-For-Review, 10good first task: Change EchoEvent->create to return Status or throw exceptions, never false - https://phabricator.wikimedia.org/T169834 (10DannyS712) [18:28:52] (03PS1) 10DannyS712: Send a message: Default to article creator [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/563238 (https://phabricator.wikimedia.org/T242324) [18:29:43] (03PS2) 10DannyS712: Send a message: Default to article creator [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/563238 (https://phabricator.wikimedia.org/T242324) [18:30:35] 10Growth-Team, 10PageCuration, 10Patch-For-Review: Page Curation: Swap the order of reviewer and author in message recipient menu - https://phabricator.wikimedia.org/T242324 (10DannyS712) @Ammarpad sorry, didn't realize that you had assigned this to yourself. I've uploaded a patch that should fix this - can... [20:50:00] 10Growth-Team, 10StructuredDiscussions: Extension:StructuredDiscussion Accessibility bugs - https://phabricator.wikimedia.org/T242369 (10Akinwale-microsoft) [20:54:12] (03PS2) 10Kosta Harlan: Suggested Edits: Add pulsing blue dot if user never set topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563187 (https://phabricator.wikimedia.org/T238611) [20:58:04] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563187 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [21:08:34] (03PS3) 10Kosta Harlan: Suggested Edits: Add pulsing blue dot if user never set topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563187 (https://phabricator.wikimedia.org/T238611) [21:12:50] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563187 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [21:29:34] 10Growth-Team, 10MediaWiki-extensions-FlaggedRevs: Flagged revs Special:ValidationStatistics update doesn't work - https://phabricator.wikimedia.org/T163107 (10Aklapper) @Tufor: T185664. [21:41:04] (03PS1) 10Kosta Harlan: Suggested Edits: Set topic names or count in button [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563282 (https://phabricator.wikimedia.org/T238611) [21:45:09] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563282 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [21:54:38] (03CR) 10jerkins-bot: [V: 04-1] Suggested Edits: Set topic names or count in button [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563282 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [21:56:25] (03PS2) 10Kosta Harlan: Suggested Edits: Set topic names or count in button [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563282 (https://phabricator.wikimedia.org/T238611) [22:01:47] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563282 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [22:02:07] 10Growth-Team, 10StructuredDiscussions, 10Accessibility: Extension:StructuredDiscussion Accessibility bugs - https://phabricator.wikimedia.org/T242369 (10Akinwale-microsoft) [22:06:15] 10Growth-Team, 10MediaWiki-Watchlist, 10Accessibility: Watchlist Section Accessibility bugs - https://phabricator.wikimedia.org/T242373 (10Reedy) >Navigate to the visual editor What does that mean? The URL in the file suggests you're staying on Special:Watchlist I note attaching a HTML file isn't a very us... [22:17:39] (03CR) 10Catrope: [C: 03+2] Suggested Edits: Only interact with topic filter button if defined [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563164 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [22:19:23] (03PS1) 10Catrope: Newcomer tasks: Expose task type / topic set in API parameter info [extensions/GrowthExperiments] (wmf/1.35.0-wmf.14) - 10https://gerrit.wikimedia.org/r/563287 (https://phabricator.wikimedia.org/T240512) [22:23:47] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] (wmf/1.35.0-wmf.14) - 10https://gerrit.wikimedia.org/r/563287 (https://phabricator.wikimedia.org/T240512) (owner: 10Catrope) [22:31:14] (03Merged) 10jenkins-bot: Suggested Edits: Only interact with topic filter button if defined [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563164 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [22:44:07] (03PS1) 10Catrope: StartEditingDialog: Only interact with topic selection widget if defined [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563297 [23:06:19] 10Growth-Team, 10MediaWiki-extensions-FlaggedRevs: Flagged revs Special:ValidationStatistics update doesn't work - https://phabricator.wikimedia.org/T163107 (10Tufor) @Aklapper: so I've read all that discussion and apparently this extension has no assigned owner/maintainer; therefore this bug won't be fixed in... [23:25:11] (03PS1) 10Catrope: StartEditingDialog: Unbold topic intro text [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563303 (https://phabricator.wikimedia.org/T238610) [23:28:08] 10Growth-Team, 10Notifications: Ghost notification count that can't be seen or marked as read - https://phabricator.wikimedia.org/T236488 (10Krinkle) >>! In T236488#5789489, @kostajh wrote: > @Krinkle do you see this with Minerva or another skin? I can see it in Vector, Monobook and Timeless. For me the bug h... [23:52:51] (03PS4) 10Catrope: Suggested Edits: Add pulsing blue dot if user never set topics [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563187 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [23:53:14] (03PS3) 10Catrope: Suggested Edits: Set topic names or count in button [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563282 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [23:56:29] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563187 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan) [23:56:49] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/563282 (https://phabricator.wikimedia.org/T238611) (owner: 10Kosta Harlan)