[00:25:09] 10Growth-Team: Deploy GrowthExperiments on Serbian Wikipedia - https://phabricator.wikimedia.org/T241181 (10Zoranzoki21) [07:35:57] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/560200 (owner: 10Libraryupgrader) [08:02:59] 10Growth-Team, 10MediaWiki-extensions-WikimediaMaintenance, 10StructuredDiscussions: Remove 'bot' and 'flow-bot' rights for Flow talk page manager on wikis where Flow was uninstalled - https://phabricator.wikimedia.org/T190261 (10Bugreporter) [12:03:08] 10Growth-Team, 10Wiktionary-fr: Get the Growth experiment for the French Wiktionary - https://phabricator.wikimedia.org/T235964 (10Otourly) [17:01:31] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560175 (owner: 10Libraryupgrader) [17:03:52] (03CR) 10Thiemo Kreuz (WMDE): "Thanks, but I'm afraid this raises even more questions. First, this is not really a failing test, but an optional warning from ESLint. We " [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560438 (owner: 10Paladox) [17:12:51] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560175 (owner: 10Libraryupgrader) [17:29:46] (03PS2) 10Simkawaii: Selenium test for verifying the availability of modules [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/558549 (https://phabricator.wikimedia.org/T233469) [19:05:32] 10Growth-Team, 10Thanks, 10AbuseFilter, 10Anti-Harassment, and 2 others: Add variables in Abusefilter to detect/block thanks - https://phabricator.wikimedia.org/T235873 (10Daimona) >>! In T235873#5764131, @DannyS712 wrote: > This requires designing how to present warnings / disallow messages, or setting it... [19:57:22] (03PS1) 10Fomafix: Remove bad tab in source code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560939 [20:15:32] (03CR) 10Umherirrender: [C: 03+2] "I have seen that also while changing that file and suprised that codesniffer have not found it" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560939 (owner: 10Fomafix) [20:16:12] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "Erm, I'm sorry. Why does the Comment extension need to call this code? This method doesn't do much but calling Parser::parse(). If the Com" [extensions/Echo] (REL1_34) - 10https://gerrit.wikimedia.org/r/560382 (owner: 10Paladox) [20:16:40] (03PS1) 10Thiemo Kreuz (WMDE): Revert "Make method parseNonEditWikitext public" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 [20:16:46] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Revert "Make method parseNonEditWikitext public" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:17:25] (03CR) 10Umherirrender: [C: 03+1] Revert "Make method parseNonEditWikitext public" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:18:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "I disagree with this being merged. Unfortunately no ticket exists, it seems. See If69b170 for discussion." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:36:44] (03CR) 10Paladox: "> Patch Set 1: Code-Review+2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:39:45] (03Merged) 10jenkins-bot: Remove bad tab in source code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560939 (owner: 10Fomafix) [20:39:48] (03Merged) 10jenkins-bot: Revert "Make method parseNonEditWikitext public" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:43:43] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/560052 (owner: 10Libraryupgrader) [20:47:17] (03PS1) 10Fomafix: Use $this->getConfig() instead of global variable [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560942 [20:48:31] (03CR) 10Paladox: "> > Patch Set 1: Code-Review+2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:53:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "This does not really count as a "self-merge" as I did not wrote any of this code. All this does is restoring the status quo as it was a fe" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:53:13] (03CR) 10Umherirrender: [C: 03+2] Use $this->getConfig() instead of global variable [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560942 (owner: 10Fomafix) [20:56:44] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/560052 (owner: 10Libraryupgrader) [21:05:52] (03Merged) 10jenkins-bot: Use $this->getConfig() instead of global variable [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560942 (owner: 10Fomafix) [21:12:53] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Use document.body instead of 'body' as jQuery selector [extensions/Flow] - 10https://gerrit.wikimedia.org/r/557876 (owner: 10Fomafix) [21:13:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Use document.body instead of 'body' as jQuery selector [extensions/Echo] - 10https://gerrit.wikimedia.org/r/557880 (owner: 10Fomafix) [23:35:26] (03CR) 10Umherirrender: [C: 03+2] "I have created T241520 to track this" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560939 (owner: 10Fomafix)