[03:09:49] (03PS1) 10Pppery: Add support for watchlist events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) [03:13:05] (03CR) 10Pppery: "This is probably the largest and most complicated patch I've ever written. I expect it to need a lot of changes in review." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [03:17:31] (03CR) 10DannyS712: "Recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [03:23:47] (03PS2) 10Pppery: Add support for watchlist events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) [03:24:15] (03CR) 10DannyS712: Add support for watchlist events (037 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [03:27:47] (03CR) 10DannyS712: "Recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [03:32:43] (03PS3) 10Pppery: Add support for watchlist events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) [03:34:45] (03CR) 10Pppery: Add support for watchlist events (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [03:40:46] (03CR) 10Zoranzoki21: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [03:41:33] (03PS4) 10Pppery: Add support for watchlist events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) [03:42:11] (03CR) 10Pppery: "Sorry, all, for cancelling your rechecks by updating new versions of the patch constantly." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [04:39:29] (03CR) 10Zoranzoki21: "> Sorry, all, for cancelling your rechecks by updating new versions" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [04:39:46] (03CR) 10Zoranzoki21: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [05:20:00] (03CR) 10Pppery: Add support for watchlist events (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [11:02:41] (03PS1) 10Daimona Eaytoy: Revert "Hack: back-compat for PHPUnit's Stub interface" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555913 (https://phabricator.wikimedia.org/T192167) [11:03:37] (03PS2) 10Daimona Eaytoy: Remove hack for PHPUnit's Stub interface [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555913 (https://phabricator.wikimedia.org/T192167) [11:03:44] (03CR) 10Daimona Eaytoy: [C: 04-2] "Not yet" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555913 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:13:44] (03CR) 10jerkins-bot: [V: 04-1] Remove hack for PHPUnit's Stub interface [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555913 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:21:38] (03PS1) 10Simkawaii: Selenium: Add a test for Special:Homepage page Add a test to check first heading of Special:Homepage page Modified files: pageobjects/homepage.page.js and specs/homepage.js [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/555919 [11:21:40] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/555919 (owner: 10Simkawaii) [12:22:34] (03PS2) 10Zfilipin: Selenium: replaced admin test with new user test [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/552661 (https://phabricator.wikimedia.org/T237021) (owner: 10Ephemeralwaves) [12:23:34] (03CR) 10Zfilipin: "PS2 is a rebase" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/552661 (https://phabricator.wikimedia.org/T237021) (owner: 10Ephemeralwaves) [12:35:24] (03Abandoned) 10Zfilipin: Selenium: replaced admin test with new user test [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/552661 (https://phabricator.wikimedia.org/T237021) (owner: 10Ephemeralwaves) [12:36:39] 10Growth-Team, 10GrowthExperiments, 10Browser-Tests, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), and 2 others: GrowthExperiments Homepage tests - https://phabricator.wikimedia.org/T237021 (10zeljkofilipin) 05Open→03Resolved Looks like this is resolved. Please reopen if there's anything left to do here. [12:37:13] 10Growth-Team, 10GrowthExperiments, 10Browser-Tests, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10User-zeljkofilipin: Refactor GrowthExperiments Homepage Selenium test - https://phabricator.wikimedia.org/T236620 (10zeljkofilipin) 05Open→03Resolved Looks like this is resolved. Please reopen if there... [12:57:07] 10Growth-Team, 10GrowthExperiments, 10Browser-Tests, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), and 2 others: GrowthExperiments Homepage tests - https://phabricator.wikimedia.org/T237021 (10kostajh) I'd like to see a test which opens the homepage, enables the Suggested Edits module, clicks on a task, and... [13:02:01] 10Growth-Team, 10GrowthExperiments, 10Browser-Tests, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), and 2 others: GrowthExperiments Homepage tests - https://phabricator.wikimedia.org/T237021 (10zeljkofilipin) I doesn't sound hard to do, if I've understood it correctly. Let me know if you would like to pair o... [13:57:07] (03Abandoned) 10Kosta Harlan: [WIP] Add LocalSearchEditSuggester [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/541404 (https://phabricator.wikimedia.org/T235717) (owner: 10Gergő Tisza) [14:22:36] (03CR) 10Esanders: Short submit/cancel keyboard shortcuts as button tooltips (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/555559 (owner: 10Esanders) [14:57:15] (03PS1) 10Kosta Harlan: Suggested Edits: Add missing dependency on mediawiki.Uri [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/555959 [15:04:56] (03PS1) 10Kosta Harlan: Suggested Edits: Display pageview info as a single line [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/555963 (https://phabricator.wikimedia.org/T238322) [15:45:03] (03CR) 10Sbisson: [C: 04-1] "Good work. A few things to tweak here and there." (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) (owner: 10Pppery) [16:46:58] (03CR) 10Zfilipin: Add accessibility check for Homepage (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/535896 (https://phabricator.wikimedia.org/T232638) (owner: 10Ephemeralwaves) [18:01:34] 10Growth-Team, 10GrowthExperiments, 10Browser-Tests, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10User-zeljkofilipin: GrowthExperiments Homepage tests - https://phabricator.wikimedia.org/T237021 (10Etonkovidova) >>! In T237021#5723368, @kostajh wrote: > I'd like to see a test which opens the homepage,... [19:00:24] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Advanced Mobile Contributions, and 7 others: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface - https://phabricator.wikimedia.org/T233649 (10ovasileva) a:05ovasileva→03Edtadros [20:56:18] (03PS1) 10Kosta Harlan: Suggested edits: Align heading with icon and indicator on desktop [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/556056 (https://phabricator.wikimedia.org/T239964) [21:03:30] (03PS1) 10Kosta Harlan: Suggested edits: Lighten the dimming effect on Drawer component [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/556058 (https://phabricator.wikimedia.org/T238164) [21:04:41] (03PS5) 10Pppery: Add support for watchlist events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) [21:06:12] (03PS6) 10Pppery: Add support for watchlist events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) [21:06:31] (03PS1) 10Kosta Harlan: Suggested edits: Update copy for pageviews component [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/556059 (https://phabricator.wikimedia.org/T238322) [21:08:16] (03PS7) 10Pppery: Add support for watchlist events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/555764 (https://phabricator.wikimedia.org/T203941) [21:23:33] (03Abandoned) 10Kosta Harlan: Suggested edits: Lighten the dimming effect on Drawer component [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/556058 (https://phabricator.wikimedia.org/T238164) (owner: 10Kosta Harlan) [21:35:11] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications, 10Tracking-Neverending: Create new types of notifications - https://phabricator.wikimedia.org/T125653 (10Pppery) [21:35:13] 10Growth-Team, 10MediaWiki-Watchlist, 10Notifications, 10Google-Code-in-2019, and 2 others: Allow watchlist notifications to be delivered as web notification (through Echo) - https://phabricator.wikimedia.org/T203941 (10Pppery) [21:41:23] (03CR) 10Kosta Harlan: [C: 04-1] "Nice work! Just a few small things to wrap up. Thanks for sticking with this." (0314 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530105 (https://phabricator.wikimedia.org/T228210) (owner: 10Urbanecm) [21:45:58] (03CR) 10Kosta Harlan: [C: 04-1] Allow experienced users to claim mentees (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530105 (https://phabricator.wikimedia.org/T228210) (owner: 10Urbanecm) [21:51:30] (03CR) 10Kosta Harlan: [C: 04-1] Allow experienced users to claim mentees (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530105 (https://phabricator.wikimedia.org/T228210) (owner: 10Urbanecm) [23:54:49] 10Growth-Team, 10Notifications, 10Google-Code-in-2019: Please do not send e-mail messages to tell me about "a new notification" that I read hours ago on-wiki - https://phabricator.wikimedia.org/T169386 (10IAmNetx) a:03IAmNetx