[00:02:19] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Readers-Web-Backlog, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Jdlrobson) Do the breaking changes impact Flow only? This seems pretty serious and I'm surprised this has... [00:08:04] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Readers-Web-Backlog, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Jdlrobson) Also FWIW Flow is using handlebars and Mustache is the standard supported template library. Wit... [00:16:02] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Readers-Web-Backlog, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Reedy) >>! In T121947#5558018, @Jdlrobson wrote: > Do the breaking changes impact Flow only? This seems pr... [00:16:15] (03CR) 10VolkerE: [C: 03+2] Do not align the bottom of the homepage columns [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/541663 (https://phabricator.wikimedia.org/T232420) (owner: 10Gergő Tisza) [00:24:32] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Readers-Web-Backlog, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Reedy) An amusing one to me was finding this in #bluespice Foundation to just add helpers... `lang=php /... [00:27:37] (03Merged) 10jenkins-bot: Do not align the bottom of the homepage columns [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/541663 (https://phabricator.wikimedia.org/T232420) (owner: 10Gergő Tisza) [00:31:26] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Readers-Web-Backlog, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Jdlrobson) I guess first step would be to restore the upgrade and take a look at the test failures. To be... [00:38:13] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Readers-Web-Backlog, and 2 others: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Reedy) >>! In T121947#5558066, @Jdlrobson wrote: > I guess first step would be to restore the upgrade and take a look a... [00:45:55] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Readers-Web-Backlog, and 2 others: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Reedy) Vendor failing due to what is basically a cyclic dependancy on it and core A patch for Flow needs making... At... [00:47:57] (03PS1) 10Reedy: Update zordius/lightncandy v0.23 to v1.2.4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541681 (https://phabricator.wikimedia.org/T121947) [00:51:41] (03PS2) 10Reedy: Update zordius/lightncandy v0.23 to v1.2.4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541681 (https://phabricator.wikimedia.org/T121947) [00:55:39] (03CR) 10jerkins-bot: [V: 04-1] Update zordius/lightncandy v0.23 to v1.2.4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541681 (https://phabricator.wikimedia.org/T121947) (owner: 10Reedy) [00:57:37] (03CR) 10jerkins-bot: [V: 04-1] Update zordius/lightncandy v0.23 to v1.2.4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541681 (https://phabricator.wikimedia.org/T121947) (owner: 10Reedy) [00:59:11] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Readers-Web-Backlog, and 2 others: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Krinkle) This library is using extreme measures with regards to security and performance. It only //barely// got throug... [01:03:41] (03PS20) 10Catrope: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [01:10:16] 10Growth-Team, 10Notifications, 10ApiFeatureUsage, 10BetaFeatures, and 23 others: All API help links should use `Special:MyLanguage` - https://phabricator.wikimedia.org/T231269 (10DannyS712) @JTannerWMF is #editing-team willing to take a look at the one remaining patch (https://gerrit.wikimedia.org/r/#/c/m... [01:22:17] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Performance-Team, and 4 others: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Krinkle) [01:42:51] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Performance-Team, and 4 others: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Reedy) Current failure on core from flow... ` 02:00:48 1) Flow\Tests\TemplateHelperTest::testIfCond 02:00:48 Exception: C... [02:24:40] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Performance-Team, and 4 others: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Jdlrobson) >>! In T121947#5558095, @Krinkle wrote: > This library is using extreme measures with regards to security and p... [07:58:41] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Performance-Team, and 4 others: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Reedy) >>! In T121947#5558144, @Jdlrobson wrote: >>>! In T121947#5558095, @Krinkle wrote: >> This library is using extreme... [08:23:04] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications, 10Outreach-Programs-Projects, and 3 others: Notification: Your file was used - https://phabricator.wikimedia.org/T77154 (10thiemowmde) [08:34:40] 10Collaboration-Team-Triage, 10Community-Tech, 10TCB-Team, 10Community-Wishlist-Survey-2015, and 3 others: Improve diff compare screen - https://phabricator.wikimedia.org/T121469 (10thiemowmde) [08:37:21] 10Collaboration-Team-Triage, 10Community-Tech, 10TCB-Team, 10Community-Wishlist-Survey-2015, and 3 others: Improve diff compare screen - https://phabricator.wikimedia.org/T121469 (10thiemowmde) [09:10:55] (03PS5) 10Thiemo Kreuz (WMDE): Minor cleanups: Add type hints and remove unused parameters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [09:10:57] (03PS1) 10Thiemo Kreuz (WMDE): articlecompile: Fix all ArticleCompile… classes appearing unused [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/541765 [09:13:57] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Minor cleanups: Add type hints and remove unused parameters (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [09:41:28] (03CR) 10Kosta Harlan: [C: 03+2] StartEditing: Remove special message for add-change response [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/541631 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [15:58:10] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), 10User-DannyS712: Enqueue: Don't allow enqueueing a page already in the queue - https://phabricator.wikimedia.org/T234587 (10dom_walden) Using the API, I cannot requeue pages in the Article, U... [16:12:46] (03PS1) 10HMonroy: Add ability to message previous reviewer [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/541844 (https://phabricator.wikimedia.org/T233729) [16:44:24] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), 10User-DannyS712: Enqueue: Don't allow enqueueing pages in unsupported namespaces - https://phabricator.wikimedia.org/T234574 (10dom_walden) On beta, using the API I am able to enqueue pages i... [16:57:34] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), and 2 others: Don't allow requeueing main page - https://phabricator.wikimedia.org/T234073 (10dom_walden) With my Admin user ("Dom walden") on both https://en.wikipedia.beta.wmflabs.org/wiki/Ma... [19:36:20] (03PS21) 10Catrope: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [19:37:29] (03CR) 10Catrope: [C: 03+2] Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [19:50:58] (03Merged) 10jenkins-bot: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [20:15:45] 10Growth-Team, 10Notifications, 10CPT Initiatives (Multi-DC Echo Notification Storage): Provision Cassandra access for Echo timestamp storage - https://phabricator.wikimedia.org/T234374 (10Eevans) The following has been created on the RESTBase cluster: `lang=sql CREATE KEYSPACE echostore WITH replication =... [21:07:48] 10Growth-Team, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Performance-Team, and 4 others: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947 (10Krinkle) Compared to other Mustache libs (for PHP), LightNCandy is actually quite good in terms of coding principles and i... [21:24:18] 10Growth-Team, 10StructuredDiscussions: Logged-out Flow page starts with a heading called "false" - https://phabricator.wikimedia.org/T235134 (10Krinkle) [22:02:25] 10Growth-Team, 10MediaWiki-Watchlist: Preference 'usenewrc' should imply 'extendwatchlist' - https://phabricator.wikimedia.org/T53022 (10Krinkle) [22:11:10] 10Growth-Team, 10MediaWiki-Watchlist: Preference 'usenewrc' should imply 'extendwatchlist' - https://phabricator.wikimedia.org/T53022 (10Krinkle) With the new RCFilters feature being deployed to Special:RecentChanges and Special:Watchlist and now being the default experience as well, this makes the "new" aspec... [22:11:20] 10Growth-Team, 10MediaWiki-Watchlist, 10Technical-Debt: Preference 'usenewrc' should imply 'extendwatchlist' - https://phabricator.wikimedia.org/T53022 (10Krinkle) [22:21:48] 10Growth-Team, 10MediaWiki-Watchlist, 10OOUI, 10Design, 10Regression: "Edit watchlist" missing namespace designations - https://phabricator.wikimedia.org/T235137 (10Krinkle) [22:57:40] (03PS1) 10Jforrester: build: Upgrade mediawiki-codesniffer to v28.0.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/541962 [23:09:55] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade mediawiki-codesniffer to v28.0.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/541962 (owner: 10Jforrester) [23:23:28] (03PS1) 10Jforrester: build: Upgrade mediawiki-codesniffer to v28.0.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541975 [23:45:29] (03PS1) 10Jforrester: build: Upgrade mediawiki-codesniffer to v28.0.0 [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/541989 [23:49:33] 10Growth-Team, 10MediaWiki-Watchlist, 10Technical-Debt: Preference 'usenewrc' should imply 'extendwatchlist' - https://phabricator.wikimedia.org/T53022 (10Dvorapa) Perhaps the preferences checkboxes about these features should be rethought? [23:53:46] (03PS1) 10Jdlrobson: WIP: Style improvements to Echo OOUI dialog in desktop Minerva [extensions/Echo] - 10https://gerrit.wikimedia.org/r/541992 [23:56:09] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade mediawiki-codesniffer to v28.0.0 [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/541989 (owner: 10Jforrester)