[00:01:57] (03PS8) 10DannyS712: API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [00:03:46] 10Growth-Team, 10PageCuration, 10Patch-For-Review, 10User-DannyS712: Api: Don't log (un)reviewing or tagging as copyvio if state doesn't change - https://phabricator.wikimedia.org/T234074 (10DannyS712) [00:06:40] (03CR) 10jerkins-bot: [V: 04-1] API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) (owner: 10DannyS712) [00:11:07] (03PS9) 10DannyS712: API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [00:17:28] 10Collaboration-Team-Triage, 10Growth-Team, 10PageCuration, 10Documentation, and 4 others: Option not to review article when adding maintenance tags - https://phabricator.wikimedia.org/T148353 (10DannyS712) @MMiller_WMF @JTannerWMF @Catrope @kostajh @Trizek-WMF @Tgr can someone please take a look at the pa... [00:38:51] 10Growth-Team, 10Performance-Team (Radar), 10Performance-Team-publish: Investigate 2X regression in StartupModule::buildContent generation time - https://phabricator.wikimedia.org/T223260 (10Krinkle) [00:43:39] 10Growth-Team, 10Performance-Team (Radar), 10Performance-Team-publish: Investigate 2X regression in StartupModule::buildContent generation time - https://phabricator.wikimedia.org/T223260 (10Krinkle) 05Open→03Resolved >>! Task description **§ Regression 2: 2019-03-01** > > From 450 ms to 720 ms. > > (03CR) 10Mooeypoo: [C: 04-1] "A couple of comments inline. Also, this needs to be tested before merge." (033 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) (owner: 10DannyS712) [01:23:03] (03CR) 10Catrope: [C: 04-1] "First stab at a review, I'll have to come back to this after the weekend and look at it in more detail" (039 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [01:24:45] (03CR) 10Mooeypoo: [C: 04-1] "I tried to test whether .on would work (I suspect not) and the patch crashed for me in two places." (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) (owner: 10DannyS712) [01:53:23] (03PS5) 10DannyS712: Partially revert "bug39208 - Add auto review to tagging/deletion" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) [01:58:08] (03CR) 10jerkins-bot: [V: 04-1] Partially revert "bug39208 - Add auto review to tagging/deletion" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) (owner: 10DannyS712) [02:32:02] (03PS6) 10DannyS712: Partially revert "bug39208 - Add auto review to tagging/deletion" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) [03:55:33] (03PS1) 10MaxSem: Drop old PHPUnit rudiments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540986 [06:52:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I'm happy with this now and would merge it. But since I added quite some changes in patch sets 3 and 4, I don't think I should be the one " [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [06:53:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Drop old PHPUnit rudiments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540986 (owner: 10MaxSem) [07:05:00] (03Merged) 10jenkins-bot: Drop old PHPUnit rudiments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540986 (owner: 10MaxSem) [09:23:24] (03CR) 10Mobrovac: "As stated in PS1, I wonder if setting the variable's default value to $wgMainStash would be more appropriate than null" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540729 (https://phabricator.wikimedia.org/T222851) (owner: 10Catrope) [09:26:09] (03CR) 10Mobrovac: "What is the performance implication of TTL-ing records? Will that cause full-table scans? If so, isn't it cheaper to keep the data around " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540975 (https://phabricator.wikimedia.org/T222851) (owner: 10Catrope) [15:48:29] (03CR) 10Ladsgroup: [C: 03+2] Cleanup use of Wikimedia\Rdbms\ResultWrapper [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540902 (owner: 10Umherirrender) [15:53:16] (03Merged) 10jenkins-bot: Cleanup use of Wikimedia\Rdbms\ResultWrapper [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540902 (owner: 10Umherirrender) [18:15:12] (03PS6) 10Umherirrender: phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 [18:23:20] (03CR) 10Daimona Eaytoy: [C: 03+2] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [18:37:06] (03Merged) 10jenkins-bot: phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [19:16:07] 10Growth-Team: Deploy Growth experiments at Ukrainian Wikipedia - https://phabricator.wikimedia.org/T231720 (10Ata) [19:19:07] 10Growth-Team: Deploy Growth experiments at Ukrainian Wikipedia - https://phabricator.wikimedia.org/T231720 (10Ata) I'm not sure I understand the parts about namespaces. Isn't it decided in the project already which namespaces to cover with help panel etc.? Should there be a community discussion? I used example... [19:33:41] (03PS1) 10Ladsgroup: Clean up most of b/c for phpunit4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541039 [20:15:39] (03CR) 10MaxSem: [C: 03+2] Clean up most of b/c for phpunit4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541039 (owner: 10Ladsgroup) [20:48:10] (03Merged) 10jenkins-bot: Clean up most of b/c for phpunit4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541039 (owner: 10Ladsgroup) [21:06:21] 10Growth-Team, 10StructuredDiscussions: "Call to a member function $user->getGroups() on null" in StructuredDiscussions when running update.php - https://phabricator.wikimedia.org/T227392 (10Tinss) @Nicolas_NALLET thanks a bunch, that worked.