[00:01:27] (03PS1) 10Catrope: [WIP] Make EchoSeenTime cache type configurable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540729 (https://phabricator.wikimedia.org/T222851) [00:04:38] 10Growth-Team, 10Notifications, 10Patch-For-Review, 10User-Eevans: Improve Echo seentime code for multi-DC access - https://phabricator.wikimedia.org/T222851 (10Catrope) I've put two patches in Gerrit that sketch out how I think this would be done. I'll come back to them tomorrow and test them properly etc. [00:09:45] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20): Page Curation: Provide Customized Message to Previous Reviewer [small] - https://phabricator.wikimedia.org/T233729 (10HMonroy) @Prtksxna Can we get the select element out of the label `Add a message for "select dropdown":` for translation p... [00:31:54] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Make EchoSeenTime cache type configurable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540729 (https://phabricator.wikimedia.org/T222851) (owner: 10Catrope) [02:06:05] (03PS1) 10VolkerE: Remove IE 6 & 7 hacks [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540744 (https://phabricator.wikimedia.org/T234582) [02:09:30] (03CR) 10Krinkle: [C: 03+2] Remove IE 6 & 7 hacks [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540744 (https://phabricator.wikimedia.org/T234582) (owner: 10VolkerE) [02:21:20] (03Merged) 10jenkins-bot: Remove IE 6 & 7 hacks [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540744 (https://phabricator.wikimedia.org/T234582) (owner: 10VolkerE) [02:34:30] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-Installer, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: MysqlUpdater::doWatchlistUpdate is very slow - https://phabricator.wikimedia.org/T160993 (10Krinkle) >>! @aaron wrote on [Gerrit](https://gerrit.wikimedia.org/r/#/c/mediawiki/core/... [02:58:54] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10User-DannyS712: Enqueue: Don't allow enqueueing a page already in the queue - https://phabricator.wikimedia.org/T234587 (10DannyS712) [03:00:07] (03PS1) 10DannyS712: Enqueue: Don't allow enqueueing pages already in the queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540749 (https://phabricator.wikimedia.org/T234587) [03:00:40] (03PS2) 10DannyS712: Enqueue: Don't allow enqueueing pages already in the queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540749 (https://phabricator.wikimedia.org/T234587) [03:06:24] (03PS3) 10DannyS712: Enqueue: Don't allow enqueueing pages already in the queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540749 (https://phabricator.wikimedia.org/T234587) [04:44:26] 10Growth-Team, 10PageCuration, 10User-DannyS712: Delete a row from pagetriage_page on beta cluster - https://phabricator.wikimedia.org/T234577 (10Marostegui) DBAs do not maintain the beta cluster [04:45:37] 10Growth-Team, 10PageCuration, 10User-DannyS712: Delete a row from pagetriage_page on beta cluster - https://phabricator.wikimedia.org/T234577 (10DannyS712) >>! In T234577#5545944, @Marostegui wrote: > DBAs do not maintain the beta cluster Do you know who does? [04:57:53] 10Growth-Team, 10PageCuration, 10User-DannyS712: Delete a row from pagetriage_page on beta cluster - https://phabricator.wikimedia.org/T234577 (10Marostegui) I am not really sure - I have seen different people like @Krenair @Catrope or people from releng operating it, so maybe the can help with the proper ta... [05:58:42] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): Enable page curation tools to be loaded on any page (optionally) - https://phabricator.wikimedia.org/T207485 (10DannyS712) Moving to in development - a few bugs already found but not merged yet... [07:23:44] (03CR) 10Thiemo Kreuz (WMDE): "This looks like it would still be useful. Do you want to rebase and fix this?" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [07:35:20] (03PS2) 10MaxSem: Minor cleanups [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 [07:35:22] (03PS2) 10MaxSem: Throw an exception if article quality can't be determined [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535298 [07:39:27] (03CR) 10jerkins-bot: [V: 04-1] Throw an exception if article quality can't be determined [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535298 (owner: 10MaxSem) [07:39:32] (03CR) 10jerkins-bot: [V: 04-1] Minor cleanups [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [07:39:44] (03CR) 10jerkins-bot: [V: 04-1] Throw an exception if article quality can't be determined [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535298 (owner: 10MaxSem) [07:40:05] (03CR) 10jerkins-bot: [V: 04-1] Minor cleanups [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [09:29:17] (03PS1) 10Umherirrender: phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 [09:42:05] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [10:14:50] (03PS2) 10Umherirrender: phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 [10:31:30] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [10:36:54] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [10:37:31] (03PS3) 10Umherirrender: phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 [10:49:12] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [10:51:42] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [11:01:06] (03PS4) 10Umherirrender: phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 [11:13:27] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [11:29:49] (03CR) 10Umherirrender: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [11:47:59] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [12:11:40] (03CR) 10Mobrovac: "I think it's a good direction, left a comment/question in-line. Also, I wonder if perhaps the wording should be changed so as not to refer" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540729 (https://phabricator.wikimedia.org/T222851) (owner: 10Catrope) [12:38:24] (03CR) 10Huji: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [12:51:55] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [13:57:12] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Makes a lot of sense. The error appears to be unrelated." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535298 (owner: 10MaxSem) [15:02:08] (03PS1) 10Zfilipin: Selenium: make it possible to run daily Jenkins job targeting beta cluster [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540891 (https://phabricator.wikimedia.org/T199113) [15:02:28] (03CR) 10Zfilipin: [C: 03+2] Selenium: make it possible to run daily Jenkins job targeting beta cluster [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540891 (https://phabricator.wikimedia.org/T199113) (owner: 10Zfilipin) [15:16:56] (03Merged) 10jenkins-bot: Selenium: make it possible to run daily Jenkins job targeting beta cluster [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540891 (https://phabricator.wikimedia.org/T199113) (owner: 10Zfilipin) [15:58:47] (03CR) 10MusikAnimal: [C: 03+2] "Thank you!" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540690 (https://phabricator.wikimedia.org/T234574) (owner: 10DannyS712) [16:01:00] (03PS1) 10Umherirrender: Cleanup use of Wikimedia\Rdbms\ResultWrapper [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540902 [16:03:49] (03Merged) 10jenkins-bot: Enqueue: Don't allow enqueueing pages in unsupported namespaces [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540690 (https://phabricator.wikimedia.org/T234574) (owner: 10DannyS712) [16:10:23] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10User-DannyS712: Enqueue: Don't allow enqueueing pages in unsupported namespaces - https://phabricator.wikimedia.org/T234574 (10MusikAnimal) Much appreciated, @DannyS712! I think this is relevant to our work, so tagging with #community-t... [16:11:35] (03PS1) 10Umherirrender: Type hint against IResultWrapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540910 [16:26:08] (03CR) 10jerkins-bot: [V: 04-1] Type hint against IResultWrapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540910 (owner: 10Umherirrender) [16:27:12] (03CR) 10MusikAnimal: [C: 03+2] Enqueue: Don't allow enqueueing pages already in the queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540749 (https://phabricator.wikimedia.org/T234587) (owner: 10DannyS712) [16:32:07] (03Merged) 10jenkins-bot: Enqueue: Don't allow enqueueing pages already in the queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540749 (https://phabricator.wikimedia.org/T234587) (owner: 10DannyS712) [16:32:54] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10Patch-For-Review, 10User-DannyS712: Enqueue: Don't allow enqueueing a page already in the queue - https://phabricator.wikimedia.org/T234587 (10MusikAnimal) Good stuff! Probably could use QA. [16:36:20] 10Growth-Team: Deploy Growth experiments at Ukrainian Wikipedia - https://phabricator.wikimedia.org/T231720 (10Ata) [16:42:16] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10User-DannyS712: Enqueue: Don't allow enqueueing pages in unsupported namespaces - https://phabricator.wikimedia.org/T234574 (10DannyS712) >>! In T234574#5547513, @MusikAnimal wrote: > Much appreciated, @DannyS712! I think this is releva... [16:46:39] (03PS1) 10Umherirrender: Prefer DOM building to parsing HTML literals [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540919 [16:47:51] (03CR) 10DannyS712: [C: 04-1] "This will conflict with newer changes; rebase tips added" (033 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/538123 (https://phabricator.wikimedia.org/T207485) (owner: 10MaxSem) [16:47:53] (03PS2) 10Umherirrender: Prefer DOM building to parsing HTML literals [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540919 [16:50:01] (03CR) 10DannyS712: Minor cleanups (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [16:50:23] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10User-DannyS712: Enqueue: Don't allow enqueueing pages in unsupported namespaces - https://phabricator.wikimedia.org/T234574 (10MusikAnimal) > it was under the Kanban board because it was created as a sub task. Should I ensure that I rem... [16:50:55] (03CR) 10Sbisson: Prefer DOM building to parsing HTML literals (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540919 (owner: 10Umherirrender) [16:51:34] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10User-DannyS712: Enqueue: Don't allow enqueueing pages in unsupported namespaces - https://phabricator.wikimedia.org/T234574 (10DannyS712) >>! In T234574#5547751, @MusikAnimal wrote: >> it was under the Kanban board because it was create... [16:55:23] (03PS3) 10Umherirrender: Prefer DOM building to parsing HTML literals [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540919 [17:04:34] (03PS5) 10Umherirrender: phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 [17:04:46] (03PS2) 10Umherirrender: Type hint against IResultWrapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540910 [17:09:26] (03PS4) 10Umherirrender: Prefer DOM building to parsing HTML literals [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540919 [17:09:32] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [17:09:34] (03CR) 10jerkins-bot: [V: 04-1] Type hint against IResultWrapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540910 (owner: 10Umherirrender) [17:09:37] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [17:09:40] (03CR) 10jerkins-bot: [V: 04-1] Type hint against IResultWrapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540910 (owner: 10Umherirrender) [17:09:47] (03PS5) 10Umherirrender: Prefer DOM building to parsing HTML literals [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540919 [17:10:22] (03CR) 10Umherirrender: Prefer DOM building to parsing HTML literals (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540919 (owner: 10Umherirrender) [17:10:24] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban-Q2-2019-20), 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), 10User-DannyS712: Enqueue: Don't allow enqueueing pages in unsupported namespaces - https://phabricator.wikimedia.org/T234574 (10MusikAnimal) > I've been thinking of requesting +2 for PageTria... [17:23:03] (03CR) 10Umherirrender: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [17:23:06] (03CR) 10Umherirrender: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540910 (owner: 10Umherirrender) [17:28:02] (03CR) 10Jdlrobson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [17:29:00] (03PS3) 10Gergő Tisza: [WIP] API module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540391 (https://phabricator.wikimedia.org/T234426) (owner: 10Kosta Harlan) [17:30:16] (03CR) 10jerkins-bot: [V: 04-1] [WIP] API module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540391 (https://phabricator.wikimedia.org/T234426) (owner: 10Kosta Harlan) [17:35:06] (03CR) 10jerkins-bot: [V: 04-1] [WIP] API module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540391 (https://phabricator.wikimedia.org/T234426) (owner: 10Kosta Harlan) [17:40:56] (03CR) 10jerkins-bot: [V: 04-1] Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [17:46:43] 10Growth-Team, 10PageCuration, 10User-DannyS712: Define behaviour for page creator - https://phabricator.wikimedia.org/T234681 (10DannyS712) [17:47:06] 10Growth-Team, 10PageCuration, 10User-DannyS712: Define behaviour for page creator - https://phabricator.wikimedia.org/T234681 (10DannyS712) [17:47:11] 10Growth-Team, 10Community-Tech, 10PageCuration, 10User-DannyS712: After requeueing a page, define behaviour for creator [medium] - https://phabricator.wikimedia.org/T234071 (10DannyS712) [17:47:39] 10Growth-Team, 10Community-Tech, 10MediaWiki-User-management, 10PageCuration, 10User-DannyS712: Define behaviour for page creator - https://phabricator.wikimedia.org/T234681 (10DannyS712) [18:02:50] (03PS8) 10Jdlrobson: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) [18:15:29] (03CR) 10jerkins-bot: [V: 04-1] Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [18:23:07] (03PS3) 10Thiemo Kreuz (WMDE): Minor cleanups: Add type hints and remove unused parameters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [18:24:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I think I found the reason for the Phan error, and fixed in in patch set 3. I ended adding a few additional, very closely related cleanups" (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [18:25:29] (03PS9) 10Jdlrobson: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) [18:27:16] (03CR) 10jerkins-bot: [V: 04-1] Minor cleanups: Add type hints and remove unused parameters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [18:35:21] (03CR) 10DannyS712: [C: 04-1] Minor cleanups: Add type hints and remove unused parameters (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [18:36:20] (03CR) 10jerkins-bot: [V: 04-1] Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [18:40:38] (03PS10) 10Jdlrobson: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) [18:41:10] (03PS2) 10Jdlrobson: Added Extension name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/539450 (owner: 10Haritha Mattupalli) [18:41:12] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/539450 (owner: 10Haritha Mattupalli) [18:46:16] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Prefer DOM building to parsing HTML literals [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540919 (owner: 10Umherirrender) [18:47:21] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Type hint against IResultWrapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540910 (owner: 10Umherirrender) [18:56:02] (03CR) 10jerkins-bot: [V: 04-1] Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [18:57:53] (03PS11) 10Jdlrobson: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) [18:58:00] (03PS12) 10Jdlrobson: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) [18:59:12] (03PS4) 10Thiemo Kreuz (WMDE): Minor cleanups: Add type hints and remove unused parameters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [19:00:01] (03CR) 10Jdlrobson: "I'm not sure what's up with phan... Error message is not helpful. Any ideas Roan?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [19:01:22] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Minor cleanups: Add type hints and remove unused parameters (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [19:02:41] (03CR) 10Huji: [C: 03+1] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [19:03:11] (03CR) 10Catrope: Dormant mobile notifications overlay lives in Echo (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [19:05:45] (03CR) 10jerkins-bot: [V: 04-1] Minor cleanups: Add type hints and remove unused parameters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [19:08:26] (03CR) 10Jdlrobson: "I feel silly now. I didn't realise I could click "show details"" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [19:10:53] (03CR) 10jerkins-bot: [V: 04-1] Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [19:15:33] (03PS13) 10Jdlrobson: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) [19:21:38] (03Merged) 10jenkins-bot: Prefer DOM building to parsing HTML literals [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540919 (owner: 10Umherirrender) [19:21:42] (03Merged) 10jenkins-bot: Type hint against IResultWrapper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540910 (owner: 10Umherirrender) [19:26:43] (03CR) 10jerkins-bot: [V: 04-1] Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [19:31:38] (03PS14) 10Jdlrobson: Dormant mobile notifications overlay lives in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) [20:17:20] (03PS1) 10Catrope: Homepage: Don't use flexbox for vertical layouts in mobile start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540959 (https://phabricator.wikimedia.org/T234689) [20:23:56] (03CR) 10Catrope: Add gender to some messages (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540449 (https://phabricator.wikimedia.org/T234350) (owner: 10Gergő Tisza) [20:33:28] (03CR) 10Catrope: [C: 03+2] Fix SuggestedEdits module positioning [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540501 (https://phabricator.wikimedia.org/T232420) (owner: 10Gergő Tisza) [20:33:42] (03PS3) 10Catrope: Fix SuggestedEdits module positioning [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540501 (https://phabricator.wikimedia.org/T232420) (owner: 10Gergő Tisza) [20:33:53] (03CR) 10Catrope: [C: 03+2] Fix SuggestedEdits module positioning [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540501 (https://phabricator.wikimedia.org/T232420) (owner: 10Gergő Tisza) [20:45:35] (03Merged) 10jenkins-bot: Fix SuggestedEdits module positioning [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540501 (https://phabricator.wikimedia.org/T232420) (owner: 10Gergő Tisza) [21:17:40] 10Growth-Team, 10GrowthExperiments-Homepage: [regression- mobile] Homepage - Start model displays broken layout - https://phabricator.wikimedia.org/T234380 (10Catrope) [21:18:26] (03PS2) 10Catrope: Homepage: Don't use flexbox for vertical layouts in mobile start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540959 (https://phabricator.wikimedia.org/T234380) [21:22:07] (03CR) 10Jdlrobson: [C: 03+1] "Feel free to self merge this Catrope if you need to get it out on the train. Code looks fine but I don't know enough about this extension " [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540959 (https://phabricator.wikimedia.org/T234380) (owner: 10Catrope) [21:49:43] (03PS2) 10Catrope: Make EchoSeenTime cache type configurable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540729 (https://phabricator.wikimedia.org/T222851) [22:30:15] (03CR) 10Gergő Tisza: [C: 03+2] "I can't test in Safari, but the change makes sense, and looks fine in Chrome." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540959 (https://phabricator.wikimedia.org/T234380) (owner: 10Catrope) [22:40:59] (03PS1) 10Catrope: Make EchoSeenTime cache entries expire after 1 year [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540975 (https://phabricator.wikimedia.org/T222851) [22:43:52] (03Merged) 10jenkins-bot: Homepage: Don't use flexbox for vertical layouts in mobile start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/540959 (https://phabricator.wikimedia.org/T234380) (owner: 10Catrope) [22:58:00] 10Growth-Team, 10Notifications, 10Patch-For-Review, 10User-Eevans: Improve Echo seentime code for multi-DC access - https://phabricator.wikimedia.org/T222851 (10Catrope) >>! In T222851#5545642, @Catrope wrote: > I've put two patches in Gerrit that sketch out how I think this would be done. I'll come back t... [22:58:38] 10Growth-Team, 10Notifications, 10Patch-For-Review, 10User-Eevans: Improve Echo seentime code for multi-DC access - https://phabricator.wikimedia.org/T222851 (10Catrope) [23:58:33] 10Growth-Team, 10PageCuration, 10Patch-For-Review, 10User-DannyS712: Api: Don't log (un)reviewing if state doesn't change - https://phabricator.wikimedia.org/T234074 (10DannyS712) The same applies to marking as a potential copyright a revision that is already marked; updating patch to include that