[00:35:06] 10Growth-Team, 10GrowthExperiments-Help panel: [minor] HelpPanel on euwiki has different padding for processDialog-location - https://phabricator.wikimedia.org/T234000 (10Etonkovidova) [01:04:52] (03PS8) 10Catrope: [WIP] JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 [01:05:09] (03CR) 10jerkins-bot: [V: 04-1] [WIP] JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (owner: 10Catrope) [01:05:16] (03CR) 10jerkins-bot: [V: 04-1] [WIP] JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (owner: 10Catrope) [04:59:17] (03PS1) 10Arshia Md: Added Extension Name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/539448 [05:00:57] (03PS1) 10Haritha Mattupalli: Added Extension name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/539450 [05:12:42] (03PS11) 10Catrope: Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) [05:12:52] (03PS9) 10Catrope: Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) [05:12:53] (03CR) 10jerkins-bot: [V: 04-1] Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [05:13:05] (03CR) 10jerkins-bot: [V: 04-1] Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [05:13:07] (03CR) 10jerkins-bot: [V: 04-1] Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [05:13:09] (03CR) 10jerkins-bot: [V: 04-1] Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [05:13:52] (03CR) 10Catrope: "When testing this, you may want to reset the startediting module back to the uncompleted state, which you can do with:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [05:14:52] (03PS12) 10Catrope: Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) [05:15:00] (03PS10) 10Catrope: Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) [05:26:31] (03CR) 10jerkins-bot: [V: 04-1] Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [05:26:38] (03CR) 10jerkins-bot: [V: 04-1] Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [06:35:55] (03CR) 10Samwilson: [C: 03+1] "Works in my testing." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535725 (https://phabricator.wikimedia.org/T231357) (owner: 10MaxSem) [07:15:55] (03PS13) 10Catrope: Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) [07:15:57] (03PS11) 10Catrope: Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) [07:16:03] (03CR) 10jerkins-bot: [V: 04-1] Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [07:16:11] (03CR) 10jerkins-bot: [V: 04-1] Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [07:16:14] (03CR) 10jerkins-bot: [V: 04-1] Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [07:16:23] (03CR) 10jerkins-bot: [V: 04-1] Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [07:23:49] (03PS12) 10Catrope: Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) [07:24:02] (03CR) 10jerkins-bot: [V: 04-1] Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [07:24:09] (03PS14) 10Catrope: Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) [07:24:17] (03PS13) 10Catrope: Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) [07:33:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/539473 (owner: 10L10n-bot) [07:40:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539482 (owner: 10L10n-bot) [13:08:54] 10Growth-Team, 10Notifications, 10MediaWiki-Page-Diffs: Undefined property: Diff::$edits in includes/diff/DiffFormatter.php - https://phabricator.wikimedia.org/T234040 (10Tgr) [16:48:23] (03CR) 10Kosta Harlan: [C: 04-1] "When I open the dialog and press "Cancel" (which should be "Go back") I get jQuery.Deferred exception: data is undefined." (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [16:53:05] (03PS14) 10Kosta Harlan: Add JS and dialog for startediting module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [16:54:06] (03CR) 10Kosta Harlan: "> Patch Set 9:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [16:56:43] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): Enable page curation tools to be loaded on any page (optionally) - https://phabricator.wikimedia.org/T207485 (10Xaosflux) Following up from enwiki discussion at https://en.wikipedia.org/w/ind... [16:58:56] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10User-DannyS712: Enqueueing a page marks it as unreviewed without logging it as such - https://phabricator.wikimedia.org/T233509 (10DannyS712) 05Open→03Resolved Working in production -... [16:58:59] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): Enable page curation tools to be loaded on any page (optionally) - https://phabricator.wikimedia.org/T207485 (10DannyS712) [17:05:38] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): Page triage leads to a one way action in some cases - https://phabricator.wikimedia.org/T234067 (10Xaosflux) [17:12:48] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10User-DannyS712: After requeueing a page, define behaviour for creator - https://phabricator.wikimedia.org/T234071 (10DannyS712) [17:13:21] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): Page triage leads to a one way action in some cases - https://phabricator.wikimedia.org/T234067 (10DannyS712) [17:13:24] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10User-DannyS712: After requeueing a page, define behaviour for creator - https://phabricator.wikimedia.org/T234071 (10DannyS712) [17:13:44] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): Page triage leads to a one way action in some cases - https://phabricator.wikimedia.org/T234067 (10DannyS712) This is a partial duplicate of {T234071} - you can still mark it as reviewed usin... [17:16:40] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10User-DannyS712: After requeueing a page, define behaviour for creator - https://phabricator.wikimedia.org/T234071 (10Xaosflux) From merged: T234067, this is creating a dead-end workflow in the webui. Those with (patrol) access should... [17:22:23] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10User-DannyS712: Don't show option to requeue main page - https://phabricator.wikimedia.org/T234073 (10DannyS712) [17:22:46] (03PS1) 10DannyS712: Don't show option to enqueue main page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) [17:24:34] (03PS2) 10DannyS712: Don't show option to enqueue main page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) [17:26:32] (03CR) 10Kosta Harlan: [C: 04-1] Homepage: Add startediting placeholder module for suggested edits (036 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [17:36:42] 10Growth-Team, 10PageCuration, 10User-DannyS712: Api: Don't log (un)reviewing if state doesn't change - https://phabricator.wikimedia.org/T234074 (10DannyS712) [17:37:03] 10Growth-Team, 10PageCuration, 10User-DannyS712: Api: Don't log (un)reviewing if state doesn't change - https://phabricator.wikimedia.org/T234074 (10DannyS712) [17:37:24] (03CR) 10Kosta Harlan: [C: 04-1] Add JS and dialog for startediting module (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [17:45:57] 10Growth-Team, 10PageCuration, 10User-DannyS712: Enqueue: Allow enqueueing without unreviewing - https://phabricator.wikimedia.org/T234077 (10DannyS712) [17:50:07] (03CR) 10MusikAnimal: [C: 03+2] "Thank you for this! We will try to get this deployed ASAP, which might have to be Monday." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) (owner: 10DannyS712) [17:58:50] (03PS1) 10Kosta Harlan: Homepage: Stop querying non-existent help module storage [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/539592 (https://phabricator.wikimedia.org/T232548) [18:08:41] 10Growth-Team, 10PageCuration, 10User-DannyS712: Api: Allow enqueueing without unreviewing - https://phabricator.wikimedia.org/T234077 (10DannyS712) [18:54:00] (03CR) 10Kosta Harlan: Homepage: add banners for mobile discovery (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/539176 (https://phabricator.wikimedia.org/T224883) (owner: 10Gergő Tisza) [18:55:59] 10Growth-Team: Email subject header displays transcluded template - https://phabricator.wikimedia.org/T234093 (10Etonkovidova) [18:58:10] (03PS1) 10DannyS712: Don't allow enqueueing main page via API [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539606 (https://phabricator.wikimedia.org/T234073) [19:02:19] (03PS2) 10DannyS712: Don't allow enqueueing main page via API [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539606 (https://phabricator.wikimedia.org/T234073) [19:03:08] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10Patch-For-Review, 10User-DannyS712: Don't show option to requeue main page - https://phabricator.wikimedia.org/T234073 (10DannyS712) @MusikAnimal can you take a look at the second patch I submitted? The API shouldn't allow it either [19:04:25] 10Growth-Team: [euwiki] Email subject header displays transcluded template - https://phabricator.wikimedia.org/T234093 (10Etonkovidova) [19:12:59] 10Growth-Team, 10PageCuration, 10User-DannyS712: Api: Allow enqueueing without unreviewing - https://phabricator.wikimedia.org/T234077 (10DannyS712) [19:13:25] 10Growth-Team, 10PageCuration, 10User-DannyS712: Api: Allow enqueueing without unreviewing - https://phabricator.wikimedia.org/T234077 (10DannyS712) [19:19:07] (03CR) 10Kosta Harlan: [C: 04-1] Homepage: add banners for mobile discovery (036 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/539176 (https://phabricator.wikimedia.org/T224883) (owner: 10Gergő Tisza) [19:23:15] 10Growth-Team: [euwiki] Email subject header displays transcluded template - https://phabricator.wikimedia.org/T234093 (10Ammarpad) Fixed on [[https://translatewiki.net/w/i.php?title=MediaWiki:Growthexperiments-confirmemail-confirm-subject/eu&diff=9026073&oldid=8795131|translatewiki]]. SITENAME magic word was m... [19:31:25] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): Allow filtering by date range in Special:NewPagesFeed - https://phabricator.wikimedia.org/T167475 (10MusikAnimal) >>! In T167475#5524623, @Kudpung wrote: > Looks good and works, except the po... [20:07:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Homepage: Stop querying non-existent help module storage (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/539592 (https://phabricator.wikimedia.org/T232548) (owner: 10Kosta Harlan) [20:26:43] (03CR) 10Catrope: "Thanks for the svgo. I am a bit confused that it modified the tags slightly, because those were copy-pasted from OOUI icons which h" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/538352 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope) [20:48:25] (03Merged) 10jenkins-bot: Don't show option to enqueue main page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) (owner: 10DannyS712) [20:53:31] (03CR) 10jenkins-bot: Don't show option to enqueue main page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) (owner: 10DannyS712) [21:09:12] 10Growth-Team, 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), and 2 others: Don't allow requeueing main page - https://phabricator.wikimedia.org/T234073 (10DannyS712) [21:14:36] (03PS1) 10DannyS712: API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [21:21:52] (03PS2) 10DannyS712: API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [21:51:31] (03PS3) 10DannyS712: API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [21:52:46] (03CR) 10jerkins-bot: [V: 04-1] API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) (owner: 10DannyS712) [21:55:34] (03CR) 10jerkins-bot: [V: 04-1] API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) (owner: 10DannyS712) [21:57:25] (03PS4) 10DannyS712: API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [23:39:22] (03PS15) 10Catrope: Homepage: Add startediting placeholder module for suggested edits [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) [23:39:33] (03CR) 10Catrope: Homepage: Add startediting placeholder module for suggested edits (036 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/536719 (https://phabricator.wikimedia.org/T232419) (owner: 10Catrope)