[01:29:14] 10Growth-Team, 10WikiLove, 10Timeless, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Timeless uses words instead of a heart for wikilove - https://phabricator.wikimedia.org/T173219 (10Isarra) 05Open→03Resolved a:03Isarra [02:31:28] 10Growth-Team, 10StructuredDiscussions, 10Timeless: The dropdown menu in flow (three dots on a thread) has weird borders in Timeless - https://phabricator.wikimedia.org/T173220 (10Isarra) 05Open→03Resolved a:03Isarra Looks like we've all happily (?) converged on using normal ooui stuff, which timeless... [03:01:50] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications, 10Timeless, 10Mobile: Timeless: Usability issues on mobile devices - https://phabricator.wikimedia.org/T173152 (10Isarra) [03:09:15] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications, 10Timeless, 10Mobile: Timeless: Usability issues on mobile devices - https://phabricator.wikimedia.org/T173152 (10Isarra) [03:10:15] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications, 10Timeless, 10Mobile: Timeless: Usability issues on mobile devices - https://phabricator.wikimedia.org/T173152 (10Isarra) 05Open→03Resolved a:03Isarra All right, we still got T179265 open, but everything seems to at least be generally res... [03:48:18] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications, 10Timeless, 10Mobile: Timeless: Usability issues on mobile devices - https://phabricator.wikimedia.org/T173152 (10Isarra) [03:50:08] (03PS1) 10Samwilson: Use plural variable name everywhere for page ID arrays [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/532286 [03:55:38] (03PS2) 10Samwilson: Use plural variable name everywhere for page ID arrays [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/532286 [04:04:59] 10Collaboration-Team-Triage, 10Notifications, 10Timeless: Better icons for echo in timeless skin - https://phabricator.wikimedia.org/T160653 (10Isarra) 05Open→03Resolved a:03Isarra Eh who cares. Much, much more of an issue is that there are //two// icons... [04:05:57] 10Collaboration-Team-Triage, 10Notifications, 10Timeless: Better icons for echo in timeless skin - https://phabricator.wikimedia.org/T160653 (10Isarra) 05Resolved→03Declined [04:09:32] 10Growth-Team, 10Notifications, 10MonoBook, 10Timeless: Use single Echo badge for notifications with different colours to indicate status/type - https://phabricator.wikimedia.org/T231180 (10Isarra) [04:20:54] (03CR) 10Mooeypoo: [C: 03+1] "Looks good to me, but I didn't have a chance to test." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/532286 (owner: 10Samwilson) [07:01:58] (03CR) 10Mooeypoo: [C: 03+1] "LGTM, but didn't test yet. Awaiting for other comments to resolve before merging." (034 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530977 (https://phabricator.wikimedia.org/T230455) (owner: 10MusikAnimal) [07:22:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/532314 (owner: 10L10n-bot) [07:28:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532315 (owner: 10L10n-bot) [09:29:05] (03PS2) 10Catrope: Homepage: Transit mobile overlay HTML as HTML, not JSON [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/532087 [10:18:12] (03PS1) 10Samwilson: Remove 'broken' group from ArticleMetadataTest [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/532349 [10:18:39] 10Growth-Team, 10MediaWiki-Watchlist: Improve watchlist/edit layout - https://phabricator.wikimedia.org/T25387 (10DannyS712) Now at https://www.mediawiki.org/wiki/File:T25387.png [11:01:00] 10Growth-Team, 10MediaWiki-Watchlist: Improve watchlist/edit layout - https://phabricator.wikimedia.org/T25387 (10kostajh) See also T220245 which proposes to change this further. [12:11:30] 10Growth-Team, 10Community-Tech, 10PageCuration: Display Number of Pageviews in New Pages Feed - https://phabricator.wikimedia.org/T230567 (10Prtksxna) Will the average (or median) be calculated since the page was created? Or will it be the average of that week or something? If it is since the beginning I t... [12:24:23] (03CR) 10Kosta Harlan: [C: 03+2] "I'm not sure why this only started breaking recently." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/532086 (owner: 10Catrope) [12:38:23] (03CR) 10Kosta Harlan: [C: 04-1] Homepage: Restructure mobile overlay handling (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/527800 (https://phabricator.wikimedia.org/T229271) (owner: 10Catrope) [12:52:25] (03CR) 10Catrope: [C: 03+2] Cleanup setTriageStatus() and IDatabase::affectedRows() usage [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/526594 (https://phabricator.wikimedia.org/T229456) (owner: 10Aaron Schulz) [12:59:43] (03CR) 10Kosta Harlan: Homepage: Transit mobile overlay HTML as HTML, not JSON (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/532087 (owner: 10Catrope) [13:10:35] (03PS15) 10Kosta Harlan: Homepage discovery for desktop no-JS users [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/526179 (https://phabricator.wikimedia.org/T225318) [14:31:24] 10Growth-Team, 10GrowthExperiments: Welcome Survey: not accessible when database is in read-only mode - https://phabricator.wikimedia.org/T229054 (10kostajh) 05Open→03Declined OK, thanks for the response. I've marked this as Declined but we can re-open if need be. [14:32:52] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, and 2 others: Click trash on recent changes doesn't clear open filter menus - https://phabricator.wikimedia.org/T231053 (10kostajh) @MMiller_WMF seems like this could go into a future quarter, un... [14:33:49] 10Growth-Team, 10StructuredDiscussions: Mentioning with @ puts the caret before the name - https://phabricator.wikimedia.org/T139292 (10kostajh) Seems like this is getting solved in T231094 [14:35:26] 10Growth-Team, 10MediaWiki-Watchlist: Improve watchlist/edit layout - https://phabricator.wikimedia.org/T25387 (10kostajh) 05Open→03Invalid Nothing especially actionable here so I'm going to mark this as invalid. As noted in T25387#5437418, the layout will probably change soon anyway as a result of the pat... [14:37:03] 10Growth-Team, 10Notifications, 10MonoBook, 10Timeless: Use single Echo badge for notifications with different colours to indicate status/type - https://phabricator.wikimedia.org/T231180 (10kostajh) @Isarra do you plan to work on this? I've moved it to External on the #growth-team under that assumption. [14:41:48] 10Growth-Team, 10GrowthExperiments, 10GrowthExperiments-Help panel, 10GrowthExperiments-Homepage: Users should have either both homepage and help panel, or none of those projects - https://phabricator.wikimedia.org/T231175 (10kostajh) This came up recently in a separate context, but I can't find a link at... [14:43:25] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-History-and-Diffs, 10MediaWiki-Special-pages, 10patch-welcome: Please display revision length in characters, not bytes, in history and Recent Changes - https://phabricator.wikimedia.org/T27198 (10kostajh) This is not something the #Growth-team plans... [14:44:20] 10Growth-Team, 10StructuredDiscussions, 10Wikimedia-Site-requests: Remove Flow from the Reference desk on the Persian Wikipedia - https://phabricator.wikimedia.org/T231156 (10kostajh) Per T231156#5436159 sounds like a task for a steward, so marking as external to #growth-team. [14:45:18] 10Collaboration-Team-Triage, 10Growth-Team, 10PageCuration, 10Accessibility: New page patrol uses only color to indicate patrol status - https://phabricator.wikimedia.org/T172765 (10kostajh) 05Open→03Invalid Marking as invalid per T172765#5434983, please reopen (with more detail please) if this is stil... [14:46:06] 10Growth-Team, 10StructuredDiscussions: Copying mentions from posts into VE doesn't work in Firefox - https://phabricator.wikimedia.org/T101376 (10kostajh) Marking as External as this will be fixed in VE per T101376#5434379 [15:19:48] 10Growth-Team, 10Notifications, 10MonoBook, 10Timeless: Use single Echo badge for notifications with different colours to indicate status/type - https://phabricator.wikimedia.org/T231180 (10Isarra) >>! In T231180#5437819, @kostajh wrote: > @Isarra do you plan to work on this? I've moved it to External on t... [15:36:35] 10Growth-Team, 10Notifications, 10MonoBook, 10Timeless: Use single Echo badge for notifications with different colours to indicate status/type - https://phabricator.wikimedia.org/T231180 (10Jdlrobson) We would like to move all mobilefrontends echo code into the Echo extension. It's a continued annoyance t... [16:29:59] (03Merged) 10jenkins-bot: Impact: Fix undefined index notice when fetching pageview data fails [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/532086 (owner: 10Catrope) [16:34:52] 10Growth-Team, 10Thanks, 10Advanced Mobile Contributions, 10Growth Design, and 2 others: Thanks extension is not shown on Minerva history page (AMC mode) - https://phabricator.wikimedia.org/T230657 (10alexhollender) I can't find the conversation but I remember our rationale being something like: it doesn't... [16:35:43] (03CR) 10Paladox: "recheck" [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox) [16:36:49] (03PS1) 10Paladox: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532401 [16:42:35] (03Merged) 10jenkins-bot: Cleanup setTriageStatus() and IDatabase::affectedRows() usage [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/526594 (https://phabricator.wikimedia.org/T229456) (owner: 10Aaron Schulz) [17:06:21] 10Growth-Team, 10Notifications, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Notifications tray (mobile) - design refinements - https://phabricator.wikimedia.org/T225535 (10alexhollender) >>! In T225535#5432450, @Niedzielski wrote: > @alexhollender, there are three icon colors currently AFAIK: p... [17:08:31] (03CR) 10jerkins-bot: [V: 04-1] NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox) [17:09:28] (03PS2) 10Paladox: NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) [17:18:22] (03CR) 10jenkins-bot: Impact: Fix undefined index notice when fetching pageview data fails [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/532086 (owner: 10Catrope) [17:21:54] 10Growth-Team, 10Thanks, 10Advanced Mobile Contributions, 10Growth Design, and 2 others: Thanks extension is not shown on Minerva history page (AMC mode) - https://phabricator.wikimedia.org/T230657 (10Jdlrobson) p:05Triage→03Low [17:23:08] 10Growth-Team, 10Notifications, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Notifications tray (mobile) - design refinements - https://phabricator.wikimedia.org/T225535 (10Jdlrobson) Removing story points per https://phabricator.wikimedia.org/T225535#5434577 as it sounds like the scope has chan... [17:27:45] (03CR) 10jenkins-bot: Cleanup setTriageStatus() and IDatabase::affectedRows() usage [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/526594 (https://phabricator.wikimedia.org/T229456) (owner: 10Aaron Schulz) [18:19:53] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532401 (owner: 10Paladox) [18:20:09] (03CR) 10Jforrester: [C: 03+2] NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox) [18:59:05] 10Growth-Team, 10StructuredDiscussions: Mentioning with @ puts the caret before the name - https://phabricator.wikimedia.org/T139292 (10matmarex) 05Open→03Resolved a:03Esanders Fixed by https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/531945 [18:59:07] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10Tracking-Neverending: Flow mentions (tracking) - https://phabricator.wikimedia.org/T108400 (10matmarex) [19:10:40] 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review, 10Performance-Team (Radar): Investigate 2X regression in StartupModule::buildContent generation time - https://phabricator.wikimedia.org/T223260 (10Krinkle) a:03Catrope [19:20:07] (03CR) 10Krinkle: Override confirmation email with redesigned version if so configured (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/493144 (https://phabricator.wikimedia.org/T215665) (owner: 10Catrope) [20:59:06] 10Growth-Team, 10Notifications, 10MonoBook, 10Timeless: Use single Echo badge for notifications with different colours to indicate status/type - https://phabricator.wikimedia.org/T231180 (10kostajh) > We would like to move all mobilefrontends echo code into the Echo extension. It's a continued annoyance th... [21:01:45] 10Growth-Team, 10PageCuration, 10Accessibility, 10UX-Debt, and 2 others: NewPagesFeed article snippet fails WCAG AA - https://phabricator.wikimedia.org/T217781 (10kostajh) [21:10:20] 10Growth-Team, 10Community-Tech, 10PageCuration: Special:NewPageFeed - add option to filter by pageviews - https://phabricator.wikimedia.org/T207238 (10ifried) The Community Tech team has evaluated this request, which included an investigative ticket: T225169. The work presents significant challenges, but th... [22:22:08] (03CR) 10Jforrester: [C: 03+2] Prepend in-topic mention matches to results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/531947 (owner: 10Esanders) [22:22:46] (03CR) 10Jforrester: [C: 03+2] MentionInspector: Don't assume the board can be found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/531949 (https://phabricator.wikimedia.org/T201511) (owner: 10Esanders) [22:55:59] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532401 (owner: 10Paladox) [22:58:19] (03Merged) 10jenkins-bot: NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox) [23:07:03] (03PS2) 10Paladox: Use addDescription() instead of accessing guts directly [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530703 [23:15:08] (03PS3) 10Paladox: Use addDescription() instead of accessing guts directly [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530703 [23:15:10] (03PS1) 10Paladox: removeOrphanedEvents.php: Don't remove events waiting to be emailed [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532481 [23:15:13] (03PS1) 10Paladox: removeOrphanedEvents.php: Also remove echo_target_page rows [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532482 (https://phabricator.wikimedia.org/T221261) [23:20:35] (03PS1) 10Paladox: Proactively delete echo_event rows when they become orphaned [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532483 (https://phabricator.wikimedia.org/T221262) [23:52:17] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532401 (owner: 10Paladox) [23:55:36] (03CR) 10jenkins-bot: NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox)