[04:57:14] (03CR) 10Samwilson: [C: 03+1] "This all looks good to me and works in my testing. My only comment is about documentation, but it's hardly major." (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530977 (https://phabricator.wikimedia.org/T230455) (owner: 10MusikAnimal) [05:15:15] (03PS1) 10Samwilson: Prevent badges from getting in the way of clicks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/531592 (https://phabricator.wikimedia.org/T207452) [07:13:19] 10Growth-Team, 10MediaWiki-Watchlist, 10Core Platform Team, 10MediaWiki-Redirects, and 2 others: Add a Special:UnwatchedRedirects - https://phabricator.wikimedia.org/T20520 (10kostajh) Tagging #core_platform_team for visibility too. [07:35:25] (03CR) 10Kosta Harlan: Invert configuration, defaulting features to ON (034 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/527103 (https://phabricator.wikimedia.org/T229389) (owner: 10Kosta Harlan) [07:53:52] (03CR) 10Kosta Harlan: QuestionStore API: Accept language code from client (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531434 (https://phabricator.wikimedia.org/T230374) (owner: 10Kosta Harlan) [07:55:51] 10MediaWiki-Watchlist, 10OOUI, 10Core Platform Team Workboards (Clinic Duty Team), 10Growth-Team (Current Sprint), and 3 others: Introduce alphabetic pager for Special:EditWatchlist - https://phabricator.wikimedia.org/T220245 (10daniel) p:05Triage→03Normal [08:16:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531629 (owner: 10L10n-bot) [08:19:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/531639 (owner: 10L10n-bot) [08:55:32] (03CR) 10Gergő Tisza: [C: 03+2] Homepage: add bottom border to the minerva tabs [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530604 (https://phabricator.wikimedia.org/T225662) (owner: 10Sbisson) [09:10:44] (03CR) 10Gergő Tisza: QuestionStore API: Accept language code from client (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531434 (https://phabricator.wikimedia.org/T230374) (owner: 10Kosta Harlan) [09:17:44] (03Merged) 10jenkins-bot: Homepage: add bottom border to the minerva tabs [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530604 (https://phabricator.wikimedia.org/T225662) (owner: 10Sbisson) [09:22:07] (03CR) 10jenkins-bot: Homepage: add bottom border to the minerva tabs [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530604 (https://phabricator.wikimedia.org/T225662) (owner: 10Sbisson) [11:00:58] (03PS5) 10Kosta Harlan: Invert configuration, defaulting features to "on" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/527103 (https://phabricator.wikimedia.org/T229389) [11:06:51] (03PS3) 10Kosta Harlan: QuestionStore API: Accept language code from client [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531434 (https://phabricator.wikimedia.org/T230374) [11:07:28] (03CR) 10Kosta Harlan: QuestionStore API: Accept language code from client (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531434 (https://phabricator.wikimedia.org/T230374) (owner: 10Kosta Harlan) [11:11:42] (03CR) 10jerkins-bot: [V: 04-1] QuestionStore API: Accept language code from client [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531434 (https://phabricator.wikimedia.org/T230374) (owner: 10Kosta Harlan) [11:17:51] (03PS4) 10Kosta Harlan: QuestionStore API: Accept language code from client [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531434 (https://phabricator.wikimedia.org/T230374) [11:19:15] (03CR) 10Kosta Harlan: [C: 03+2] Use only default letter spacing [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531495 (https://phabricator.wikimedia.org/T230364) (owner: 10Sbisson) [11:27:05] (03PS10) 10Kosta Harlan: Selenium: Homepage can be enabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/517200 (https://phabricator.wikimedia.org/T224903) (owner: 10Ephemeralwaves) [11:28:25] (03CR) 10Kosta Harlan: [C: 04-1] "Note that the parent commit now automatically enables the homepage for all users. So you could either invert this test (go to preferences " [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/517200 (https://phabricator.wikimedia.org/T224903) (owner: 10Ephemeralwaves) [11:40:51] (03Merged) 10jenkins-bot: Use only default letter spacing [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531495 (https://phabricator.wikimedia.org/T230364) (owner: 10Sbisson) [11:41:59] (03CR) 10jerkins-bot: [V: 04-1] Selenium: Homepage can be enabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/517200 (https://phabricator.wikimedia.org/T224903) (owner: 10Ephemeralwaves) [11:42:14] (03CR) 10jerkins-bot: [V: 04-1] Selenium: Homepage can be enabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/517200 (https://phabricator.wikimedia.org/T224903) (owner: 10Ephemeralwaves) [11:55:22] (03CR) 10jenkins-bot: Use only default letter spacing [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531495 (https://phabricator.wikimedia.org/T230364) (owner: 10Sbisson) [12:01:12] (03CR) 10Gergő Tisza: [C: 03+2] Invert configuration, defaulting features to "on" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/527103 (https://phabricator.wikimedia.org/T229389) (owner: 10Kosta Harlan) [12:06:06] (03CR) 10Kosta Harlan: Invert configuration, defaulting features to "on" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/527103 (https://phabricator.wikimedia.org/T229389) (owner: 10Kosta Harlan) [12:15:20] (03Merged) 10jenkins-bot: Invert configuration, defaulting features to "on" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/527103 (https://phabricator.wikimedia.org/T229389) (owner: 10Kosta Harlan) [12:19:20] (03CR) 10jenkins-bot: Invert configuration, defaulting features to "on" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/527103 (https://phabricator.wikimedia.org/T229389) (owner: 10Kosta Harlan) [13:31:04] (03CR) 10Gergő Tisza: "How about making things a bit more generic and call the page Special:Mentors (where in the future maybe mentees can select / request mento" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530105 (https://phabricator.wikimedia.org/T228210) (owner: 10Urbanecm) [13:39:19] 10Growth-Team, 10MediaWiki-Watchlist, 10MediaWiki-Redirects, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Add a Special:UnwatchedRedirects - https://phabricator.wikimedia.org/T20520 (10WDoranWMF) [13:42:45] (03CR) 10Gergő Tisza: "ApiUsageError is clearly the wrong thing to use as there is nothing wrong with how the API is used. OTOH not returning an error makes the " [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530085 (https://phabricator.wikimedia.org/T222204) (owner: 10Kosta Harlan) [13:48:09] (03CR) 10Kosta Harlan: "> Patch Set 4:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530085 (https://phabricator.wikimedia.org/T222204) (owner: 10Kosta Harlan) [13:57:13] (03CR) 10Gergő Tisza: "> dieWithError ends up throwing ApiUsageException, right? Are you saying that $this->dieWithError is more readable?" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530085 (https://phabricator.wikimedia.org/T222204) (owner: 10Kosta Harlan) [15:46:39] (03PS6) 10D3r1ck01: mapper: Declare `insert()` method in a Mapper.php interface file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/531304 [16:08:12] (03CR) 10Catrope: [C: 04-1] QuestionPoster: Return result for non-exceptional errors (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530085 (https://phabricator.wikimedia.org/T222204) (owner: 10Kosta Harlan) [16:20:14] (03CR) 10Catrope: [C: 04-1] QuestionStore API: Accept language code from client (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/531434 (https://phabricator.wikimedia.org/T230374) (owner: 10Kosta Harlan) [16:23:11] (03CR) 10Catrope: [C: 04-1] "I agree with Gergő that away status should be done as a user preference" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530436 (https://phabricator.wikimedia.org/T227876) (owner: 10Urbanecm) [16:40:31] (03CR) 10Catrope: [C: 04-1] Allow mentors to identify as away (034 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530436 (https://phabricator.wikimedia.org/T227876) (owner: 10Urbanecm) [17:49:41] (03CR) 10Catrope: [C: 03+2] Update posted on timestamp when overlay is opened (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530837 (https://phabricator.wikimedia.org/T225941) (owner: 10Kosta Harlan) [17:56:38] (03CR) 10Catrope: [C: 04-1] "What's the benefit of this? The change introduces a Mapper interface, but it's not used anywhere. Where would this be used?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/531304 (owner: 10D3r1ck01) [18:01:25] 10Growth-Team, 10Notifications, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Notifications tray (mobile) - design refinements - https://phabricator.wikimedia.org/T225535 (10Niedzielski) a:03Niedzielski [18:09:02] (03Merged) 10jenkins-bot: Update posted on timestamp when overlay is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530837 (https://phabricator.wikimedia.org/T225941) (owner: 10Kosta Harlan) [18:12:42] (03CR) 10jenkins-bot: Update posted on timestamp when overlay is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530837 (https://phabricator.wikimedia.org/T225941) (owner: 10Kosta Harlan) [18:26:13] (03CR) 10D3r1ck01: "> What's the benefit of this?" (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/531304 (owner: 10D3r1ck01) [18:47:13] 10Growth-Team, 10Notifications, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Notifications tray (mobile) - design refinements - https://phabricator.wikimedia.org/T225535 (10Niedzielski) [18:48:15] (03PS3) 10Catrope: [WIP] Homepage: Restructure mobile overlay handling [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/527800 (https://phabricator.wikimedia.org/T229271) [18:49:28] (03CR) 10Catrope: "PS3 addresses most of the issues you brought up, but it still has one flaw: instrumentation of the startup module is special, and we're ex" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/527800 (https://phabricator.wikimedia.org/T229271) (owner: 10Catrope) [18:50:25] 10Growth-Team, 10Notifications, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Notifications tray (mobile) - design refinements - https://phabricator.wikimedia.org/T225535 (10Niedzielski) @alexhollender, there are three icon colors currently AFAIK: progressive (blue), constructive (teal), and blac... [20:29:41] (03CR) 10Jack Phoenix: [C: 04-1] "Finally \o/" (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/531533 (https://phabricator.wikimedia.org/T173219) (owner: 10Isarra) [20:30:51] (03CR) 10Isarra: "Ugh, fiiiiine." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/531533 (https://phabricator.wikimedia.org/T173219) (owner: 10Isarra) [20:49:35] (03PS3) 10Isarra: Use skinstyles to apply vector icon css to vector only [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/531533 (https://phabricator.wikimedia.org/T173219) [20:52:28] (03CR) 10Jack Phoenix: [C: 03+1] "Muy bueno!" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/531533 (https://phabricator.wikimedia.org/T173219) (owner: 10Isarra) [21:24:25] 10Growth-Team, 10GrowthExperiments: Welcome Survey: not accessible when database is in read-only mode - https://phabricator.wikimedia.org/T229054 (10nettrom_WMF) @kostajh : I'm not sure that it's possible for us to determine how often this happens, these users show up in the WelcomeSurvey data as having abando... [21:28:01] (03CR) 10Urbanecm: "> Patch Set 87:" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530105 (https://phabricator.wikimedia.org/T228210) (owner: 10Urbanecm) [21:29:06] (03CR) 10Urbanecm: Allow experienced users to claim mentees (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530105 (https://phabricator.wikimedia.org/T228210) (owner: 10Urbanecm) [21:33:34] (03CR) 10Urbanecm: "> Patch Set 21: Code-Review-1" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530436 (https://phabricator.wikimedia.org/T227876) (owner: 10Urbanecm) [21:33:46] (03PS88) 10Urbanecm: Allow experienced users to claim mentees [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/530105 (https://phabricator.wikimedia.org/T228210) [22:08:17] 10Growth-Team, 10GrowthExperiments, 10GrowthExperiments-Help panel: HelpPanel duplicate 'impression' events for switching between VE and wikitext editor - https://phabricator.wikimedia.org/T229637 (10nettrom_WMF) I don't see this as an issue. I ran the query shown below to identify consecutive `impression`... [22:13:59] 10Growth-Team, 10WikiLove, 10PageCuration, 10User-DannyS712: PageTriage: 'Send wikilove' fails to sign message - https://phabricator.wikimedia.org/T231048 (10DannyS712) [22:17:40] 10Growth-Team, 10WikiLove, 10PageCuration, 10User-DannyS712: PageTriage: 'Send wikilove' fails to sign message - https://phabricator.wikimedia.org/T231048 (10DannyS712) {F30068853} {F30068854} Screenshots provided above, link to diff: https://w.wiki/7N4 [22:17:58] 10Growth-Team, 10WikiLove, 10PageCuration, 10User-DannyS712: PageTriage: 'Send wikilove' fails to sign message - https://phabricator.wikimedia.org/T231048 (10DannyS712) [22:37:24] 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10OOUI, 10Readers-Web-Backlog (Tracking): oo-ui-textInputWidget zooms when focused on iOS - https://phabricator.wikimedia.org/T231049 (10Jdlrobson) [22:45:00] 10Growth-Team, 10Community-Tech, 10PageCuration: Display the number of pageviews in the article record - https://phabricator.wikimedia.org/T230567 (10ifried) [22:46:32] 10Growth-Team, 10Community-Tech, 10PageCuration: Display the number of pageviews in the article record - https://phabricator.wikimedia.org/T230567 (10ifried) @Prtksxna: We're considering doing this work. Where do you think it would be appropriate to display the number of page views (which will most likely be... [22:47:25] 10Growth-Team, 10Community-Tech, 10PageCuration: Display the number of pageviews in the article record - https://phabricator.wikimedia.org/T230567 (10ifried) [22:53:00] 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10OOUI, 10Readers-Web-Backlog (Tracking): oo-ui-textInputWidget zooms when focused on iOS - https://phabricator.wikimedia.org/T231049 (10Jdlrobson) [22:56:30] 10Growth-Team, 10Community-Tech, 10PageCuration: Display Number of Pageviews in New Pages Feed - https://phabricator.wikimedia.org/T230567 (10ifried) [22:57:19] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, and 2 others: Click trash on recent changes doesn't clear open filter menus - https://phabricator.wikimedia.org/T231053 (10Jdlrobson) [23:01:17] 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10OOUI, 10Readers-Web-Backlog (Tracking): oo-ui-textInputWidget zooms when focused on iOS - https://phabricator.wikimedia.org/T231049 (10matmarex) The computed font-size on that input is 14px. It must be at least 16px for iOS to... [23:02:09] 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10OOUI, 10Readers-Web-Backlog (Tracking): Recent changes "Save current filter settings" input zooms when focused on iOS - https://phabricator.wikimedia.org/T231049 (10matmarex) [23:02:40] 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10OOUI, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Recent changes "Save current filter settings" input zooms when focused on iOS - https://phabricator.wikimedia.org/T231049 (10Jdlrobson) [23:02:55] 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10OOUI, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Recent changes "Save current filter settings" input zooms when focused on iOS - https://phabricator.wikimedia.org/T231049 (10Jdlrobson) a:03ovasileva [23:03:03] 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10OOUI, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Recent changes "Save current filter settings" input zooms when focused on iOS - https://phabricator.wikimedia.org/T231049 (10Jdlrobson) Ready for discussion @ovasi... [23:03:19] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, and 2 others: Click trash on recent changes doesn't clear open filter menus - https://phabricator.wikimedia.org/T231053 (10Jdlrobson) a:03ovasileva Ready for discussion / prioritisation @ovasil... [23:48:53] 10Growth-Team, 10GrowthExperiments, 10GrowthExperiments-Help panel: HelpPanel duplicate 'impression' events for switching between VE and wikitext editor - https://phabricator.wikimedia.org/T229637 (10Etonkovidova) @nettrom_WMF - I looked again at the issue description and realized that "duplicate" is a wro... [23:50:23] 10Growth-Team, 10GrowthExperiments, 10GrowthExperiments-Help panel: HelpPanel 'impression' event when page is reloaded - https://phabricator.wikimedia.org/T229637 (10Etonkovidova) [23:53:55] 10Growth-Team, 10GrowthExperiments, 10GrowthExperiments-Help panel: HelpPanel 'impression' event when page is reloaded - https://phabricator.wikimedia.org/T229637 (10Etonkovidova)