[00:00:44] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, and 2 others: Cleanup Recent changes presentation on Minerva (mobile) - https://phabricator.wikimedia.org/T223363 (10nray) [00:07:58] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, and 2 others: mw-rcfilters-ui-menuSelectWidget-group contents disappears on scroll on mobile - https://phabricator.wikimedia.org/T223231 (10nray) [04:09:39] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, 10Regression: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10JJMC89) Adding #community-tech since this is a regression and the team has been working on the extension. [05:56:41] 10Growth-Team, 10MediaWiki-Cache, 10Operations, 10Performance-Team, and 5 others: Investigate increase in tx bandwidth usage for mc1033 - https://phabricator.wikimedia.org/T223310 (10Joe) I think I know what happened here - and it's possibly in relation with T223180 . PHP7's APC memory was perfectly ok wh... [06:42:14] 10Growth-Team, 10MediaWiki-Cache, 10Operations, 10Performance-Team, and 5 others: Investigate increase in tx bandwidth usage for mc1033 - https://phabricator.wikimedia.org/T223310 (10kostajh) > @kostajh @Catrope Could you rule out whether it's probably that the SpecialHomepage may have caused an increase i... [06:52:46] 10Growth-Team, 10MediaWiki-Cache, 10Operations, 10Performance-Team, and 5 others: Investigate increase in tx bandwidth usage for mc1033 - https://phabricator.wikimedia.org/T223310 (10Joe) @kostajh for now I'm switching off php7 for other investigations, so we will know immediately if the additional traffic... [07:17:16] 10Growth-Team, 10MediaWiki-Cache, 10Operations, 10Performance-Team, and 5 others: Investigate increase in tx bandwidth usage for mc1033 - https://phabricator.wikimedia.org/T223310 (10Joe) So, after turning off php7 this morning we saw no modification in the rate of requests to mc1033. It seems extremely p... [07:58:28] (03PS3) 10Shivanshbindal9: Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/510211 (https://phabricator.wikimedia.org/T139779) [08:14:10] (03CR) 10jerkins-bot: [V: 04-1] Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/510211 (https://phabricator.wikimedia.org/T139779) (owner: 10Shivanshbindal9) [08:16:34] 10Growth-Team, 10MediaWiki-Cache, 10Operations, 10Performance-Team, and 5 others: Investigate increase in tx bandwidth usage for mc1033 - https://phabricator.wikimedia.org/T223310 (10elukey) Would it be possible to deploy https://gerrit.wikimedia.org/r/511612 before the weekly train? [08:29:05] (03PS1) 10Hashar: Revert "Fix phan job: ignore line using JsonSerializable" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/511646 (https://phabricator.wikimedia.org/T223397) [08:34:45] (03PS3) 10Hashar: Revert "Make phan ignore JsonSerializable redefinition" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/511448 (https://phabricator.wikimedia.org/T223397) [08:34:52] (03PS2) 10Hashar: Revert "Fix phan job: ignore line using JsonSerializable" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/511646 (https://phabricator.wikimedia.org/T223397) [08:48:04] (03CR) 10Hashar: [C: 03+1] "phan is now happy and there are no other occurences of PhanRedefinedInheritedInterface being ignored." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/511646 (https://phabricator.wikimedia.org/T223397) (owner: 10Hashar) [08:48:44] (03CR) 10Hashar: [C: 03+1] "phan is now happy and there are no other occurences of PhanRedefinedInheritedInterface being ignored." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/511448 (https://phabricator.wikimedia.org/T223397) (owner: 10Hashar) [09:21:30] (03CR) 10Kosta Harlan: [C: 03+2] Revert "Make phan ignore JsonSerializable redefinition" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/511448 (https://phabricator.wikimedia.org/T223397) (owner: 10Hashar) [09:56:26] (03PS4) 10Shivanshbindal9: Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/510211 (https://phabricator.wikimedia.org/T139779) [09:58:57] (03Merged) 10jenkins-bot: Revert "Make phan ignore JsonSerializable redefinition" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/511448 (https://phabricator.wikimedia.org/T223397) (owner: 10Hashar) [10:03:34] (03PS5) 10Shivanshbindal9: Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/510211 (https://phabricator.wikimedia.org/T139779) [10:06:44] (03CR) 10jenkins-bot: Revert "Make phan ignore JsonSerializable redefinition" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/511448 (https://phabricator.wikimedia.org/T223397) (owner: 10Hashar) [10:17:22] (03CR) 10jerkins-bot: [V: 04-1] Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/510211 (https://phabricator.wikimedia.org/T139779) (owner: 10Shivanshbindal9) [10:43:58] (03PS6) 10Shivanshbindal9: Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/510211 (https://phabricator.wikimedia.org/T139779) [11:00:51] (03CR) 10jerkins-bot: [V: 04-1] Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/510211 (https://phabricator.wikimedia.org/T139779) (owner: 10Shivanshbindal9) [11:09:52] (03PS7) 10Shivanshbindal9: Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/510211 (https://phabricator.wikimedia.org/T139779) [11:36:51] 10Growth-Team, 10StructuredDiscussions: Wrong grammatical case of names of months in the Croatian translation of the StructuredDiscussions extension - https://phabricator.wikimedia.org/T223988 (10Hmxhmx) [11:45:40] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, and 2 others: Cleanup Recent changes presentation on Minerva (mobile) - https://phabricator.wikimedia.org/T223363 (10ovasileva) [11:45:59] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, and 2 others: Enable Recent Changes modules on mobile - https://phabricator.wikimedia.org/T223230 (10ovasileva) [11:46:31] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes, and 4 others: Enable new RC on mobile - https://phabricator.wikimedia.org/T178194 (10ovasileva) [15:45:05] (03PS1) 10Sbisson: Don't add CommentStoreComment as plaintext params [extensions/Echo] - 10https://gerrit.wikimedia.org/r/511742 (https://phabricator.wikimedia.org/T223741) [15:45:56] 10Notifications, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Wikimedia-production-error: Invalid message parameter CommentStoreComment from EventPresentationModel.php - https://phabricator.wikimedia.org/T223741 (10SBisson) [15:52:08] 10Notifications, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Wikimedia-production-error: Invalid message parameter CommentStoreComment from EventPresentationModel.php - https://phabricator.wikimedia.org/T223741 (10SBisson) a:03SBisson @Krinkle I think the patch above will fix the log spamming a... [16:48:20] 10Growth-Team, 10GrowthExperiments, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10MMiller_WMF) [16:48:23] 10Growth-Team, 10GrowthExperiments, 10Epic: [EPIC] Growth: Focus on help desk (in-context link) - https://phabricator.wikimedia.org/T206711 (10MMiller_WMF) [17:30:23] 10Growth-Team, 10StructuredDiscussions, 10I18n: Wrong grammatical case of month names in Slavic languages in StructuredDiscussions extension - https://phabricator.wikimedia.org/T223988 (10Nesmir_Kudilovic) I believe that the Polish translation is correct. Also correct are: Russian, Ukrainian, Slovene, Bulgar... [17:52:53] (03Abandoned) 10Kosta Harlan: do-not-merge: Demo for SonarQube [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/510806 (owner: 10Kosta Harlan) [17:57:35] (03CR) 10Kosta Harlan: "check codehealth" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/510211 (https://phabricator.wikimedia.org/T139779) (owner: 10Shivanshbindal9) [19:20:25] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10Niharika) p:05Triage→03High @MusikAnimal/@Samwilson Can you look into this? We've worked on redirects as part of... [19:21:48] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10MusikAnimal) Looking! [19:55:49] 10Growth-Team, 10Community-Tech, 10PageCuration, 10Community-Tech-Sprint, 10Patch-For-Review: Redirects with RfD tags should display in the feed under 'Nominated for deletion' - https://phabricator.wikimedia.org/T157046 (10Insertcleverphrasehere) >>! In T157046#5197807, @dom_walden wrote: > @Niharika @jo... [20:46:46] 10Growth-Team, 10StructuredDiscussions, 10I18n: Wrong grammatical case of month names in Slavic languages in StructuredDiscussions extension - https://phabricator.wikimedia.org/T223988 (10Aklapper) Thanks for the investigation! I tried to use the URL parameter `uselang=qqx` on a Flow page to find out where t... [20:54:10] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10MusikAnimal) I think I've tracked it down to [[ https://github.com/wikimedia/mediawiki-extensions-PageTriage/blob/ma... [21:01:48] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10Barkeep49) I regularly patrol from the old end of the queue and this is definitely a newer issue. It started at most... [21:15:29] 10Growth-Team, 10StructuredDiscussions, 10I18n: Wrong grammatical case of month names in Slavic languages in StructuredDiscussions extension - https://phabricator.wikimedia.org/T223988 (10Tacsipacsi) Using the HTML class, I found that it’s added in the template [[https://phabricator.wikimedia.org/diffusion/E... [21:17:40] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10MusikAnimal) Hmm okay. The last code change to PageTriage was on May 8 with https://gerrit.wikimedia.org/r/#/q/Ib1a1... [21:30:56] 10Growth-Team, 10MediaWiki-extensions-ORES, 10ORES, 10PageCuration, and 2 others: PageTriage requires ORES to be installed - https://phabricator.wikimedia.org/T200412 (10Ladsgroup) [21:33:54] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10UI-Standardization, and 2 others: [regression - wmf.28] The bookmark icon for Saved filters is missing - https://phabricator.wikimedia.org/T191366 (10Ladsgroup) [21:34:01] 10Collaboration-Team-Triage, 10Notifications, 10Wikimedia-production-error: InvalidArgumentException from line 13 of EchoIcon.php: The trash icon is not registered - https://phabricator.wikimedia.org/T191335 (10Ladsgroup) [21:35:23] 10MediaWiki-Recent-changes, 10MediaWiki-Special-pages, 10Wikimedia-production-error: Notice: Undefined property: stdClass::$rc_timestamp in /srv/mediawiki/php-1.31.0-wmf.23/includes/specials/SpecialNewpages.php - https://phabricator.wikimedia.org/T188555 (10Ladsgroup) [21:35:28] 10Collaboration-Team-Triage, 10WikiLove, 10Regression: Wikilove generates broken image thumbnails - https://phabricator.wikimedia.org/T187853 (10Ladsgroup) [21:35:39] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757 (10Ladsgroup) [21:35:47] 10Collaboration-Team-Triage, 10Thanks, 10Beta-Cluster-reproducible, 10User-Addshore, 10User-Ryasmeen: PHP Fatal Error: Class undefined: MediaWikiServices - ThanksHooks - https://phabricator.wikimedia.org/T186618 (10Ladsgroup) [21:36:00] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Regression: [wmf.12 -regression] ORES filters do not work - https://phabricator.wikimedia.org/T182936 (10Ladsgroup) [21:36:31] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10Barkeep49) So in looking through my patrol logs it's been longer than I thought since I can find a patrol I did from... [21:56:00] 10Growth-Team, 10Thanks, 10Anti-Harassment (Yōd - י), 10Patch-For-Review: 'Thanks' are completely blocked when a user is partially blocked - https://phabricator.wikimedia.org/T221371 (10Tchanders) @dbarratt makes the point that currently Thanks doesn't check whether a user can edit their own talk page. Cur... [21:58:02] 10Growth-Team, 10Thanks, 10Anti-Harassment (Yōd - י), 10Patch-For-Review: 'Thanks' are completely blocked when a user is partially blocked - https://phabricator.wikimedia.org/T221371 (10dbarratt) @Tchanders I think this should be a simple change, no? I was thinking we would just check `PermissionManager::... [22:33:14] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10Barkeep49) Another active patroller has confirmed 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10MusikAnimal) Interesting. The thing is, I reverted that change and I still see the problem on my local. But, I'm a b... [23:07:26] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10Krinkle) >>! In T223828#5202627, @MusikAnimal wrote: > Interesting. The thing is, I reverted that change and I still... [23:09:04] 10Growth-Team, 10MediaWiki-Cache, 10Operations, 10Performance-Team, and 5 others: Investigate increase in tx bandwidth usage for mc1033 - https://phabricator.wikimedia.org/T223310 (10Krinkle) [23:09:11] 10Growth-Team, 10MediaWiki-Cache, 10Operations, 10Performance-Team, and 5 others: Investigate increase in tx bandwidth usage for mc1033 - https://phabricator.wikimedia.org/T223310 (10Krinkle) [23:09:24] 10Growth-Team, 10Operations, 10Performance-Team, 10Wikidata, and 4 others: Investigate increase in tx bandwidth usage for mc1033 - https://phabricator.wikimedia.org/T223310 (10Krinkle) [23:25:32] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10MusikAnimal) Thanks. Back to the drawing board, I suppose. I can confirm `Revision::getPrevious()` does by itself wo... [23:36:44] 10Growth-Team, 10Community-Tech, 10English-Wikipedia-New-Pages-Patrol, 10PageCuration, and 2 others: Redirects not appearing in New Page Patrol - https://phabricator.wikimedia.org/T223828 (10MusikAnimal) I've re-enabled https://en.wikipedia.org/wiki/Special:AbuseFilter/342 as an interim solution. You can m...