[00:32:55] (03CR) 10Samwilson: [C: 03+1] "Looks good to me. I don't know if my question warrants a comment; up to you." (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/507455 (https://phabricator.wikimedia.org/T207439) (owner: 10MusikAnimal) [00:34:52] (03CR) 10Samwilson: [C: 03+1] "Ready to merge. After the next train, I guess?" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [01:19:11] 10Growth-Team, 10StructuredDiscussions, 10Verified, 10VisualEditor (Current work): Flow widgets lose focus styling after using an inspector - https://phabricator.wikimedia.org/T211515 (10ppelberg) 05Open→03Resolved [01:26:36] 10Growth-Team, 10MediaWiki-Watchlist, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10aaron) >>! In T218511#5170113, @Jonesey95 wrote: > Thanks for the... [09:45:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509251 (owner: 10L10n-bot) [09:49:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509263 (owner: 10L10n-bot) [10:23:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/509296 (owner: 10L10n-bot) [11:31:46] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019: Welcome survey: allow users to complete the survey later - https://phabricator.wikimedia.org/T212021 (10Aklapper) Assuming this is a project at #Wikimedia-Hackathon-2019. Who plans to work at this at #Wikimedia-Hackathon-201... [11:31:55] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019: Welcome survey: let communities administer survey questions - https://phabricator.wikimedia.org/T222924 (10Aklapper) Assuming this is a project at #Wikimedia-Hackathon-2019. Who plans to work at this at #Wikimedia-Hackathon-... [15:35:23] (03PS10) 10Kosta Harlan: Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) [15:43:42] (03CR) 10jerkins-bot: [V: 04-1] Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) (owner: 10Kosta Harlan) [16:04:31] (03PS11) 10Kosta Harlan: Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) [17:39:56] (03PS1) 10Kosta Harlan: Return empty array if there are no questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) [17:49:26] (03CR) 10jerkins-bot: [V: 04-1] Return empty array if there are no questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) (owner: 10Kosta Harlan) [17:50:37] (03PS2) 10Kosta Harlan: Return empty array if there are no questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) [18:03:52] (03PS6) 10Daimona Eaytoy: [WIP] Add phan [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 [18:04:15] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (owner: 10Daimona Eaytoy) [18:24:56] 10Collaboration-Team-Triage, 10Growth-Team, 10MediaWiki-extensions-LiquidThreads, 10StructuredDiscussions: Flow test failures locally with LQT enabled - https://phabricator.wikimedia.org/T182024 (10Reedy) Still failing... https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/48392/cons... [18:39:21] (03PS1) 10Kosta Harlan: Add link to help desk in footer of help module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509485 (https://phabricator.wikimedia.org/T222183) [18:46:31] (03CR) 10jerkins-bot: [V: 04-1] Add link to help desk in footer of help module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509485 (https://phabricator.wikimedia.org/T222183) (owner: 10Kosta Harlan) [18:50:34] (03PS1) 10Kosta Harlan: Disable broken tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509490 (https://phabricator.wikimedia.org/T182024) [18:52:26] (03CR) 10Sbisson: [C: 03+2] Return empty array if there are no questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) (owner: 10Kosta Harlan) [18:53:00] 10Growth-Team, 10MediaWiki-extensions-LiquidThreads, 10StructuredDiscussions, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): Flow test failures locally with LQT enabled - https://phabricator.wikimedia.org/T182024 (10kostajh) This started happening for GrowthExperiments as well. [19:06:18] (03CR) 10jerkins-bot: [V: 04-1] Return empty array if there are no questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) (owner: 10Kosta Harlan) [19:07:54] (03CR) 10Umherirrender: [C: 03+1] "Just to document: LiquidThread is now loaded as dependency and the tests not longer marked skipped - I292ad7bb815c1ad1a3e2fe709650794c8667" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509490 (https://phabricator.wikimedia.org/T182024) (owner: 10Kosta Harlan) [19:10:06] (03PS2) 10Umherirrender: Disable broken tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509490 (https://phabricator.wikimedia.org/T182024) (owner: 10Kosta Harlan) [19:10:10] (03CR) 10Umherirrender: [C: 03+2] Disable broken tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509490 (https://phabricator.wikimedia.org/T182024) (owner: 10Kosta Harlan) [19:10:35] (03CR) 10Umherirrender: [C: 03+2] "I have removed @throws on the test, because that is very uncommon in that tests from my view" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509490 (https://phabricator.wikimedia.org/T182024) (owner: 10Kosta Harlan) [19:24:06] (03CR) 10jerkins-bot: [V: 04-1] Disable broken tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509490 (https://phabricator.wikimedia.org/T182024) (owner: 10Kosta Harlan) [19:26:45] (03CR) 10Umherirrender: [C: 03+2] Disable broken tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509490 (https://phabricator.wikimedia.org/T182024) (owner: 10Kosta Harlan) [19:40:22] (03PS1) 10Kosta Harlan: Prevent user from accessing Homepage if preference isn't enabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509501 (https://phabricator.wikimedia.org/T220831) [19:42:57] (03Merged) 10jenkins-bot: Disable broken tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509490 (https://phabricator.wikimedia.org/T182024) (owner: 10Kosta Harlan) [19:44:49] (03CR) 10Kosta Harlan: [C: 03+2] "Per Stephane" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) (owner: 10Kosta Harlan) [19:45:14] (03CR) 10Umherirrender: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509485 (https://phabricator.wikimedia.org/T222183) (owner: 10Kosta Harlan) [19:45:16] (03CR) 10Kosta Harlan: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509485 (https://phabricator.wikimedia.org/T222183) (owner: 10Kosta Harlan) [19:47:10] (03CR) 10jerkins-bot: [V: 04-1] Prevent user from accessing Homepage if preference isn't enabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509501 (https://phabricator.wikimedia.org/T220831) (owner: 10Kosta Harlan) [19:47:31] (03CR) 10Kosta Harlan: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509501 (https://phabricator.wikimedia.org/T220831) (owner: 10Kosta Harlan) [19:50:00] (03CR) 10jenkins-bot: Disable broken tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509490 (https://phabricator.wikimedia.org/T182024) (owner: 10Kosta Harlan) [19:56:21] (03CR) 10jerkins-bot: [V: 04-1] Add link to help desk in footer of help module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509485 (https://phabricator.wikimedia.org/T222183) (owner: 10Kosta Harlan) [19:56:48] (03CR) 10jerkins-bot: [V: 04-1] Return empty array if there are no questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) (owner: 10Kosta Harlan) [19:58:41] (03CR) 10jerkins-bot: [V: 04-1] Prevent user from accessing Homepage if preference isn't enabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509501 (https://phabricator.wikimedia.org/T220831) (owner: 10Kosta Harlan) [20:18:32] (03PS1) 10Vedmaka Wakalaka: Support for Permission Manager [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/509513 [20:26:28] (03PS1) 10Umherirrender: Set MainConfig on DerivativeContext when running hook [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509517 [20:27:17] (03CR) 10Umherirrender: [C: 04-2] "to run tests only" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509517 (owner: 10Umherirrender) [20:35:55] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): ConfigException: HashConfig::get: undefined option: 'AllowConfirmedEmail' - https://phabricator.wikimedia.org/T222980 (10Aklapper) [20:39:00] (03PS2) 10Umherirrender: Set MainConfig on DerivativeContext when running hook [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509517 (https://phabricator.wikimedia.org/T222980) [20:39:12] (03CR) 10Umherirrender: Set MainConfig on DerivativeContext when running hook [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509517 (https://phabricator.wikimedia.org/T222980) (owner: 10Umherirrender) [20:40:07] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): ConfigException: HashConfig::get: undefined option: 'AllowConfirmedEmail' - https://phabricator.wikimedia.org/T222980 (10Umherirrender) The extension is trigged on hook `EditFil... [20:55:14] 10Notifications, 10Community-Tech, 10MediaWiki-extensions-LoginNotify, 10Growth-Team (Current Sprint), and 2 others: [betalabs] Stuck cross-wiki notification - https://phabricator.wikimedia.org/T220762 (10Etonkovidova) 05Open→03Resolved a:03Etonkovidova [20:57:43] (03PS1) 10Vedmaka Wakalaka: Support for PermissionManager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/509525 [21:02:56] (03CR) 10Kosta Harlan: [C: 03+2] Set MainConfig on DerivativeContext when running hook [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509517 (https://phabricator.wikimedia.org/T222980) (owner: 10Umherirrender) [21:03:20] (03CR) 10Kosta Harlan: [C: 03+2] "Thank you for spotting and fixing this!" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509517 (https://phabricator.wikimedia.org/T222980) (owner: 10Umherirrender) [21:41:37] (03CR) 10Catrope: [C: 03+2] Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) (owner: 10Kosta Harlan) [21:42:33] (03CR) 10Catrope: [C: 03+2] Return empty array if there are no questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) (owner: 10Kosta Harlan) [21:52:10] (03CR) 10Catrope: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509501 (https://phabricator.wikimedia.org/T220831) (owner: 10Kosta Harlan) [22:03:27] (03CR) 10jerkins-bot: [V: 04-1] Prevent user from accessing Homepage if preference isn't enabled [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509501 (https://phabricator.wikimedia.org/T220831) (owner: 10Kosta Harlan) [22:12:04] (03Merged) 10jenkins-bot: Set MainConfig on DerivativeContext when running hook [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509517 (https://phabricator.wikimedia.org/T222980) (owner: 10Umherirrender) [22:12:09] (03Merged) 10jenkins-bot: Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) (owner: 10Kosta Harlan) [22:14:31] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): ConfigException: HashConfig::get: undefined option: 'AllowConfirmedEmail' - https://phabricator.wikimedia.org/T222980 (10Umherirrender) 05Open→03Resolved a:03Umherirrender [22:15:59] (03CR) 10jenkins-bot: Set MainConfig on DerivativeContext when running hook [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509517 (https://phabricator.wikimedia.org/T222980) (owner: 10Umherirrender) [22:16:18] (03Merged) 10jenkins-bot: Return empty array if there are no questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) (owner: 10Kosta Harlan) [22:20:30] (03CR) 10jenkins-bot: Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) (owner: 10Kosta Harlan) [22:30:57] (03CR) 10jenkins-bot: Return empty array if there are no questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/509474 (https://phabricator.wikimedia.org/T222934) (owner: 10Kosta Harlan)