[00:08:18] (03CR) 10Ephemeralwaves: WIP Test that checks for user mention alerts (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/507536 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [00:13:25] (03CR) 10jenkins-bot: Remove redundant 'return true' from non-abortable hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508437 (owner: 10Krinkle) [00:26:22] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/508658 (owner: 10Jforrester) [00:53:30] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/508658 (owner: 10Jforrester) [04:02:05] (03CR) 10Samwilson: "Looks good I think." (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [04:08:16] 10Growth-Team, 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Redirects with RfD tags should display in the feed under 'Nominated for deletion' - https://phabricator.wikimedia.org/T157046 (10Samwilson) This is ready to merge, but we've not done so yet... [04:51:59] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Help panel, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage: improve error handling for questions that trigger abuse-filter - https://phabricator.wikimedia.org/T222204 (10Urbanecm) >>! In T222204#5168845, @MMiller_WMF wrot... [09:05:57] 10Growth-Team, 10Notifications, 10Anti-Harassment, 10MediaWiki-Comment-backend: Notification on invisible content in edit summary - https://phabricator.wikimedia.org/T220566 (10Scoopfinder) [11:40:14] 10Growth-Team, 10MediaWiki-Recent-changes: RecentChanges get not actualized - https://phabricator.wikimedia.org/T222838 (10Aklapper) @Luke081515: I assume the screenshot is from https://de.wikipedia.org/wiki/Special:RecentChanges ? Which filters are set? How to get that view? Exact steps to reproduce welcome.... [13:55:31] 10Growth-Team, 10MediaWiki-Watchlist, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Jonesey95) Thanks for the patch. Things are much better today, bu... [15:09:13] (03CR) 10Kosta Harlan: [C: 03+2] Help panel: Only offer the email input when email address is unset [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/506328 (https://phabricator.wikimedia.org/T222846) (owner: 10Catrope) [15:21:32] (03Merged) 10jenkins-bot: Help panel: Only offer the email input when email address is unset [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/506328 (https://phabricator.wikimedia.org/T222846) (owner: 10Catrope) [15:25:05] (03CR) 10jenkins-bot: Help panel: Only offer the email input when email address is unset [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/506328 (https://phabricator.wikimedia.org/T222846) (owner: 10Catrope) [15:46:15] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10UI-Standardization, 10Regression: Some dot-separators in recent changes and watchlist are missing surrounding whitespace - https://phabricator.wikimedia.org/T222903 (10matej_suchanek) [15:46:41] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10UI-Standardization, 10Regression: Some dot-separators in recent changes and watchlist are missing surrounding whitespace - https://phabricator.wikimedia.org/T222903 (10matej_suchanek) [15:50:06] 10Growth-Team, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Regression: Some dot-separators in recent changes and watchlist are missing surrounding whitespace - https://phabricator.wikimedia.org/T222903 (10Aklapper) [15:57:18] (03PS3) 10Umherirrender: Make use of the PHP 7 ?? operator where it makes sense [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508619 (owner: 10Thiemo Kreuz (WMDE)) [15:57:23] (03CR) 10Umherirrender: [C: 03+2] Make use of the PHP 7 ?? operator where it makes sense [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508619 (owner: 10Thiemo Kreuz (WMDE)) [16:17:13] (03Merged) 10jenkins-bot: Make use of the PHP 7 ?? operator where it makes sense [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508619 (owner: 10Thiemo Kreuz (WMDE)) [17:04:24] (03CR) 10jenkins-bot: Make use of the PHP 7 ?? operator where it makes sense [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508619 (owner: 10Thiemo Kreuz (WMDE)) [17:11:07] 10Growth-Team, 10Notifications: Improve Echo seentime code for multi-DC - https://phabricator.wikimedia.org/T222851 (10EvanProdromou) @Catrope MultiWriteBagOStuff does what you're talking about, so it's probably not necessary to replicate it in the Echo code. We can do it with a configuration. I think we'd st... [17:24:20] 10Growth-Team, 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint: Send Message to creator without needing to 'unreview'/'re-review' the article - https://phabricator.wikimedia.org/T207442 (10MBinder_WMF) @Niharika We might want to take this off the Sprint board until it's ready :) [17:25:57] (03CR) 10Zfilipin: [C: 03+2] "Looks good! 🎉" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494535 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [17:41:59] (03Merged) 10jenkins-bot: Test that checks for welcome notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494535 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [17:56:06] (03CR) 10Zfilipin: WIP Test that checks for user mention alerts (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/507536 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [18:01:14] 10Growth-Team, 10Notifications: Improve Echo seentime code for multi-DC - https://phabricator.wikimedia.org/T222851 (10EvanProdromou) @Catrope also, I talked to @kaldari by email yesterday, and he thought that //all// the data was going into the main stash. Is that true? I might need to review the Echo code ag... [18:03:32] (03CR) 10jenkins-bot: Test that checks for welcome notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494535 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [19:00:12] 10Growth-Team, 10Notifications: Improve Echo seentime code for multi-DC - https://phabricator.wikimedia.org/T222851 (10Catrope) >>! In T222851#5170947, @EvanProdromou wrote: > @Catrope also, I talked to @kaldari by email yesterday, and he thought that //all// the data was going into the main stash. Is that tru... [19:44:18] (03PS10) 10MusikAnimal: Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) [19:44:25] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:44:27] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:45:33] (03PS11) 10MusikAnimal: Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) [19:48:36] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:50:39] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:51:19] (03PS12) 10MusikAnimal: Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) [20:20:34] (03CR) 10Catrope: [C: 03+2] Update question archive/visibility status via API (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507702 (https://phabricator.wikimedia.org/T222124) (owner: 10Kosta Harlan) [20:22:20] (03CR) 10Kosta Harlan: Update question archive/visibility status via API (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507702 (https://phabricator.wikimedia.org/T222124) (owner: 10Kosta Harlan) [20:28:50] (03Merged) 10jenkins-bot: Update question archive/visibility status via API [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507702 (https://phabricator.wikimedia.org/T222124) (owner: 10Kosta Harlan) [20:34:11] (03CR) 10jenkins-bot: Update question archive/visibility status via API [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507702 (https://phabricator.wikimedia.org/T222124) (owner: 10Kosta Harlan) [20:34:40] (03CR) 10Catrope: [C: 03+2] Remove usage of deprecated Revision class in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/504589 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [20:35:50] (03CR) 10Catrope: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/504818 (owner: 10D3r1ck01) [20:36:08] (03PS6) 10Catrope: Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [20:36:39] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [20:56:19] (03Merged) 10jenkins-bot: Remove usage of deprecated Revision class in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/504589 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [20:59:24] (03CR) 10Catrope: [C: 03+2] ApiCoreThank: Replace deprecated Revision::* methods [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/504818 (owner: 10D3r1ck01) [20:59:27] (03CR) 10Catrope: [C: 03+2] Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:00:30] (03CR) 10jenkins-bot: Remove usage of deprecated Revision class in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/504589 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:05:08] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019: Personalized first day: allow users to complete the survey later - https://phabricator.wikimedia.org/T212021 (10MMiller_WMF) [21:09:15] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019: Welcome survey: let communities administer survey questions - https://phabricator.wikimedia.org/T222924 (10MMiller_WMF) [21:10:17] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019: Welcome survey: let communities administer survey questions - https://phabricator.wikimedia.org/T222924 (10MMiller_WMF) a:05MMiller_WMF→03None [21:10:38] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019: Welcome survey: allow users to complete the survey later - https://phabricator.wikimedia.org/T212021 (10MMiller_WMF) [21:11:22] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019: Help panel: ping experienced editors to answer questions - https://phabricator.wikimedia.org/T211167 (10MMiller_WMF) [21:16:02] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019, 10good first bug: Homepage: help and mentorship modals should notify bad email format with error message - https://phabricator.wikimedia.org/T219372 (10Catrope) This also applies to the help panel, which shares (much of) t... [21:24:10] (03Merged) 10jenkins-bot: ApiCoreThank: Replace deprecated Revision::* methods [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/504818 (owner: 10D3r1ck01) [21:24:12] (03Merged) 10jenkins-bot: Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:28:24] (03CR) 10jenkins-bot: Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:30:04] (03CR) 10D3r1ck01: "> Patch Set 35: Code-Review+2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/504589 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:30:33] (03CR) 10D3r1ck01: "> Patch Set 6: Code-Review+2" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/504818 (owner: 10D3r1ck01) [21:30:41] (03CR) 10D3r1ck01: "> Patch Set 6: Code-Review+2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:33:07] (03PS1) 10Catrope: Fix fatal "Object of class CommentStoreComment could not be converted to string" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) [21:35:25] (03PS2) 10Catrope: Fix fatal "Object of class CommentStoreComment could not be converted to string" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) [21:38:32] (03CR) 10D3r1ck01: [C: 03+2] "Right!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) (owner: 10Catrope) [21:39:54] (03PS9) 10Kosta Harlan: Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) [21:42:17] (03CR) 10Catrope: [C: 03+2] Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) (owner: 10Kosta Harlan) [21:48:51] (03CR) 10jerkins-bot: [V: 04-1] Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) (owner: 10Kosta Harlan) [21:50:05] (03CR) 10jerkins-bot: [V: 04-1] Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) (owner: 10Kosta Harlan) [21:51:18] 10Growth-Team, 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint: Enable page curation tools to be loaded on any page (optionally) - https://phabricator.wikimedia.org/T207485 (10MusikAnimal) a:03MusikAnimal [21:55:59] 10Growth-Team, 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint: Enable page curation tools to be loaded on any page (optionally) - https://phabricator.wikimedia.org/T207485 (10MusikAnimal) a:05MusikAnimal→03None [22:00:09] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments: Help panel: use preferences for inputting email address - https://phabricator.wikimedia.org/T222926 (10MMiller_WMF) [22:00:35] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10MMiller_WMF) [22:00:40] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: use preferences for inputting email address - https://phabricator.wikimedia.org/T222926 (10MMiller_WMF) [22:00:49] (03Merged) 10jenkins-bot: Fix fatal "Object of class CommentStoreComment could not be converted to string" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) (owner: 10Catrope) [22:00:51] (03CR) 10jerkins-bot: [V: 04-1] Append number to prevent duplicate question headers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) (owner: 10Kosta Harlan) [22:00:52] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: use preferences for inputting email address - https://phabricator.wikimedia.org/T222926 (10MMiller_WMF) a:03Cntlsn [22:01:07] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: use preferences for inputting email address - https://phabricator.wikimedia.org/T222926 (10MMiller_WMF) @Catrope -- please add any other information or specifications. [22:05:03] (03CR) 10jenkins-bot: Fix fatal "Object of class CommentStoreComment could not be converted to string" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) (owner: 10Catrope) [22:54:46] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Start module prompts to create userpage in place of global userpage - https://phabricator.wikimedia.org/T222928 (10nettrom_WMF)