[06:01:37] (03PS1) 10Samwilson: Treat RfD pages as AfDs instead of redirects [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/507913 (https://phabricator.wikimedia.org/T157046) [08:43:29] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Homepage: users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 (10Trizek-WMF) Can we f... [08:45:20] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Homepage: users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 (10Urbanecm) >>! In T22... [08:52:41] 10Growth-Team, 10Notifications, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: [Bug] Big empty gutter shown in notifications panel - https://phabricator.wikimedia.org/T219320 (10ovasileva) a:03Edtadros >>! In T219320#5154343, @Jdlrobson wrote: > Looks like this got fixed. Not su... [09:12:02] 10Growth-Team, 10MediaWiki-Watchlist: Watchlist doesn't properly track my visits - https://phabricator.wikimedia.org/T222431 (10Bdijkstra) [09:29:27] 10Growth-Team, 10MediaWiki-Watchlist: Watchlist doesn't properly track my visits - https://phabricator.wikimedia.org/T222431 (10matej_suchanek) [09:29:32] 10Growth-Team, 10MediaWiki-Watchlist, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10matej_suchanek) [10:46:07] 10Growth-Team, 10Analytics, 10EventBus, 10MediaWiki-extensions-WikimediaEvents, and 2 others: Edits to Flow pages result in a page-links-change event with no performer - https://phabricator.wikimedia.org/T216726 (10Cirdan) [10:51:48] (03CR) 10Sbisson: [C: 04-1] "Thanks for working on this" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (owner: 10Urbanecm) [11:56:09] (03CR) 10Daniel Kinzler: Replaces $user->removeWatch with WatchedItemStore service removeWatch calls (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/506885 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [12:28:09] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Trizek-WMF) [12:30:34] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: null pageviews should not be a link - https://phabricator.wikimedia.org/T222405 (10SBisson) a:03SBisson [12:43:54] (03PS6) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [12:48:28] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [13:00:10] (03PS7) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [13:03:46] (03PS8) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [13:05:55] (03PS9) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [13:06:42] (03CR) 10Sbisson: Mentor and mentee should never be the same user (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [13:09:45] (03PS10) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [13:09:58] (03CR) 10Urbanecm: Mentor and mentee should never be the same user (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [13:10:52] (03PS1) 10Sbisson: Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) [13:14:35] (03CR) 10Sbisson: [C: 04-1] "Good job!" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [13:18:01] 10Growth-Team, 10Tool-Pageviews: Same start and end date is converted to end=start - 1 day - https://phabricator.wikimedia.org/T222403 (10kostajh) @Urbanecm when I visit that link my URL doesn't change, and start/end are both 5-02. However if I modify your URL to have start/end as 2019-05-03 (today's date), th... [13:18:17] 10Growth-Team, 10Tool-Pageviews: Same start and end date is converted to end=start - 1 day when start/end are today's date - https://phabricator.wikimedia.org/T222403 (10kostajh) [13:21:27] (03PS2) 10Sbisson: Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) [13:24:05] (03PS11) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [13:24:07] (03CR) 10Urbanecm: "> Patch Set 10: Code-Review-1" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [13:27:35] 10Growth-Team, 10Tool-Pageviews: Same start and end date is converted to end=start - 1 day when start/end are today's date - https://phabricator.wikimedia.org/T222403 (10Urbanecm) [13:27:55] 10Growth-Team, 10Tool-Pageviews: Same start and end date is converted to end=start - 1 day when start/end are today's date - https://phabricator.wikimedia.org/T222403 (10Urbanecm) thanks @kostajh [13:29:05] (03PS12) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [13:30:11] (03CR) 10Sbisson: Mentor and mentee should never be the same user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [13:31:05] (03PS13) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [13:31:30] (03CR) 10Urbanecm: Mentor and mentee should never be the same user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [13:32:00] (03PS14) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [13:42:31] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [13:49:30] (03CR) 10Sbisson: Mentor and mentee should never be the same user (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [13:54:03] (03PS15) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [13:55:09] (03CR) 10Sbisson: "FWIW I think adding seconds to the timestamp is a better, simpler, and more universal solution." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507886 (https://phabricator.wikimedia.org/T222125) (owner: 10Kosta Harlan) [13:59:52] (03CR) 10Urbanecm: Mentor and mentee should never be the same user (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [14:09:15] (03CR) 10Kosta Harlan: Mentor and mentee should never be the same user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [14:14:37] (03CR) 10Sbisson: Mentor and mentee should never be the same user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [14:15:32] (03CR) 10Sbisson: [C: 03+2] Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [14:28:28] (03CR) 10jerkins-bot: [V: 04-1] Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [14:29:51] (03CR) 10Sbisson: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [14:40:21] (03CR) 10Sbisson: Mentor and mentee should never be the same user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [14:44:06] (03CR) 10Sbisson: [C: 03+2] Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [14:56:01] (03CR) 10jerkins-bot: [V: 04-1] Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [14:58:09] (03CR) 10Kosta Harlan: Update question archive/visibility status via API (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507702 (https://phabricator.wikimedia.org/T222124) (owner: 10Kosta Harlan) [15:10:15] (03CR) 10Kosta Harlan: [C: 03+2] Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [15:12:24] (03CR) 10Kosta Harlan: [C: 03+2] "> Also refactor building of impact rows for readability." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [15:16:36] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: null pageviews should not be a link - https://phabricator.wikimedia.org/T222405 (10kostajh) [15:37:59] (03CR) 10jerkins-bot: [V: 04-1] Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [15:49:28] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Help module keeps asking for email address even it was already provided - https://phabricator.wikimedia.org/T220918 (10Etonkovidova) 05Open→03Resolved a:03Etonkovidova Fixed as per https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GrowthExperim... [15:54:33] (03CR) 10Urbanecm: Mentor and mentee should never be the same user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [16:01:47] (03PS16) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [16:04:00] (03PS17) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [16:08:27] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [16:09:56] 10Growth-Team, 10MediaWiki-Recent-changes, 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" - https://phabricator.wikimedia.org/T222394 (10Aklapper) [16:10:56] (03PS18) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [16:13:57] (03PS19) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [16:14:00] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [16:14:07] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [16:15:19] (03CR) 10Urbanecm: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [16:16:29] (03PS20) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [16:16:36] (03PS5) 10Tchanders: Allow partially blocked users to use Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) [16:27:29] (03PS1) 10Urbanecm: [tests] Test "no mentor available" case [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 [16:29:47] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [16:33:05] 10Growth-Team, 10Tool-Pageviews: Same start and end date is converted to end=start - 1 day when start/end are today's date - https://phabricator.wikimedia.org/T222403 (10MusikAnimal) This has something to do with it enforcing the max end date (roughly yesterday at midnight UTC), but it isn't applying the same... [16:34:17] (03CR) 10jerkins-bot: [V: 04-1] Allow partially blocked users to use Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) (owner: 10Tchanders) [16:38:36] (03CR) 10Urbanecm: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [16:41:39] (03CR) 10jerkins-bot: [V: 04-1] [tests] Test "no mentor available" case [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 (owner: 10Urbanecm) [16:43:37] (03CR) 10Sbisson: "Our builds have started failing with" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 (owner: 10Urbanecm) [16:47:05] (03CR) 10Urbanecm: "> Patch Set 1:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 (owner: 10Urbanecm) [16:49:24] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [16:52:35] (03CR) 10Tchanders: Allow partially blocked users to use Thanks (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) (owner: 10Tchanders) [16:52:42] (03CR) 10Tchanders: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) (owner: 10Tchanders) [17:00:38] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) [17:00:54] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) p:05Triage→03High [17:08:21] (03CR) 10jerkins-bot: [V: 04-1] Allow partially blocked users to use Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) (owner: 10Tchanders) [17:08:56] (03PS1) 10Sbisson: Fix phan job: ignore line using JsonSerializable [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507994 (https://phabricator.wikimedia.org/T222465) [17:15:34] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) Apparently fixed in the library but not yet released: https://github.com/JakubOnderka/PHP-Parallel-Lint/is... [17:25:19] (03CR) 10Kosta Harlan: [C: 03+2] Fix phan job: ignore line using JsonSerializable [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507994 (https://phabricator.wikimedia.org/T222465) (owner: 10Sbisson) [17:30:26] (03CR) 10Kosta Harlan: Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [17:30:41] (03CR) 10Kosta Harlan: [C: 03+2] Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [17:32:12] (03CR) 10Kosta Harlan: [C: 03+2] Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [17:36:39] (03CR) 10Urbanecm: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 (owner: 10Urbanecm) [17:36:41] (03CR) 10Urbanecm: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [17:38:45] (03CR) 10jerkins-bot: [V: 04-1] Fix phan job: ignore line using JsonSerializable [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507994 (https://phabricator.wikimedia.org/T222465) (owner: 10Sbisson) [17:41:07] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) 05Resolved→03Open The patch failed to merge because of a MobileFrontend selenium test ` 13:34:06 1)... [17:46:54] (03CR) 10jerkins-bot: [V: 04-1] Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [17:48:04] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [17:48:31] (03CR) 10jerkins-bot: [V: 04-1] [tests] Test "no mentor available" case [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 (owner: 10Urbanecm) [17:50:12] (03CR) 10jerkins-bot: [V: 04-1] Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [17:51:30] (03CR) 10Kosta Harlan: Fix phan job: ignore line using JsonSerializable [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507994 (https://phabricator.wikimedia.org/T222465) (owner: 10Sbisson) [17:51:34] (03CR) 10Kosta Harlan: [C: 03+2] Fix phan job: ignore line using JsonSerializable [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507994 (https://phabricator.wikimedia.org/T222465) (owner: 10Sbisson) [18:03:03] (03Merged) 10jenkins-bot: Fix phan job: ignore line using JsonSerializable [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507994 (https://phabricator.wikimedia.org/T222465) (owner: 10Sbisson) [18:06:20] (03CR) 10jenkins-bot: Fix phan job: ignore line using JsonSerializable [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507994 (https://phabricator.wikimedia.org/T222465) (owner: 10Sbisson) [18:19:14] (03PS21) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [18:30:32] (03PS3) 10Sbisson: Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) [18:36:26] (03CR) 10Sbisson: "Could you a test for the case where there's only 2 mentors available: the mentee and another user." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [18:40:20] (03CR) 10Sbisson: [C: 04-1] "Looks good but the Start module tasks' headers now have a border-bottom and there's generally more spacing in those tasks." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507712 (owner: 10Catrope) [18:42:33] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) 05Open→03Resolved Now it's merged. [18:46:32] (03CR) 10Sbisson: [C: 03+2] "Per Kosta" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [18:53:54] (03PS2) 10Urbanecm: [tests] Test "no mentor available" case [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 [19:01:47] (03CR) 10jerkins-bot: [V: 04-1] Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [19:12:25] (03PS4) 10Catrope: Homepage: Move start module subheaders to bodies, bodies to footers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507712 [19:15:31] (03CR) 10Catrope: "> Patch Set 3: Code-Review-1" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507712 (owner: 10Catrope) [19:17:46] (03CR) 10Urbanecm: "> Patch Set 21:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [19:22:42] 10Growth-Team, 10MediaWiki-Watchlist, 10Community-Tech, 10Discovery-Search, and 8 others: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope - https://phabricator.wikimedia.org/T221577 (10aaron) >>! In T221577#5154583, @Jdforrester-WMF wrote: > Is i... [19:35:39] (03PS22) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [19:39:22] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Size improvements for Curation toolbar - https://phabricator.wikimedia.org/T207439 (10MusikAnimal) >>! In T207439#5151534, @Niharika wrote: > @MusikAnimal Is there a reason we don't want to allow the textare... [19:46:32] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [19:48:31] (03CR) 10Sbisson: Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [19:48:39] (03CR) 10Sbisson: [C: 03+2] "Per Kosta" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [19:49:20] (03PS5) 10Sbisson: Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [19:49:26] (03CR) 10Sbisson: Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [19:49:47] (03CR) 10Sbisson: [C: 03+2] Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [19:52:59] 10Growth-Team, 10MediaWiki-Watchlist, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10aaron) After struggling to reproduce anything, I saw T222431 mentioned the old non-default watchlist... [19:53:02] (03CR) 10Sbisson: Mentor and mentee should never be the same user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [19:54:03] (03PS10) 10Catrope: Help panel: Only offer the email input when email address is unset [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/506328 [19:54:30] (03CR) 10Catrope: "PS10 also carries over email changes between dialogs. This patch is now ready for review." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/506328 (owner: 10Catrope) [19:58:21] 10Growth-Team, 10MediaWiki-Watchlist, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) Unfortunately, a lot of people in two wikipedias are complaining, with js, including myself. [20:00:35] (03PS23) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [20:01:16] (03CR) 10Urbanecm: Mentor and mentee should never be the same user (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [20:02:21] (03Merged) 10jenkins-bot: Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [20:05:16] (03Merged) 10jenkins-bot: Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [20:05:42] (03CR) 10jenkins-bot: Impact: No link to pageviews tool when data is not available (--) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507956 (https://phabricator.wikimedia.org/T222405) (owner: 10Sbisson) [20:10:13] (03PS5) 10Sbisson: Homepage: Move start module subheaders to bodies, bodies to footers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507712 (owner: 10Catrope) [20:11:06] (03CR) 10jenkins-bot: Homepage: Use flexbox to align buttons in start module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507708 (owner: 10Catrope) [20:12:26] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [20:16:56] (03PS24) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [20:18:36] (03CR) 10Sbisson: [C: 03+2] Homepage: Move start module subheaders to bodies, bodies to footers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507712 (owner: 10Catrope) [20:28:16] (03CR) 10jerkins-bot: [V: 04-1] Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) (owner: 10Urbanecm) [20:29:31] (03PS25) 10Urbanecm: Mentor and mentee should never be the same user [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507876 (https://phabricator.wikimedia.org/T222400) [20:41:58] (03Merged) 10jenkins-bot: Homepage: Move start module subheaders to bodies, bodies to footers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507712 (owner: 10Catrope) [20:42:12] (03PS3) 10Urbanecm: [tests] Test "no mentor available" case [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 [20:46:00] (03CR) 10jerkins-bot: [V: 04-1] [tests] Test "no mentor available" case [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 (owner: 10Urbanecm) [20:48:48] (03PS4) 10Urbanecm: [tests] Test "no mentor available" case [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507988 [20:54:35] (03CR) 10jenkins-bot: Homepage: Move start module subheaders to bodies, bodies to footers [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/507712 (owner: 10Catrope) [21:07:09] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Epic: [EPIC] Growth: Emailability - https://phabricator.wikimedia.org/T215626 (10MMiller_WMF) [21:22:36] 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Actively delete echo_event rows when they become orphaned - https://phabricator.wikimedia.org/T221262 (10Etonkovidova) 05Open→03Resolved Checked in betalabs ` @deployment-deploy01:~$ mwscr... [21:23:23] 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: When deleting orphaned echo_event rows, also delete echo_target_page rows that refer to them - https://phabricator.wikimedia.org/T221261 (10Etonkovidova) 05Open→03Resolved [21:37:05] 10Growth-Team, 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Redirects with RfD tags should display in the feed under 'Nominated for deletion' - https://phabricator.wikimedia.org/T157046 (10Niharika) a:03Samwilson [21:39:42] 10Growth-Team, 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Redirects with RfD tags should display in the feed under 'Nominated for deletion' - https://phabricator.wikimedia.org/T157046 (10Niharika) a:05Samwilson→03None [21:40:00] 10Growth-Team, 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Redirects with RfD tags should display in the feed under 'Nominated for deletion' - https://phabricator.wikimedia.org/T157046 (10Niharika) a:03Samwilson [22:15:50] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Etonkovidova) [22:15:57] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbie... - https://phabricator.wikimedia.org/T222206 [22:17:13] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Etonkovidova) [22:17:15] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbie... - https://phabricator.wikimedia.org/T222206 [22:23:03] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Wikimedia-production-error: CAS update failed on user_touched. The version of the user to be saved is older than the current version. - https://phabricator.wikimedia.org/T222195 (10Etonkovidova) 05Open→03Reso... [22:33:59] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbie... - https://phabricator.wikimedia.org/T222206 [23:23:39] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbie... - https://phabricator.wikimedia.org/T222206