[00:12:55] 10Growth-Team, 10Notifications, 10Community-Tech, 10MediaWiki-extensions-LoginNotify: [betalabs] Stuck cross-wiki notification - https://phabricator.wikimedia.org/T220762 (10JJMC89) [00:51:05] 10Growth-Team, 10Notifications, 10MinervaNeue, 10Readers-Web-Backlog: [Bug] Wrong number of notifications shown on initial edit - https://phabricator.wikimedia.org/T220511 (10Etonkovidova) Could not reproduce it in betalabs. Betalabs shows the correct behavior for a new user account: - a newly registered... [06:32:18] (03CR) 10Raimond Spekking: "Is this deployed already? I see no effect on https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Einstellungen?uselang=en#mw-prefsection-ec" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/499582 (https://phabricator.wikimedia.org/T219444) (owner: 10Jforrester) [07:50:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/503215 (owner: 10L10n-bot) [07:54:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503212 (owner: 10L10n-bot) [08:00:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/503219 (owner: 10L10n-bot) [09:46:52] 10Growth-Team: Analytics: Tutorial give-up rate - https://phabricator.wikimedia.org/T220797 (10Urbanecm) [09:53:12] 10Growth-Team: Tutorial: Create small&simple tutorials - https://phabricator.wikimedia.org/T220800 (10Urbanecm) [09:53:58] 10Growth-Team, 10Wikimedia-Hackathon-2019: Analytics: Tutorial give-up rate - https://phabricator.wikimedia.org/T220797 (10Urbanecm) If we don't find a time for this before the Hackathon, it can be a good project there probably. [09:54:36] 10Growth-Team, 10Wikimedia-Hackathon-2019: Tutorial: Create small&simple tutorials - https://phabricator.wikimedia.org/T220800 (10Urbanecm) Good project for hackathon. [10:11:12] 10Growth-Team: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10Urbanecm) [10:11:24] 10Growth-Team: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10Urbanecm) [10:26:34] 10Growth-Team: Homepage: Getting started: Tutorial task can never be completed - https://phabricator.wikimedia.org/T220804 (10Urbanecm) [10:33:25] 10Growth-Team, 10Wikimedia-Hackathon-2019: Tutorial: Create small&simple tutorials - https://phabricator.wikimedia.org/T220800 (10SBisson) > Is linking/enabling guided tours from Help pane possible? It is possible to show it right there or link to another page with the tour shown immediately (with the `tour`... [10:39:05] 10Growth-Team: Homepage: Getting started: Tutorial task can never be completed - https://phabricator.wikimedia.org/T220804 (10SBisson) We use a job to record the tutorial page as visited but {T215339} [10:41:39] 10Growth-Team: Homepage: Getting started: Tutorial task can never be completed - https://phabricator.wikimedia.org/T220804 (10Urbanecm) [10:42:09] 10Growth-Team: Homepage: Getting started: Tutorial task can never be completed - https://phabricator.wikimedia.org/T220804 (10Urbanecm) >>! In T220804#5106705, @SBisson wrote: > We use a job to record the tutorial page as visited but {T215339} Thx. I've set the task as parent of this one, since those bugs are n... [10:47:54] 10Growth-Team: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10SBisson) The difference between the two message is the last word: "minuta" (incorrect) vs. "minutu" (correct). Are they plural and singular respectively or is it a different rule? This is the message is uses: `"duration-mi... [10:54:03] 10Growth-Team: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10Urbanecm) No, it's not relevant to singular/plural. Different [grammatical case](https://en.wikipedia.org/wiki/Grammatical_case) should be used. "minuta" is singular nominative, "minutu" is singular accusative. Depending on... [10:57:42] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10Aklapper) [11:00:31] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10SBisson) >>! In T220802#5106751, @Urbanecm wrote: > [...] > Where is `duration-minutes` used? I think it's only used in `Language::formatDuration` so it should be safe the change the transl... [11:11:29] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10Urbanecm) The problem is that for sentence "Length of this video is 1 minute", it can be translated to Czech in two ways. One alternative is "Video trvá 1 minutu" (where accusative would be u... [11:12:43] 10Growth-Team, 10MediaWiki-Watchlist, 10Patch-For-Review: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10TheDJ) @isaacl mentions: "I'm still having the opposite issue that I mentioned before: diffs being marked as read even though... [11:27:00] 10Growth-Team, 10Wikimedia-Hackathon-2019: Tutorial: Create small&simple tutorials - https://phabricator.wikimedia.org/T220800 (10Urbanecm) Great, thanks @SBisson . [12:17:52] 10Growth-Team, 10StructuredDiscussions: Add missing action- messages to Flow - https://phabricator.wikimedia.org/T220814 (10Reedy) [12:46:02] 10Growth-Team, 10MediaWiki-Watchlist, 10Patch-For-Review: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) >>! In T218511#5106768, @TheDJ wrote: > @isaacl mentions: "I'm still having the opposite issue that I mentioned bef... [12:56:25] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10SBisson) You're right, the output of `Language::formatDuration()` is used in several places even within the `Message` class when `durationParams()` is used. This is not Growth-specific and we... [13:27:28] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10Amire80) The initial task description applies also to Russian and probably most other Slavic languages. I'm on my phone and I haven't looked at the code, but {{PLURAL}} is the way to go. Tra... [14:02:37] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10Urbanecm) @Amire80 Plural is allowed, and if you scroll up in this task, you'll see that the cs definition indeed makes use of it. The problem is we have TWO singular forms, that depend on pa... [14:08:28] 10Notifications, 10Growth-Team (Current Sprint), 10Wikimedia-production-error: Exception executing job: EchoNotificationJob "No EchoEvent found with ID ..." - https://phabricator.wikimedia.org/T204894 (10SBisson) For reference, the code in the job goes like this: ` MWEchoDbFactory::newFromDefault()->waitForS... [14:09:50] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10Urbanecm) Anyway, I'll think about potentional rephrasings, maybe something feasible exists... [14:20:12] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10SBisson) >>! In T220802#5107166, @Amire80 wrote: > [...] > Translators must be allowed to use PLURAL in each message. If there's a message that has just the word "minutes", it must either be... [15:22:41] 10Growth-Team, 10Notifications, 10MinervaNeue, 10Readers-Web-Backlog: [Bug] Big empty gutter shown in notifications panel - https://phabricator.wikimedia.org/T219320 (10SBisson) @Jdlrobson My apologies. I assumed this was controlled by MobileFrontend since the same component is not full width when used in... [17:06:03] 10Notifications, 10Growth-Team (Current Sprint), 10Wikimedia-production-error: Exception executing job: EchoNotificationJob "No EchoEvent found with ID ..." - https://phabricator.wikimedia.org/T204894 (10SBisson) a:03SBisson [17:09:32] (03PS1) 10Sbisson: NotificationJob: make sure we retry to load the event from master [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503404 (https://phabricator.wikimedia.org/T204894) [18:25:30] (03PS1) 10Reedy: Add missing action- messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/503426 (https://phabricator.wikimedia.org/T220814) [18:37:19] (03CR) 10Sbisson: Add missing action- messages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/503426 (https://phabricator.wikimedia.org/T220814) (owner: 10Reedy) [18:38:00] (03CR) 10Reedy: Add missing action- messages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/503426 (https://phabricator.wikimedia.org/T220814) (owner: 10Reedy) [18:39:40] (03PS2) 10Reedy: Add missing action- messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/503426 (https://phabricator.wikimedia.org/T220814) [18:45:17] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/503426 (https://phabricator.wikimedia.org/T220814) (owner: 10Reedy) [19:06:34] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/503426 (https://phabricator.wikimedia.org/T220814) (owner: 10Reedy) [19:07:20] 10Growth-Team, 10StructuredDiscussions: Add missing action- messages to Flow - https://phabricator.wikimedia.org/T220814 (10Reedy) 05Open→03Resolved a:03Reedy [19:18:05] (03CR) 10jenkins-bot: Add missing action- messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/503426 (https://phabricator.wikimedia.org/T220814) (owner: 10Reedy) [20:05:06] (03PS1) 10Jforrester: build: Update eslint-config-wikimedia from 0.8.1 to 0.11.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/503472 [20:05:09] (03CR) 10Catrope: [C: 03+1] "Looks good to me, but I'd like Aaron (or Timo) to approve this" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503404 (https://phabricator.wikimedia.org/T204894) (owner: 10Sbisson) [20:11:15] (03PS1) 10Jforrester: build: Update eslint-config-wikimedia from 0.8.1 to 0.11.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/503479 [20:15:48] 10Growth-Team, 10GrowthExperiments-Homepage: Homepage: Time localisation - https://phabricator.wikimedia.org/T220802 (10Amire80) OK, now I've looked at the code properly and I see formatDuration. It's kind of like a simplified Moment.js, for PHP. Like Moment.js, it's good for standalone expressions, but not ne... [20:21:31] 10Collaboration-Team-Triage, 10Parsoid, 10StructuredDiscussions, 10Growth-Team (Current Sprint), and 3 others: Flow should fire wikipage.content on content insertion - https://phabricator.wikimedia.org/T94818 (10Etonkovidova) 05Open→03Resolved a:03Etonkovidova [20:27:03] 10Growth-Team, 10MediaWiki-Recent-changes: Rename un-prefixed rcfilters classes - https://phabricator.wikimedia.org/T220852 (10Esanders) [20:28:09] 10Growth-Team, 10MediaWiki-Recent-changes: Rename un-prefixed rcfilters classes - https://phabricator.wikimedia.org/T220852 (10Esanders) ` $ mwgrep rcfilters-head hewiki MediaWiki:Gadget-WLM.js ruwiki MediaWiki:Gadget-watchlist.js ruwikisource MediaWiki:Gadget-watchlist.js tgwi... [21:34:38] (03CR) 10MaxSem: [C: 03+2] build: Update eslint-config-wikimedia from 0.8.1 to 0.11.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/503479 (owner: 10Jforrester) [21:35:39] (03CR) 10MaxSem: [C: 03+2] build: Update eslint-config-wikimedia from 0.8.1 to 0.11.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/503472 (owner: 10Jforrester) [22:23:18] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia from 0.8.1 to 0.11.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/503479 (owner: 10Jforrester) [22:33:36] (03PS1) 10Catrope: removeOrphanedEvents.php: Don't remove events waiting to be emailed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503518 [22:34:02] (03PS2) 10Catrope: removeOrphanedEvents.php: Don't remove events waiting to be emailed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503518 [22:35:42] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia from 0.8.1 to 0.11.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/503479 (owner: 10Jforrester) [22:37:20] (03PS1) 10Catrope: AttributeManager: Check notify type availability before notifying [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503519 [22:43:10] (03CR) 10jerkins-bot: [V: 04-1] AttributeManager: Check notify type availability before notifying [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503519 (owner: 10Catrope) [22:47:25] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia from 0.8.1 to 0.11.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/503472 (owner: 10Jforrester) [23:12:27] 10Growth-Team, 10Notifications, 10Community-Tech, 10MediaWiki-extensions-LoginNotify: [betalabs] Stuck cross-wiki notification - https://phabricator.wikimedia.org/T220762 (10Catrope) I haven't been able to reproduce this problem, or otherwise figure out how it was possible for a web notification for `login... [23:15:52] (03CR) 10Krinkle: [C: 03+1] "Good point (re: phab comment) that waitForSlaves doesn't work here. I was wondering about that as well and made the same mistake thinking " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503404 (https://phabricator.wikimedia.org/T204894) (owner: 10Sbisson) [23:21:14] 10Growth-Team, 10Notifications, 10Community-Tech, 10MediaWiki-extensions-LoginNotify: [betalabs] Stuck cross-wiki notification - https://phabricator.wikimedia.org/T220762 (10Catrope) It appears that something happened in 1.32.0-wmf.24 that caused us to stop inserting these notifications: ` 2018-10-03 21:16... [23:32:41] 10Growth-Team, 10Notifications, 10Community-Tech, 10MediaWiki-extensions-LoginNotify, and 4 others: [Spike 8 hours] Successful login notification gets sent out even when disabled in preferences - https://phabricator.wikimedia.org/T174220 (10Catrope) I found this task and its fix in the context of {T220762}... [23:45:00] 10Growth-Team, 10Notifications, 10Community-Tech, 10MediaWiki-extensions-LoginNotify: [betalabs] Stuck cross-wiki notification - https://phabricator.wikimedia.org/T220762 (10Catrope) Found it! The change in 1.32.0-wmf.24 that changed the behavior was {b82b54f0a6ef3096e360d0fed3d7d29ebe79b248}, which was a... [23:57:04] (03CR) 10Catrope: "Ah, I see. I forgot that notify-type-availability can only be set on a per-notification basis for hidden categories. For non-hidden catego" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/499582 (https://phabricator.wikimedia.org/T219444) (owner: 10Jforrester) [23:59:26] (03PS1) 10Catrope: Disable notification emails for article-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503538 (https://phabricator.wikimedia.org/T219444)