[00:11:05] (03PS5) 10Catrope: Update references to ORESServices after namespace move. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502894 (https://phabricator.wikimedia.org/T220649) [00:12:00] (03PS1) 10Jforrester: Update references to ORESServices after namespace move. [extensions/PageTriage] (wmf/1.33.0-wmf.25) - 10https://gerrit.wikimedia.org/r/502925 (https://phabricator.wikimedia.org/T220649) [00:12:04] (03Restored) 10Catrope: Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 (owner: 10Catrope) [00:19:08] (03PS3) 10Catrope: Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 [00:20:59] (03CR) 10jerkins-bot: [V: 04-1] Update references to ORESServices after namespace move. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502894 (https://phabricator.wikimedia.org/T220649) (owner: 10Catrope) [00:25:03] (03CR) 10Catrope: [C: 03+2] Do not recreate echo_event.event_page_namespace on sqlite update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502848 (owner: 10Umherirrender) [00:27:59] (03CR) 10jerkins-bot: [V: 04-1] Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 (owner: 10Catrope) [00:32:16] (03CR) 10Jforrester: [C: 03+2] Update references to ORESServices after namespace move. [extensions/PageTriage] (wmf/1.33.0-wmf.25) - 10https://gerrit.wikimedia.org/r/502925 (https://phabricator.wikimedia.org/T220649) (owner: 10Jforrester) [00:32:17] (03PS6) 10Ephemeralwaves: Test that checks for welcome notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494535 (https://phabricator.wikimedia.org/T217051) [00:39:18] (03Merged) 10jenkins-bot: Update references to ORESServices after namespace move. [extensions/PageTriage] (wmf/1.33.0-wmf.25) - 10https://gerrit.wikimedia.org/r/502925 (https://phabricator.wikimedia.org/T220649) (owner: 10Jforrester) [00:39:55] (03CR) 10Jforrester: [V: 03+2 C: 03+2] "wmf.25 cherry-pick merged fine, so taking that as a sign that this would merge were it not for the MWNamespace difficulties." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502894 (https://phabricator.wikimedia.org/T220649) (owner: 10Catrope) [00:40:37] (03CR) 10Jforrester: "GLHF." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 (owner: 10Catrope) [00:40:50] (03CR) 10jerkins-bot: [V: 04-1] Do not recreate echo_event.event_page_namespace on sqlite update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502848 (owner: 10Umherirrender) [00:43:25] (03CR) 10jenkins-bot: Update references to ORESServices after namespace move. [extensions/PageTriage] (wmf/1.33.0-wmf.25) - 10https://gerrit.wikimedia.org/r/502925 (https://phabricator.wikimedia.org/T220649) (owner: 10Jforrester) [00:45:53] (03CR) 10jenkins-bot: Update references to ORESServices after namespace move. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502894 (https://phabricator.wikimedia.org/T220649) (owner: 10Catrope) [00:48:25] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502848 (owner: 10Umherirrender) [01:07:03] (03Merged) 10jenkins-bot: Do not recreate echo_event.event_page_namespace on sqlite update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502848 (owner: 10Umherirrender) [01:09:40] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10OOUI, 10Accessibility: Show last 250 changes and period selection dropdowns are not keyboard accessible - https://phabricator.wikimedia.org/T174819 (10kostajh) [01:11:12] (03CR) 10jenkins-bot: Do not recreate echo_event.event_page_namespace on sqlite update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502848 (owner: 10Umherirrender) [01:16:28] 10Collaboration-Team-Triage, 10MediaWiki-Interface, 10Parsoid, 10StructuredDiscussions, and 5 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247 (10Tgr) >>! In T37247#5102699, @Isarra wrote: > Can someone clarify for me if this is why ParserOptions::s... [01:54:29] (03PS1) 10Kosta Harlan: Assign mentor on account creation [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/502932 [01:58:53] (03CR) 10Kosta Harlan: "Apparently selectMentor()'s usage of getParserOutput() results in a connection to master, which TransactionProfiler complains about." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/502932 (owner: 10Kosta Harlan) [02:03:44] 10Edit-Review-Improvements-Integrated-Filters, 10OOUI, 10Accessibility, 10Growth-Team (Current Sprint): Buttons in FilterMenuHeaderWidget like “Highlight results“ are not keyboard accessible - https://phabricator.wikimedia.org/T191860 (10kostajh) a:03kostajh [02:07:01] (03CR) 10MaxSem: Remove Hungarian notation (033 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/496094 (owner: 10MaxSem) [02:07:15] (03PS4) 10MaxSem: Remove Hungarian notation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/496094 [02:15:25] (03CR) 10jerkins-bot: [V: 04-1] Remove Hungarian notation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/496094 (owner: 10MaxSem) [07:14:13] (03PS4) 10MaxSem: Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 (owner: 10Catrope) [07:22:15] (03CR) 10jerkins-bot: [V: 04-1] Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 (owner: 10Catrope) [07:48:41] 10Growth-Team, 10MediaWiki-Watchlist, 10Commons, 10Mobile: On mobile view of Wikimedia Commons, uploaded files are not listed on watchlist as "Pages" - https://phabricator.wikimedia.org/T220678 (10gh87) [07:53:28] 10Growth-Team, 10MediaWiki-Watchlist, 10Commons, 10Mobile: On mobile view of Wikimedia Commons, uploaded files are not listed on watchlist as "Pages" - https://phabricator.wikimedia.org/T220678 (10gh87) [07:54:32] 10Growth-Team, 10MediaWiki-Watchlist, 10Commons, 10Mobile: On mobile view of Wikimedia Commons, uploaded files are not listed on watchlist as "Pages" - https://phabricator.wikimedia.org/T220678 (10gh87) [09:25:27] (03CR) 10simetrical: Update references to ORESServices after namespace move. (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502894 (https://phabricator.wikimedia.org/T220649) (owner: 10Catrope) [09:31:23] (03CR) 10simetrical: Remove call to removed MWNamespace::clearCaches() (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 (owner: 10Catrope) [09:40:55] (03CR) 10simetrical: Update references to ORESServices after namespace move. (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502894 (https://phabricator.wikimedia.org/T220649) (owner: 10Catrope) [09:49:04] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: Flow renders interwiki links as external links - https://phabricator.wikimedia.org/T97552 (10Pipetricker) [10:52:15] (03CR) 10Sbisson: [C: 03+2] Do not fail on unknown revids in mention-summary events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/499558 (https://phabricator.wikimedia.org/T219155) (owner: 10Umherirrender) [10:52:18] 10Growth-Team, 10Notifications, 10Patch-For-Review, 10Wikimedia-production-error: Fatal Error when trying to read notifications: Call to a member function getComment() on null - https://phabricator.wikimedia.org/T219155 (10SBisson) >>! In T219155#5102148, @Umherirrender wrote: > I have no idea what the mai... [10:56:51] (03CR) 10Sbisson: [C: 04-1] "This patch is partly the same as I397e601dd9db45fc34669c43df5f9dd8d337ed95, which was merged and now generates a conflict." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495682 (owner: 10Daimona Eaytoy) [11:01:04] (03CR) 10Sbisson: [C: 04-2] "The help menu item was removed completely in Iaf321f88322e8a9686be62eb9b055c6544cf0ad6. This patch can probably be abandoned." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476051 (https://phabricator.wikimedia.org/T90414) (owner: 10Gopavasanth) [11:12:52] (03Merged) 10jenkins-bot: Do not fail on unknown revids in mention-summary events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/499558 (https://phabricator.wikimedia.org/T219155) (owner: 10Umherirrender) [11:19:58] (03CR) 10jenkins-bot: Do not fail on unknown revids in mention-summary events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/499558 (https://phabricator.wikimedia.org/T219155) (owner: 10Umherirrender) [11:26:51] (03PS3) 10Daimona Eaytoy: Remove deleted columns from SQLite patch file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495682 [11:27:52] (03PS4) 10Daimona Eaytoy: Update column names in SQLite patch file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495682 [11:28:18] (03CR) 10Daimona Eaytoy: ">" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495682 (owner: 10Daimona Eaytoy) [11:47:15] (03CR) 10simetrical: Update references to ORESServices after namespace move. (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502894 (https://phabricator.wikimedia.org/T220649) (owner: 10Catrope) [11:53:42] (03PS1) 10simetrical: Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502974 [11:54:03] (03CR) 10simetrical: "I don't have permission to update this change, so I made an alternative one: https://gerrit.wikimedia.org/r/502974" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 (owner: 10Catrope) [12:29:21] (03CR) 10Sbisson: [C: 03+2] Update column names in SQLite patch file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495682 (owner: 10Daimona Eaytoy) [12:49:53] (03Merged) 10jenkins-bot: Update column names in SQLite patch file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495682 (owner: 10Daimona Eaytoy) [12:58:34] (03CR) 10jenkins-bot: Update column names in SQLite patch file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495682 (owner: 10Daimona Eaytoy) [14:34:14] 10Growth-Team, 10Notifications, 10Need-volunteer, 10Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779 (10Shivanshbindal9) Hi @kostajh, can I work on this? [14:39:56] (03CR) 10Kosta Harlan: [C: 03+1] "I tested this and it works, the code looks correct to me." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502876 (https://phabricator.wikimedia.org/T217452) (owner: 10Sbisson) [14:40:24] 10Growth-Team, 10Notifications, 10Need-volunteer, 10Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779 (10kostajh) @Shivanshbindal9 yes please do! [14:48:56] (03PS3) 10Sbisson: Use echo_event.event_page_id to find events to moderate [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502876 (https://phabricator.wikimedia.org/T217452) [14:50:06] (03CR) 10Sbisson: "> Patch Set 2: Code-Review+1" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502876 (https://phabricator.wikimedia.org/T217452) (owner: 10Sbisson) [15:07:04] (03CR) 10Kosta Harlan: [C: 03+2] Use echo_event.event_page_id to find events to moderate [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502876 (https://phabricator.wikimedia.org/T217452) (owner: 10Sbisson) [15:07:05] 10Collaboration-Team-Triage, 10MediaWiki-Interface, 10Parsoid, 10StructuredDiscussions, and 5 others: content-holding
should only contain the page text - https://phabricator.wikimedia.org/T37247 (10Isarra) Thanks, that helps a lot. I wasn't even clear on what I should be looking for in the first plac... [15:15:32] (03CR) 10Jforrester: [C: 03+2] Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502974 (owner: 10simetrical) [15:15:41] (03Abandoned) 10Jforrester: Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 (owner: 10Catrope) [15:16:54] (03CR) 10Jforrester: "> Patch Set 4:" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502910 (owner: 10Catrope) [15:32:12] (03Merged) 10jenkins-bot: Use echo_event.event_page_id to find events to moderate [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502876 (https://phabricator.wikimedia.org/T217452) (owner: 10Sbisson) [15:39:04] (03CR) 10jenkins-bot: Use echo_event.event_page_id to find events to moderate [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502876 (https://phabricator.wikimedia.org/T217452) (owner: 10Sbisson) [15:43:18] (03Merged) 10jenkins-bot: Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502974 (owner: 10simetrical) [15:47:03] (03CR) 10jenkins-bot: Remove call to removed MWNamespace::clearCaches() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/502974 (owner: 10simetrical) [16:06:24] 10Growth-Team, 10MediaWiki-extensions-GettingStarted, 10Patch-For-Review, 10Wikimedia-production-error: "CAS update failed on user_touched" from GettingStarted\Hooks::onMakeGlobalVariablesScript - https://phabricator.wikimedia.org/T220275 (10Umherirrender) From the patch set, which is to overview also: >... [16:20:27] 10Growth-Team, 10Notifications, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Patch-For-Review, 10Wikimedia-production-error: Fatal Error when trying to read notifications: Call to a member function getComment() on null - https://phabricator.wikimedia.org/T219155 (10Umherirrender) 05Open→03Resolved p... [16:58:12] 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Patch-For-Review, 10good first bug: Add visible help link for Special:Notifications at the usual position - https://phabricator.wikimedia.org/T200184 (10Etonkovidova) 05Open→03Resolved Checked in betalabs... [17:55:56] 10Notifications, 10Growth-Team (Current Sprint), 10Wikimedia-production-error: Exception executing job: EchoNotificationJob "No EchoEvent found with ID ..." - https://phabricator.wikimedia.org/T204894 (10JTannerWMF) [17:58:27] 10MediaWiki-Watchlist, 10OOUI, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Wikimedia-production-error: Special:EditWatchlist fatal timeout from array_search() in oojs-ui/php/Tag.php - https://phabricator.wikimedia.org/T220245 (10JTannerWMF) [18:30:36] 10Growth-Team, 10Notifications, 10MinervaNeue, 10Readers-Web-Backlog: [Bug] Big empty gutter shown in notifications panel - https://phabricator.wikimedia.org/T219320 (10SBisson) Marking as "external" to the Growth team since this is about the notifications overlay in MobileFrontend. [18:30:36] 10MediaWiki-Watchlist, 10OOUI, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Wikimedia-production-error: Special:EditWatchlist fatal timeout from array_search() in oojs-ui/php/Tag.php - https://phabricator.wikimedia.org/T220245 (10kostajh) a:03kostajh Plan as discussed with @Catrope and @SBisso... [18:31:29] 10Collaboration-Team-Triage, 10Growth-Team, 10Pywikibot-Flow, 10Pywikibot, 10StructuredDiscussions: Add a flag to view-post to include replies - https://phabricator.wikimedia.org/T106733 (10SBisson) Marking as "external" to the Growth team since this is about pywikibot. [18:32:56] 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019, 10Growth-Team (Current Sprint): Homepage: "Your Recent Questions" - https://phabricator.wikimedia.org/T218841 (10MMiller_WMF) [18:33:31] 10Growth-Team, 10Notifications, 10MinervaNeue, 10Readers-Web-Backlog: [Bug] Big empty gutter shown in notifications panel - https://phabricator.wikimedia.org/T219320 (10kostajh) This bug is also noted in {T220407} but not sure if those regressions were introduced at the same time. [18:34:10] 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019, 10Growth-Team (Current Sprint): Homepage: "Your Recent Questions" - https://phabricator.wikimedia.org/T218841 (10MMiller_WMF) I re-specified specifications in the task description in how to deal with broken links, and this is now ready for... [18:44:05] (03PS1) 10Jforrester: [WIP] namespaceification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503081 [18:44:33] (Roan, don't worry, that definitely doesn't work, don't expect it to. :-)) [18:47:40] (03CR) 10jerkins-bot: [V: 04-1] [WIP] namespaceification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503081 (owner: 10Jforrester) [18:49:07] 10Growth-Team: Homepage: identify when a question has been responded to - https://phabricator.wikimedia.org/T220753 (10MMiller_WMF) [18:58:51] (03CR) 10Catrope: "> Patch Set 1:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/502932 (owner: 10Kosta Harlan) [19:00:36] (03CR) 10Kosta Harlan: "> Patch Set 1:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/502932 (owner: 10Kosta Harlan) [19:10:25] 10Growth-Team, 10MediaWiki-extensions-GettingStarted, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Patch-For-Review, 10Wikimedia-production-error: "CAS update failed on user_touched" from GettingStarted\Hooks::onMakeGlobalVariablesScript - https://phabricator.wikimedia.org/T220275 (10Umherirrender) 05O... [19:40:50] 10Edit-Review-Improvements-Integrated-Filters, 10OOUI, 10Accessibility, 10Growth-Team (Current Sprint): Buttons in FilterMenuHeaderWidget like “Highlight results“ are not keyboard accessible - https://phabricator.wikimedia.org/T191860 (10kostajh) I don't have great ideas about this one. We could modify `Me... [19:40:50] 10Edit-Review-Improvements-Integrated-Filters, 10OOUI, 10Accessibility, 10Growth-Team (Current Sprint): Buttons in FilterMenuHeaderWidget like “Highlight results“ are not keyboard accessible - https://phabricator.wikimedia.org/T191860 (10kostajh) a:05kostajh→03None [19:57:01] 10Growth-Team, 10Notifications, 10MinervaNeue, 10Readers-Web-Backlog: [Bug] Big empty gutter shown in notifications panel - https://phabricator.wikimedia.org/T219320 (10Jdlrobson) The widget with the problem as far as I can see is defined in Echo not mobile-frontend. Does it just need a width:100% somewhere? [20:58:07] (03CR) 10Catrope: [C: 03+2] Assign mentor on account creation [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/502932 (owner: 10Kosta Harlan) [21:02:04] (03CR) 10Catrope: [C: 03+1] Make thank-you-edit notifications configurable (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502893 (https://phabricator.wikimedia.org/T169924) (owner: 10Sbisson) [21:03:17] (03CR) 10Catrope: [C: 03+1] Make thank-you-edit notifications configurable (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/502893 (https://phabricator.wikimedia.org/T169924) (owner: 10Sbisson) [21:17:23] (03Merged) 10jenkins-bot: Assign mentor on account creation [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/502932 (owner: 10Kosta Harlan) [21:21:57] (03CR) 10jenkins-bot: Assign mentor on account creation [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/502932 (owner: 10Kosta Harlan) [21:30:38] 10Growth-Team: [betalabs] Stuck cross-wiki notification - https://phabricator.wikimedia.org/T220762 (10Catrope) Well, this is interesting: {F28619880} {F28619877} [21:46:38] 10Growth-Team: [betalabs] Stuck cross-wiki notification - https://phabricator.wikimedia.org/T220762 (10Catrope) As you say, this is a `login-success` notification. Web delivery is disabled for these notifications (not in LoginNotify itself, but in WMF config: {4f3bfc93b785ef95d0e7e2a46ced2948d5572fec}). So it ma... [21:49:14] 10Growth-Team: [betalabs] Stuck cross-wiki notification - https://phabricator.wikimedia.org/T220762 (10Catrope) BTW @Niharika is it intentional that `login-success` notifications are not deliverable through the web (only by email), and users cannot choose for them to be web-delivered even if they want to? If it... [22:10:01] 10Collaboration-Team-Triage, 10Growth-Team, 10Pywikibot-Flow, 10Pywikibot, 10StructuredDiscussions: Add a flag to view-post to include replies - https://phabricator.wikimedia.org/T106733 (10happy5214) This is a requested change in the Flow API, so while it's required by PWB, this task isn't something ext... [23:52:08] 10Growth-Team: [betalabs] Stuck cross-wiki notification - https://phabricator.wikimedia.org/T220762 (10Niharika) >>! In T220762#5105630, @Catrope wrote: > BTW @Niharika is it intentional that `login-success` notifications are not deliverable through the web (only by email), and users cannot choose for them to be...