[00:05:04] 10Collaboration-Team-Triage, 10Growth-Team, 10MediaWiki-extensions-PageCuration: Allow filtering by no citations in page curation - https://phabricator.wikimedia.org/T169120 (10Niharika) @TonyBallioni When you say //"the page curation toolbar currently..."//, you mean the New Pages Feed toolbar, right? [00:57:51] (03CR) 10MGChecker: "Shouldn't, matter, code is fine. I would be willing to adopt this change." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492595 (https://phabricator.wikimedia.org/T191599) (owner: 10Setian) [01:00:28] 10Collaboration-Team-Triage, 10Growth-Team, 10Thanks, 10MediaWiki-Logging, and 3 others: Remove Thanks for autopromote log - https://phabricator.wikimedia.org/T191599 (10MGChecker) @MaxSem This shouldn't matter, as the code is fine. I would be willing to adopt this change. I'm not really able to find a re... [01:01:57] (03CR) 10Kosta Harlan: [C: 03+2] Factor out base-url attribute transformation into static methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495415 (owner: 10Catrope) [01:09:41] 10MediaWiki-extensions-GrowthExperiments, 10MobileFrontend, 10OOUI, 10Growth-Team (Current Sprint), 10Mobile: [iOs only] Help panel doesn't have a vertical scrolling in question box - https://phabricator.wikimedia.org/T217106 (10kostajh) Adding #mobilefrontend and #ooui. I noticed that the textarea for t... [01:24:16] (03PS3) 10Kosta Harlan: Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) (owner: 10Sbisson) [01:27:10] (03PS4) 10Kosta Harlan: Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) (owner: 10Sbisson) [01:38:52] (03PS1) 10Kosta Harlan: Help Panel: Set previous editor interface as fallback for mobile [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495819 (https://phabricator.wikimedia.org/T217802) [01:41:55] (03PS2) 10Kosta Harlan: Help Panel: Set previous editor interface as fallback for mobile [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495819 (https://phabricator.wikimedia.org/T217802) [01:47:53] (03CR) 10jerkins-bot: [V: 04-1] Help Panel: Set previous editor interface as fallback for mobile [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495819 (https://phabricator.wikimedia.org/T217802) (owner: 10Kosta Harlan) [01:53:35] (03CR) 10Kosta Harlan: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495819 (https://phabricator.wikimedia.org/T217802) (owner: 10Kosta Harlan) [02:07:58] (03CR) 10Kosta Harlan: [C: 03+2] Conversion\Utils: Work around DOMDocument serialization bug [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495139 (https://phabricator.wikimedia.org/T217766) (owner: 10Catrope) [02:26:26] (03Merged) 10jenkins-bot: Conversion\Utils: Work around DOMDocument serialization bug [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495139 (https://phabricator.wikimedia.org/T217766) (owner: 10Catrope) [02:26:29] (03Merged) 10jenkins-bot: Factor out base-url attribute transformation into static methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495415 (owner: 10Catrope) [02:31:07] (03CR) 10jenkins-bot: Conversion\Utils: Work around DOMDocument serialization bug [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495139 (https://phabricator.wikimedia.org/T217766) (owner: 10Catrope) [02:35:38] (03CR) 10jenkins-bot: Factor out base-url attribute transformation into static methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495415 (owner: 10Catrope) [09:03:11] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: help module - https://phabricator.wikimedia.org/T215986 (10Cntlsn) I'm not sure I get exactly all the technicalities that @Trizek-WMF highlighted in the previous comment, but I got an idea for the help sea... [09:14:16] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Homepage: impact module - https://phabricator.wikimedia.org/T216217 (10Cntlsn) @Trizek-WMF thanks a lot for your input! Also thinking about it, I'm feeling like we hav... [13:19:14] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Homepage: impact module - https://phabricator.wikimedia.org/T216217 (10Trizek-WMF) >>! In T216217#5016743, @Cntlsn wrote: > Also thinking about it, I'm feeling like we... [13:32:47] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: help module - https://phabricator.wikimedia.org/T215986 (10Trizek-WMF) >>! In T215986#5016735, @Cntlsn wrote: > I'm not sure I get exactly all the technicalities that @Trizek-WMF highlighted in the previou... [13:33:38] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: help module - https://phabricator.wikimedia.org/T215986 (10kostajh) @Cntlsn and @Trizek-WMF, I still have the questions from T215986#4969525 . Also, keep in mind how narrow this module is – the help panel... [13:34:31] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: help module - https://phabricator.wikimedia.org/T215986 (10kostajh) [13:40:22] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: help module - https://phabricator.wikimedia.org/T215986 (10Trizek-WMF) >>! In T215986#4969525, @kostajh wrote: > Where should the search results appear? Should it be a box populated with suggestions (like the main search on e.g... [13:40:31] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: help module - https://phabricator.wikimedia.org/T215986 (10Trizek-WMF) >>! In T215986#4969525, @kostajh wrote: > Where should the search results appear? Should it be a box populated with suggestions (like the main search on e.g... [13:47:58] (03CR) 10Sbisson: "Added some notes after reviewing and testing. Will push a new patchset soon." (033 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) (owner: 10Sbisson) [14:56:11] (03PS1) 10Kosta Harlan: Help module: Set tag and fix section heading [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495897 (https://phabricator.wikimedia.org/T215986) [14:58:30] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Emailability: Improve verification email - https://phabricator.wikimedia.org/T215665 (10kostajh) @MMiller_WMF did we talk about redirecting the user to their homepage a... [15:07:09] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Homepage: impact module - https://phabricator.wikimedia.org/T216217 (10MMiller_WMF) @SBisson -- do you have any opinion on translations from the engineering perspective... [15:08:06] (03PS5) 10Sbisson: Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) [15:08:42] (03Abandoned) 10Sbisson: Help Panel: Set previous editor interface as fallback for mobile [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495819 (https://phabricator.wikimedia.org/T217802) (owner: 10Kosta Harlan) [15:15:49] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: location, navigation, and framework - https://phabricator.wikimedia.org/T215982 (10MMiller_WMF) In T217927, we are continuing to discuss the title of the page, in light of the fact that the modules are tit... [15:18:14] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Homepage: impact module - https://phabricator.wikimedia.org/T216217 (10MMiller_WMF) a:05SBisson→03Cntlsn Moving to design review and assigning to @Cntlsn for him to... [15:23:37] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: help module - https://phabricator.wikimedia.org/T215986 (10MMiller_WMF) Discussed the mockups with @Cntlsn and we noticed that the current mockups does not show the flow that we want to implement for the i... [15:34:38] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Homepage: impact module - https://phabricator.wikimedia.org/T216217 (10SBisson) >>! In T216217#5017770, @MMiller_WMF wrote: > @SBisson -- do you have any opinion on tra... [17:00:50] (03PS6) 10Sbisson: Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) [17:01:17] (03PS7) 10Sbisson: Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) [17:03:03] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: account completion module - https://phabricator.wikimedia.org/T217105 (10Cntlsn) I have updated the InVision mockup as per new specifications: - The “Email address” and “Editing” CTAs are prioritized - CTAs share same hierarch... [17:18:31] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: help module - https://phabricator.wikimedia.org/T215986 (10Cntlsn) InVision mockup updated as per latest specification: - No question-asking dialogue as in the Help panel - "Ask help desk" button will send... [17:22:16] 10Growth-Team, 10ORES, 10Scoring-platform-team: Add ORES topic prediction to the NewPagesFeed - https://phabricator.wikimedia.org/T218132 (10Halfak) [17:34:12] 10Growth-Team, 10MediaWiki-extensions-PageCuration, 10ORES, 10Scoring-platform-team: Add ORES topic prediction to the NewPagesFeed - https://phabricator.wikimedia.org/T218132 (10kostajh) [17:41:55] (03CR) 10Krinkle: Fire wikipage.content hook after content update (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495698 (https://phabricator.wikimedia.org/T62014) (owner: 10Esanders) [17:43:48] (03CR) 10Krinkle: Fire wikipage.content hook after content update (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495698 (https://phabricator.wikimedia.org/T62014) (owner: 10Esanders) [17:46:17] (03CR) 10Krinkle: Fire wikipage.content hook after content update (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495698 (https://phabricator.wikimedia.org/T62014) (owner: 10Esanders) [17:53:20] (03PS1) 10FR30799386: Changing sidebar link behaviour [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/495951 (https://phabricator.wikimedia.org/T158513) [18:00:51] (03CR) 10FR30799386: "@Kosta_Harlan, I sort of put together the "Close Page Curation" toolbar behavior ( the message will be "Hide Page Curation" though). :-)" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/495951 (https://phabricator.wikimedia.org/T158513) (owner: 10FR30799386) [18:03:44] 10Notifications, 10Growth-Team (Current Sprint), 10Wikimedia-production-error (Shared Build Failure): mediawiki-extensions-hhvm-jessie failures on EchoDiscussionParserTest - https://phabricator.wikimedia.org/T194632 (10kostajh) [18:16:24] 10Notifications, 10Growth-Team (Current Sprint), 10Wikimedia-production-error (Shared Build Failure): mediawiki-extensions-hhvm-jessie failures on EchoDiscussionParserTest - https://phabricator.wikimedia.org/T194632 (10kostajh) a:03kostajh [18:41:46] 10Collaboration-Team-Triage, 10Growth-Team, 10MediaWiki-extensions-PageCuration: Allow filtering by no citations in page curation - https://phabricator.wikimedia.org/T169120 (10Niharika) [18:42:14] 10Collaboration-Team-Triage, 10Growth-Team, 10MediaWiki-extensions-PageCuration: Allow filtering by no citations in page curation - https://phabricator.wikimedia.org/T169120 (10Niharika) @TonyBallioni I cleaned up the ticket description for the engineers. Can you confirm if it's accurate? Thank you! [18:42:43] 10Collaboration-Team-Triage, 10Growth-Team, 10MediaWiki-extensions-PageCuration: Allow filtering by no citations in page curation - https://phabricator.wikimedia.org/T169120 (10Niharika) p:05Triage→03Normal [18:42:56] 10Notifications, 10Growth-Team (Current Sprint), 10Wikimedia-production-error (Shared Build Failure): mediawiki-extensions-hhvm-jessie failures on EchoDiscussionParserTest - https://phabricator.wikimedia.org/T194632 (10kostajh) For reasons not yet clear to me, replacing instances of `Benutzer:Schnark` with `... [18:43:06] (03CR) 10Sbisson: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495251 (owner: 10Sbisson) [18:45:16] (03PS1) 10Kosta Harlan: Remove problematic test case [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495961 (https://phabricator.wikimedia.org/T194632) [18:49:53] (03CR) 10Kosta Harlan: [C: 03+1] Fix reading mode detection (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) (owner: 10Sbisson) [18:53:33] (03PS1) 10Daimona Eaytoy: [WIP] Add phan [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 [18:54:13] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (owner: 10Daimona Eaytoy) [18:58:56] (03PS8) 10Sbisson: Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) [19:04:31] (03PS2) 10Daimona Eaytoy: [WIP] Add phan [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 [19:04:43] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (owner: 10Daimona Eaytoy) [19:17:30] (03PS3) 10Daimona Eaytoy: [WIP] Add phan [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 [19:17:52] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (owner: 10Daimona Eaytoy) [19:31:40] (03CR) 10Catrope: [C: 03+2] Remove problematic test case [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495961 (https://phabricator.wikimedia.org/T194632) (owner: 10Kosta Harlan) [19:43:05] (03Merged) 10jenkins-bot: Remove problematic test case [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495961 (https://phabricator.wikimedia.org/T194632) (owner: 10Kosta Harlan) [19:47:33] (03CR) 10jenkins-bot: Remove problematic test case [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495961 (https://phabricator.wikimedia.org/T194632) (owner: 10Kosta Harlan) [19:50:09] 10Growth-Team, 10CommRel-Specialists-Support (Jan-Mar-2019), 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External): Community input for patrol log reviews in 'all public logs' - https://phabricator.wikimedia.org/T215922 (10Quiddity... [19:56:02] (03CR) 10D3r1ck01: [C: 03+2] Avoid use of func_get_args() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495482 (owner: 10Legoktm) [20:04:06] (03PS1) 10Umherirrender: Use php null coalesce operator ?? [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495989 [20:06:33] (03CR) 10Catrope: [C: 03+2] Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) (owner: 10Sbisson) [20:07:50] (03Merged) 10jenkins-bot: Avoid use of func_get_args() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495482 (owner: 10Legoktm) [20:15:19] (03CR) 10jenkins-bot: Avoid use of func_get_args() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495482 (owner: 10Legoktm) [20:18:24] (03Merged) 10jenkins-bot: Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) (owner: 10Sbisson) [20:21:32] (03CR) 10jenkins-bot: Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) (owner: 10Sbisson) [20:24:58] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Emailability: basic changes to Special:CreateAccount - https://phabricator.wikimedia.org/T216087 (10Etonkovidova) [20:26:38] (03PS4) 10Daimona Eaytoy: [WIP] Add phan [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 [20:45:13] (03CR) 10Jforrester: [C: 03+2] Use php null coalesce operator ?? [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495989 (owner: 10Umherirrender) [20:49:10] (03PS2) 10Sbisson: Refactor helppanel code [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495251 [20:56:10] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Emailability: basic changes to Special:CreateAccount - https://phabricator.wikimedia.org/T216087 (10Etonkovidova) All specs seem to be in place. Here are some screenshots: |**Desktop**|**Mobile** |{F28376847}|{F2... [21:07:21] (03Merged) 10jenkins-bot: Use php null coalesce operator ?? [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495989 (owner: 10Umherirrender) [21:11:33] (03CR) 10jenkins-bot: Use php null coalesce operator ?? [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495989 (owner: 10Umherirrender) [21:12:14] 10Growth-Team, 10Thanks, 10Advanced Mobile Contributions, 10Product-Analytics, and 2 others: Tag Thanks actions with AMC tag - https://phabricator.wikimedia.org/T215477 (10Jdlrobson) [21:12:42] 10Growth-Team, 10Thanks, 10Advanced Mobile Contributions, 10Product-Analytics, and 2 others: Tag Thanks actions with AMC tag - https://phabricator.wikimedia.org/T215477 (10Jdlrobson) This doesn't appear to be working after following the new QA steps. This is not ready for QA. [21:54:07] 10Growth-Team: [betalabs] EditAttemptStep has undeclared properties - https://phabricator.wikimedia.org/T218163 (10Etonkovidova) [21:54:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/496035 (owner: 10L10n-bot) [21:59:50] (03CR) 10Catrope: Fire wikipage.content hook after content update (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495698 (https://phabricator.wikimedia.org/T62014) (owner: 10Esanders) [22:09:52] (03PS2) 10Catrope: Help module: Set tag and fix section heading [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495897 (https://phabricator.wikimedia.org/T215986) (owner: 10Kosta Harlan) [22:10:18] (03CR) 10Catrope: [C: 03+2] Help module: Set tag and fix section heading [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495897 (https://phabricator.wikimedia.org/T215986) (owner: 10Kosta Harlan) [22:19:07] (03CR) 10jerkins-bot: [V: 04-1] Help module: Set tag and fix section heading [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495897 (https://phabricator.wikimedia.org/T215986) (owner: 10Kosta Harlan)