[00:44:22] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: mentorship module - https://phabricator.wikimedia.org/T216631 (10SBisson) >>! In T216631#5007062, @MMiller_WMF wrote: > In thinking about this some more, I'm trying to anticipate reasons that we would want... [00:48:09] (03PS1) 10Sbisson: Homepage: update page title [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494862 (https://phabricator.wikimedia.org/T215982) [00:50:51] (03PS1) 10Sbisson: Impact: update tooltips [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494863 (https://phabricator.wikimedia.org/T216217) [00:55:50] (03PS13) 10Sbisson: Homepage: Add Help module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/493070 (https://phabricator.wikimedia.org/T215986) (owner: 10Kosta Harlan) [01:05:14] (03CR) 10Sbisson: [C: 03+2] Homepage: Add Help module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/493070 (https://phabricator.wikimedia.org/T215986) (owner: 10Kosta Harlan) [01:17:43] (03Merged) 10jenkins-bot: Homepage: Add Help module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/493070 (https://phabricator.wikimedia.org/T215986) (owner: 10Kosta Harlan) [01:21:37] (03CR) 10jenkins-bot: Homepage: Add Help module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/493070 (https://phabricator.wikimedia.org/T215986) (owner: 10Kosta Harlan) [01:26:00] 10Growth-Team, 10MediaWiki-Recent-changes: ‏ListeriaBot appear in recent changes although human (not bot) filter is active in arwiki - https://phabricator.wikimedia.org/T217141 (10alanajjar) Also, some edits of [[https://ar.wikipedia.org/wiki/%D9%85%D8%B3%D8%AA%D8%AE%D8%AF%D9%85:ASammourBot|user:ASammourBot]]... [01:43:24] 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Milestone notifications are incorrect - https://phabricator.wikimedia.org/T209541 (10Etonkovidova) 05Open→03Resolved Checked the fix in betalabs. Added to the list of fixes to be checked af... [01:44:57] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: impressions with VE are incorrectly marked as reading editor_interface - https://phabricator.wikimedia.org/T217802 (10kostajh) Hmm. I can reproduce this on cswiki but not locally. A similar problem happens if you edit in wiki... [06:21:55] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: mentorship module - https://phabricator.wikimedia.org/T216631 (10MMiller_WMF) Okay, sounds good. I updated the task description. [08:57:08] 10Growth-Team, 10Notifications, 10MobileFrontend: Notification links redirects to desktop site - https://phabricator.wikimedia.org/T211559 (10Force_Radical) 05Open→03Stalled [09:06:03] 10Growth-Team, 10MediaWiki-Recent-changes: ‏ListeriaBot appear in recent changes although human (not bot) filter is active in arwiki - https://phabricator.wikimedia.org/T217141 (10Magnus) Fixed Listeria. Don't know anything about ASammourBot. [11:16:49] 10Growth-Team, 10MediaWiki-Vagrant, 10StructuredDiscussions: Database error on Admin talk page when Flow Role enabled in Vagrant: "Error: 1146 Table 'blobs' doesn't exist" - https://phabricator.wikimedia.org/T213142 (10zeljkofilipin) [12:37:58] 10Growth-Team, 10Thanks, 10Advanced Mobile Contributions, 10Product-Analytics, and 2 others: Tag Thanks actions with AMC tag - https://phabricator.wikimedia.org/T215477 (10pmiazga) The `mobile edit` and `mobile web edit` tags were applied only to article edits and file uploads. The acceptance criteria say:... [14:34:59] (03PS1) 10Sbisson: Update helppanel schema version to accept editor=homepage [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494932 (https://phabricator.wikimedia.org/T215986) [14:57:15] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Homepage: impact module - https://phabricator.wikimedia.org/T216217 (10Cntlsn) >>! In T216217#5007030, @MMiller_WMF wrote: > I updated the description to include toolti... [16:41:33] (03Abandoned) 10Pmiazga: Publish Thanks log actions to `rcandudp` [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/493740 (https://phabricator.wikimedia.org/T215477) (owner: 10Pmiazga) [17:55:18] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: impressions with VE are incorrectly marked as reading editor_interface - https://phabricator.wikimedia.org/T217802 (10SBisson) a:03SBisson When VE is the default editor, clicking the `edit` tab load the editor in place and... [17:57:36] (03PS3) 10Umherirrender: Pass IContextSource to parent in NotificationPager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/490927 [18:04:12] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: impressions with VE are incorrectly marked as reading editor_interface - https://phabricator.wikimedia.org/T217802 (10SBisson) Somewhat related: If you leave the help panel open and save your edit in VE, the page goes back to... [18:24:45] 10Collaboration-Team-Triage, 10Growth-Team, 10Notifications: The Great Echo Database Cleanup of 2016 (and 2019) - https://phabricator.wikimedia.org/T143963 (10Catrope) [18:34:23] (03CR) 10FR30799386: "@Kosta_Harlan, I have made the changes.... hope it is okay to be merged." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/492474 (https://phabricator.wikimedia.org/T207847) (owner: 10FR30799386) [18:34:36] 10Growth-Team, 10StructuredDiscussions: Upgrade from 1.31.1 to 1.32.0 breaks existing StructuredDiscussions pages: error message: **flow-error-unknown-workflow-id** - https://phabricator.wikimedia.org/T217330 (10Catrope) Oh, aha, I see. Yeah the table is intended to be shared between multiple wikis. In your ca... [18:45:09] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: impressions with VE are incorrectly marked as reading editor_interface - https://phabricator.wikimedia.org/T217802 (10SBisson) @MMiller_WMF, @nettrom_WMF I think this started breaking with [[ https://gerrit.wikimedia.org/r/... [19:09:36] (03CR) 10Sbisson: [C: 03+2] Homepage: Add Help module (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/493070 (https://phabricator.wikimedia.org/T215986) (owner: 10Kosta Harlan) [19:17:24] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Homepage: impact module - https://phabricator.wikimedia.org/T216217 (10MMiller_WMF) @Cntlsn -- I don't see the changed mockups. Where can I find those? [19:18:50] (03PS1) 10Catrope: FlowException: Don't HTML-escape in getPageTitle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495018 [19:18:53] (03PS1) 10Catrope: Don't override message and stack trace for UnknownWorkflowIdException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) [19:19:33] 10Growth-Team, 10StructuredDiscussions, 10Patch-For-Review: Upgrade from 1.31.1 to 1.32.0 breaks existing StructuredDiscussions pages: error message: **flow-error-unknown-workflow-id** - https://phabricator.wikimedia.org/T217330 (10Catrope) Before: {F28343895} After: {F28343897} [19:42:00] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): [iOs only] Help panel doesn't have a vertical scrolling in question box - https://phabricator.wikimedia.org/T217106 (10Etonkovidova) [19:48:12] (03CR) 10Catrope: [C: 03+2] eslint: Update eslint-config-wikimedia 0.11.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/494046 (owner: 10Esanders) [19:49:42] (03CR) 10Catrope: [C: 03+2] Enable thanks on Page creation log [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492387 (https://phabricator.wikimedia.org/T213660) (owner: 10Matěj Suchánek) [19:50:19] 10Growth-Team, 10Thanks, 10Patch-For-Review: Enable thanks on Page creation log - https://phabricator.wikimedia.org/T213660 (10Catrope) 05Open→03Resolved a:03Catrope [19:50:42] 10Collaboration-Team-Triage, 10Growth-Team, 10Thanks, 10Community-Tech, and 3 others: [Epic] Allow thanks of log entry - https://phabricator.wikimedia.org/T60485 (10Catrope) [19:50:46] 10Growth-Team, 10Thanks, 10Patch-For-Review: Enable thanks on Page creation log - https://phabricator.wikimedia.org/T213660 (10Catrope) a:05Catrope→03matej_suchanek [19:51:29] (03CR) 10Catrope: [C: 03+2] Pass IContextSource to parent in NotificationPager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/490927 (owner: 10Umherirrender) [19:51:49] (03CR) 10Sbisson: [C: 03+2] FlowException: Don't HTML-escape in getPageTitle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495018 (owner: 10Catrope) [19:52:14] (03CR) 10Catrope: [C: 03+2] Update helppanel schema version to accept editor=homepage [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494932 (https://phabricator.wikimedia.org/T215986) (owner: 10Sbisson) [19:53:21] (03CR) 10Catrope: [C: 03+2] Homepage: update page title [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494862 (https://phabricator.wikimedia.org/T215982) (owner: 10Sbisson) [19:53:24] (03CR) 10Sbisson: [C: 03+2] Don't override message and stack trace for UnknownWorkflowIdException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) (owner: 10Catrope) [19:55:23] (03CR) 10Catrope: [C: 03+2] Impact: update tooltips [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494863 (https://phabricator.wikimedia.org/T216217) (owner: 10Sbisson) [20:04:34] 10Growth-Team, 10MediaWiki-extensions-GrowthExperiments: Help panel not displayed on a page after switching from editing (VE) to reading mode - https://phabricator.wikimedia.org/T217610 (10Etonkovidova) [20:07:05] (03Merged) 10jenkins-bot: eslint: Update eslint-config-wikimedia 0.11.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/494046 (owner: 10Esanders) [20:07:11] (03Merged) 10jenkins-bot: Enable thanks on Page creation log [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492387 (https://phabricator.wikimedia.org/T213660) (owner: 10Matěj Suchánek) [20:07:21] (03Merged) 10jenkins-bot: Pass IContextSource to parent in NotificationPager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/490927 (owner: 10Umherirrender) [20:10:06] (03Merged) 10jenkins-bot: FlowException: Don't HTML-escape in getPageTitle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495018 (owner: 10Catrope) [20:10:08] (03Merged) 10jenkins-bot: Update helppanel schema version to accept editor=homepage [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494932 (https://phabricator.wikimedia.org/T215986) (owner: 10Sbisson) [20:16:29] (03Merged) 10jenkins-bot: Homepage: update page title [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494862 (https://phabricator.wikimedia.org/T215982) (owner: 10Sbisson) [20:16:33] (03CR) 10jerkins-bot: [V: 04-1] Impact: update tooltips [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494863 (https://phabricator.wikimedia.org/T216217) (owner: 10Sbisson) [20:19:15] (03PS2) 10Sbisson: Impact: update tooltips [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494863 (https://phabricator.wikimedia.org/T216217) [20:20:36] (03CR) 10jenkins-bot: Homepage: update page title [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494862 (https://phabricator.wikimedia.org/T215982) (owner: 10Sbisson) [20:20:41] (03CR) 10jerkins-bot: [V: 04-1] Don't override message and stack trace for UnknownWorkflowIdException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) (owner: 10Catrope) [20:25:04] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) (owner: 10Catrope) [20:35:16] (03CR) 10Catrope: [C: 03+2] Impact: update tooltips [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494863 (https://phabricator.wikimedia.org/T216217) (owner: 10Sbisson) [20:40:33] (03CR) 10Sbisson: [C: 03+2] Don't override message and stack trace for UnknownWorkflowIdException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) (owner: 10Catrope) [20:46:47] (03Merged) 10jenkins-bot: Impact: update tooltips [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494863 (https://phabricator.wikimedia.org/T216217) (owner: 10Sbisson) [20:49:59] (03CR) 10jenkins-bot: Impact: update tooltips [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/494863 (https://phabricator.wikimedia.org/T216217) (owner: 10Sbisson) [20:52:52] (03CR) 10jerkins-bot: [V: 04-1] Don't override message and stack trace for UnknownWorkflowIdException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) (owner: 10Catrope) [21:05:24] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) (owner: 10Catrope) [21:05:35] (03CR) 10Catrope: [C: 03+2] Don't override message and stack trace for UnknownWorkflowIdException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) (owner: 10Catrope) [21:32:52] (03Merged) 10jenkins-bot: Don't override message and stack trace for UnknownWorkflowIdException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) (owner: 10Catrope) [21:36:24] 10Growth-Team, 10StructuredDiscussions, 10Patch-For-Review: Upgrade from 1.31.1 to 1.32.0 breaks existing StructuredDiscussions pages: error message: **flow-error-unknown-workflow-id** - https://phabricator.wikimedia.org/T217330 (10Catrope) 05Open→03Resolved a:03Catrope [21:37:40] (03PS1) 10Sbisson: Fix reading mode detection [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) [21:38:47] (03CR) 10jenkins-bot: Don't override message and stack trace for UnknownWorkflowIdException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495019 (https://phabricator.wikimedia.org/T217330) (owner: 10Catrope) [21:55:31] (03PS1) 10Catrope: Conversion\Utils: Work around DOMDocument serialization bug [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495139 (https://phabricator.wikimedia.org/T217766) [22:00:47] (03CR) 10jerkins-bot: [V: 04-1] Conversion\Utils: Work around DOMDocument serialization bug [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495139 (https://phabricator.wikimedia.org/T217766) (owner: 10Catrope) [22:00:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/495094 (owner: 10L10n-bot) [22:07:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495097 (owner: 10L10n-bot) [22:15:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495098 (owner: 10L10n-bot) [22:56:35] (03CR) 10Catrope: [C: 03+1] "Looks good to me, but I think you said you wanted to test this more, so I won't merge until you say it's ready." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/495076 (https://phabricator.wikimedia.org/T217802) (owner: 10Sbisson) [23:59:43] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: Homepage: impact module - https://phabricator.wikimedia.org/T216217 (10Etonkovidova)