[00:22:13] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10User-DannyS712: NewPagesFeed filter request: accepted AfC drafts - https://phabricator.wikimedia.org/T217221 (10Niharika) Thanks @JTanner! Feel free to leave these project tickets on #mediawiki-extensions-pagecuration board and I'll pull them in to the #c... [00:48:23] 10Edit-Review-Improvements-Integrated-Filters, 10editquality-modeling, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Enable ORES filters on RC for Italian Wikipedia - https://phabricator.wikimedia.org/T211032 (10Catrope) 05Open→03Resolved [00:48:39] 10Edit-Review-Improvements-Integrated-Filters, 10editquality-modeling, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Enable ORES filters on RC for Italian Wikipedia - https://phabricator.wikimedia.org/T211032 (10Catrope) 05Resolved→03Open [01:41:08] (03PS3) 10Kosta Harlan: Fix off-by-one edit count for ThankYouEdit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494257 (https://phabricator.wikimedia.org/T209541) (owner: 10Sbisson) [01:41:32] (03CR) 10Kosta Harlan: [C: 03+2] Fix off-by-one edit count for ThankYouEdit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494257 (https://phabricator.wikimedia.org/T209541) (owner: 10Sbisson) [01:56:10] 10MediaWiki-extensions-PageCuration, 10Growth-Team: "Curate this article" should disappear as soon as you click on it - https://phabricator.wikimedia.org/T158513 (10kostajh) [01:58:48] (03Merged) 10jenkins-bot: Fix off-by-one edit count for ThankYouEdit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494257 (https://phabricator.wikimedia.org/T209541) (owner: 10Sbisson) [02:04:10] (03CR) 10jenkins-bot: Fix off-by-one edit count for ThankYouEdit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494257 (https://phabricator.wikimedia.org/T209541) (owner: 10Sbisson) [03:09:15] 10MediaWiki-extensions-PageCuration, 10Growth-Team: "Open Page Curation" should become "Close Page Curation" as soon as you click on it - https://phabricator.wikimedia.org/T158513 (10GeoffreyT2000) [06:10:23] 10Notifications, 10DBA, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Marostegui) Thank you! :) [06:10:42] 10Notifications, 10DBA, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Marostegui) p:05Triage→03Normal [06:20:24] 10Notifications, 10Growth-Team: Feature to receive notifications when a particular thing of interest happens - https://phabricator.wikimedia.org/T217623 (10Ammarpad) [10:27:19] (03CR) 10Zfilipin: "I guess we've misunderstood each other. This is a pretty small commit. I'm not sure how you could make it smaller. :)" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493642 (owner: 10Ephemeralwaves) [10:29:11] (03CR) 10Zfilipin: "This is also a good commit, no need to abandon it." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493643 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [10:34:16] (03CR) 10Zfilipin: "This is also a commit of appropriate size." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493644 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [11:34:33] (03CR) 10Zfilipin: "This commit is too big. I would recommend abandoning it and creating a smaller commit. If you prefer, you can amend this commit so it's sm" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/486411 (https://phabricator.wikimedia.org/T204068) (owner: 10Ephemeralwaves) [11:34:41] (03CR) 10Zfilipin: "This commit is too big. I would recommend abandoning it and creating a smaller commit. If you prefer, you can amend this commit so it's sm" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/492230 (https://phabricator.wikimedia.org/T204068) (owner: 10Ephemeralwaves) [13:14:53] (03CR) 10Zfilipin: [C: 03+2] "Congratulations on the first merged commit! 🎉" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [13:21:09] (03CR) 10Krinkle: [C: 04-1] Code improvements for includes/ **only** directory (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 (owner: 10D3r1ck01) [13:21:25] (03CR) 10Krinkle: [C: 04-1] Code improvements for includes/ **only** directory (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 (owner: 10D3r1ck01) [13:28:05] (03Merged) 10jenkins-bot: Test that checks for alerts' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [13:31:50] (03CR) 10jenkins-bot: Test that checks for alerts' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [15:04:31] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review: NewPagesFeed not working when sorted oldest first - https://phabricator.wikimedia.org/T216674 (10kostajh) > AFAICT it is not trying to fix the problem but only prevent it from breaking the page and add some logs. > Shoul... [15:09:09] (03CR) 10FR30799386: "@Kosta_Harlan are there any other problems ?" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/492474 (https://phabricator.wikimedia.org/T207847) (owner: 10FR30799386) [15:40:28] (03PS4) 10Kosta Harlan: Unbreak potential issues flyout [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/492474 (https://phabricator.wikimedia.org/T207847) (owner: 10FR30799386) [15:46:06] 10MediaWiki-Recent-changes, 10Growth-Team, 10Lexicographical data, 10Wikidata, and 2 others: Special:RecentChanges shows lemmas in title links to lexemes failed - https://phabricator.wikimedia.org/T215752 (10alaa_wmde) 05Open→03Invalid Appears to be the same flaky test situation as in T199446 [15:50:07] (03CR) 10jerkins-bot: [V: 04-1] Unbreak potential issues flyout [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/492474 (https://phabricator.wikimedia.org/T207847) (owner: 10FR30799386) [16:05:54] (03CR) 10Kosta Harlan: [C: 04-1] "I think this is the last change, then we could merge. Thanks for all your work on this!" (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/492474 (https://phabricator.wikimedia.org/T207847) (owner: 10FR30799386) [18:00:33] (03CR) 10D3r1ck01: "These cases makes sense and generally for these 2 cases you've spotted (maybe more in the code base), leaving them untouched makes it easi" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 (owner: 10D3r1ck01) [18:00:52] (03PS2) 10D3r1ck01: Code improvements for includes/ **only** directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 [19:16:20] (03PS1) 10Ephemeralwaves: Test that checks for notices' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494533 [19:27:08] (03PS1) 10Ephemeralwaves: Test that checks for welcome notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494535 (https://phabricator.wikimedia.org/T217051) [19:27:15] (03CR) 10jerkins-bot: [V: 04-1] Test that checks for notices' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494533 (owner: 10Ephemeralwaves) [19:29:28] (03PS2) 10Ephemeralwaves: Test that checks for notices' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494533 [19:31:02] (03CR) 10Sbisson: [C: 03+2] "I can't say that I'm 100% confident about all the comments, especially when it comes to which index is used in which situations, but this " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 (owner: 10Catrope) [19:33:30] 10Notifications, 10Outreachy, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), and 2 others: Echo automation smoke test - https://phabricator.wikimedia.org/T217051 (10JTannerWMF) [19:39:16] 10Notifications, 10Growth-Team, 10MediaWiki-extensions-UserMerge, 10Release-Engineering-Team, and 2 others: Various tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10JTannerWMF) 05Open→03Resolved a:03JTannerWMF [19:40:20] 10Notifications, 10Growth-Team, 10MediaWiki-extensions-UserMerge, 10Release-Engineering-Team, 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12): Various tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Daimona) The patch for changing Database::select was still pending, bu... [19:43:05] 10MediaWiki-extensions-PageCuration, 10Growth-Team: "Open Page Curation" should become "Close Page Curation" as soon as you click on it - https://phabricator.wikimedia.org/T158513 (10JTannerWMF) Hey tagging #community-tech for awareness. [19:48:30] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team (Current Sprint), 10Patch-For-Review: Remove unused bundling DB fields - https://phabricator.wikimedia.org/T143763 (10JTannerWMF) [19:50:51] (03Merged) 10jenkins-bot: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 (owner: 10Catrope) [19:51:07] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team (Current Sprint), 10Patch-For-Review: Remove event_page_namespace and event_page_title - https://phabricator.wikimedia.org/T136427 (10JTannerWMF) [19:54:52] 10Notifications, 10Growth-Team (Current Sprint): Notifications won't go away - https://phabricator.wikimedia.org/T217522 (10JTannerWMF) [19:57:48] 10Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10Growth-Team, 10StructuredDiscussions, and 2 others: Allow people to add customized buttons to OOUI/VE toolbar in an easy way - https://phabricator.wikimedia.org/T136152 (10JTannerWMF) @iamjessklein tagging you for awareness [20:00:42] (03CR) 10jenkins-bot: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 (owner: 10Catrope) [20:35:57] 10MediaWiki-extensions-PageCuration, 10Growth-Team: "Open Page Curation" should become "Close Page Curation" as soon as you click on it - https://phabricator.wikimedia.org/T158513 (10Aklapper) >>! In T158513#5002779, @JTannerWMF wrote: > Hey tagging #community-tech for awareness. Mentioning a project tag in... [20:44:35] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team: "Open Page Curation" should become "Close Page Curation" as soon as you click on it - https://phabricator.wikimedia.org/T158513 (10kostajh) [20:59:10] (03CR) 10Bartosz Dziewoński: [C: 03+2] Apply unseen notifications colours to all skins by default [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491757 (owner: 10Isarra) [21:18:09] (03Merged) 10jenkins-bot: Apply unseen notifications colours to all skins by default [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491757 (owner: 10Isarra) [21:22:49] (03CR) 10jenkins-bot: Apply unseen notifications colours to all skins by default [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491757 (owner: 10Isarra) [21:24:32] 10Edit-Review-Improvements-Integrated-Filters, 10editquality-modeling, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Enable ORES filters on RC for Italian Wikipedia - https://phabricator.wikimedia.org/T211032 (10Etonkovidova) 05Open→03Resolved [21:36:48] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Timeless, and 2 others: Notification numbers always grey in other skins - red/blue highlighting for new items only works in vector/monobook - https://phabricator.wikimedia.org/T181142 (10matmarex) 05Open→03Resolved a:03Isarra [21:46:56] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: NewPagesFeed not working when sorted oldest first - https://phabricator.wikimedia.org/T216674 (10kostajh) Moving to QA per the above. [21:49:25] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Patch-Needs-Improvement: 'Potential Issues' flagged in Page Curation Toolbar Page Info flyout - https://phabricator.wikimedia.org/T207847 (10kostajh) a:03Force_Radical [21:53:59] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team: "Open Page Curation" should become "Close Page Curation" as soon as you click on it - https://phabricator.wikimedia.org/T158513 (10aezell) I appreciate the awareness building. However, we are not the owners of the Curation Feed or NPP and... [22:03:11] 10MediaWiki-extensions-PageCuration, 10Growth-Team: "Open Page Curation" should become "Close Page Curation" as soon as you click on it - https://phabricator.wikimedia.org/T158513 (10Niharika) Copying over what I wrote in {T217221}: Thanks @JTannerWMF! Feel free to leave these project tickets on #mediawiki-ex... [22:03:45] (03PS1) 10Sbisson: DO NOT MERGE test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494608 [22:05:30] (03Abandoned) 10Sbisson: DO NOT MERGE test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494608 (owner: 10Sbisson) [22:09:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494576 (owner: 10L10n-bot) [22:19:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/494580 (owner: 10L10n-bot) [23:18:20] (03CR) 10Krinkle: Code improvements for includes/ **only** directory (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 (owner: 10D3r1ck01) [23:18:26] (03CR) 10Krinkle: [C: 03+2] Code improvements for includes/ **only** directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 (owner: 10D3r1ck01) [23:31:50] (03Merged) 10jenkins-bot: Code improvements for includes/ **only** directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 (owner: 10D3r1ck01) [23:35:54] (03CR) 10jenkins-bot: Code improvements for includes/ **only** directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 (owner: 10D3r1ck01)