[07:38:22] (03CR) 10Legoktm: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [07:43:34] (03CR) 10Legoktm: [C: 03+2] Fix UserMerge integration for use with table prefix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [07:55:08] (03Merged) 10jenkins-bot: Fix UserMerge integration for use with table prefix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [07:58:58] (03CR) 10jenkins-bot: Fix UserMerge integration for use with table prefix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [08:45:56] (03CR) 10D3r1ck01: [C: 03+2] "Most of these changes touches interface code and by nature of an interface, all methods declared inside it must be public :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472705 (owner: 10Umherirrender) [08:56:51] (03Merged) 10jenkins-bot: Add method scope visibility [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472705 (owner: 10Umherirrender) [09:01:13] (03CR) 10jenkins-bot: Add method scope visibility [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472705 (owner: 10Umherirrender) [09:54:33] 10Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10Growth-Team, 10StructuredDiscussions, and 2 others: Allow people to add customized buttons to OOUI/VE toolbar in an easy way - https://phabricator.wikimedia.org/T136152 (10Trizek-WMF) [09:55:47] 10Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10Growth-Team, 10StructuredDiscussions, and 2 others: Allow people to add customized buttons to OOUI/VE toolbar in an easy way - https://phabricator.wikimedia.org/T136152 (10Trizek-WMF) [11:09:26] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Wikimedia-Hackathon-2019: Have a way to mark specific edits as seen directly from RC or watchlist - https://phabricator.wikimedia.org/T196629 (10Trizek-WMF) [13:09:35] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Stewards-and-global-tools (Temporary-UserRights): Notify users when their user group membership is about to expire, or has expired - https://phabricator.wikimedia.org/T153817 (10matej_suchanek) [13:11:16] 10Notifications, 10Growth-Team: Notifications won't go away - https://phabricator.wikimedia.org/T217522 (10Aklapper) Which exact website (full web address) is this about? Which exact steps have you tried to perform to "make them go away"? Can you please go to that website but use `debug=true` in the address,... [14:38:18] (03CR) 10Sbisson: [C: 03+2] Check required metadata properties in list API and compilation job [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/493505 (https://phabricator.wikimedia.org/T216674) (owner: 10Kosta Harlan) [14:41:46] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review: NewPagesFeed not working when sorted oldest first - https://phabricator.wikimedia.org/T216674 (10SBisson) I've +2 the patch above. AFAICT it is not trying to fix the problem but only prevent it from breaking the page and... [14:44:29] (03CR) 10Sbisson: [C: 03+2] Convert caching to WANObjectCache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493514 (owner: 10Aaron Schulz) [15:06:34] (03Merged) 10jenkins-bot: Check required metadata properties in list API and compilation job [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/493505 (https://phabricator.wikimedia.org/T216674) (owner: 10Kosta Harlan) [15:06:36] (03Merged) 10jenkins-bot: Convert caching to WANObjectCache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493514 (owner: 10Aaron Schulz) [15:11:38] (03CR) 10jenkins-bot: Check required metadata properties in list API and compilation job [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/493505 (https://phabricator.wikimedia.org/T216674) (owner: 10Kosta Harlan) [15:16:53] (03CR) 10jenkins-bot: Convert caching to WANObjectCache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493514 (owner: 10Aaron Schulz) [15:22:25] (03CR) 10Sbisson: "So this patch has been sitting there for a while. What do we expect it's going to do?" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461192 (owner: 10Catrope) [15:23:31] (03Abandoned) 10Sbisson: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [15:55:21] (03PS1) 10Sbisson: Fix off-by-one edit count for ThankYouEdit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494257 (https://phabricator.wikimedia.org/T209541) [15:55:58] 10Notifications, 10Growth-Team (Current Sprint), 10Patch-For-Review: Milestone notifications are incorrect - https://phabricator.wikimedia.org/T209541 (10SBisson) [15:56:13] 10Notifications, 10Growth-Team (Current Sprint), 10Patch-For-Review: Milestone notifications are incorrect - https://phabricator.wikimedia.org/T209541 (10SBisson) a:03SBisson [16:32:19] (03CR) 10Zfilipin: Test that checks for alerts' flyout (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [16:40:59] (03PS3) 10Zfilipin: Test that checks for alerts' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [16:46:33] (03PS4) 10Zfilipin: Test that checks for alerts' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [16:47:32] (03CR) 10Zfilipin: Test that checks for alerts' flyout (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [16:49:03] (03CR) 10Zfilipin: Test that checks for alerts' flyout (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [16:49:44] (03CR) 10Zfilipin: "PS3 and PS4 implement the changes reviewer requested." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [17:51:12] (03CR) 10Zfilipin: Test that checks for alerts' flyout (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [18:00:40] (03PS5) 10Ephemeralwaves: Test that checks for alerts' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) [18:03:33] (03PS4) 10Kosta Harlan: ArticleCompileProcessor: Actually pass LinksUpdate objects to compilers [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461192 (owner: 10Catrope) [18:07:01] (03CR) 10Kosta Harlan: "> Patch Set 3:" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461192 (owner: 10Catrope) [18:13:21] (03PS5) 10Kosta Harlan: ArticleCompileProcessor: Actually pass LinksUpdate objects to compilers [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461192 (owner: 10Catrope) [18:23:54] (03CR) 10jerkins-bot: [V: 04-1] Test that checks for alerts' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [18:26:49] (03PS6) 10Ephemeralwaves: Test that checks for alerts' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) [18:30:13] 10Notifications, 10DBA, 10Growth-Team (Current Sprint), 10WorkType-Maintenance: Clean up orphaned echo_event rows again - https://phabricator.wikimedia.org/T217073 (10Catrope) >>! In T217073#4992540, @jcrespo wrote: > Please tell us from which set of servers, which tables you deleted rows from, as we agree... [18:33:52] 10Notifications, 10DBA, 10Growth-Team (Current Sprint), 10WorkType-Maintenance: Clean up orphaned echo_event rows again - https://phabricator.wikimedia.org/T217073 (10Marostegui) 05Open→03Resolved Thanks! I will create a ticket to get them defragmented [18:35:30] 10Notifications, 10DBA, 10Growth-Team (Current Sprint), 10WorkType-Maintenance: Clean up orphaned echo_event rows again - https://phabricator.wikimedia.org/T217073 (10Marostegui) [18:49:53] 10Notifications, 10DBA, 10Growth-Team (Current Sprint), 10WorkType-Maintenance: Clean up orphaned echo_event rows again - https://phabricator.wikimedia.org/T217073 (10jcrespo) Thanks to both! [19:10:29] 10Notifications, 10DBA, 10Growth-Team (Current Sprint), 10WorkType-Maintenance: Clean up orphaned echo_event rows again - https://phabricator.wikimedia.org/T217073 (10jcrespo) @Catrope One last think, not sure if you are in charge of that, and obviously not a huge priority, but maybe there should be some c... [19:24:14] (03CR) 10Kosta Harlan: Fix off-by-one edit count for ThankYouEdit notification (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494257 (https://phabricator.wikimedia.org/T209541) (owner: 10Sbisson) [19:29:06] (03CR) 10Ephemeralwaves: "> Patch Set 5: Verified-1" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493640 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [20:03:13] (03Abandoned) 10Ephemeralwaves: Test that checks for notices' flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493642 (owner: 10Ephemeralwaves) [20:03:22] (03Abandoned) 10Ephemeralwaves: Test that checks for welcome notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493643 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [20:03:27] (03Abandoned) 10Ephemeralwaves: Test that checks for Notifications Page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493644 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [20:28:26] (03PS1) 10Reedy: Fix UserMerge integration for use with table prefix [extensions/Echo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/494304 (https://phabricator.wikimedia.org/T217487) [20:29:17] (03CR) 10Reedy: [C: 03+2] Fix UserMerge integration for use with table prefix [extensions/Echo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/494304 (https://phabricator.wikimedia.org/T217487) (owner: 10Reedy) [20:42:14] 10Notifications, 10DBA, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Catrope) [20:42:45] (03Merged) 10jenkins-bot: Fix UserMerge integration for use with table prefix [extensions/Echo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/494304 (https://phabricator.wikimedia.org/T217487) (owner: 10Reedy) [20:42:49] 10Notifications, 10DBA, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Catrope) Updated the task description to match the template. Sorry for forgetting, and thanks for the reminder, it's been a few years since I've request... [20:45:13] 10Notifications, 10Growth-Team, 10MediaWiki-extensions-UserMerge, 10Release-Engineering-Team, 10Patch-For-Review: Various tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Reedy) [20:46:10] 10Notifications, 10DBA, 10Growth-Team (Current Sprint), 10WorkType-Maintenance: Clean up orphaned echo_event rows again - https://phabricator.wikimedia.org/T217073 (10Catrope) It's funny that you should mention Wikidata, because that wiki actually had a very very high cleanup rate (something like 274M/276M... [20:47:30] 10Notifications, 10DBA, 10Growth-Team (Current Sprint), 10WorkType-Maintenance: Clean up orphaned echo_event rows again - https://phabricator.wikimedia.org/T217073 (10Catrope) Also if you want to talk more about this, feel free to ping me on IRC any time. It's a somewhat complicated topic and we probably b... [20:50:48] (03CR) 10jenkins-bot: Fix UserMerge integration for use with table prefix [extensions/Echo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/494304 (https://phabricator.wikimedia.org/T217487) (owner: 10Reedy) [20:55:55] (03PS10) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [20:59:45] (03PS4) 10Catrope: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 [20:59:47] (03PS11) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [21:00:03] (03CR) 10jerkins-bot: [V: 04-1] Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [21:01:21] (03CR) 10Catrope: [C: 03+2] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 (owner: 10Umherirrender) [21:03:18] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Patch-For-Review, 10Schema-change: Add index on event_page_id - https://phabricator.wikimedia.org/T143961 (10Catrope) [21:04:52] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Patch-For-Review: Remove event_page_namespace and event_page_title - https://phabricator.wikimedia.org/T136427 (10Catrope) [21:05:02] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Patch-For-Review: Remove event_page_namespace and event_page_title - https://phabricator.wikimedia.org/T136427 (10Catrope) [21:06:37] (03CR) 10Sbisson: [C: 03+2] Remove use of deprecated addModuleScripts() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/494058 (https://phabricator.wikimedia.org/T188689) (owner: 10Krinkle) [21:09:50] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team: The Great Echo Database Cleanup of 2016 (and 2019) - https://phabricator.wikimedia.org/T143963 (10Catrope) [21:10:27] (03PS2) 10Sbisson: Fix off-by-one edit count for ThankYouEdit notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494257 (https://phabricator.wikimedia.org/T209541) [21:10:29] (03CR) 10Sbisson: Fix off-by-one edit count for ThankYouEdit notification (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494257 (https://phabricator.wikimedia.org/T209541) (owner: 10Sbisson) [21:12:29] (03Merged) 10jenkins-bot: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 (owner: 10Umherirrender) [21:13:37] (03PS5) 10Catrope: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 [21:13:39] (03PS12) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [21:14:51] (03PS9) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [21:16:46] (03PS8) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [21:17:37] (03CR) 10jenkins-bot: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 (owner: 10Umherirrender) [21:18:58] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [21:19:38] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [21:20:52] (03Merged) 10jenkins-bot: Remove use of deprecated addModuleScripts() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/494058 (https://phabricator.wikimedia.org/T188689) (owner: 10Krinkle) [21:20:57] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [21:22:22] (03PS10) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [21:23:39] (03PS9) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [21:45:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/494322 (owner: 10L10n-bot) [22:03:25] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review: NewPagesFeed not working when sorted oldest first - https://phabricator.wikimedia.org/T216674 (10MMiller_WMF) @SBisson -- in case that's a question for me, I just want to say that I think that's a better question for @ko... [22:22:27] (03CR) 10jenkins-bot: Remove use of deprecated addModuleScripts() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/494058 (https://phabricator.wikimedia.org/T188689) (owner: 10Krinkle) [22:42:31] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Patch-For-Review: Remove event_page_namespace and event_page_title - https://phabricator.wikimedia.org/T136427 (10Catrope) [22:43:16] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Patch-For-Review: Remove unused bundling DB fields - https://phabricator.wikimedia.org/T143763 (10Catrope) [23:11:23] (03CR) 10Catrope: [C: 04-1] "This change also causes thanks to be published to Special:Recentchanges, which is not what we want" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/493740 (https://phabricator.wikimedia.org/T215477) (owner: 10Pmiazga) [23:15:13] (03CR) 10Catrope: [C: 04-1] "The DB schema seems to indicate that you should be able to associate a change tag with a log ID without needing an RC ID, and I've found r" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/493740 (https://phabricator.wikimedia.org/T215477) (owner: 10Pmiazga)