[00:27:03] 10MediaWiki-Recent-changes, 10Growth-Team: RCFilters Guided Tour still visible on certain languages - https://phabricator.wikimedia.org/T217451 (10Volker_E) [00:45:15] 10Notifications, 10Growth-Team: Echo should use event_page_id for delete/undelete moderation, instead of or in addition to echo_target_page - https://phabricator.wikimedia.org/T217452 (10Catrope) [00:45:27] 10Notifications, 10Growth-Team, 10Technical-Debt: Echo should use event_page_id for delete/undelete moderation, instead of or in addition to echo_target_page - https://phabricator.wikimedia.org/T217452 (10Catrope) [00:51:38] (03PS1) 10Catrope: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 [00:54:45] (03PS2) 10Catrope: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 [00:56:51] 10Collaboration-Team-Triage, 10Notifications, 10Patch-For-Review: Add index on event_page_id - https://phabricator.wikimedia.org/T143961 (10Catrope) [00:56:54] 10Notifications, 10Growth-Team, 10Technical-Debt: Echo should use event_page_id for delete/undelete moderation, instead of or in addition to echo_target_page - https://phabricator.wikimedia.org/T217452 (10Catrope) [00:57:05] 10Notifications, 10Growth-Team, 10Technical-Debt: Echo should use event_page_id for delete/undelete moderation, instead of or in addition to echo_target_page - https://phabricator.wikimedia.org/T217452 (10Catrope) This depends on having an index on `event_page_id`: {T143961} [00:58:01] 10Collaboration-Team-Triage, 10Notifications, 10Patch-For-Review: Add index on event_page_id - https://phabricator.wikimedia.org/T143961 (10Catrope) [00:58:03] 10Notifications, 10Growth-Team, 10Technical-Debt: Echo should use event_page_id for delete/undelete moderation, instead of or in addition to echo_target_page - https://phabricator.wikimedia.org/T217452 (10Catrope) [00:58:11] 10Notifications, 10Growth-Team, 10Technical-Debt: Echo should use event_page_id for delete/undelete moderation, instead of or in addition to echo_target_page - https://phabricator.wikimedia.org/T217452 (10Catrope) [00:58:14] 10Collaboration-Team-Triage, 10Notifications, 10Patch-For-Review: Add index on event_page_id - https://phabricator.wikimedia.org/T143961 (10Catrope) [00:59:53] 10Notifications, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Catrope) [01:00:07] 10Collaboration-Team-Triage, 10Notifications: The Great Echo Database Cleanup of 2016 - https://phabricator.wikimedia.org/T143963 (10Catrope) [01:00:11] 10Notifications, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Catrope) [01:00:18] 10Notifications, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Catrope) [01:00:21] 10Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10Patch-For-Review: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959 (10Catrope) [01:00:29] 10Collaboration-Team-Triage, 10Notifications: The Great Echo Database Cleanup of 2016 - https://phabricator.wikimedia.org/T143963 (10Catrope) [01:00:32] 10Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10Patch-For-Review: Remove etp_user from echo_target_page - https://phabricator.wikimedia.org/T143959 (10Catrope) [01:00:54] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team: The Great Echo Database Cleanup of 2016 - https://phabricator.wikimedia.org/T143963 (10Catrope) [01:01:22] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team: The Great Echo Database Cleanup of 2016 - https://phabricator.wikimedia.org/T143963 (10Catrope) [01:02:37] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Patch-For-Review, 10Schema-change: Add index on event_page_id - https://phabricator.wikimedia.org/T143961 (10Catrope) [01:04:49] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Patch-For-Review: Remove event_page_namespace and event_page_title - https://phabricator.wikimedia.org/T136427 (10Catrope) Untagging for now because the patch is not yet merged. [01:05:35] (03PS1) 10Catrope: NotificationDeleteJob: Remove unused variable $targetMapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493773 [01:17:04] (03PS8) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [01:20:07] (03CR) 10jerkins-bot: [V: 04-1] Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [01:29:07] (03PS7) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [01:29:09] (03PS6) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [01:29:40] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:29:52] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:31:47] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:32:11] (03PS3) 10Catrope: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 [01:32:13] (03PS9) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [01:32:16] (03PS8) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [01:32:19] (03PS7) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [01:34:38] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:36:09] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:36:19] (03CR) 10jerkins-bot: [V: 04-1] Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [02:07:04] 10Notifications, 10DBA, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Zoranzoki21) [03:12:31] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Patch-Needs-Improvement: 'Potential Issues' flagged in Page Curation Toolbar Page Info flyout - https://phabricator.wikimedia.org/T207847 (10Force_Radical) I have made the changes to the patch. [03:23:03] (03CR) 10Aaron Schulz: [C: 03+2] NotificationDeleteJob: Remove unused variable $targetMapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493773 (owner: 10Catrope) [03:43:52] (03Merged) 10jenkins-bot: NotificationDeleteJob: Remove unused variable $targetMapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493773 (owner: 10Catrope) [03:48:42] (03CR) 10jenkins-bot: NotificationDeleteJob: Remove unused variable $targetMapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493773 (owner: 10Catrope) [06:01:55] 10Notifications, 10DBA, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Marostegui) @Catrope this is ready to go anytime? [08:37:13] (03PS1) 10D3r1ck01: Code improvements for includes/ **only** directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 [09:21:26] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 (owner: 10D3r1ck01) [16:47:08] (03CR) 10Krinkle: [C: 03+1] Convert caching to WANObjectCache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493514 (owner: 10Aaron Schulz) [16:47:22] 10Notifications, 10DBA, 10Growth-Team, 10Schema-change: Remove etp_user from echo_target_page in production - https://phabricator.wikimedia.org/T217453 (10Marostegui) If this schema change is ready to go, it would be great if we could get the task following the template described at https://wikitech.wikime... [17:17:41] 10MediaWiki-Recent-changes, 10Growth-Team, 10Patch-For-Review: RecentChanges should update entries when user move a page - https://phabricator.wikimedia.org/T215696 (10Aklapper) a:05Setian→03None [17:29:30] (03PS3) 10Reedy: Pass string as field to IDatabase::selectField and ::selectRowCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493758 (owner: 10Umherirrender) [17:29:35] (03CR) 10Reedy: [C: 03+2] Pass string as field to IDatabase::selectField and ::selectRowCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493758 (owner: 10Umherirrender) [17:50:09] (03Merged) 10jenkins-bot: Pass string as field to IDatabase::selectField and ::selectRowCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493758 (owner: 10Umherirrender) [18:01:28] (03CR) 10jenkins-bot: Pass string as field to IDatabase::selectField and ::selectRowCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493758 (owner: 10Umherirrender) [18:18:39] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493843 [18:48:01] 10Notifications, 10Growth-Team, 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Reedy) [19:12:50] (03PS1) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 [19:13:52] (03PS1) 10Reedy: Move PHP files to includes/ [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 [19:14:15] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493843 (owner: 10Umherirrender) [19:14:22] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 (owner: 10Reedy) [19:15:05] (03CR) 10jerkins-bot: [V: 04-1] Move PHP files to includes/ [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 (owner: 10Reedy) [19:16:57] (03PS2) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 [19:17:46] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493843 (owner: 10Umherirrender) [19:51:20] 10Notifications, 10Growth-Team, 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Release-Engineering-Team: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Reedy) p:05Triage→03High [20:19:58] (03PS3) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 [20:20:00] (03PS2) 10Reedy: Move PHP files to includes/ [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 [20:21:31] (03CR) 10jerkins-bot: [V: 04-1] Move PHP files to includes/ [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 (owner: 10Reedy) [20:24:14] 10Notifications, 10Growth-Team, 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Release-Engineering-Team: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Umherirrender) https://gerrit.wikimedia.org/r/#/c/integration/config/+/493808/4/zuul/pa... [20:24:53] (03PS3) 10Reedy: Move PHP files to includes/ [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 [20:25:38] (03PS1) 10Umherirrender: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) [20:29:29] (03CR) 10Reedy: [C: 03+1] "Patch is definitely useful, will revert the problematic CI patch in the meantime though" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:31:18] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:31:53] (03CR) 10Reedy: [C: 03+1] "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:33:20] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:34:25] (03PS2) 10Umherirrender: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) [20:34:30] 10Notifications, 10Growth-Team, 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, and 2 others: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Reedy) p:05High→03Normal [20:39:59] (03CR) 10Umherirrender: Use ExtensionRegistry rather than class_exists (032 comments) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 (owner: 10Reedy) [20:41:34] (03PS4) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 [20:42:43] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 (owner: 10Reedy) [20:43:26] (03PS5) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 [20:44:51] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:50:26] (03CR) 10Krinkle: [C: 03+2] Move PHP files to includes/ [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 (owner: 10Reedy) [20:55:13] (03CR) 10Krinkle: [C: 04-1] "Hm.. yeah, it looks like ExtensionProcessor uses the "name" name indeed, not the extension directory name." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 (owner: 10Reedy) [20:55:45] (03CR) 10Reedy: "Thought I added a space. Apparently not" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 (owner: 10Reedy) [20:55:53] (03PS6) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 [20:59:19] 10Notifications, 10Growth-Team, 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, and 2 others: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Daimona) Thanks for the prompt fix! I'm sorry for the inconvenience, although IMHO it's been useful to... [21:05:32] (03PS3) 10Umherirrender: Fix UserMerge integration for use with table prefix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) [21:06:27] 10Notifications, 10Growth-Team, 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, and 2 others: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Umherirrender) >>! In T217487#4995844, @Daimona wrote: > Thanks for the prompt fix! I'm sorry for the i... [21:14:33] (03PS1) 10Umherirrender: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 [21:17:06] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 (owner: 10Umherirrender) [21:17:22] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 (owner: 10Umherirrender) [21:31:56] (03CR) 10Umherirrender: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 (owner: 10Reedy) [21:40:04] (03PS2) 10Umherirrender: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 [21:40:44] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493861 (owner: 10Reedy) [21:44:04] (03PS4) 10Reedy: Move PHP files to includes/ [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 [21:45:18] (03CR) 10Reedy: "rebased" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 (owner: 10Reedy) [21:45:26] (03CR) 10Umherirrender: [C: 03+2] Move PHP files to includes/ [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 (owner: 10Reedy) [21:51:56] (03Merged) 10jenkins-bot: Move PHP files to includes/ [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/493863 (owner: 10Reedy) [21:57:29] (03CR) 10Reedy: "LGTM, but want to leave it for an Echo maintainer (CC'd Roan)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [21:57:32] (03CR) 10Reedy: [C: 03+1] Fix UserMerge integration for use with table prefix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [22:19:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493914 (owner: 10L10n-bot) [22:27:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493920 (owner: 10L10n-bot) [22:43:48] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 [22:45:12] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [22:49:26] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [22:51:18] (03PS2) 10Umherirrender: Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 [22:51:20] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [23:01:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/493937 (owner: 10L10n-bot) [23:31:07] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [23:52:10] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [23:58:04] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender)