[06:13:36] 10Thanks, 10Growth-Team, 10MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), 10Mobile, and 3 others: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737 (10WingedBladesofGodric) @Jdlrobson @Etonkovidova Why not go with a confirmation button; as executed via [[ http... [07:04:27] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087 (10RhinosF1) [08:18:40] 10MediaWiki-Recent-changes, 10Growth-Team, 10Lexicographical data, 10Wikidata, and 2 others: Special:RecentChanges shows lemmas in title links to lexemes failed - https://phabricator.wikimedia.org/T215752 (10Jdforrester-WMF) Also blocked https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaIn... [08:57:02] (03PS1) 10Thiemo Kreuz (WMDE): Simplify a few overly complex code snippets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491422 [10:37:46] (03PS1) 10Thiemo Kreuz (WMDE): Prefer the …::class feature over hard-coded strings in all tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491436 [10:39:51] (03PS1) 10Thiemo Kreuz (WMDE): Replace @expectedException with $this->expectException() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491437 [10:42:09] (03PS1) 10Thiemo Kreuz (WMDE): Add type hints and remove unused code from tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491438 [10:43:23] (03PS1) 10Thiemo Kreuz (WMDE): Make use of the …::class feature in production code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491439 [10:48:09] (03CR) 10jerkins-bot: [V: 04-1] Make use of the …::class feature in production code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491439 (owner: 10Thiemo Kreuz (WMDE)) [10:49:09] (03CR) 10jerkins-bot: [V: 04-1] Make use of the …::class feature in production code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491439 (owner: 10Thiemo Kreuz (WMDE)) [11:27:11] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Wikidata, 10Epic: Be able to filter Wikibase edits in Recent Changes on type of change - https://phabricator.wikimedia.org/T216265 (10Jdforrester-WMF) [11:34:21] 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Wikidata, 10Epic: Be able to filter Wikibase edits in Recent Changes on type of change - https://phabricator.wikimedia.org/T216265 (10Jdforrester-WMF) Edit summary is in a different table so that would be a bit expensive, but probably doable? Of course i... [14:19:30] (03CR) 10D3r1ck01: [C: 03+1] "This is also very good as it resolves to the fully qualified class name :) taking care of namespace issues etc :)" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491436 (owner: 10Thiemo Kreuz (WMDE)) [14:35:30] (03PS2) 10Thiemo Kreuz (WMDE): Prefer the …::class feature over hard-coded strings in all tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491436 [15:02:09] 10Thanks, 10Growth-Team, 10MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), 10Mobile, and 3 others: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737 (10Jdlrobson) T71804: Thanks tool: How much does the confirmation button cost us? Has a lot of background on why... [17:38:15] (03CR) 10D3r1ck01: [C: 03+2] Prefer the …::class feature over hard-coded strings in all tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491436 (owner: 10Thiemo Kreuz (WMDE)) [17:51:27] (03Merged) 10jenkins-bot: Prefer the …::class feature over hard-coded strings in all tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491436 (owner: 10Thiemo Kreuz (WMDE)) [17:56:06] (03CR) 10jenkins-bot: Prefer the …::class feature over hard-coded strings in all tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491436 (owner: 10Thiemo Kreuz (WMDE)) [18:29:57] (03PS1) 10FR30799386: ext.pageTriage.toolView.js: Fix that may resolve the "sticky blue" bug phab:T179220 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/491547 (https://phabricator.wikimedia.org/T179220) [18:30:00] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/491547 (https://phabricator.wikimedia.org/T179220) (owner: 10FR30799386) [18:42:28] (03CR) 10Kosta Harlan: [C: 03+1] "Looks good to me! But I haven't tested it." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/491547 (https://phabricator.wikimedia.org/T179220) (owner: 10FR30799386) [18:48:53] (03CR) 10Kosta Harlan: [C: 04-1] "FR30799386, here's how I'd suggest rewording the commit message:" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/491547 (https://phabricator.wikimedia.org/T179220) (owner: 10FR30799386) [20:09:29] (03PS2) 10Umherirrender: Pass IContextSource to parent in NotificationPager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/490927 [20:13:56] (03CR) 10Umherirrender: Pass IContextSource to parent in NotificationPager (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/490927 (owner: 10Umherirrender) [20:19:54] (03CR) 10Umherirrender: "check php" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/490927 (owner: 10Umherirrender) [20:34:27] (03CR) 10Umherirrender: Make use of the …::class feature in production code (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491439 (owner: 10Thiemo Kreuz (WMDE)) [20:36:35] (03CR) 10Umherirrender: Prefer the …::class feature over hard-coded strings in all tests (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491436 (owner: 10Thiemo Kreuz (WMDE)) [20:39:26] (03PS2) 10Umherirrender: Simplify a few overly complex code snippets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491422 (owner: 10Thiemo Kreuz (WMDE)) [20:39:30] (03CR) 10Umherirrender: [C: 03+2] Simplify a few overly complex code snippets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491422 (owner: 10Thiemo Kreuz (WMDE)) [20:52:32] (03PS2) 10Umherirrender: Replace @expectedException with $this->expectException() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491437 (owner: 10Thiemo Kreuz (WMDE)) [20:52:37] (03CR) 10Umherirrender: [C: 03+2] Replace @expectedException with $this->expectException() (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491437 (owner: 10Thiemo Kreuz (WMDE)) [20:53:23] (03CR) 10Umherirrender: "I have seen your other patch set (I96862a18874f36355e817accd64d8703c1965c86) which removes this code, so all is okay" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491436 (owner: 10Thiemo Kreuz (WMDE)) [20:54:16] (03PS3) 10Umherirrender: Replace @expectedException with $this->expectException() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491437 (owner: 10Thiemo Kreuz (WMDE)) [20:54:22] (03CR) 10Umherirrender: [C: 03+2] Replace @expectedException with $this->expectException() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491437 (owner: 10Thiemo Kreuz (WMDE)) [20:56:47] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team (Current Sprint), 10Patch-For-Review: Have a way to exclude Tags with 0 edits from selection - https://phabricator.wikimedia.org/T182219 (10Catrope) a:03Catrope This turned out to be really easy now that the tag cou... [21:38:01] (03Merged) 10jenkins-bot: Simplify a few overly complex code snippets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491422 (owner: 10Thiemo Kreuz (WMDE)) [21:39:29] (03Merged) 10jenkins-bot: Replace @expectedException with $this->expectException() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491437 (owner: 10Thiemo Kreuz (WMDE)) [21:43:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/491609 (owner: 10L10n-bot) [21:46:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491606 (owner: 10L10n-bot) [22:01:51] (03CR) 10Catrope: [C: 03+2] Store Parsoid version and base URL in Flow body content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486304 (https://phabricator.wikimedia.org/T209114) (owner: 10Kosta Harlan) [22:07:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/491626 (owner: 10L10n-bot) [22:10:48] (03CR) 10jenkins-bot: Replace @expectedException with $this->expectException() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491437 (owner: 10Thiemo Kreuz (WMDE)) [22:12:43] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), and 2 others: Have a way to exclude Tags with 0 edits from selection - https://phabricator.wikimedia.org/T182219 (10Catrope) [22:13:58] (03CR) 10jenkins-bot: Simplify a few overly complex code snippets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/491422 (owner: 10Thiemo Kreuz (WMDE)) [22:15:58] (03Merged) 10jenkins-bot: Store Parsoid version and base URL in Flow body content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486304 (https://phabricator.wikimedia.org/T209114) (owner: 10Kosta Harlan) [22:19:52] (03CR) 10jenkins-bot: Store Parsoid version and base URL in Flow body content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486304 (https://phabricator.wikimedia.org/T209114) (owner: 10Kosta Harlan)