[15:31:17] (03CR) 10Kosta Harlan: [C: 04-1] ArticleCompileProcessor: Actually pass LinksUpdate objects to compilers (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461192 (owner: 10Catrope) [15:33:37] (03PS1) 10Esanders: Make widget teardown async [extensions/Flow] - 10https://gerrit.wikimedia.org/r/489234 [17:47:46] 10MediaWiki-Recent-changes, 10Growth-Team, 10Shape Expressions Sprint 1, 10Wikidata: Implement translatable edit summaries / multilingual comments using comment_data - https://phabricator.wikimedia.org/T215637 (10Lucas_Werkmeister_WMDE) p:05Triage→03Normal [19:25:25] 10Collaboration-Team-Triage, 10QuickSurveys, 10Readers-Web-Backlog: Retool quicksurveys so we can do a survey on one page only - https://phabricator.wikimedia.org/T146495 (10Whatamidoing-WMF) >>! In T146495#4882541, @jmatazzoni wrote: > Which raises the question, what are the current capabilities re. target... [19:27:32] (03PS15) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) [19:34:32] 10Thanks, 10Advanced Mobile Contributions, 10Growth-Team, 10MobileFrontend, 10Readers-Web-Backlog: Tag Thanks actions with AMC tag - https://phabricator.wikimedia.org/T215477 (10Jdlrobson) a:03Jdlrobson [19:45:11] 10Notifications, 10Growth-Team: All the other SUL wikis are missing in my Echo notifications - https://phabricator.wikimedia.org/T215283 (10Whatamidoing-WMF) It was turned off. I have turned it on, and also set it on in my GlobalPreferences. Can you tell me what the sitewide default is for that setting at no... [20:12:49] (03CR) 10Kosta Harlan: "Some observations from testing this:" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [20:17:03] 10Thanks, 10Growth-Team, 10Readers-Web-Backlog, 10Mobile, 10Patch-For-Review: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737 (10Jdlrobson) > The wording "undo" seems off to me, since it implies that the action has already be done. However the wording... [20:17:11] 10Thanks, 10Growth-Team, 10Readers-Web-Backlog, 10Mobile, 10Patch-For-Review: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737 (10Jdlrobson) a:03alexhollender [20:17:53] (03CR) 10Jdlrobson: "> The wording "undo" seems off to me, since it implies that the action has already be done. However the wording is in the present tense ("" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [20:19:54] (03CR) 10Kosta Harlan: "> Patch Set 15:" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [20:31:30] (03PS1) 10Jdlrobson: popup is undefined [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/489310 [20:39:02] (03PS16) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) [20:39:18] (03CR) 10Jdlrobson: "The -1 issue is fixed - I used a tag to ensure messages get overriden rather than stacked." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [20:43:17] 10Collaboration-Team-Triage, 10QuickSurveys, 10Readers-Web-Backlog: Retool quicksurveys so we can do a survey on one page only - https://phabricator.wikimedia.org/T146495 (10Tgr) Ideally there should be a separate targeting extension that other extensions could be the clients of. It's not sane to continuous... [20:47:22] (03CR) 10Kosta Harlan: [C: 03+2] popup is undefined [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/489310 (owner: 10Jdlrobson) [20:59:34] (03CR) 10Kosta Harlan: [C: 03+1] "If Alex doesn't want to change "undo" to "cancel" then I can +2 it as is. I would like to see the full bar tappable to cancel/undo but tha" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [21:22:03] (03Merged) 10jenkins-bot: popup is undefined [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/489310 (owner: 10Jdlrobson) [21:52:31] (03PS17) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) [21:54:10] (03CR) 10Jdlrobson: "Alex said renaming this cancel makes sense, but we feel limiting the cancel action to the button is probably a more standard UX" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [21:54:43] 10Thanks, 10Growth-Team, 10Readers-Web-Backlog, 10Mobile, 10Patch-For-Review: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737 (10alexhollender) @Jdlrobson, I agree that "Cancel" makes more sense. I think the cancel action should only be triggered by ta... [22:22:50] (03PS2) 10Catrope: Make widget teardown async [extensions/Flow] - 10https://gerrit.wikimedia.org/r/489234 (owner: 10Esanders) [22:29:22] (03CR) 10Catrope: [C: 03+2] Make widget teardown async [extensions/Flow] - 10https://gerrit.wikimedia.org/r/489234 (owner: 10Esanders) [22:31:47] (03PS18) 10Kosta Harlan: Add client side click to cancel on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [22:34:33] (03CR) 10Kosta Harlan: [C: 03+1] "Looks good. If no one objects then I can +2 on Monday." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [22:46:15] (03CR) 10jerkins-bot: [V: 04-1] Make widget teardown async [extensions/Flow] - 10https://gerrit.wikimedia.org/r/489234 (owner: 10Esanders) [23:06:56] 10Thanks, 10Advanced Mobile Contributions, 10Growth-Team, 10MobileFrontend, 10Readers-Web-Backlog: Tag Thanks actions with AMC tag - https://phabricator.wikimedia.org/T215477 (10pmiazga) T215675 is a blocker, we need to decide on how to dynamically tag log entries before we can do this task. [23:21:21] (03CR) 10Esanders: [C: 03+2] "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/489234 (owner: 10Esanders) [23:21:23] (03CR) 10Catrope: "So, this generally doesn't break, and getting it to break is pretty convoluted and edge-case-reliant, but it still doesn't make me feel gr" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486304 (https://phabricator.wikimedia.org/T209114) (owner: 10Kosta Harlan) [23:25:56] 10Collaboration-Team-Triage, 10StructuredDiscussions: Cancel button should have a border? - https://phabricator.wikimedia.org/T100324 (10Volker_E) 05Open→03Invalid As mentioned above, the current separation between quiet and primary makes sense from an UX perspective. It's also learnt behaviour now. Let's... [23:29:25] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: [wmf.3 - minor] Structured discussion Reply to post button not displayed correctly - https://phabricator.wikimedia.org/T193589 (10Volker_E) @Trizek-WMF Do you refer to the Google Translate toolbar? [23:37:15] (03Merged) 10jenkins-bot: Make widget teardown async [extensions/Flow] - 10https://gerrit.wikimedia.org/r/489234 (owner: 10Esanders) [23:42:48] (03CR) 10jenkins-bot: Make widget teardown async [extensions/Flow] - 10https://gerrit.wikimedia.org/r/489234 (owner: 10Esanders)