[00:50:31] (03CR) 10Catrope: [C: 04-1] "> Patch Set 1:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481632 (https://phabricator.wikimedia.org/T211876) (owner: 10Matěj Suchánek) [01:58:17] 10Notifications, 10Growth-Team, 10StructuredDiscussions, 10VisualEditor, 10VisualEditor-MediaWiki: Now that you can ping people from an edit summary, Notifications should add StructuredDiscussion's "Mention" inspector into the VE/2017WTE publish dialog - https://phabricator.wikimedia.org/T209970 (10Nihari... [06:05:50] 10Notifications, 10Growth-Team, 10StructuredDiscussions, 10TechCom: Remove custom 'CatchableFatalErrorException' logic from Echo/Flow code bases - https://phabricator.wikimedia.org/T208146 (10Krinkle) Moving to the radar for now on the assumption this would likely be removed. If you find there's something... [07:30:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add missing use statments (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481930 (owner: 10Umherirrender) [07:43:51] (03Merged) 10jenkins-bot: Add missing use statments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481930 (owner: 10Umherirrender) [07:50:49] (03CR) 10jenkins-bot: Add missing use statments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481930 (owner: 10Umherirrender) [07:51:29] (03CR) 10Thiemo Kreuz (WMDE): "> […] but it is OK to directly access those same properties on a DeletedContribsPager? Why is that?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481900 (https://phabricator.wikimedia.org/T212771) (owner: 10Thiemo Kreuz (WMDE)) [08:44:27] (03PS1) 10Thiemo Kreuz (WMDE): Make ContributionsQuery accept value objects instead of DeletedContribsPager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481990 (https://phabricator.wikimedia.org/T212771) [08:54:23] (03PS1) 10Thiemo Kreuz (WMDE): Remove all default return true from hook handler functions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481991 [08:56:13] (03CR) 10Thiemo Kreuz (WMDE): "I figured creating this other patch that will remove the dependency on the DeletedContribsPager class is not that complicated, so I did it" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481900 (https://phabricator.wikimedia.org/T212771) (owner: 10Thiemo Kreuz (WMDE)) [09:05:01] (03PS1) 10Thiemo Kreuz (WMDE): Move indexField names into (Deleted)ContributionsRow sub-classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481992 [09:08:11] (03CR) 10jerkins-bot: [V: 04-1] Remove all default return true from hook handler functions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481991 (owner: 10Thiemo Kreuz (WMDE)) [11:26:52] 10MediaWiki-Watchlist, 10CatWatch, 10Commons, 10Growth-Team, and 4 others: [Commons] A new image added to a category is not shown in Watchlist - https://phabricator.wikimedia.org/T192691 (10mobrovac) I took a quick look and it seems like there were quite a few `categoryMembershipChange` jobs that failed wi... [14:57:37] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team: On Special:RecentChanges, the meaning of filled/unfilled bullet points should be explained - https://phabricator.wikimedia.org/T212860 (10Trizek-WMF) [15:20:39] (03PS1) 10Umherirrender: Fix variable name when throw in TreeRepository::fetchSubtreeIdentityMap [extensions/Flow] - 10https://gerrit.wikimedia.org/r/482041 [15:40:52] 10Collab-Notifications-Page, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Regression: Navigation controls are out of place in the Notification page - https://phabricator.wikimedia.org/T210487 (10JTannerWMF) [15:42:31] 10Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-Watchlist, 10Growth-Team: Box to choose different numbers of changes to show in "new filters for edit review" overflows with custom number specified in URL - https://phabricator.wikimedia.org/T176971 (10JTannerWMF) 05Open→03Resolved a... [15:43:49] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Dropdowns are inconsistently styled in recent changes - https://phabricator.wikimedia.org/T177598 (10JTannerWMF) 05Open→03Declined Rita believes based on reviewing comments from Pau et al, think we can decline. [15:44:21] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: Flow: Better error handling on unexpected responses is needed - https://phabricator.wikimedia.org/T181526 (10JTannerWMF) 05Open→03Invalid No follow up since author filed it a year ago, we can mark as stalled or decline it. [15:45:12] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team, 10Wikimedia-General-or-Unknown: Thank action failed (error code: badtoken). Please try again. - https://phabricator.wikimedia.org/T179941 (10JTannerWMF) 05Open→03Declined Author says we can close it if we want. This seems like a browser session issu... [15:45:48] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: Structured Discussion - "This topic has been hidden" warning appears for posting in threaded comments - https://phabricator.wikimedia.org/T177109 (10JTannerWMF) This is a bug but I'm not sure if it happens often, and would require some plum... [15:51:12] 10MediaWiki-Recent-changes, 10Growth-Team, 10goodfirstbug: Mark redirects in RecentChanges and Watchlist - https://phabricator.wikimedia.org/T177281 (10JTannerWMF) [15:51:43] 10MediaWiki-Recent-changes, 10Core Platform Team, 10Growth-Team: RSS RecentChanges does not work on login-required wiki - https://phabricator.wikimedia.org/T92469 (10JTannerWMF) [16:48:59] 10MediaWiki-Watchlist, 10Growth-Team, 10MediaWiki-extensions-NewUserActions: Allow adding pages to the watchlists of new accounts, either by default or during manual account creation - https://phabricator.wikimedia.org/T118540 (10Trizek-WMF) >>! In T118540#4832279, @Whatamidoing-WMF wrote: >>>! In T118540#46... [17:30:02] (03CR) 10D3r1ck01: [C: 03+1] "This looks good! I've not tested yet!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/482041 (owner: 10Umherirrender) [17:31:37] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: Flow: Better error handling on unexpected responses is needed - https://phabricator.wikimedia.org/T181526 (10MarkAHershberger) 05Invalid→03Open @Catrope: I did not install EventLogging. I don't think that is related to the timeout issu... [19:09:36] (03PS1) 10Kosta Harlan: Use getters to access ContribsPager properties [extensions/Flow] - 10https://gerrit.wikimedia.org/r/482120 (https://phabricator.wikimedia.org/T212771) [20:04:42] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: When deleting StructuredDiscussion content, attribute the deleted content to its author nor the sysop that deleted it - https://phabricator.wikimedia.org/T118024 (10greg) p:05Unbreak!→03High >>! In T118024#4823328, @MarcoAurelio wrote:... [20:13:32] 10Notifications, 10Community-Tech, 10Growth-Team: Deduplicate mention and mention-summary notifications for the same edit - https://phabricator.wikimedia.org/T203893 (10Catrope) [20:44:56] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [22:00:07] (03PS2) 10Catrope: Use getters to access ContribsPager properties [extensions/Flow] - 10https://gerrit.wikimedia.org/r/482120 (https://phabricator.wikimedia.org/T212771) (owner: 10Kosta Harlan) [22:03:06] 10MediaWiki-Watchlist, 10CatWatch, 10Commons, 10Growth-Team, and 4 others: [Commons] A new image added to a category is not shown in Watchlist - https://phabricator.wikimedia.org/T192691 (10Tgr) It's not a race condition in the obvious sense, this affected all category membership changes, not just new or d... [22:11:37] (03CR) 10Catrope: [C: 04-1] "ContribsPager has the getters you're using here, but DeletedContribsPager doesn't (and, strangely, does not extend ContribsPager)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/482120 (https://phabricator.wikimedia.org/T212771) (owner: 10Kosta Harlan) [22:22:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/482180 (owner: 10L10n-bot) [22:38:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/482184 (owner: 10L10n-bot)