[13:52:16] (03PS1) 10Umherirrender: Required argument follows optional [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481851 [14:18:06] (03CR) 10Nikerabbit: "The actual behavior seems to contradict documentation: https://gerrit.wikimedia.org/g/mediawiki/core/+/9d7a2a625193e8e1c767629e3d01da72c3e" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481632 (https://phabricator.wikimedia.org/T211876) (owner: 10Matěj Suchánek) [14:47:41] 10MediaWiki-Recent-changes, 10Growth-Team: Special:RecentChangesLinked returns 404 - https://phabricator.wikimedia.org/T212702 (10kostajh) MediaWiki's output of HTTP response codes is not always immediately intuitive or consistent for Special pages, but this is working as designed. The page returns a 404 becau... [14:50:31] 10MediaWiki-Recent-changes, 10Growth-Team: Special:RecentChangesLinked returns 404 - https://phabricator.wikimedia.org/T212702 (10Smile4ever) > If you specify a target, i.e. https://en.wikipedia.org/wiki/Special:RecentChangesLinked?target=Main+Page, the HTTP response is a 200. Even curl -I https://nl.wikipe... [14:54:53] 10MediaWiki-Recent-changes, 10Growth-Team: Special:RecentChangesLinked returns 404 - https://phabricator.wikimedia.org/T212702 (10kostajh) Yeah, it's probably this block of code: ` lang=php if ( !$this->runMainQueryHook( $tables, $select, $conds, $query_options, $join_conds, $opts ) ) { return false... [17:28:07] (03PS1) 10Thiemo Kreuz (WMDE): Fix documentation mistake in FlowHooks::onDeletedContributionsQuery [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481892 [17:31:14] (03PS1) 10Thiemo Kreuz (WMDE): Use more narrow interfaces in ContribsPager related code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481895 [17:41:49] (03CR) 10Catrope: [C: 03+2] Use ExtensionRegistry instead of class_exists [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/444250 (https://phabricator.wikimedia.org/T183096) (owner: 10Matěj Suchánek) [17:43:27] (03CR) 10Catrope: [C: 03+1] "Looks good to me but I'm going to ask Marshall to weigh in" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481630 (owner: 10Matěj Suchánek) [17:46:04] (03PS1) 10Thiemo Kreuz (WMDE): Make ContributionsQuery work with a value object instead of a ContribsPager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481900 (https://phabricator.wikimedia.org/T212771) [17:46:15] (03CR) 10Catrope: [C: 04-1] "Maybe this could instead use the same logic as MentionPresentationModel, where the namespace prefix is only dropped if the namespace is NS" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481630 (owner: 10Matěj Suchánek) [17:56:08] (03Merged) 10jenkins-bot: Use ExtensionRegistry instead of class_exists [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/444250 (https://phabricator.wikimedia.org/T183096) (owner: 10Matěj Suchánek) [17:58:11] 10MediaWiki-Recent-changes, 10Growth-Team: Special:RecentChangesLinked returns 404 - https://phabricator.wikimedia.org/T212702 (10Smile4ever) > Note how the page for https://nl.wikipedia.org/wiki/Speciaal:RecenteWijzigingenGelinkt/Sjabloon:Citeer_web contains no content. If you try with a target that has conte... [18:41:00] (03PS1) 10Umherirrender: Add missing use for Wikimedia\Rdbms\Database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481911 [19:21:06] 10MediaWiki-Recent-changes, 10Growth-Team: Category membership and wikidata not showing up in recent changes - https://phabricator.wikimedia.org/T212432 (10Tgr) [19:21:10] 10MediaWiki-Watchlist, 10CatWatch, 10Commons, 10Growth-Team, and 2 others: [Commons] A new image added to a category is not shown in Watchlist - https://phabricator.wikimedia.org/T192691 (10Tgr) [19:23:19] 10MediaWiki-Watchlist, 10CatWatch, 10Commons, 10Growth-Team, and 2 others: [Commons] A new image added to a category is not shown in Watchlist - https://phabricator.wikimedia.org/T192691 (10Tgr) This affected all category membership changes and wikidata changes (ie. all the "artificial" recentchanges/watch... [19:25:18] (03PS1) 10Umherirrender: Add missing use statments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481930 [19:27:25] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team, 10Regression, 10User-Ladsgroup: A particular edit not showing on watchlist - https://phabricator.wikimedia.org/T211849 (10Tgr) [19:28:33] (03CR) 10jerkins-bot: [V: 04-1] Add missing use statments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481930 (owner: 10Umherirrender) [19:29:56] (03CR) 10jerkins-bot: [V: 04-1] Add missing use statments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481930 (owner: 10Umherirrender) [19:37:58] (03PS2) 10Umherirrender: Add missing use statments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481930 [19:40:00] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [19:48:58] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team, 10Regression, 10User-Ladsgroup: A particular edit not showing on watchlist - https://phabricator.wikimedia.org/T211849 (10Tgr) 05Open→03Resolved {T192691}/{T212432} is a separate issue, the first has been merged here incorrectly. It af... [19:50:44] 10MediaWiki-Watchlist, 10CatWatch, 10Commons, 10Growth-Team, and 2 others: [Commons] A new image added to a category is not shown in Watchlist - https://phabricator.wikimedia.org/T192691 (10Tgr) [19:54:22] 10MediaWiki-Watchlist, 10CatWatch, 10Commons, 10Growth-Team, and 2 others: [Commons] A new image added to a category is not shown in Watchlist - https://phabricator.wikimedia.org/T192691 (10Tgr) [20:17:44] 10MediaWiki-Watchlist, 10CatWatch, 10Commons, 10Growth-Team, and 3 others: [Commons] A new image added to a category is not shown in Watchlist - https://phabricator.wikimedia.org/T192691 (10Tgr) This problem was originally reported on December 17 (allegedly started a few days before that) and apparently it... [20:52:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Required argument follows optional [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481851 (owner: 10Umherirrender) [21:00:40] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [21:02:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add missing use for Wikimedia\Rdbms\Database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481911 (owner: 10Umherirrender) [21:08:14] (03PS2) 10Thiemo Kreuz (WMDE): Make ContributionsQuery work with a value object instead of a ContribsPager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481900 (https://phabricator.wikimedia.org/T212771) [21:15:02] (03Merged) 10jenkins-bot: Required argument follows optional [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481851 (owner: 10Umherirrender) [21:19:20] (03CR) 10jenkins-bot: Required argument follows optional [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481851 (owner: 10Umherirrender) [21:22:51] (03Merged) 10jenkins-bot: Add missing use for Wikimedia\Rdbms\Database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481911 (owner: 10Umherirrender) [22:01:02] (03CR) 10jenkins-bot: Add missing use for Wikimedia\Rdbms\Database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/481911 (owner: 10Umherirrender) [22:46:46] (03CR) 10Catrope: [C: 03+2] Use more narrow interfaces in ContribsPager related code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481895 (owner: 10Thiemo Kreuz (WMDE)) [22:50:40] (03CR) 10Catrope: [C: 04-1] "Wait, so it's not OK for Flow to directly access properties on a ContribsPager, but it is OK to directly access those same properties on a" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481900 (https://phabricator.wikimedia.org/T212771) (owner: 10Thiemo Kreuz (WMDE)) [23:06:39] (03Merged) 10jenkins-bot: Use more narrow interfaces in ContribsPager related code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481895 (owner: 10Thiemo Kreuz (WMDE)) [23:12:01] (03CR) 10jenkins-bot: Use more narrow interfaces in ContribsPager related code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/481895 (owner: 10Thiemo Kreuz (WMDE))