[00:04:16] (03Merged) 10jenkins-bot: Remove obsolete aliases from closures [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473068 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [00:05:54] (03Merged) 10jenkins-bot: build: Update devDependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473069 (owner: 10Esanders) [00:16:25] (03CR) 10Sbisson: [C: 032] Unbreak RFD: use the same template name everywhere [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473294 (https://phabricator.wikimedia.org/T194826) (owner: 10Catrope) [00:19:22] (03CR) 10jenkins-bot: Remove jshint/jscs remnants [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473061 (owner: 10Esanders) [00:24:26] (03Merged) 10jenkins-bot: Unbreak RFD: use the same template name everywhere [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473294 (https://phabricator.wikimedia.org/T194826) (owner: 10Catrope) [00:24:34] (03CR) 10jenkins-bot: Remove obsolete aliases from closures [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473060 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [00:44:37] (03CR) 10jenkins-bot: Unbreak RFD: use the same template name everywhere [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473294 (https://phabricator.wikimedia.org/T194826) (owner: 10Catrope) [01:03:45] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [01:05:41] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [01:06:01] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [01:08:17] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [01:20:03] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [01:21:33] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Patch-For-Review: Copyvio: make links to CopyPatrol work for moved pages - https://phabricator.wikimedia.org/T207345 (10Etonkovidova) @kostajh - yes, https://tools.wmflabs.org/copypatrol/en?... [01:27:23] 10MediaWiki-Watchlist, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review, and 2 others: WatchedItemStore::addWatchBatchForUser does not have outer scope. - https://phabricator.wikimedia.org/T208003 (10Etonkovidova) 05Open>03Resolved [01:30:30] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [01:30:49] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Front-end-Standards-Group, 10Growth-Team, and 8 others: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T205581 (10Jdlrobson) [01:50:27] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Patch-For-Review: Copyvio: make links to CopyPatrol work for moved pages - https://phabricator.wikimedia.org/T207345 (10kostajh) @Etonkovidova what I was trying to say earlier is that this can... [09:17:56] 10MediaWiki-Recent-changes, 10Growth-Team, 10ORES, 10Scoring-platform-team, 10Wikidata: Wikidata recentchages API request with oresscores parameter returns 0 results - https://phabricator.wikimedia.org/T209459 (10Addshore) [09:20:23] 10MediaWiki-Recent-changes, 10Growth-Team, 10ORES, 10Scoring-platform-team, 10Wikidata: Wikidata recentchages API request with oresscores parameter returns 0 results - https://phabricator.wikimedia.org/T209459 (10Addshore) A profile of the request: https://performance.wikimedia.org/xhgui/run/view?id=5beb... [09:22:27] 10MediaWiki-Recent-changes, 10Growth-Team, 10ORES, 10Scoring-platform-team, 10Wikidata: Wikidata recentchages API request with oresscores parameter returns 0 results - https://phabricator.wikimedia.org/T209459 (10Addshore) p:05Triage>03High [09:22:49] 10MediaWiki-Recent-changes, 10Growth-Team, 10ORES, 10Scoring-platform-team, 10Wikidata: Wikidata recentchages API request with ORESscores parameter returns 0 results - https://phabricator.wikimedia.org/T209459 (10Addshore) [09:41:36] 10MediaWiki-Recent-changes, 10Growth-Team, 10ORES, 10Scoring-platform-team, 10Wikidata: Wikidata recentchages API request with ORESscores parameter returns 0 results - https://phabricator.wikimedia.org/T209459 (10Addshore) Logs for the request can be found @ https://logstash.wikimedia.org/goto/a1655d3903... [09:46:37] 10MediaWiki-Recent-changes, 10Growth-Team, 10ORES, 10Scoring-platform-team, and 2 others: Wikidata recentchages API request with ORESscores parameter returns 0 results - https://phabricator.wikimedia.org/T209459 (10Addshore) [09:51:30] (03PS1) 10Mogmog123: Clean up back-compatible code in NotificationController.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/473423 [09:54:19] (03PS2) 10Mogmog123: Clean up back-compatible code in NotificationController.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/473423 [09:58:35] (03CR) 10Addshore: [C: 032] Clean up back-compatible code in NotificationController.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/473423 (owner: 10Mogmog123) [10:01:37] 10Notifications, 10Growth-Team: Moved notification leads to the old location - https://phabricator.wikimedia.org/T209462 (10YaronSh) [10:07:15] 10Notifications, 10Growth-Team, 10MediaWiki-Email: Moved notification leads to the old location - https://phabricator.wikimedia.org/T209462 (10Amire80) [10:08:51] 10Notifications, 10Growth-Team, 10MediaWiki-Email: Moved notification leads to the old location - https://phabricator.wikimedia.org/T209462 (10Amire80) I confirm this. An admin will see a log of moving and deletion, which happens to be helpful, but it looks like a coincidence, and in any case it's not avail... [10:32:19] (03Merged) 10jenkins-bot: Clean up back-compatible code in NotificationController.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/473423 (owner: 10Mogmog123) [10:39:18] (03CR) 10jenkins-bot: Clean up back-compatible code in NotificationController.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/473423 (owner: 10Mogmog123) [11:06:24] 10Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10CommRel-Documentation, 10Growth-Team, and 3 others: Create a guided tour about StructuredDiscussions - https://phabricator.wikimedia.org/T112757 (10Aklapper) @Trizek-WMF: For GCI this would need steps for a contributor what's expected, wh... [11:15:21] 10Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10CommRel-Documentation, 10Growth-Team, and 3 others: Create a guided tour about StructuredDiscussions - https://phabricator.wikimedia.org/T112757 (10Trizek-WMF) @Aklapper, at the moment @SBisson will review the task to see if we create mul... [11:18:08] 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences, 10Growth-Team (Current Sprint), 10Patch-For-Review: Change the opt-out message for watchlists and recent changes in preferences, to reflect the fact that those features are now default - https://phabricator.wikimedia.org/T207741 (1... [12:59:03] 10MediaWiki-Recent-changes, 10Growth-Team, 10ORES, 10Wikidata, and 3 others: Wikidata recentchages API request with ORESscores parameter returns 0 results - https://phabricator.wikimedia.org/T209459 (10Ladsgroup) a:03Ladsgroup I will work on it. [13:12:42] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 23.0.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/473473 (owner: 10Libraryupgrader) [15:24:13] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 23.0.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473524 (owner: 10Libraryupgrader) [16:14:04] 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences, 10Growth-Team (Current Sprint), 10Patch-For-Review: Change the opt-out message for watchlists and recent changes in preferences, to reflect the fact that those features are now default - https://phabricator.wikimedia.org/T207741 (1... [16:23:19] (03PS1) 10Flutterish: Written QUnit tests [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473556 (https://phabricator.wikimedia.org/T160267) [16:26:11] (03PS2) 10Flutterish: Written QUnit tests [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473556 (https://phabricator.wikimedia.org/T160267) [16:26:48] (03PS3) 10Flutterish: Written QUnit tests [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473556 (https://phabricator.wikimedia.org/T160267) [16:31:12] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10VisualEditor-ContentLanguage, and 5 others: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters - https://phabricator.wikimedia.org/T85093 (10matmarex) [18:26:43] 10MediaWiki-Recent-changes, 10Core Platform Team, 10Growth-Team, 10Wikimedia-production-error: Failed executing job: categoryMembershipChange - https://phabricator.wikimedia.org/T204761 (10Catrope) [18:27:18] 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Clicking a link unexpectedly changes 'usenewrc' preference - https://phabricator.wikimedia.org/T208868 (10Catrope) We decided that we want to fix this eventually, but we think this is a low-impact issue, b... [19:02:29] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Fix large screen New Pages Feed display to save space (remove empty white-space to condense entries) - https://phabricator.wikimedia.org/T209116 (10Catrope) Moving this to 'Triaged but future' because many Page Curation tasks are currently part of the 2019 Wi... [19:02:32] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Keyword Search for New Pages Feed - https://phabricator.wikimedia.org/T207761 (10Catrope) Moving this to 'Triaged but future' because many Page Curation tasks are currently part of the 2019 Wishlist Survey [19:02:34] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Add "welcome newbie" button to Page Curation Toolbar - https://phabricator.wikimedia.org/T207225 (10Catrope) Moving this to 'Triaged but future' because many Page Curation tasks are currently part of the 2019 Wishlist Survey [19:02:37] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Documentation, and 2 others: Option not to review article when adding maintenance tags - https://phabricator.wikimedia.org/T148353 (10Catrope) Moving this to 'Triaged but future' because many Page Curation tasks are currentl... [19:02:40] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Option in New Pages Feed to 'skip viewed articles'. - https://phabricator.wikimedia.org/T207759 (10Catrope) Moving this to 'Triaged but future' because many Page Curation tasks are currently part of the 2019 Wishlist Survey [19:15:34] (03CR) 10Bartosz Dziewoński: "There is a merge conflict with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Thanks/+/473068 – I'll rebase the change to fix it." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473556 (https://phabricator.wikimedia.org/T160267) (owner: 10Flutterish) [19:16:37] (03PS4) 10Bartosz Dziewoński: Written QUnit tests [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473556 (https://phabricator.wikimedia.org/T160267) (owner: 10Flutterish) [19:40:21] (03PS1) 10Takidelfin: jQuery/findWithParent: Add QUnit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) [19:47:46] (03CR) 10D3r1ck01: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [19:47:55] (03CR) 10jerkins-bot: [V: 04-1] Written QUnit tests [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473556 (https://phabricator.wikimedia.org/T160267) (owner: 10Flutterish) [19:51:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] "* For the tests to actually run, you need to register them – see the method onResourceLoaderTestModules() in ThanksHooks.php and add anoth" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473556 (https://phabricator.wikimedia.org/T160267) (owner: 10Flutterish) [19:55:04] (03CR) 10Bartosz Dziewoński: [C: 032] Minor fixes to improve readability and CC [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/472803 (owner: 10D3r1ck01) [20:00:56] (03CR) 10jerkins-bot: [V: 04-1] jQuery/findWithParent: Add QUnit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [20:06:14] (03PS2) 10Takidelfin: jQuery/findWithParent: Add QUnit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) [20:07:12] (03CR) 10D3r1ck01: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [20:17:07] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Patch-For-Review: Copyvio: make links to CopyPatrol work for moved pages - https://phabricator.wikimedia.org/T207345 (10Etonkovidova) 05Open>03Resolved Thanks, @kostajh - based on >that t... [20:17:29] (03CR) 10jerkins-bot: [V: 04-1] Minor fixes to improve readability and CC [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/472803 (owner: 10D3r1ck01) [20:25:35] (03CR) 10D3r1ck01: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/472803 (owner: 10D3r1ck01) [20:32:51] (03CR) 10Bartosz Dziewoński: [C: 032] "Flaky tests" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/472803 (owner: 10D3r1ck01) [20:52:45] (03Merged) 10jenkins-bot: Minor fixes to improve readability and CC [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/472803 (owner: 10D3r1ck01) [20:54:28] (03CR) 10D3r1ck01: jQuery/findWithParent: Add QUnit tests (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [21:04:52] (03PS3) 10Takidelfin: jquery.findWithParent.js: Add QUnit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) [21:17:26] (03PS4) 10Takidelfin: jquery.findWithParent.js: Add QUnit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) [21:21:11] (03CR) 10D3r1ck01: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [21:40:39] (03PS1) 10D3r1ck01: Mark a flaky test as broken in ApiFlowViewTopicListTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473627 (https://phabricator.wikimedia.org/T209535) [23:45:01] 10Edit-Review-Improvements, 10Growth-Team, 10JADE: New watchlist filter: diffs without corresponding Judgment-space pages - https://phabricator.wikimedia.org/T209548 (10Harej) [23:53:35] (03CR) 10Bartosz Dziewoński: [C: 032] "Seems okay, tests run and pass… I'm not really familiar with this code." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473281 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [23:53:38] (03CR) 10Bartosz Dziewoński: [C: 032] "Seems okay, tests run and pass… I'm not really familiar with this code." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473592 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin)