[07:56:43] 10MediaWiki-Recent-changes, 10Growth-Team, 10Wikimedia-production-error: Failed executing job: categoryMembershipChange - https://phabricator.wikimedia.org/T204761 (10Catrope) The majority of these are not due to missing page IDs, but have error messages like "Could not acquire lock" or "Timed out while wait... [08:27:50] 10Notifications, 10Growth-Team, 10Design: Welcome notice should use a different icon - https://phabricator.wikimedia.org/T209254 (10Catrope) That's the placeholder icon for when the site icon is not configured. It's meant to use the logo of the wiki. It can be configured by setting `$wgEchoNotificationIcons[... [08:41:13] (03CR) 10Catrope: [C: 032] Add a null check in getTalkpageManager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472516 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [08:51:09] 10MediaWiki-Watchlist, 10Growth-Team, 10Performance-Team, 10Wikimedia-production-error: Spike of DBTransactionSizeError exceptions from /w/api.php from Special:Watchlist - https://phabricator.wikimedia.org/T207941 (10Catrope) We'll need better logging to figure out what's causing this. The stack trace come... [08:58:52] (03Merged) 10jenkins-bot: Add a null check in getTalkpageManager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472516 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [09:04:44] (03CR) 10jenkins-bot: Add a null check in getTalkpageManager [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472516 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [10:45:00] (03PS1) 10Paladox: Add a null check in getTalkpageManager [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/473179 (https://phabricator.wikimedia.org/T209113) [10:45:12] (03PS1) 10Paladox: Add a null check in getTalkpageManager [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/473180 (https://phabricator.wikimedia.org/T209113) [10:48:26] (03CR) 10jerkins-bot: [V: 04-1] Add a null check in getTalkpageManager [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/473179 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [10:48:41] (03CR) 10jerkins-bot: [V: 04-1] Add a null check in getTalkpageManager [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/473180 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [10:51:42] (03CR) 10Paladox: "Wil need a force merge as test failures not caused by this change." [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/473180 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [10:52:03] (03CR) 10Paladox: "Wil need a force merge as test failures not caused by this change." [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/473179 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [12:26:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix @param data type in TemplateHelper.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468847 (owner: 10D3r1ck01) [12:28:33] 10Collaboration-Team-Triage, 10Notifications, 10Community-Tech, 10Growth-Team, and 5 others: LoginNotify should inform users of the IP address of failed login attempts to their account - https://phabricator.wikimedia.org/T174388 (10Krenair) [12:43:50] (03Merged) 10jenkins-bot: Fix @param data type in TemplateHelper.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468847 (owner: 10D3r1ck01) [12:49:37] (03CR) 10jenkins-bot: Fix @param data type in TemplateHelper.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468847 (owner: 10D3r1ck01) [12:56:44] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Add a null check in getTalkpageManager (031 comment) [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/473180 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [12:58:15] (03CR) 10Paladox: "But this was merged in master already :)" [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/473180 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [16:17:31] (03PS1) 10Kosta Harlan: Revert "Add a null check in getTalkpageManager" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 [16:18:07] (03CR) 10Kosta Harlan: [C: 04-1] "> Patch Set 1:" [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/473180 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [16:19:55] (03CR) 10Kosta Harlan: "As the OccupationController interface notes, getTalkPageManager should throw an exception on failure. I haven't tested what happens with t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (owner: 10Kosta Harlan) [16:20:07] (03CR) 10Paladox: [C: 04-1] "This will cause the migration to actor to fail." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (owner: 10Kosta Harlan) [16:20:46] (03PS2) 10Kosta Harlan: Revert "Add a null check in getTalkpageManager" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (https://phabricator.wikimedia.org/T209113) [16:22:35] (03CR) 10Kosta Harlan: "> Patch Set 1: Code-Review-1" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (https://phabricator.wikimedia.org/T209113) (owner: 10Kosta Harlan) [16:23:51] (03CR) 10Paladox: [C: 04-1] "> Patch Set 2:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (https://phabricator.wikimedia.org/T209113) (owner: 10Kosta Harlan) [16:32:54] (03CR) 10Anomie: "> Patch Set 2:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (https://phabricator.wikimedia.org/T209113) (owner: 10Kosta Harlan) [16:36:20] (03CR) 10Paladox: [C: 04-1] "> Patch Set 2:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (https://phabricator.wikimedia.org/T209113) (owner: 10Kosta Harlan) [17:32:14] (03CR) 10Catrope: [C: 032] Revert "Add a null check in getTalkpageManager" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (https://phabricator.wikimedia.org/T209113) (owner: 10Kosta Harlan) [17:49:58] (03Merged) 10jenkins-bot: Revert "Add a null check in getTalkpageManager" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (https://phabricator.wikimedia.org/T209113) (owner: 10Kosta Harlan) [17:55:56] (03CR) 10jenkins-bot: Revert "Add a null check in getTalkpageManager" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/473239 (https://phabricator.wikimedia.org/T209113) (owner: 10Kosta Harlan) [18:28:02] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Patch-For-Review: Copyvio: make links to CopyPatrol work for moved pages - https://phabricator.wikimedia.org/T207345 (10kostajh) I checked the Mullach link in production and https://tools.wmfl... [18:52:56] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10Patch-For-Review: Page curation (rfd) creates an error message - https://phabricator.wikimedia.org/T194826 (10kostajh) Looking at it in the debugger, `specialDeletionTagging` isn't a defined variab... [19:45:30] 10Notifications, 10Growth-Team, 10Design: Welcome notice should use a different icon - https://phabricator.wikimedia.org/T209254 (10RHo) Just quickly created an icon using the TWN logo since that seems to be the format. Created in 20x20 and 30x30px in color (their logo colors), grayscale (WMF colors) and mo... [20:52:48] (03Abandoned) 10Catrope: Add a null check in getTalkpageManager [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/473180 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [20:52:53] (03Abandoned) 10Catrope: Add a null check in getTalkpageManager [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/473179 (https://phabricator.wikimedia.org/T209113) (owner: 10Paladox) [21:13:50] (03PS1) 10Takidelfin: Thanks/thank: Add tests for thanked cookie and getUserGender() [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473281 (https://phabricator.wikimedia.org/T160267) [21:20:37] (03CR) 10D3r1ck01: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473281 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [21:29:39] (03CR) 10jerkins-bot: [V: 04-1] Thanks/thank: Add tests for thanked cookie and getUserGender() [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473281 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [21:33:09] (03PS2) 10Takidelfin: Thanks/thank: Add tests for thanked cookie and getUserGender() [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473281 (https://phabricator.wikimedia.org/T160267) [21:33:56] (03CR) 10D3r1ck01: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473281 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [21:34:19] (03CR) 10Paladox: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473281 (https://phabricator.wikimedia.org/T160267) (owner: 10Takidelfin) [21:48:37] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10Growth-Team, and 3 others: Enable new RC on mobile - https://phabricator.wikimedia.org/T178194 (10Jdlrobson) [21:48:51] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10Growth-Team, and 3 others: Enable new RC on mobile - https://phabricator.wikimedia.org/T178194 (10ovasileva) p:05Triage>03High [22:32:22] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10Patch-For-Review: Page curation (rfd) creates an error message - https://phabricator.wikimedia.org/T194826 (10Catrope) That's not what I see. Instead, `specialDeletionTagging` is defined, but `tagO... [22:48:57] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10Patch-For-Review: Page curation (rfd) creates an error message - https://phabricator.wikimedia.org/T194826 (10Catrope) Looks like this was directly caused by the previous fix for this bug, which ch... [22:53:56] (03CR) 10Jforrester: [C: 032] Remove obsolete aliases from closures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/472989 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [22:55:25] (03CR) 10Jforrester: [C: 032] Remove obsolete aliases from closures [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472998 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [22:55:35] (03PS2) 10Jforrester: Limit 've' global to the 'visualeditor' folder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472999 (owner: 10Esanders) [22:56:01] (03CR) 10Jforrester: [C: 032] Limit 've' global to the 'visualeditor' folder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472999 (owner: 10Esanders) [22:56:34] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Patch-For-Review: "Other review tools" is not working when using Minerva on Recent Changes or JS is disabled on desktop - https://phabricator.wikimedia.org/T181545 (10Jdlrobson) [22:56:51] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): "Other review tools" is not working when using Minerva on Recent Changes or JS is disabled ... - https://phabricator.wikimedia.org/T181545 [23:00:25] (03PS1) 10Catrope: Unbreak RFD: use the same template name everywhere [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473294 (https://phabricator.wikimedia.org/T194826) [23:00:54] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10Patch-For-Review: Page curation (rfd) creates an error message - https://phabricator.wikimedia.org/T194826 (10Catrope) [23:01:28] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10Patch-For-Review: Page curation (rfd) creates an error message - https://phabricator.wikimedia.org/T194826 (10Catrope) a:03Catrope [23:08:27] (03Merged) 10jenkins-bot: Remove obsolete aliases from closures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/472989 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [23:24:41] (03Merged) 10jenkins-bot: Remove obsolete aliases from closures [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472998 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [23:24:44] (03Merged) 10jenkins-bot: Limit 've' global to the 'visualeditor' folder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472999 (owner: 10Esanders) [23:27:08] (03CR) 10jenkins-bot: Remove obsolete aliases from closures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/472989 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [23:37:50] (03CR) 10jenkins-bot: Limit 've' global to the 'visualeditor' folder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472999 (owner: 10Esanders) [23:38:34] (03CR) 10Jforrester: [C: 032] Remove obsolete aliases from closures [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473060 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [23:38:45] (03CR) 10Jforrester: [C: 032] Remove jshint/jscs remnants [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473061 (owner: 10Esanders) [23:39:37] (03CR) 10Jforrester: [C: 032] Remove obsolete aliases from closures [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473068 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [23:39:49] (03CR) 10Jforrester: [C: 032] build: Update devDependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/473069 (owner: 10Esanders) [23:46:27] (03CR) 10jenkins-bot: Remove obsolete aliases from closures [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472998 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [23:58:27] (03Merged) 10jenkins-bot: Remove obsolete aliases from closures [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473060 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [23:58:29] (03Merged) 10jenkins-bot: Remove jshint/jscs remnants [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/473061 (owner: 10Esanders)