[00:16:01] (03PS1) 10MaxSem: Don't override checkmatrix defaults set elsewhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/461832 (https://phabricator.wikimedia.org/T174220) [00:52:46] (03PS2) 10Kosta Harlan: Render bottom navigation stats only when not in AfC mode [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461754 (https://phabricator.wikimedia.org/T204634) [01:32:00] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Growth-Team (Current Sprint), 10Wikimedia-production-error: Flow: InvalidDataException "Flow workflow is for different page" from WorkflowLoaderFactory.php - https://phabricator.wikimedia.org/T70526 (10kostajh) Some more notes on this. There are two i... [04:21:49] 10Collaboration-Team-Triage, 10WikiLove, 10Growth-Team, 10MassMessage, and 4 others: Convert MediaWiki extensions WikiLove and MassMessage to use OOUI - https://phabricator.wikimedia.org/T187992 (10Prtksxna) Hey @Paarmita, I think a good first step would be to setup [[ https://doc.wikimedia.org/oojs-ui/mas... [06:31:45] 10Collaboration-Team-Triage, 10WikiLove, 10Growth-Team, 10MassMessage, and 4 others: Convert MediaWiki extensions WikiLove and MassMessage to use OOUI - https://phabricator.wikimedia.org/T187992 (10Paarmita) @Prtksxna Thanks for the reply. I read the tutorial and set up vagrant, so now how can I proceed wi... [07:43:09] 10Collaboration-Team-Triage, 10WikiLove, 10Growth-Team, 10MassMessage, and 4 others: Convert MediaWiki extensions WikiLove and MassMessage to use OOUI - https://phabricator.wikimedia.org/T187992 (10Aklapper) @Paarmita: Thanks. Please see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [09:24:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461899 (owner: 10L10n-bot) [13:10:24] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team, 10Google-Code-in-2018: Write unit tests for Thanks JS modules - https://phabricator.wikimedia.org/T160267 (10D3r1ck01) [13:14:37] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team, 10Google-Code-in-2018: Write unit tests for Thanks JS modules - https://phabricator.wikimedia.org/T160267 (10D3r1ck01) Imported as: https://codein.withgoogle.com/dashboard/tasks/5802758423707648/. Will give a helping hand to @Framawiki in mentoring this. [13:16:05] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team, 10Google-Code-in-2018: Write unit tests for Thanks JS modules - https://phabricator.wikimedia.org/T160267 (10D3r1ck01) [13:22:15] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team, 10Google-Code-in-2018: Write unit tests for Thanks JS modules - https://phabricator.wikimedia.org/T160267 (10D3r1ck01) [14:46:47] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Regression: PageTriage last use not persisted properly for user session - https://phabricator.wikimedia.org/T203273 (10kostajh) 05stalled>03Open Per our last triage meeting, @Catrope is going to review this. [14:47:15] (03CR) 10Kosta Harlan: [C: 031] Allow thanking discontinued revisions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/461709 (https://phabricator.wikimedia.org/T186470) (owner: 10Sbisson) [15:03:52] (03PS2) 10Kosta Harlan: Add logging to help debug IRC / RCFeeds reporting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/460928 (https://phabricator.wikimedia.org/T187861) [15:04:38] (03CR) 10Kosta Harlan: "> Patch Set 1:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/460928 (https://phabricator.wikimedia.org/T187861) (owner: 10Kosta Harlan) [15:05:56] (03CR) 10Kosta Harlan: "I'm leaving this as WIP as I coded and tested it pretty quickly; please test it out locally as you review." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458550 (https://phabricator.wikimedia.org/T203273) (owner: 10Kosta Harlan) [15:44:31] (03PS1) 10Kosta Harlan: Use DBLoadBalancerFactory to rollback all DBs, add more logging [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461980 (https://phabricator.wikimedia.org/T70526) [15:45:21] (03CR) 10Kosta Harlan: [C: 04-1] "Marking as -1 because I don't want to merge this yet, I want to test it on testwiki first." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461980 (https://phabricator.wikimedia.org/T70526) (owner: 10Kosta Harlan) [15:47:54] (03PS1) 10Esanders: Fix alignment of 'About this board' icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461981 [15:55:30] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review: Change wp10 references to articlequality - https://phabricator.wikimedia.org/T202998 (10SBisson) [16:16:21] (03PS1) 10Esanders: Fix alignment of icons in popup menus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461987 [16:29:19] (03CR) 10Esanders: [C: 04-1] Fix alignment of 'About this board' icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461981 (owner: 10Esanders) [16:34:36] (03CR) 10Kosta Harlan: [C: 04-2] "-2 until manually tested on testwiki" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461980 (https://phabricator.wikimedia.org/T70526) (owner: 10Kosta Harlan) [16:57:18] (03PS2) 10Esanders: Fix alignment of 'About this board' icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461981 [16:57:20] (03PS2) 10Esanders: Fix alignment of icons in popup menus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461987 [17:17:36] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team (Current Sprint): Filters: Display the time and date of the last refresh - https://phabricator.wikimedia.org/T200353 (10JTannerWMF) a:05Pginer-WMF>03None [17:17:46] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team (Current Sprint): Create a global Talk page filter - https://phabricator.wikimedia.org/T201520 (10JTannerWMF) a:05Pginer-WMF>03None [17:26:52] (03CR) 10Sbisson: [C: 032] Fix alignment of 'About this board' icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461981 (owner: 10Esanders) [17:26:58] (03CR) 10Sbisson: [C: 032] Fix alignment of icons in popup menus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461987 (owner: 10Esanders) [17:30:43] 10Edit-Review-Improvements-RC-Page, 10Growth-Team (Current Sprint): [wmf.14-minor] Misalignment of labels - RC filters and Structured discussion board menu icons - https://phabricator.wikimedia.org/T200364 (10SBisson) The part about the Flow menu icons was fixed by @Esanders in https://gerrit.wikimedia.org/r/#... [17:31:11] 10Edit-Review-Improvements-RC-Page, 10Growth-Team (Current Sprint): [wmf.14-minor] Misalignment of labels - RC filters - https://phabricator.wikimedia.org/T200364 (10SBisson) [17:32:20] 10MediaWiki-extensions-PageCuration, 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Deploy PageTriage AfC to production - https://phabricator.wikimedia.org/T203184 (10SBisson) [17:35:56] (03CR) 10Sbisson: [C: 032] Add logging to help debug IRC / RCFeeds reporting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/460928 (https://phabricator.wikimedia.org/T187861) (owner: 10Kosta Harlan) [17:43:22] (03CR) 10Kaldari: [C: 031] "Looks good, but haven't tested." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/461832 (https://phabricator.wikimedia.org/T174220) (owner: 10MaxSem) [17:59:14] 10MediaWiki-extensions-PageCuration, 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team, 10MediaWiki-Patrolling, 10Performance: Idle Wikipedia pages cause a memory leak - https://phabricator.wikimedia.org/T205127 (10Whatamidoing-WMF) [18:00:53] (03CR) 10Sbisson: [C: 04-1] "This works well but I would not disable the mode radio buttons for the following reasons:" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461754 (https://phabricator.wikimedia.org/T204634) (owner: 10Kosta Harlan) [18:05:52] (03CR) 10Kosta Harlan: "> 1) It introduces a different pattern from we have everywhere else in this app" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461754 (https://phabricator.wikimedia.org/T204634) (owner: 10Kosta Harlan) [18:21:26] (03Merged) 10jenkins-bot: Fix alignment of 'About this board' icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461981 (owner: 10Esanders) [18:21:28] (03Merged) 10jenkins-bot: Fix alignment of icons in popup menus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461987 (owner: 10Esanders) [18:23:14] 10Notifications, 10Growth-Team, 10StructuredDiscussions, 10Technical-Debt: Flow and Echo use inconsistent file names - https://phabricator.wikimedia.org/T205131 (10Jdlrobson) [18:25:10] (03Merged) 10jenkins-bot: Add logging to help debug IRC / RCFeeds reporting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/460928 (https://phabricator.wikimedia.org/T187861) (owner: 10Kosta Harlan) [18:29:58] (03CR) 10jenkins-bot: Fix alignment of 'About this board' icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461981 (owner: 10Esanders) [18:31:40] (03CR) 10Sbisson: [C: 04-1] "> > 1) It introduces a different pattern from we have everywhere else" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461754 (https://phabricator.wikimedia.org/T204634) (owner: 10Kosta Harlan) [18:38:24] (03CR) 10jenkins-bot: Add logging to help debug IRC / RCFeeds reporting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/460928 (https://phabricator.wikimedia.org/T187861) (owner: 10Kosta Harlan) [18:46:27] (03CR) 10jenkins-bot: Fix alignment of icons in popup menus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/461987 (owner: 10Esanders) [19:23:43] 10Edit-Review-Improvements-RC-Page, 10Growth-Team (Current Sprint), 10Patch-For-Review: [wmf.22 testwiki] RC user selected 'Time period to search' in hours does not update "Days to show in recent changes" option - https://phabricator.wikimedia.org/T204623 (10kostajh) [19:30:14] (03PS3) 10Kosta Harlan: Render bottom navigation stats only when not in AfC mode [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461754 (https://phabricator.wikimedia.org/T204634) [19:45:06] (03CR) 10Sbisson: [C: 032] "Thanks" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461754 (https://phabricator.wikimedia.org/T204634) (owner: 10Kosta Harlan) [19:47:44] 10Edit-Review-Improvements-RC-Page, 10Growth-Team (Current Sprint), 10Patch-For-Review: [wmf.22 testwiki] RC user selected 'Time period to search' in hours does not update "Days to show in recent changes" option - https://phabricator.wikimedia.org/T204623 (10kostajh) @Etonkovidova as far as I can tell, ther... [19:52:30] 10MediaWiki-extensions-PageCuration, 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team, 10MediaWiki-Patrolling, and 2 others: Idle Wikipedia pages cause a memory leak - https://phabricator.wikimedia.org/T205127 (10Count_Count) [19:54:25] 10MediaWiki-extensions-PageCuration, 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team, 10MediaWiki-Patrolling, and 2 others: Idle Wikipedia pages cause a memory leak - https://phabricator.wikimedia.org/T205127 (10JFG) Thanks for reporting my issue here. Let me add that only the English Wikipedia suffers... [19:54:40] (03Merged) 10jenkins-bot: Render bottom navigation stats only when not in AfC mode [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461754 (https://phabricator.wikimedia.org/T204634) (owner: 10Kosta Harlan) [19:58:12] (03CR) 10jenkins-bot: Render bottom navigation stats only when not in AfC mode [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/461754 (https://phabricator.wikimedia.org/T204634) (owner: 10Kosta Harlan) [20:03:32] 10Edit-Review-Improvements-RC-Page, 10Growth-Team (Current Sprint), 10Patch-For-Review: [wmf.22 testwiki] RC user selected 'Time period to search' in hours does not update "Days to show in recent changes" option - https://phabricator.wikimedia.org/T204623 (10SBisson) >>! In T204623#4606952, @kostajh wrote:... [20:03:41] 10MediaWiki-extensions-PageCuration, 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team, 10MediaWiki-Patrolling, and 2 others: Idle Wikipedia pages cause a memory leak - https://phabricator.wikimedia.org/T205127 (10JFG) I took a memory profiling excerpt from the JS console, but I can't upload it here. The... [20:09:01] 10MediaWiki-extensions-PageCuration, 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team, 10MediaWiki-Patrolling, and 2 others: Idle Wikipedia pages cause a memory leak - https://phabricator.wikimedia.org/T205127 (10SBisson) @JFG thanks for taking the time to investigate this problem. You can send me the... [20:53:09] 10Edit-Review-Improvements-RC-Page, 10Growth-Team (Current Sprint), 10Patch-For-Review: [wmf.22 testwiki] RC user selected 'Time period to search' in hours does not update "Days to show in recent changes" option - https://phabricator.wikimedia.org/T204623 (10kostajh) > DefaultPreferencesFactory.php:1039 is... [20:57:56] 10Edit-Review-Improvements-RC-Page, 10Growth-Team (Current Sprint), 10Patch-For-Review: [wmf.22 testwiki] RC user selected 'Time period to search' in hours does not update "Days to show in recent changes" option - https://phabricator.wikimedia.org/T204623 (10SBisson) >>! In T204623#4607239, @kostajh wrote:... [21:17:54] 10Edit-Review-Improvements-RC-Page, 10Growth-Team (Current Sprint), 10Patch-For-Review: [wmf.22 testwiki] RC user selected 'Time period to search' in hours does not update "Days to show in recent changes" option - https://phabricator.wikimedia.org/T204623 (10kostajh) I should have put that it my last commen... [21:19:25] 10MediaWiki-extensions-PageCuration, 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Deploy PageTriage AfC to production - https://phabricator.wikimedia.org/T203184 (10Etonkovidova) @SBisson There i... [21:28:48] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: .flow-post color override div#content color - https://phabricator.wikimedia.org/T75455 (10hashar) 05Open>03declined Flow is in maintenance mode anyway so that is unlikely to be ever fixed. I don't have interest in it anymore. [21:38:13] 10MediaWiki-extensions-PageCuration, 10Multi-Content-Revisions, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), and 2 others: DB error in PageTriage: Unknown column 'actor_rev_user.actor_user' in 'on clause' - https://phabricator.wikimedia.org/T204764 (10Eton... [21:45:45] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 10Patch-For-Review: Stats appear intermittently on AfC side of Special:NewPagesFeed, should be hidden - https://phabricator.wikimedia.org/T204634 (10Etonkovidova) 05Open>...