[00:09:57] (03CR) 10jenkins-bot: Remove deprecated UsageException fallback code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454372 (owner: 10Umherirrender) [00:31:31] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10User-notice-collaboration: Styling adjustments for the New filters for edit review - https://phabricator.wikimedia.org/T168826 (10Catrope) [00:31:34] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10UI-Standardization, 10User-notice-collaboration: Help icon is misplaced on the Tags panel - https://phabricator.wikimedia.org/T191014 (10Catrope) 05Open>03Resolved a:03Catrope @Volker_E says this task is re... [01:13:25] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Group changes across days in enhanced rc - https://phabricator.wikimedia.org/T10681 (10Quiddity) I'm worried that it will become harder to determine //which changes we've already seen// (e.g. yesterday, or 3 days ago), if we can't tell which d... [02:10:00] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Group changes across days in enhanced rc - https://phabricator.wikimedia.org/T10681 (10Izno) >>! In T10681#4521605, @Quiddity wrote: > I'm worried that it will become harder to determine //which changes we've already seen// (e.g. yesterday, or... [05:01:41] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Group changes across days in enhanced rc - https://phabricator.wikimedia.org/T10681 (10Jonesey95) I don't use RC either. I don't think I've ever even visited that page; the idea of seeing all recent changes is mind-boggling on en.WP. I suspect... [08:32:28] (03CR) 10Daniel Kinzler: Work around exception in DifferenceEngine::showDiffStyle() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [09:38:40] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team: Update Echo Notifications in real time without page reloads - https://phabricator.wikimedia.org/T34284 (10JTannerWMF) This is a powerful long-standing feature idea, but the team will not have time to work on it in the near future. [09:40:02] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team: Have a way to mark specific edits as seen directly from RC or watchlist - https://phabricator.wikimedia.org/T196629 (10JTannerWMF) This is a useful feature idea, but the team won’t have bandwidth to work on it in the near term. This is a good candi... [09:40:58] 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Growth-Team: 'Restore default filters' on Watchlist may be no-op - https://phabricator.wikimedia.org/T199513 (10JTannerWMF) Because this issue is a relatively rare edge-case, the team won’t be able to prioritize it now. [09:42:15] 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Growth-Team, 10MediaWiki-User-preferences: Changed preferences are not detected when opening/refreshing the watchlist with previously used settings - https://phabricator.wikimedia.org/T199920 (10JTannerWMF) Team is still considering wh... [09:43:54] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team: Filters: Display the time and date of the last refresh - https://phabricator.wikimedia.org/T200353 (10JTannerWMF) Since this is useful functionality that is no longer in the new interface, we’ll work with our designer in Q1 to bring it back. [09:44:57] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team: Implement a 'By pages views' set of filters - https://phabricator.wikimedia.org/T200981 (10JTannerWMF) This is a powerful feature that seems to be a major engineering challenge. The team will not be able to prioritize this in the near future. [09:45:37] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team: Reset current active filters from the last saved set used - https://phabricator.wikimedia.org/T200986 (10JTannerWMF) Unfortunately we won’t be able to prioritize this in the near future. [10:22:23] (03CR) 10Gergő Tisza: Work around exception in DifferenceEngine::showDiffStyle() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [10:27:52] (03CR) 10Gergő Tisza: Work around exception in DifferenceEngine::showDiffStyle() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [11:24:29] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Group changes across days in enhanced rc - https://phabricator.wikimedia.org/T10681 (10Nemo_bis) > I'm worried that it will become harder to determine which changes we've already seen (e.g. yesterday, or 3 days ago), if we can't tell which day... [12:55:59] 10Thanks, 10Growth-Team, 10MediaWiki-History-or-Diffs, 10MediaWiki-extensions-Diff, 10Wikidata: Diffs for page creation show error - https://phabricator.wikimedia.org/T202526 (10Daask) [12:57:27] (03PS1) 10Umherirrender: Replace some wfMessage by ContextSource::msg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454536 [13:25:58] (03PS3) 10Kosta Harlan: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [13:49:53] 10Thanks, 10Growth-Team, 10MediaWiki-History-or-Diffs: Diffs for page creation show error - https://phabricator.wikimedia.org/T202526 (10Lydia_Pintscher) [13:51:35] (03PS4) 10Kosta Harlan: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [14:13:12] (03PS1) 10Umherirrender: Split long lines over 200 chars [extensions/Echo] - 10https://gerrit.wikimedia.org/r/454550 [14:48:14] (03PS1) 10Umherirrender: Split long lines over 200 chars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454561 [14:55:42] 10Thanks, 10Growth-Team, 10MediaWiki-History-or-Diffs: Diffs for page creation show error - https://phabricator.wikimedia.org/T202526 (10matej_suchanek) [15:19:11] (03PS4) 10Huji: Use new syntax for AbuseFilter variables and deprecate the old ones [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454274 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [15:20:47] (03CR) 10Huji: "Should it not depend on something else as well? As in, if the only dependecy is If5f238cddb41ef92b141e36b4f2f15fd4cc86476 then we would ha" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454292 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [15:22:04] (03CR) 10Huji: Remove superfluos parameter from AbuseFilter call (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454292 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [15:24:42] (03CR) 10Daimona Eaytoy: "> Should it not depend on something else as well? As in, if the only" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454292 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [15:26:29] (03PS2) 10Daimona Eaytoy: Remove superfluous parameter from AbuseFilter call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454292 (https://phabricator.wikimedia.org/T173889) [15:26:57] (03CR) 10Daimona Eaytoy: "> > Should it not depend on something else as well? As in, if the" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454292 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [15:35:15] 10WikiLove, 10Growth-Team, 10Wikimedia-Extension-setup: Deploy Wikilove on yue.wp - https://phabricator.wikimedia.org/T202548 (10deryckchan) [16:27:15] (03CR) 10Catrope: Work around exception in DifferenceEngine::showDiffStyle() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [17:15:27] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review: Fix warning for unrecognized API params (mode, timestamp) - https://phabricator.wikimedia.org/T202131 (10Etonkovidova) 05Open>03Resolved a:03Etonkov... [17:47:46] (03PS5) 10Catrope: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) [17:48:06] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Growth-Team (Current Sprint), 10Wikimedia-log-errors: Flow: InvalidDataException "Flow workflow is for different page" from WorkflowLoaderFactory.php - https://phabricator.wikimedia.org/T70526 (10JTannerWMF) [17:49:07] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team (Current Sprint): Filters: Display the time and date of the last refresh - https://phabricator.wikimedia.org/T200353 (10JTannerWMF) [17:50:11] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team (Current Sprint), 10User-notice, 10User-notice-collaboration: Rephrase confusing "thanks" message on diff page - https://phabricator.wikimedia.org/T159302 (10JTannerWMF) [17:50:15] (03CR) 10Kosta Harlan: [C: 04-1] Work around exception in DifferenceEngine::showDiffStyle() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [18:00:10] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Growth-Team (Current Sprint), 10Wikimedia-log-errors: Flow: InvalidDataException "Flow workflow is for different page" from WorkflowLoaderFactory.php - https://phabricator.wikimedia.org/T70526 (10JTannerWMF) a:03kostajh [18:00:19] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team (Current Sprint): Filters: Display the time and date of the last refresh - https://phabricator.wikimedia.org/T200353 (10JTannerWMF) a:03MMiller_WMF [18:06:18] (03PS6) 10Catrope: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) [18:06:23] (03CR) 10Catrope: Work around exception in DifferenceEngine::showDiffStyle() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [18:10:00] 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Growth-Team, 10MediaWiki-User-preferences: Changed preferences are not detected when opening/refreshing the watchlist with previously used settings - https://phabricator.wikimedia.org/T199920 (10Aklapper) >>! In T199920#4522217, @JTann... [18:21:43] (03CR) 10Gergő Tisza: Work around exception in DifferenceEngine::showDiffStyle() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [18:24:06] (03CR) 10Catrope: Work around exception in DifferenceEngine::showDiffStyle() (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [18:28:09] (03PS7) 10Catrope: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) [18:28:36] (03CR) 10Catrope: "PS7: Roll back to PS4" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [18:42:37] (03PS12) 10Sbisson: Show copyvio hint and link to report in feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) [18:49:53] (03CR) 10Kosta Harlan: [C: 032] Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [18:54:49] 10Notifications, 10Growth-Team, 10Mail, 10Operations, 10User-herron: SRE query: Is it possible to measure how many e-mails are sent to "black hole" e-mail addresses? - https://phabricator.wikimedia.org/T202329 (10herron) Yes, messages using the blackhole transport are indeed logged. What timeframe are y... [19:00:27] (03PS1) 10Thcipriani: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] (wmf/1.32.0-wmf.18) - 10https://gerrit.wikimedia.org/r/454626 (https://phabricator.wikimedia.org/T202454) [19:06:27] (03Merged) 10jenkins-bot: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [19:07:09] (03CR) 10Thcipriani: [C: 032] Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] (wmf/1.32.0-wmf.18) - 10https://gerrit.wikimedia.org/r/454626 (https://phabricator.wikimedia.org/T202454) (owner: 10Thcipriani) [19:08:14] (03CR) 10jerkins-bot: [V: 04-1] Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] (wmf/1.32.0-wmf.18) - 10https://gerrit.wikimedia.org/r/454626 (https://phabricator.wikimedia.org/T202454) (owner: 10Thcipriani) [19:14:49] (03CR) 10jenkins-bot: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454425 (https://phabricator.wikimedia.org/T202454) (owner: 10Catrope) [19:27:59] (03Merged) 10jenkins-bot: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] (wmf/1.32.0-wmf.18) - 10https://gerrit.wikimedia.org/r/454626 (https://phabricator.wikimedia.org/T202454) (owner: 10Thcipriani) [19:36:56] (03CR) 10jenkins-bot: Work around exception in DifferenceEngine::showDiffStyle() [extensions/Flow] (wmf/1.32.0-wmf.18) - 10https://gerrit.wikimedia.org/r/454626 (https://phabricator.wikimedia.org/T202454) (owner: 10Thcipriani) [20:26:44] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): "Nominated for deletion" filter doesn't work - https://phabricator.wikimedia.org/T202582 (10SBisson) [20:29:40] (03PS1) 10Sbisson: Update 'ptrp_deleted' when any of the deletion category is present [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/454646 (https://phabricator.wikimedia.org/T202582) [20:34:16] (03CR) 10Sbisson: Show copyvio hint and link to report in feed (034 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [21:12:54] 10Notifications, 10Growth-Team, 10Mail, 10Operations, 10User-herron: SRE query: Is it possible to measure how many e-mails are sent to "black hole" e-mail addresses? - https://phabricator.wikimedia.org/T202329 (10MMiller_WMF) @Jdforrester-WMF -- to put some specific around this, here's what I would like... [21:14:47] 10Notifications, 10Growth-Team, 10Mail, 10Operations, 10User-herron: SRE query: Is it possible to measure how many e-mails are sent to "black hole" e-mail addresses? - https://phabricator.wikimedia.org/T202329 (10MMiller_WMF) Adding Morten, our team's data analyst, as this involves data. [21:34:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/454677 (owner: 10L10n-bot) [21:59:20] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10JavaScript, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), and 2 others: Use MediaWiki JavaScript API instead of custom code - https://phabricator.wikimedia.org/T202129 (10Etonkovidova) 05Open>03Resolved [22:12:54] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, and 2 others: PageTriage performs unexpected db writes on GET request (TransactionProfiler warning from Articl... - https://phabricator.wikimedia.org/T199699 [22:13:58] RoanKattouw: are you able to explain to me what's going on in https://phabricator.wikimedia.org/T200089 ? I'm struggling to understand the problem [22:15:07] is it that all his edits are being tagged with mobile? https://vec.wikipedia.org/w/index.php?title=Speciale%3AContributi&contribs=user&target=Alvise+Morosin&namespace=&tagfilter=&start=&end= [22:35:12] 10Notifications, 10Growth-Team, 10Mail, 10Operations, 10User-herron: SRE query: Is it possible to measure how many e-mails are sent to "black hole" e-mail addresses? - https://phabricator.wikimedia.org/T202329 (10Jdforrester-WMF) >>! In T202329#4524878, @MMiller_WMF wrote: > @Jdforrester-WMF -- to put so... [22:36:51] jdlrobson: So there's this behavior in MW core where, when a user who has the 'bot' right makes an edit, the edit is automatically flagged as a bot edit unless the user indicates otherwise (with &bot=0 in the URL) [22:37:26] Some communities have a group called "flood" which they (temporarily) put users in when they're going to do very noisy things, so their edits get marked as bot edits and hidden from RC/WL by default [22:37:52] It seems like the desktop editors and api.php correctly do the bot flag thing, but somehow MobileFrontend edits don't [22:38:32] I haven't tried to reproduce that though, all I did was confirm that the one user that people complained about was doing 100% of their edits through mobile web [22:38:51] (the complaint being, we put this user in the "flood" group but their edits aren't being marked with the bot flag) [22:39:11] FYI the "bot flag" is the rc_bot field in the recentchangse table [22:53:56] I can reproduce it [22:54:15] How does the hidebot flag work? Does it apply if any other filters exist on the edit? [22:54:32] https://reading-web-staging.wmflabs.org/w/index.php?title=Special:RecentChanges&hidebots=1 is showing "Bot edit" [22:54:36] which is tagged "mobile edit" [22:55:38] the code here seems pretty safe to me > https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/422d02fd6bcf673dba4e2121a54a267c20ce7521/includes/MobileFrontend.hooks.php#L570 [22:56:02] gonna dig a bit more and debug RecentChanges to see why it's not showing [22:57:39] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-extensions-PageCuration, 10Availability, 10Growth-Team (Current Sprint), and 3 others: PageTriage opens master connection on GET for ArticleMetadata cache misses - https://phabricator.wikimedia.org/T154719 (10Etonkovidova) 05Open>03Reso... [23:02:05] (03CR) 10Catrope: [C: 032] Update 'ptrp_deleted' when any of the deletion category is present [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/454646 (https://phabricator.wikimedia.org/T202582) (owner: 10Sbisson) [23:03:23] Yeah and https://reading-web-staging.wmflabs.org/w/index.php?title=Special:RecentChanges&hidebots=0 shows 4 bot edits while &hidebots=1 only shows the one [23:04:50] jdlrobson: Yeah I don't think the bug would be in the place where you register or apply the tasks, my guess is it's in whatever code glues the MF edit form to the MW core edit process [23:11:16] (03CR) 10Catrope: [C: 032] Show copyvio hint and link to report in feed (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [23:13:01] (03Merged) 10jenkins-bot: Update 'ptrp_deleted' when any of the deletion category is present [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/454646 (https://phabricator.wikimedia.org/T202582) (owner: 10Sbisson) [23:19:09] (03Merged) 10jenkins-bot: Show copyvio hint and link to report in feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [23:19:48] (03CR) 10jenkins-bot: Update 'ptrp_deleted' when any of the deletion category is present [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/454646 (https://phabricator.wikimedia.org/T202582) (owner: 10Sbisson) [23:26:37] (03CR) 10jenkins-bot: Show copyvio hint and link to report in feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson)