[00:09:26] (03Merged) 10jenkins-bot: Only update ptrp_reviewed_updated when the afc_state changes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453157 (https://phabricator.wikimedia.org/T201644) (owner: 10Sbisson) [00:09:30] (03Merged) 10jenkins-bot: Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 (owner: 10Sbisson) [00:10:53] (03CR) 10jenkins-bot: Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 (owner: 10Sbisson) [00:14:53] (03PS1) 10Catrope: Add an API module for tagging a revision as copyvio [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) [00:15:00] (03CR) 10jerkins-bot: [V: 04-1] Add an API module for tagging a revision as copyvio [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) (owner: 10Catrope) [00:15:03] (03CR) 10jerkins-bot: [V: 04-1] Add an API module for tagging a revision as copyvio [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) (owner: 10Catrope) [00:17:47] (03CR) 10jenkins-bot: Only update ptrp_reviewed_updated when the afc_state changes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453157 (https://phabricator.wikimedia.org/T201644) (owner: 10Sbisson) [00:24:44] (03CR) 10jenkins-bot: Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 (owner: 10Sbisson) [00:35:17] (03PS2) 10Catrope: Add an API module for tagging a revision as copyvio [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) [00:38:47] (03CR) 10jerkins-bot: [V: 04-1] Add an API module for tagging a revision as copyvio [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) (owner: 10Catrope) [00:48:05] (03PS3) 10Catrope: Add an API module for tagging a revision as copyvio [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) [03:01:46] (03PS1) 10Krinkle: cache: Reduce responsibility of subclass and remove unused parts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/453315 [03:03:10] (03CR) 10Krinkle: [C: 031] Migrate EchoLocalCache to MapCacheLRU (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452986 (owner: 10Aaron Schulz) [03:03:12] (03CR) 10Krinkle: [C: 031] "Fixed in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/453315/" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452986 (owner: 10Aaron Schulz) [03:05:39] (03CR) 10jerkins-bot: [V: 04-1] cache: Reduce responsibility of subclass and remove unused parts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/453315 (owner: 10Krinkle) [03:07:00] (03PS2) 10Krinkle: cache: Reduce responsibility of subclass and remove unused parts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/453315 [03:24:50] (03CR) 10jerkins-bot: [V: 04-1] cache: Reduce responsibility of subclass and remove unused parts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/453315 (owner: 10Krinkle) [03:25:46] (03CR) 10jerkins-bot: [V: 04-1] cache: Reduce responsibility of subclass and remove unused parts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/453315 (owner: 10Krinkle) [03:28:05] (03PS3) 10Krinkle: cache: Reduce responsibility of subclass and remove unused parts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/453315 [09:31:43] (03PS1) 10Umherirrender: Add tests/phan/issues to .gitignore [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453369 [10:00:51] (03CR) 10MarcoAurelio: [C: 032] Add tests/phan/issues to .gitignore [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453369 (owner: 10Umherirrender) [10:14:58] (03CR) 10Sbisson: "Looks good. 2 questions inline." (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) (owner: 10Catrope) [10:15:38] (03Merged) 10jenkins-bot: Add tests/phan/issues to .gitignore [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453369 (owner: 10Umherirrender) [10:20:41] (03CR) 10jenkins-bot: Add tests/phan/issues to .gitignore [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453369 (owner: 10Umherirrender) [10:36:13] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10TechCom-RFC, and 2 others: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607 (10Deskana) p:05Triage>03Lowest This seems out of scope of the annual plan, and the relevant teams have all d... [11:46:15] 10MediaWiki-Recent-changes, 10Collaboration-Community-Engagement, 10Growth-Team, 10Documentation: Review and update Help:Enhanced recent changes on Meta - https://phabricator.wikimedia.org/T181722 (10matej_suchanek) [11:46:59] 10MediaWiki-Recent-changes, 10Growth-Team, 10Documentation: Update documentation about enhanced changes after Wikidata is included - https://phabricator.wikimedia.org/T169119 (10matej_suchanek) [12:18:50] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): Use MediaWiki JavaScript API instead of custom code - https://phabricator.wikimedia.org/T202129 (10SBisson) [12:22:30] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10JavaScript, 10Technical-Debt: Use MediaWiki JavaScript API instead of custom code - https://phabricator.wikimedia.org/T202129 (10TheDJ) [12:35:25] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): Fix warning for unrecognized API params (mode, timestamp) - https://phabricator.wikimedia.org/T202131 (10SBisson) [12:37:36] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, and 2 others: PageCuration: Get rid of synchronous AJAX request on page load - https://phabricator.wikimedia.org/T68898 (10kostajh) @matmarex thanks for... [13:20:03] (03PS1) 10Sbisson: [WIP] Show copyvio hint and link to report in feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) [14:10:59] (03PS2) 10Sbisson: [WIP] Show copyvio hint and link to report in feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) [14:20:14] (03PS3) 10Sbisson: [WIP] Show copyvio hint and link to report in feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) [15:19:13] Follow-up question (from yesterday) regarding Extension:Echo... [15:19:26] Suppose I wanted to build an app that polls the API at regular intervals, checking for new notifications for the current user. [15:19:38] What would be the most efficient (i.e. easiest on the server) API call for doing this? [16:07:56] dbrant: I think something like that is as lightweight as it can be with the current api: https://en.wikipedia.org/w/api.php?action=query&meta=notifications¬prop=count&format=json [16:10:23] It gets notifications count for the current user, current wiki. You can add &filter=!read to check specifically for new (unread) notifications [16:12:39] dbrant: and you can add `¬crosswikisummary=1` to include notifications from all other wikis where the user account is recognized [16:13:31] Don't be fooled by the "not" prefix.. it's short for "notifications", it doesn't negate what follows ;) [16:23:19] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): Fix warning for unrecognized API params (mode, timestamp) - https://phabricator.wikimedia.org/T202131 (10MMiller_WMF) [16:23:35] stephanebisson: thanks! I also found "action=query&meta=unreadnotificationpages"... is one of them more preferable to the other? [16:23:47] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10JavaScript, 10Technical-Debt: Use MediaWiki JavaScript API instead of custom code - https://phabricator.wikimedia.org/T202129 (10MMiller_WMF) [16:37:52] dbrant: 'unreadnotificationpages' will return a list of pages so it does more work and the payload is bigger. I think what I posted above it better in terms of load. [16:48:45] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): New pages feed filter Nominated for deletion doesn't work - https://phabricator.wikimedia.org/T169244 (10SBisson) "Nominated for deletion" (as well as "Redirects") works by **excluding** those pages unless it is explicitly checked, in which c... [16:49:34] (03PS4) 10Sbisson: [WIP] Show copyvio hint and link to report in feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) [17:11:56] stephanebisson: good to know! thanks [17:12:38] dbrant: no prob. It's good to see notifications on mobile getting some attentions [19:15:12] stephanebisson: one more follow-up, if I may: [19:15:28] How would an API client determine whether there are any new notifications *since* a certain time? [19:15:41] I can see that there's a "seenTime" functionality in the API, but I can't figure out how to leverage it to check for new notifications in a lightweight way. [19:16:04] for instance, when looking at the desktop site, how does it know to give the notification inbox a red color, instead of gray? [19:17:25] dbrant: That's exactly what seenTime is for. When you open the popup, we assume that you have "seen" that you have notifications even if you don't open any. We set the seenTime then. [19:20:09] I need to go back and check how exactly you could use it... [19:23:50] Right, supposing I set the seenTime to the current time, i'd like to pass the seenTime back to the API to see if there are any new notifications since then. [19:30:18] dbrant: I don't think you can. You would have to request the top 1 notifications (newest) and seenTime and compare them. https://en.wikipedia.org/w/api.php?action=query&meta=notifications&format=json¬prop=list|seenTime¬limit=1 [19:32:30] stephanebisson: ah ok, that can work as a strategy [19:33:07] so the "first" notification returned by the API is guaranteed to be the latest? [19:37:17] dbrant: It's supposed to [20:37:22] (03PS4) 10Catrope: Add an API module for tagging a revision as copyvio [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) [20:37:27] (03CR) 10Catrope: Add an API module for tagging a revision as copyvio (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) (owner: 10Catrope) [20:38:54] (03PS5) 10Catrope: Add an API module for tagging a revision as copyvio [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453308 (https://phabricator.wikimedia.org/T202041) [20:53:24] (03CR) 10Catrope: [C: 04-1] "Looks good overall; comments about escaping inline" (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453399 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [21:00:31] 10MediaWiki-extensions-PageCuration, 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint): NPP - multiple-click on 'Refresh list' displays multiple spinning icons - https://phabricator.wikimedia.org/T201554 (10Catrope) a:03Catrope [21:11:13] (03PS13) 10Kosta Harlan: DBPerformance: Master connections and writes via POST not GET [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/446517 (https://phabricator.wikimedia.org/T154719) [21:11:22] (03CR) 10Kosta Harlan: DBPerformance: Master connections and writes via POST not GET (034 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/446517 (https://phabricator.wikimedia.org/T154719) (owner: 10Kosta Harlan) [21:29:07] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, and 2 others: PageCuration: Get rid of synchronous AJAX request on page load - https://phabricator.wikimedia.org/T68898 (10Etonkovidova) 05Open>03Reso... [22:00:37] (03CR) 10Catrope: [C: 04-1] DBPerformance: Master connections and writes via POST not GET (036 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/446517 (https://phabricator.wikimedia.org/T154719) (owner: 10Kosta Harlan) [22:32:20] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Notifications, 10Growth-Team, 10Documentation: Document technical aspects of cross-wiki notifications (for non MediaWiki-Vagrant users) - https://phabricator.wikimedia.org/T125728 (10srodlund) [22:37:20] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Delete rows for 'pagetriage-lastuse' preference - https://phabricator.wikimedia.org/T202175 (10Catrope) [22:38:58] (03CR) 10Catrope: [C: 04-1] DBPerformance: Master connections and writes via POST not GET (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/446517 (https://phabricator.wikimedia.org/T154719) (owner: 10Kosta Harlan) [22:39:47] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10JavaScript, 10Technical-Debt: Use MediaWiki JavaScript API instead of custom code - https://phabricator.wikimedia.org/T202129 (10Catrope) a:03kostajh [22:41:21] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10JavaScript, 10Technical-Debt: Use MediaWiki JavaScript API instead of custom code - https://phabricator.wikimedia.org/T202129 (10Catrope) a:05kostajh>03Catrope So it looks like @kostajh did part of this in https://gerrit.wikimedia.o... [22:46:14] 10Collaboration-Team-Archive-2015-2016, 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Documentation: Document new Echo formatting system - https://phabricator.wikimedia.org/T116612 (10srodlund) [22:53:13] 10Collaboration-Team-Triage, 10Notifications, 10Analytics, 10Analytics-EventLogging, and 6 others: Multiple MediaWiki hooks are not documented on mediawiki.org - https://phabricator.wikimedia.org/T157757 (10srodlund) [23:00:18] 10Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10CommRel-Documentation, 10Growth-Team, and 4 others: Create a general public documentation for Flow (tracking) - https://phabricator.wikimedia.org/T111367 (10srodlund) [23:00:44] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10Documentation, 10I18n: In Flow, "Moderation" and its derivatives need better documentation - https://phabricator.wikimedia.org/T94345 (10srodlund) [23:03:55] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Documentation: Document how much memory Echo needs - https://phabricator.wikimedia.org/T70632 (10srodlund) [23:26:03] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10Documentation: Make an on-wiki table of all details about Flow's entries in the feeds - https://phabricator.wikimedia.org/T109632 (10srodlund) [23:27:14] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10Documentation, 10Upstream: Help update the bot User:CommonsDelinker to enable editing Flow posts and boards - https://phabricator.wikimedia.org/T93650 (10srodlund) [23:37:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/453501 (owner: 10L10n-bot)