[00:03:54] (03CR) 10jenkins-bot: Migrate EchoLocalCache to MapCacheLRU [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452986 (owner: 10Aaron Schulz) [00:12:10] (03CR) 10jenkins-bot: Make use of inline {@see …} tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452307 (owner: 10Thiemo Kreuz (WMDE)) [00:16:10] (03Merged) 10jenkins-bot: Escape message used in html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452319 (owner: 10Umherirrender) [00:23:22] (03CR) 10jenkins-bot: Escape message used in html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452319 (owner: 10Umherirrender) [00:40:32] (03CR) 10Catrope: [C: 032] Make "@… array" type hints more specific [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452309 (owner: 10Thiemo Kreuz (WMDE)) [00:40:59] (03CR) 10Catrope: [C: 032] Use "false" as type hint in PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452313 (owner: 10Thiemo Kreuz (WMDE)) [00:47:48] (03CR) 10Catrope: [C: 04-1] Fix missing/mismatching type hints PHPDoc tags (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [00:57:45] (03Merged) 10jenkins-bot: Make "@… array" type hints more specific [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452309 (owner: 10Thiemo Kreuz (WMDE)) [01:00:41] (03Merged) 10jenkins-bot: Use "false" as type hint in PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452313 (owner: 10Thiemo Kreuz (WMDE)) [01:04:32] (03CR) 10jenkins-bot: Make "@… array" type hints more specific [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452309 (owner: 10Thiemo Kreuz (WMDE)) [01:10:20] (03CR) 10jenkins-bot: Use "false" as type hint in PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452313 (owner: 10Thiemo Kreuz (WMDE)) [07:06:53] (03CR) 10Thiemo Kreuz (WMDE): Fix missing/mismatching type hints PHPDoc tags (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [07:07:40] (03PS2) 10Thiemo Kreuz (WMDE): Fix missing/mismatching type hints PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 [07:08:23] (03CR) 10Thiemo Kreuz (WMDE): "I simply reverted the offending change in this patch, because it really has nothing to do with the underlying issue. See I7fd395a for furt" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [07:52:49] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Documentation, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0): OOUI tutorial migration - https://phabricator.wikimedia.org/T198845 (10Volker_E) @Hagarshilo I'd recommend opening one or several follow-up tasks f... [08:16:05] (03CR) 10Catrope: [C: 032] Fix missing/mismatching type hints PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [08:28:11] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Documentation, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0): OOUI tutorial migration - https://phabricator.wikimedia.org/T198845 (10Hagarshilo) [08:39:30] (03Merged) 10jenkins-bot: Fix missing/mismatching type hints PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [08:39:53] (03PS5) 10Umherirrender: Add phan-taint-check-plugin [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 [08:39:56] (03CR) 10Umherirrender: Add phan-taint-check-plugin (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 (owner: 10Umherirrender) [08:40:02] (03CR) 10Umherirrender: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 (owner: 10Umherirrender) [08:45:37] (03CR) 10jenkins-bot: Fix missing/mismatching type hints PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [08:46:52] (03PS6) 10Umherirrender: Add phan-taint-check-plugin [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 [08:46:59] (03CR) 10Umherirrender: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 (owner: 10Umherirrender) [08:47:32] (03CR) 10Umherirrender: Add phan-taint-check-plugin (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 (owner: 10Umherirrender) [12:57:14] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-extensions-PageCuration, 10Availability, 10Growth-Team (Current Sprint), and 2 others: PageTriage opens master connection on GET for ArticleMetadata cache misses - https://phabricator.wikimedia.org/T154719 (10kostajh) > Is it possible to j... [13:05:57] 10Collaboration-Team-Triage, 10Notifications, 10Community-Tech, 10Growth-Team, and 4 others: [Epic] Ping/notify user when username used in an edit summary - https://phabricator.wikimedia.org/T32750 (10Pipetricker) [13:15:55] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Notifications, 10Growth-Team, 10VisualEditor: Undo notification is not sent if the editor switches to the visual editor - https://phabricator.wikimedia.org/T185548 (10kostajh) a:05kostajh>03None Unassigning myself in case someone else wants to p... [13:47:27] (03PS1) 10Sbisson: Set default filters value for AfC [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453125 (https://phabricator.wikimedia.org/T200948) [13:57:26] (03PS1) 10Sbisson: Cleanup isReviewedSorting [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453133 (https://phabricator.wikimedia.org/T201373) [14:14:29] (03CR) 10Kosta Harlan: [C: 032] Cleanup isReviewedSorting [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453133 (https://phabricator.wikimedia.org/T201373) (owner: 10Sbisson) [14:32:21] (03Merged) 10jenkins-bot: Cleanup isReviewedSorting [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453133 (https://phabricator.wikimedia.org/T201373) (owner: 10Sbisson) [14:36:21] (03CR) 10jenkins-bot: Cleanup isReviewedSorting [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453133 (https://phabricator.wikimedia.org/T201373) (owner: 10Sbisson) [16:20:13] (03PS1) 10Sbisson: Only update ptrp_reviewed_updated when the afc_state changes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453157 (https://phabricator.wikimedia.org/T201644) [16:21:27] (03PS1) 10Sbisson: Fix random typos [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453158 [16:25:16] (03CR) 10jerkins-bot: [V: 04-1] Fix random typos [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453158 (owner: 10Sbisson) [16:28:41] (03CR) 10jerkins-bot: [V: 04-1] Fix random typos [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453158 (owner: 10Sbisson) [16:28:58] (03PS1) 10EBernhardson: [DNM] Test Jenkins [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453159 [16:38:12] (03CR) 10EBernhardson: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453159 (owner: 10EBernhardson) [16:42:14] (03PS2) 10Sbisson: Fix random typos [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453158 [16:42:53] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts - https://phabricator.wikimedia.org/T201253 (10Etonkovidova) 05Open>03Resolved Che... [16:53:52] 10MediaWiki-extensions-PageCuration, 10Notifications, 10MediaWiki-Core-Tests, 10Growth-Team (Current Sprint), and 2 others: Running Echo as dependency of PageTriage fails unit tests - https://phabricator.wikimedia.org/T201812 (10Etonkovidova) 05Open>03Resolved Checked - the most recent test run is ok... [17:07:59] (03CR) 10Kosta Harlan: [C: 032] Fix random typos [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453158 (owner: 10Sbisson) [17:14:02] (03CR) 10Kosta Harlan: [C: 032] Set default filters value for AfC [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453125 (https://phabricator.wikimedia.org/T200948) (owner: 10Sbisson) [17:17:03] (03PS1) 10Jdlrobson: Fix indentation in extension.json [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/453166 [17:17:18] (03CR) 10Jdlrobson: [C: 032] Do not use PNG for thanks button (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [17:17:24] (03Abandoned) 10EBernhardson: [DNM] Test Jenkins [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453159 (owner: 10EBernhardson) [17:22:09] (03Merged) 10jenkins-bot: Fix random typos [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453158 (owner: 10Sbisson) [17:32:39] (03Merged) 10jenkins-bot: Set default filters value for AfC [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453125 (https://phabricator.wikimedia.org/T200948) (owner: 10Sbisson) [17:34:59] (03CR) 10jenkins-bot: Fix random typos [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453158 (owner: 10Sbisson) [17:37:52] (03CR) 10VolkerE: [C: 032] Fix indentation in extension.json [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/453166 (owner: 10Jdlrobson) [17:37:54] (03CR) 10jenkins-bot: Fix random typos [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453158 (owner: 10Sbisson) [17:39:47] (03CR) 10jenkins-bot: Set default filters value for AfC [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453125 (https://phabricator.wikimedia.org/T200948) (owner: 10Sbisson) [17:56:25] (03Merged) 10jenkins-bot: Fix indentation in extension.json [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/453166 (owner: 10Jdlrobson) [18:10:44] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): New pages feed filter Nominated for deletion doesn't work - https://phabricator.wikimedia.org/T169244 (10JTannerWMF) [18:11:18] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Performance-Team (Radar), 10Wikimedia-log-errors: PageTriage performs unexpected db writes on GET request (TransactionProfiler warning from ArticleCompileProcessor) - https://phabricator.wikimedia.org/T199699 (10JTannerWMF) [18:43:15] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10Documentation: Document how to use MediaWiki:Echo-blacklist - https://phabricator.wikimedia.org/T187001 (10srodlund) [18:56:34] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): AfC: [minor] Make capitalization filters names consistent - https://phabricator.wikimedia.org/T200582 (10Etonkovidova) All seems to be fine with the capitalization (and handling filter selections display): {F25023353} [19:12:03] (03CR) 10Kosta Harlan: Only update ptrp_reviewed_updated when the afc_state changes (033 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453157 (https://phabricator.wikimedia.org/T201644) (owner: 10Sbisson) [19:26:57] (03PS2) 10Sbisson: Only update ptrp_reviewed_updated when the afc_state changes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453157 (https://phabricator.wikimedia.org/T201644) [19:27:00] (03CR) 10Sbisson: Only update ptrp_reviewed_updated when the afc_state changes (033 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453157 (https://phabricator.wikimedia.org/T201644) (owner: 10Sbisson) [19:29:46] (03PS1) 10Sbisson: Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 [19:29:53] (03CR) 10jerkins-bot: [V: 04-1] Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 (owner: 10Sbisson) [19:29:55] (03CR) 10jerkins-bot: [V: 04-1] Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 (owner: 10Sbisson) [19:38:15] (03PS2) 10Sbisson: Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 [20:04:18] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Performance-Team (Radar), 10Wikimedia-log-errors: PageTriage performs unexpected db writes on GET request (TransactionProfiler warning from ArticleCompileProcessor) - https://phabricator.wikimedia.org/T199699 (10SBisson) a:03kostajh [20:29:46] (03CR) 10Kosta Harlan: [C: 031] "Looks good! Thanks for making those changes. I'll leave it as +1 so Roan can look it over as well." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453157 (https://phabricator.wikimedia.org/T201644) (owner: 10Sbisson) [20:52:13] o/ [20:52:19] anyone around who is familiar with Extension:Echo? [20:52:51] probably [20:52:54] dbrant: what's up? [20:54:10] I'm using the API to get unread notifications, and when I specify `notwikis=*` it gives me all my notifications across all wikis, as expected... [20:54:23] But, if I want to get my list of *read* notifications, and specify `notwikis=*`, it doesn't seem to return notifications from all wikis. [20:54:29] is that expected? [20:55:20] IIRC we only show unread notifications from other wikis [20:55:30] and as a result, that's the only thing we track in the DB [20:55:43] ah, so it's not a bug then. [20:56:12] maybe there's a documentation bug? but I think that's what's expected [20:56:25] cool, just wanted to confirm. thanks! [20:59:28] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Documentation, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0): OOUI tutorial migration - https://phabricator.wikimedia.org/T198845 (10Hagarshilo) [21:09:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/453228 (owner: 10L10n-bot) [21:25:03] (03CR) 10Catrope: [C: 032] Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 (owner: 10Sbisson) [21:31:59] (03CR) 10Catrope: [C: 032] Only update ptrp_reviewed_updated when the afc_state changes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453157 (https://phabricator.wikimedia.org/T201644) (owner: 10Sbisson) [21:34:12] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), and 2 others: Remove preference "Show talk page message indicator in my toolbar" (echo-show-alert) - https://phabricator.wikimedia.org/T58845 (10Catrope) 05stalled>03Resolved [21:34:22] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Documentation, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0): OOUI tutorial migration - https://phabricator.wikimedia.org/T198845 (10Volker_E) 05Open>03Resolved 💯 [22:45:12] (03PS3) 10Catrope: Deliver HTML templates using ResourceLoader rather than API calls [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/449612 (https://phabricator.wikimedia.org/T68898) (owner: 10Bartosz Dziewoński) [22:47:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453246 (owner: 10L10n-bot) [22:48:13] (03CR) 10Catrope: [C: 032] Deliver HTML templates using ResourceLoader rather than API calls [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/449612 (https://phabricator.wikimedia.org/T68898) (owner: 10Bartosz Dziewoński) [22:56:02] (03Merged) 10jenkins-bot: Deliver HTML templates using ResourceLoader rather than API calls [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/449612 (https://phabricator.wikimedia.org/T68898) (owner: 10Bartosz Dziewoński) [23:10:55] 10Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10Growth-Team, 10StructuredDiscussions, 10Documentation: Create or gather interactive animations to illustrate how to use Flow features - https://phabricator.wikimedia.org/T130913 (10srodlund) [23:34:17] (03CR) 10jenkins-bot: Deliver HTML templates using ResourceLoader rather than API calls [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/449612 (https://phabricator.wikimedia.org/T68898) (owner: 10Bartosz Dziewoński) [23:45:33] (03CR) 10Jforrester: [C: 032] "…" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453157 (https://phabricator.wikimedia.org/T201644) (owner: 10Sbisson) [23:47:01] RoanKattouw: Did you want https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/453191 to land? Jenkins has lost track of it, but also it merge conflicts… [23:49:01] Yes I do [23:49:17] (03CR) 10Catrope: [C: 032] "Come on Jenkins" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 (owner: 10Sbisson) [23:49:28] RoanKattouw: That won't help without a manual rebase, I fear. [23:49:54] Hmph, OK [23:50:29] (03PS3) 10Catrope: Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 (owner: 10Sbisson) [23:50:43] Didn't get any conflicts locally [23:50:54] (03CR) 10Catrope: [C: 032] Revert "Show copyvio scores in Special:NewPagesFeed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453191 (owner: 10Sbisson)