[00:09:57] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10Growth-Team, 10StructuredDiscussions, 10Mobile: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set" - https://phabricator.wikimedia.org/T191442 (10Mh-3110) a:03Mh-3110 [03:26:04] (03PS3) 10Legoktm: Remove $wgEchoNewMsgAlert and 'echo-show-alert' preference [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) [03:30:22] (03CR) 10Legoktm: "PS3: Rebased." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) (owner: 10Legoktm) [07:18:19] (03PS1) 10Thiemo Kreuz (WMDE): Make use of inline {@see …} tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452307 [07:22:15] (03PS1) 10Thiemo Kreuz (WMDE): Remove two unused properties from AttributeManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 [07:27:42] (03PS1) 10Thiemo Kreuz (WMDE): Make "@… array" type hints more specific [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452309 [07:29:47] (03PS1) 10Thiemo Kreuz (WMDE): Add missing newlines before "use" sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452310 [07:31:30] (03PS1) 10Thiemo Kreuz (WMDE): Add missing strict "array" type hints to DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452311 [07:33:23] (03PS1) 10Thiemo Kreuz (WMDE): Use "false" as type hint in PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452313 [07:35:33] (03PS1) 10Thiemo Kreuz (WMDE): Fix missing/mismatching type hints PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 [08:23:56] (03PS1) 10Umherirrender: Escape message used in html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452319 [08:51:30] (03CR) 10Umherirrender: [C: 032] Add missing newlines before "use" sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452310 (owner: 10Thiemo Kreuz (WMDE)) [09:14:01] (03Merged) 10jenkins-bot: Add missing newlines before "use" sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452310 (owner: 10Thiemo Kreuz (WMDE)) [09:15:26] 10MediaWiki-extensions-PageCuration, 10Notifications, 10Growth-Team, 10MediaWiki-Core-Tests: Running Echo as dependency of PageTriage fails unit tests - https://phabricator.wikimedia.org/T201812 (10Umherirrender) [09:15:34] (03CR) 10Umherirrender: "Created T201812 for the failure" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/444345 (owner: 10Umherirrender) [09:20:00] (03CR) 10jenkins-bot: Add missing newlines before "use" sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452310 (owner: 10Thiemo Kreuz (WMDE)) [10:48:54] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts - https://phabricator.wikimedia.org/T201253 (10SBisson) @Etonkovidova it is NOT the de... [10:52:33] (03PS1) 10Sbisson: Fix indentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452338 (https://phabricator.wikimedia.org/T201070) [11:46:22] (03CR) 10Umherirrender: [C: 032] Fix indentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452338 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [11:56:18] (03Merged) 10jenkins-bot: Fix indentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452338 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [12:19:48] (03CR) 10jenkins-bot: Fix indentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452338 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [12:28:19] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10OOUI, 10Documentation, 10Patch-For-Review: OOUI tutorial migration - https://phabricator.wikimedia.org/T198845 (10Hagarshilo) [13:53:08] 10MediaWiki-extensions-PageCuration, 10Notifications, 10MediaWiki-Core-Tests, 10Growth-Team (Current Sprint): Running Echo as dependency of PageTriage fails unit tests - https://phabricator.wikimedia.org/T201812 (10SBisson) [13:53:25] 10MediaWiki-extensions-PageCuration, 10Notifications, 10MediaWiki-Core-Tests, 10Growth-Team (Current Sprint): Running Echo as dependency of PageTriage fails unit tests - https://phabricator.wikimedia.org/T201812 (10SBisson) a:03SBisson [13:55:45] (03PS1) 10Sbisson: Check for irrelevant rc_types first in hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452364 (https://phabricator.wikimedia.org/T201812) [15:24:44] (03CR) 10Krinkle: Use "false" as type hint in PHPDoc tags (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452313 (owner: 10Thiemo Kreuz (WMDE)) [15:31:18] (03PS2) 10Thiemo Kreuz (WMDE): Use "false" as type hint in PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452313 [15:32:57] (03CR) 10Krinkle: Fix missing/mismatching type hints PHPDoc tags (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [15:33:48] (03CR) 10Krinkle: Fix missing/mismatching type hints PHPDoc tags (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [15:33:57] (03CR) 10Krinkle: [C: 031] Add missing strict "array" type hints to DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452311 (owner: 10Thiemo Kreuz (WMDE)) [16:37:40] (03PS4) 10Paladox: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 [16:37:44] (03PS5) 10Paladox: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 [16:38:43] (03CR) 10Paladox: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 (owner: 10Paladox) [17:15:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 (owner: 10Paladox) [17:36:55] (03Merged) 10jenkins-bot: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 (owner: 10Paladox) [17:46:55] (03CR) 10jenkins-bot: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 (owner: 10Paladox) [17:50:13] (03PS1) 10Paladox: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] (REL1_31) - 10https://gerrit.wikimedia.org/r/452430 [18:16:54] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts - https://phabricator.wikimedia.org/T201253 (10Catrope) @SBisson ARGH you're right, I... [18:17:15] (03PS1) 10Catrope: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 [18:17:31] (03PS2) 10Catrope: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 [18:17:35] (03CR) 10Catrope: [C: 032] Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 (owner: 10Catrope) [18:17:41] (03Restored) 10Catrope: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [18:17:48] (03PS2) 10Catrope: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [18:17:52] (03CR) 10Catrope: [C: 032] Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [18:19:51] (03CR) 10Catrope: [C: 032] Check for irrelevant rc_types first in hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452364 (https://phabricator.wikimedia.org/T201812) (owner: 10Sbisson) [18:46:54] (03Merged) 10jenkins-bot: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 (owner: 10Catrope) [18:46:56] (03Merged) 10jenkins-bot: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [18:47:07] (03Merged) 10jenkins-bot: Check for irrelevant rc_types first in hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452364 (https://phabricator.wikimedia.org/T201812) (owner: 10Sbisson) [18:55:25] (03CR) 10jenkins-bot: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 (owner: 10Catrope) [18:57:07] (03CR) 10jerkins-bot: [V: 04-1] Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] (REL1_31) - 10https://gerrit.wikimedia.org/r/452430 (owner: 10Paladox) [18:57:36] (03CR) 10Paladox: "recheck" [extensions/Echo] (REL1_31) - 10https://gerrit.wikimedia.org/r/452430 (owner: 10Paladox) [19:01:30] 10Collaboration-Team-Triage, 10Notifications, 10Availability (MediaWiki-MultiDC), 10Growth-Team (Current Sprint), and 2 others: Update Echo's caching strategy for multi-dc compatibility - https://phabricator.wikimedia.org/T164860 (10Catrope) 05Open>03Resolved >>! In T164860#4495353, @aaron wrote: > Can... [19:18:13] (03CR) 10jenkins-bot: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [19:32:07] (03CR) 10jenkins-bot: Check for irrelevant rc_types first in hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452364 (https://phabricator.wikimedia.org/T201812) (owner: 10Sbisson) [19:38:07] 10Collaboration-Team-Triage, 10Notifications, 10Availability (MediaWiki-MultiDC), 10Growth-Team (Current Sprint), and 2 others: Update Echo's caching strategy for multi-dc compatibility - https://phabricator.wikimedia.org/T164860 (10Krinkle) [19:38:14] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-extensions-PageCuration, 10Availability, 10Growth-Team (Current Sprint), and 2 others: PageTriage opens master connection on GET for ArticleMetadata cache misses - https://phabricator.wikimedia.org/T154719 (10Krinkle) [19:50:16] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts - https://phabricator.wikimedia.org/T201253 (10Catrope) >>! In T201253#4495808, @Etonk... [19:52:46] (03CR) 10jenkins-bot: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 (owner: 10Catrope) [20:03:06] (03CR) 10jenkins-bot: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [20:09:45] RoanKattouw: Review on https://gerrit.wikimedia.org/r/c/oojs/ui/+/450612 might be good? [21:17:40] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Documentation, 10OOUI (OOUI-0.28.0), 10Patch-For-Review: OOUI tutorial migration - https://phabricator.wikimedia.org/T198845 (10Volker_E) [21:33:28] (03PS1) 10Fomafix: Use ContentLanguage service instead of global $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452570 [21:39:18] (03PS1) 10Fomafix: Replace deprecated Linker::link() with LinkRenderer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452571 (https://phabricator.wikimedia.org/T149346) [21:54:55] 10MediaWiki-extensions-PageCuration, 10Growth-Team: New pages feed filter Nominated for deletion doesn't work - https://phabricator.wikimedia.org/T169244 (10MMiller_WMF) This was brought up again in community testing related to [[ https://phabricator.wikimedia.org/T193782 | this project ]]. Moving to Growth t... [22:22:53] (03CR) 10Legoktm: [C: 032] Replace deprecated Linker::link() with LinkRenderer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452571 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [22:25:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452528 (owner: 10L10n-bot) [22:40:30] 10MediaWiki-extensions-PageCuration, 10Growth-Team: [betalabs] Special:NewPagesFeed not updated - https://phabricator.wikimedia.org/T201661 (10Etonkovidova) 05Open>03Resolved a:03Etonkovidova Closed as Resolved with the patch from T201253 in place. [22:49:01] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts - https://phabricator.wikimedia.org/T201253 (10Etonkovidova) 05Open>03Resolved Yes... [22:53:32] (03Merged) 10jenkins-bot: Replace deprecated Linker::link() with LinkRenderer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452571 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [23:00:53] (03CR) 10Jforrester: [C: 032] Use ContentLanguage service instead of global $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452570 (owner: 10Fomafix) [23:26:43] (03CR) 10jenkins-bot: Replace deprecated Linker::link() with LinkRenderer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452571 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [23:39:28] (03Merged) 10jenkins-bot: Use ContentLanguage service instead of global $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452570 (owner: 10Fomafix) [23:49:06] (03CR) 10jenkins-bot: Use ContentLanguage service instead of global $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452570 (owner: 10Fomafix) [23:59:43] (03CR) 10Jforrester: "> Patch Set 1: Code-Review-2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) (owner: 10Legoktm)