[00:09:22] (03CR) 10jenkins-bot: Use mw.track() to submit EventLogging data client-side [extensions/Echo] - 10https://gerrit.wikimedia.org/r/448099 (owner: 10Legoktm) [00:18:47] (03Merged) 10jenkins-bot: Show copyvio scores in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451318 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [00:27:50] (03CR) 10jenkins-bot: Remove $wgEchoEventLoggingSchemas qunit hack [extensions/Echo] - 10https://gerrit.wikimedia.org/r/448101 (https://phabricator.wikimedia.org/T118488) (owner: 10Legoktm) [00:33:20] (03CR) 10jenkins-bot: Move ext.echo.logger module registration to extension.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/448100 (owner: 10Legoktm) [00:37:32] (03CR) 10jenkins-bot: Show copyvio scores in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451318 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [01:04:33] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: NewPagesFeed in AFC mode shows each page 4 times when all four "predicted issues" checkboxes are checked - https://phabricator.wikimedia.org/T201560 (10Et... [01:24:15] 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)): new Wikimania wiki is credited as "Wikipedia" in notifications - https://phabricator.wikimedia.org/T201012 (10Etonkovidova) For https://wikimania.wikimedia.org all notifications still refer to as... [01:29:50] 10MediaWiki-Recent-changes, 10Growth-Team: Put RCFilters i18n messages and other config in a ResourceLoader data module - https://phabricator.wikimedia.org/T201574 (10Catrope) [09:26:55] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team: Create a global Talk page filter - https://phabricator.wikimedia.org/T201520 (10Trizek-WMF) >>! In T201520#4490223, @Timeshifter wrote: > I would like 2 global talk page filters for watchlists. One for the latest revision on the most recent day. >... [09:53:40] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Design: Explore how to make filters more compact - https://phabricator.wikimedia.org/T201443 (10Trizek-WMF) I haven't really thought about the order of the buttons. :) Anyway, the request is to have the most compacted design as possible. That's... [11:32:58] 10Collaboration-Team-Triage, 10Maps, 10VisualEditor, 10User-Ryasmeen: Map preview is not loading in VE - https://phabricator.wikimedia.org/T190892 (10Deskana) 05Open>03Resolved a:03Deskana The 400 isn't happening any more, although the map is blank. As far as I know, for performance reasons, only ver... [12:54:08] (03PS22) 10VolkerE: Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [12:54:15] (03CR) 10VolkerE: [C: 032] Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [12:56:06] (03CR) 10VolkerE: [C: 032] "It's mostly 'mediawiki.ui' through our code, let's stay with that. Otherwise looks good!" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [13:10:14] (03CR) 10jerkins-bot: [V: 04-1] Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [13:17:54] (03CR) 10jerkins-bot: [V: 04-1] Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [14:19:49] (03PS4) 10Krinkle: Clean up EventLogging integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/448102 (owner: 10Legoktm) [14:19:54] (03CR) 10Krinkle: [C: 031] "Oops :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/448102 (owner: 10Legoktm) [16:47:02] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Design: Explore how to make filters more compact - https://phabricator.wikimedia.org/T201443 (10Cirdan) ([[https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#Neue_Seiten|This topic came up on dewiki a couple of days ago]]. If you are l... [17:07:49] 10Thanks, 10Growth-Team, 10phan-taint-check-plugin: Phan error inside ThanksLogFormatter - https://phabricator.wikimedia.org/T201565 (10Umherirrender) The taint was set with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/444452/ [17:13:21] (03PS23) 10Jdlrobson: Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) [17:13:31] (03CR) 10Jdlrobson: [C: 032] Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [17:32:42] (03CR) 10jerkins-bot: [V: 04-1] Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [17:34:39] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10VisualEditor, and 3 others: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters - https://phabricator.wikimedia.org/T85093 (10matmarex) If you want to test this and can't easily insert combining c... [17:34:55] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10VisualEditor, and 3 others: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters - https://phabricator.wikimedia.org/T85093 (10matmarex) [17:46:52] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Accessibility: Buttons in FilterMenuHeaderWidget like “Highlight results“ are not keyboard accessible - https://phabricator.wikimedia.org/T191860 (10MMiller_WMF) [17:48:02] 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Growth-Team, 10Technical-Debt: Clean up RCFilters preference tech debt once watchlist is out of beta - https://phabricator.wikimedia.org/T196033 (10MMiller_WMF) [17:48:10] (03CR) 10jerkins-bot: [V: 04-1] Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [17:50:43] 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Accessibility: Show last 250 changes and period selection dropdowns are not keyboard accessible - https://phabricator.wikimedia.org/T174819 (10MMiller_WMF) [17:52:36] (03CR) 10Catrope: "> Patch Set 7:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/442982 (owner: 10Catrope) [17:53:57] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Beta-Cluster-reproducible: [betalabs]: Page triage: "Uncaught TypeError: Cannot read property 'getLogPageTitle' of undefined" for 'Redirects for discussion' - https://phabricator.wikimedia.org/T196954 (10MMiller_WMF) [17:54:55] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Beta-Cluster-reproducible: [betalabs]: Page triage: "Uncaught TypeError: Cannot read property 'getLogPageTitle' of undefined" for 'Redirects for discussion' - https://phabricator.wikimedia.org/T196954 (10MMiller_WMF) Since we don't think this issue exists... [17:56:28] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Patch-For-Review, 10Performance, 10Technical-Debt: PageCuration: Get rid of synchronous AJAX request on page load - https://phabricator.wikimedia.org/T68898 (10MMiller_WMF) [17:56:59] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Performance, 10Technical-Debt: PageCuration: Get rid of synchronous AJAX request on page load - https://phabricator.wikimedia.org/T68898 (10MMiller_WMF) [18:08:28] 10Thanks, 10phan-taint-check-plugin, 10Growth-Team (Current Sprint): Phan error inside ThanksLogFormatter - https://phabricator.wikimedia.org/T201565 (10JTannerWMF) [18:20:52] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): AfC: [minor] Make capitalization filters names consistent - https://phabricator.wikimedia.org/T200582 (10MMiller_WMF) [18:22:48] 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10VisualEditor, and 3 others: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters - https://phabricator.wikimedia.org/T85093 (10matmarex) [18:24:31] (03CR) 10Krinkle: [C: 032] NotificationMapper: Use batching in deleteByUserEventOffset() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/442982 (owner: 10Catrope) [18:24:56] (03CR) 10Krinkle: [C: 032] "Fair :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/442982 (owner: 10Catrope) [18:52:08] (03Merged) 10jenkins-bot: NotificationMapper: Use batching in deleteByUserEventOffset() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/442982 (owner: 10Catrope) [18:54:44] 10Thanks, 10phan-taint-check-plugin, 10Growth-Team (Current Sprint): Phan error inside ThanksLogFormatter - https://phabricator.wikimedia.org/T201565 (10pmiazga) Very similar construct has also the [[ https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/includes/logging/NewsletterLogForma... [18:55:25] 10Thanks, 10phan-taint-check-plugin, 10Growth-Team (Current Sprint): Phan error inside ThanksLogFormatter - https://phabricator.wikimedia.org/T201565 (10Jdlrobson) p:05Triage>03High This is blocking merges in Thanks right now. I'm not 100% sure what this issue is about, but it appears to be a pre-existin... [19:01:30] (03CR) 10jenkins-bot: NotificationMapper: Use batching in deleteByUserEventOffset() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/442982 (owner: 10Catrope) [19:44:11] 10Thanks, 10phan-taint-check-plugin, 10Growth-Team (Current Sprint): Phan error inside ThanksLogFormatter - https://phabricator.wikimedia.org/T201565 (10Bawolff) Im on vacation right now but will look into what the cause is when i get back in a couple days. It may just be a bug in the plugin. In the mean whi... [21:08:03] 10Notifications, 10Community-Tech, 10Growth-Team, 10MediaWiki-extensions-CodeMirror, and 5 others: WikiEditor toolbar overlaps Notifications flyout in Timeless and Modern skins - https://phabricator.wikimedia.org/T200148 (10Amorymeltzer) @Isarra Thanks for fixing this! I first noticed this as it affected... [21:16:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451741 (owner: 10L10n-bot) [21:28:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/451744 (owner: 10L10n-bot) [21:30:45] 10MediaWiki-Recent-changes, 10Core-Platform-Team, 10Growth-Team, 10Wikimedia-log-errors: SpecialRecentChangesLinked::doMainQuery blocking database infrastructure - https://phabricator.wikimedia.org/T134976 (10Krinkle) [21:33:29] (03CR) 10Catrope: "Thanks! could you also re-review my original change, the one on top of this one? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Ech" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/442982 (owner: 10Catrope) [21:34:42] (03CR) 10Catrope: [C: 032] Clean up EventLogging integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/448102 (owner: 10Legoktm) [21:40:30] (03PS7) 10Krinkle: NotifUser: Remove basically-unused talk notification cache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436697 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [21:54:38] (03Merged) 10jenkins-bot: Clean up EventLogging integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/448102 (owner: 10Legoktm) [22:10:34] 10Thanks, 10phan-taint-check-plugin, 10Growth-Team (Current Sprint): Phan error inside ThanksLogFormatter - https://phabricator.wikimedia.org/T201565 (10Catrope) This is strange. The offending code in ThanksLogFormatter is: ```lang=php protected function getMessageParameters() { $params = parent::getMess... [22:13:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451762 (owner: 10L10n-bot) [22:19:01] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Technical-Debt: Get rid of wgEchoConfig hack for qunit tests - https://phabricator.wikimedia.org/T118488 (10Krinkle) 05Open>03Resolved a:03Legoktm [22:20:57] (03CR) 10Catrope: [C: 032] Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [22:32:09] (03CR) 10jenkins-bot: Clean up EventLogging integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/448102 (owner: 10Legoktm) [22:33:23] 10Thanks, 10Growth-Team, 10phan-taint-check-plugin: Phan error inside ThanksLogFormatter - https://phabricator.wikimedia.org/T201565 (10Catrope) Now that seccheck is non-voting, this no longer blocks merges in Thanks. [22:36:49] (03CR) 10Krinkle: "Sorry if we already covered this, and remind me if I was previously convinced otherwise, but it seems like this would start allowing an UP" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436697 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [22:37:27] (03Merged) 10jenkins-bot: Do not use PNG for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [22:39:33] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team, 10Patch-For-Review, and 2 others: Upgrade Thanks icon - https://phabricator.wikimedia.org/T198151 (10Jdlrobson) [22:40:09] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team, 10Readers-Web-Backlog, and 3 others: Upgrade Thanks icon - https://phabricator.wikimedia.org/T198151 (10Jdlrobson) An old patch got merged so adding to the kanbana board to go through our process. @alexhollender assigning to you for design review. [22:40:21] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team, 10Readers-Web-Backlog, and 3 others: Upgrade Thanks icon - https://phabricator.wikimedia.org/T198151 (10Jdlrobson) a:03alexhollender [22:41:48] 10Collaboration-Team-Triage, 10Notifications, 10Growth-Team, 10MediaWiki-Page-editing: Consider throttling edit summary Mention notifications - https://phabricator.wikimedia.org/T186658 (10Niharika) [22:42:48] 10Collaboration-Team-Triage, 10Thanks, 10Growth-Team, 10Readers-Web-Backlog, and 3 others: Upgrade Thanks icon - https://phabricator.wikimedia.org/T198151 (10Jdlrobson) [23:28:27] (03CR) 10Catrope: "> Sorry if we already covered this, and remind me if I was previously convinced otherwise, but it seems like this would start allowing an " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436697 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [23:34:10] (03PS8) 10Catrope: NotifUser: Remove basically-unused talk notification cache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436697 (https://phabricator.wikimedia.org/T164860) [23:34:12] (03PS1) 10Catrope: UserNotificationGateway: Use batching in markRead() and markUnread() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451812 [23:34:37] (03CR) 10Catrope: "> That said, 2k isn't exactly an ideal batch size, so it'd probably be a good idea to make the markRead() method perform a batched UPDATE." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436697 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope)