[00:21:06] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist: Changes shifted down on Special:RecentChanges and Special:Watchlist - https://phabricator.wikimedia.org/T198440 (10GeoffreyT2000) [00:49:49] (03CR) 10Samwilson: [C: 032] "I wasn't able to replicate this bug, but this looks good to me and works in testing." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442995 (https://phabricator.wikimedia.org/T195924) (owner: 10Mooeypoo) [01:05:46] (03PS1) 10Samwilson: Only set afc mode if Draft namespace is defined [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443015 [01:10:36] (03CR) 10jerkins-bot: [V: 04-1] Only set afc mode if Draft namespace is defined [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443015 (owner: 10Samwilson) [01:17:10] (03CR) 10Samwilson: [C: 031] "I guess it'd be nicer if the reviewed/unreviewed checkboxes were radio buttons, given that with this patch that is now how they behave (ex" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442980 (https://phabricator.wikimedia.org/T198364) (owner: 10Mooeypoo) [01:55:32] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist: Changes shifted down on Special:RecentChanges and Special:Watchlist - https://phabricator.wikimedia.org/T198440 (10Xaosflux) Couldn't replicate this on enwiki under any skin with Firefox or Chrome [01:59:38] (03Merged) 10jenkins-bot: Verify is_draft exists before checking its value in underscore [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442995 (https://phabricator.wikimedia.org/T195924) (owner: 10Mooeypoo) [02:01:24] (03CR) 10jenkins-bot: Verify is_draft exists before checking its value in underscore [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442995 (https://phabricator.wikimedia.org/T195924) (owner: 10Mooeypoo) [02:46:53] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Daybeers) [03:07:19] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist: Changes shifted down on Special:RecentChanges and Special:Watchlist - https://phabricator.wikimedia.org/T198440 (10JJMC89) I noticed this on Wikitech earlier today when my watchlist updated (live updates on). Refreshing the page fixed the issue. I haven't enco... [03:38:08] (03CR) 10Mooeypoo: "> I guess it'd be nicer if the reviewed/unreviewed checkboxes were" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442980 (https://phabricator.wikimedia.org/T198364) (owner: 10Mooeypoo) [03:58:09] (03PS3) 10Samwilson: Add maintenance script to backfull Draft NS pages in the triage queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442777 (https://phabricator.wikimedia.org/T196181) [04:03:04] (03CR) 10jerkins-bot: [V: 04-1] Add maintenance script to backfull Draft NS pages in the triage queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442777 (https://phabricator.wikimedia.org/T196181) (owner: 10Samwilson) [04:03:42] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Daybeers) [04:36:20] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist: Changes shifted down on Special:RecentChanges and Special:Watchlist - https://phabricator.wikimedia.org/T198440 (10Catrope) I think this is because the highlight container divs (added by {T198139}) have no CSS rules hiding them in the old UI (non-RCFilters mod... [04:41:52] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist: Changes shifted down on Special:RecentChanges and Special:Watchlist - https://phabricator.wikimedia.org/T198440 (10Catrope) Also note they're set to `display: inline-block` by the RCFilters CSS, but that doesn't load with RCFilters disabled of course. [04:50:11] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Patch-For-Review: Changes shifted down on Special:RecentChanges and Special:Watchlist - https://phabricator.wikimedia.org/T198440 (10Catrope) >>! In T198440#4323808, @gerritbot wrote: > Change 443019 had a related patch set uploaded (by Catrope; owner: Cat... [04:53:34] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Patch-For-Review: Changes shifted down on Special:RecentChanges and Special:Watchlist - https://phabricator.wikimedia.org/T198440 (10JJMC89) >>! In T198440#4323802, @Catrope wrote: > I think this is because the highlight container divs (added by {T198139})... [08:36:47] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Aklapper) 05Open>03stalled Hi @Daybeers, thanks for taking the time to report this and welcome to Phabricator! Unfortunately this report lacks some information. Please follow https://www.mediawiki.org/wiki/How_to_rep... [12:53:19] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Daybeers) [12:59:47] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Daybeers) [12:59:55] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Daybeers) @Aklapper that's because I'm using the improved Watchlist interface, which you can get to by following the steps above. [13:08:39] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Daybeers) [13:21:55] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10kostajh) @Daybeers thank you for filing this report and for the detailed steps to reproduce. This is likely a side effect from the work we we deployed for T197168. I'll look into this today. [13:22:14] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10kostajh) a:03kostajh [15:16:09] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-API, 10Pywikibot-General, and 2 others: Determine source of notifications API change - https://phabricator.wikimedia.org/T138690 (10Aklapper) [15:40:34] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Patch-For-Review: Changes shifted down on Special:RecentChanges and Special:Watchlist - https://phabricator.wikimedia.org/T198440 (10matmarex) Please, folks, always include a screenshot. I couldn't reproduce this at first because I had enhanced RC enabled... [15:54:03] 10Collaboration-Team-Triage: [wmf.10-regression] Watchlist with filters does not display bullet points - https://phabricator.wikimedia.org/T198496 (10Etonkovidova) [15:54:32] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10kostajh) a:05kostajh>03Mooeypoo @Mooeypoo assigning the task to you as you're working on the patch. [15:59:51] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10GeoffreyT2000) [15:59:59] 10Collaboration-Team-Triage: [wmf.10-regression] Watchlist with filters does not display bullet points - https://phabricator.wikimedia.org/T198496 (10matmarex) [16:01:04] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10matmarex) 05stalled>03Open [16:03:04] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Mooeypoo) >>! In T198445#4325599, @kostajh wrote: > @Mooeypoo assigning the task to you as you're working on the patch. Yup, I'm working on it now. Found the culprit, cleaning it up and testing, will have the patch up soon. [16:03:12] MatmaRex: thanks for adding those screenshots and reviewing the patch [16:03:28] 10MediaWiki-Watchlist: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Etonkovidova) [16:03:32] 10Collaboration-Team-Triage: [wmf.10-regression] Watchlist with filters does not display bullet points - https://phabricator.wikimedia.org/T198496 (10Etonkovidova) [16:04:29] kostajh: no problem, i happen to be one of the few people to run Windows on my machine, so that's easy to do [16:06:22] MatmaRex: cool. While we're on the topic, I'd be interested to see your performance trace on the watchlist if you have a few minutes (https://phabricator.wikimedia.org/T197168, see the "Send us your performance traces" heading for what we're looking for) [16:09:57] kostajh: sure, which browser? (both?) [16:10:10] MatmaRex: probably Chrome is the easiest, thanks [16:24:01] kostajh: sent [16:34:01] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Patrolling, 10Regression: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10JJMC89) This might have a similar cause to {T198449}. [16:34:59] MatmaRex: got it, thanks! [17:38:22] kaldari: The speed fixes we were working on are in production. We need before and after comparisons, so please redo your test(s) and send the profile to Kosta. Thanks The results so far (and your link if you need to get it conveniently) are here, FYI: [17:38:22] https://docs.google.com/spreadsheets/d/13fzHcWGSwGktJMGE8SQWVzOCN6fDmYNiQVo_6V21Ye8/edit?usp=sharing [17:49:40] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Patrolling, 10Multi-Content-Revisions (MCR-SDC phase 1), 10Regression: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10daniel) I'll have a look... [17:49:51] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Patrolling, 10Multi-Content-Revisions (MCR-SDC phase 1), 10Regression: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10daniel) a:03daniel [17:55:56] jmatazzoni_: cool, I'll redo my profling [18:16:41] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Patrolling, 10Multi-Content-Revisions (MCR-SDC phase 1), 10Regression: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10MusikAnimal) This //migh... [18:37:10] (03PS1) 10MusikAnimal: Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) [18:37:29] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Patrolling, 10Multi-Content-Revisions (MCR-SDC phase 1), and 2 others: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10MusikAnimal) a:05daniel>... [18:37:44] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Patrolling, 10Community-Tech-Sprint, and 3 others: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10MusikAnimal) [18:37:54] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Patrolling, 10Community-Tech-Sprint, and 2 others: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10MusikAnimal) [18:42:15] (03CR) 10jerkins-bot: [V: 04-1] Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [18:45:11] 10Collaboration-Team-Triage, 10Notifications, 10Timeless, 10Patch-For-Review: Timeless: In mobile view, Echo callout displays whitespace instead of notifications - https://phabricator.wikimedia.org/T197064 (10Etonkovidova) [18:48:47] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters: [testwiki- wmf.9] - Watchlist ext-wpb-pagebanner-subtitle is present with beta feature filters enabled - https://phabricator.wikimedia.org/T197904 (10Etonkovidova) 05Open>03Invalid Re-checked - not happ... [18:49:00] (03CR) 10MusikAnimal: "FYI the above failure is from an unrelated flaky test. I'm working on a new test case for this patch, though" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [18:50:46] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters: [testwiki- wmf.9] - Watchlist ext-wpb-pagebanner-subtitle is present with beta feature filters enabled - https://phabricator.wikimedia.org/T197904 (10Etonkovidova) 05Invalid>03Open [18:51:41] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: [testwiki- wmf.9] - Watchlist ext-wpb-pagebanner-subtitle is present with beta feature filters enabled - https://phabricator.wikimedia.org/T197904 (10Etonkovidova) [18:56:32] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-Watchlist, 10Patch-For-Review: Markers not appearing - https://phabricator.wikimedia.org/T198445 (10Mooeypoo) [18:59:49] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Patrolling, 10Community-Tech-Sprint, and 2 others: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10MMiller_WMF) We realized that this problem was... [19:01:03] (03PS2) 10MusikAnimal: Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) [19:03:26] (03CR) 10jerkins-bot: [V: 04-1] Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [19:07:10] (03CR) 10jerkins-bot: [V: 04-1] Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [19:07:45] (03PS3) 10MusikAnimal: Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) [19:08:16] (03CR) 10MusikAnimal: "This change is ready for review." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [19:33:04] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review, 10Performance: Fix slow Watchlist load and interaction times - https://phabricator.wikimedia.org/T197168 (10Etonkovidova) [19:33:06] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review, 10Performance: Prevent updateInputSize() in mw.rcfilters.ui.FilterTagMultiselectWidget - https://phabricator.wikimedia.org/T198140 (10Etonkovidova) 05Open>03Resolved [20:02:36] (03CR) 10Mooeypoo: [C: 04-1] Fix setting of reviewed state based on autopatrol permission (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [20:10:54] (03PS4) 10MusikAnimal: Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) [20:22:01] (03CR) 10MusikAnimal: "Related I9e48f7c00efbce8c2de3f5db3a74462d47ae8f64" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [20:38:22] (03CR) 10Mooeypoo: [C: 032] Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [20:39:57] 10MediaWiki-Watchlist: Watchlist bullets missing colors - https://phabricator.wikimedia.org/T198513 (10AfroThundr3007730) [20:43:10] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-Watchlist: Watchlist bullets missing colors - https://phabricator.wikimedia.org/T198513 (10Mooeypoo) Hmm. This is odd, but it seems to be the same problem as {T198445}. I can't reproduce this exact effect to test if that patch fixes it, but ju... [20:43:27] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-Watchlist: Watchlist bullets missing colors - https://phabricator.wikimedia.org/T198513 (10Mooeypoo) a:03Mooeypoo [21:02:33] (03CR) 10jerkins-bot: [V: 04-1] Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [21:03:07] (03CR) 10MusikAnimal: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [21:10:24] (03CR) 10jerkins-bot: [V: 04-1] Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [21:11:54] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443164 (owner: 10L10n-bot) [21:31:36] (03CR) 10Mooeypoo: [C: 032] Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [21:54:09] (03CR) 10jerkins-bot: [V: 04-1] Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [22:05:31] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Maps, 10MediaWiki-Vagrant, and 2 others: Create 'kartotherian' role in mediawiki-vagrant - https://phabricator.wikimedia.org/T187366 (10Etonkovidova) 05Open>03Resolved Checked locally - fetching/rendering maps and lang attribute l... [22:06:58] (03CR) 10Mooeypoo: [V: 032 C: 032] "Test is unrelated and is being handled upstream. Merging." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [22:18:16] (03Merged) 10jenkins-bot: Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [22:20:28] (03CR) 10jenkins-bot: Fix setting of reviewed state based on autopatrol permission [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443127 (https://phabricator.wikimedia.org/T198497) (owner: 10MusikAnimal) [23:00:07] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-Watchlist: Watchlist bullets missing colors - https://phabricator.wikimedia.org/T198513 (10AfroThundr3007730) Just confirming that the same thing is happening from Firefox (Nightly) and Chrome (Developer) on Debian Testing (KDE). [23:43:47] 10Collaboration-Team-Triage, 10Community-Liaisons, 10StructuredDiscussions: Fix officewiki talk subpages that were archived but not Flow-enabled - https://phabricator.wikimedia.org/T78111 (10Quiddity) p:05Low>03Lowest a:05Quiddity>03None [23:44:18] 10Collaboration-Team-Triage, 10StructuredDiscussions: Fix office wiki headers - https://phabricator.wikimedia.org/T95472 (10Quiddity) p:05Low>03Lowest a:05Quiddity>03None [23:47:00] 10Collaboration-Team-Triage, 10Thanks: New thank dialog should have some return button to go back on diff/history page - https://phabricator.wikimedia.org/T142886 (10matmarex) [23:47:03] 10Collaboration-Team-Triage, 10Thanks: Without javascript, Thanking something takes you to a dead end page - https://phabricator.wikimedia.org/T118865 (10matmarex) [23:47:35] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Patrolling, 10Community-Tech-Sprint, and 2 others: Creations by autopatrolled users not marked as autopatrolled in Special:NewPagesFeed - https://phabricator.wikimedia.org/T198497 (10MMiller_WMF) The fix has been written, as well... [23:50:17] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This breaks the animation and the interface in hilarious ways: https://phabricator.wikimedia.org/F23081670" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/441078 (https://phabricator.wikimedia.org/T186254) (owner: 10Hagar Shilo) [23:50:50] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10CSS, 10Patch-For-Review: Thanks confirmation text does not wrap if longer than available space - https://phabricator.wikimedia.org/T186254 (10matmarex) [23:50:54] 10Collaboration-Team-Triage, 10Thanks, 10JavaScript, 10Patch-For-Review: Non-breaking spaces break page layout when confirming thanks in diff view - https://phabricator.wikimedia.org/T111735 (10matmarex) [23:55:25] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-Watchlist: Watchlist bullets missing colors - https://phabricator.wikimedia.org/T198513 (10Etonkovidova) 05Open>03Resolved Checked in betalabs: (the screenshots are done for Edge/Windows10 in SauceLabs, so the quality is little poor) - U...