[15:16:31] (03CR) 10Kosta Harlan: [C: 04-1] "I haven't tested it manually but the code looks good. There's a typo (epoc instead of epoch), so setting -1 for now." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 (owner: 10Mooeypoo) [15:35:27] 10Collaboration-Team-Triage, 10StructuredDiscussions: Structured discussion - mapframe and maplink do not behave as expected - https://phabricator.wikimedia.org/T196112#4247316 (10CKoerner_WMF) See also: T140920 [[ https://www.mediawiki.org/wiki/Topic:Udsylqhqoz58gykp | In this example ]] the console is givin... [15:43:04] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Chinese-Sites, and 3 others: Coordinate with Tech Ambassadors for graduating New Filters on Watchlist out of beta - https://phabricator.wikimedia.org/T195993#4319657 (10Kaartic) Word spreaded... [16:23:48] 10Collaboration-Team-Triage, 10StructuredDiscussions: Have mw.libs.ve.addPlugin working on StructuredDiscussions - https://phabricator.wikimedia.org/T198337#4319738 (10Trizek-WMF) [16:24:35] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Chinese-Sites, and 3 others: Coordinate with Tech Ambassadors for graduating New Filters on Watchlist out of beta - https://phabricator.wikimedia.org/T195993#4319749 (10Kaartic) tawikipedia:... [16:33:25] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Scoring-platform-team: Enable srwiki edit quality filters in RecentChanges - https://phabricator.wikimedia.org/T197012#4319768 (10Acamicamacaraca) @Catrope How's it going? xD [16:50:04] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10Performance: Move construction of highlight containers to server - https://phabricator.wikimedia.org/T198139#4319797 (10kostajh) Patch for this referenced T197168 (and is merged), shall we close this? [16:58:48] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10Performance: Move construction of highlight containers to server - https://phabricator.wikimedia.org/T198139#4319825 (10jmatazzoni) Normally it goes to QA first. Moving now. [17:08:02] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Patch-For-Review, 10User-notice: Graduate the New Filters UX on Watchlist out of beta on all wikis - https://phabricator.wikimedia.org/T181193#4319857 (10jmatazzoni) [17:08:04] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10Patch-For-Review: Put an opt-out for the New Filters onto the W... - https://phabricator.wikimedia.org/T195431#4319856 [17:46:34] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Re-enable test coverage reporting, add @covers tags (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440353 (https://phabricator.wikimedia.org/T195136) (owner: 10Kosta Harlan) [17:51:11] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review, 10Performance: Fix slow Watchlist load and interaction times - https://phabricator.wikimedia.org/T197168#4280839 (10Izno) I have a watchlist of a mere 480 pages (many of which are high volume e.g. en:WP:AN, en:W... [17:59:36] (03CR) 10Kosta Harlan: "Thanks for your review Thiemo! I was using `@coversNothing` based on my interpretation of https://phpunit.readthedocs.io/en/7.1/code-cover" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440353 (https://phabricator.wikimedia.org/T195136) (owner: 10Kosta Harlan) [18:01:43] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review, 10Performance: Fix slow Watchlist load and interaction times - https://phabricator.wikimedia.org/T197168#4319983 (10kostajh) @Izno thanks very much for your feedback. I'll be posting an update here soon with pro... [18:09:05] (03CR) 10Mooeypoo: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440018 (https://phabricator.wikimedia.org/T195924) (owner: 10MusikAnimal) [18:16:20] (03CR) 10jerkins-bot: [V: 04-1] Add AfC state filters for drafts [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440018 (https://phabricator.wikimedia.org/T195924) (owner: 10MusikAnimal) [18:16:27] (03PS9) 10Mooeypoo: Add timestamps to generated notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 [18:16:37] (03CR) 10Mooeypoo: Add timestamps to generated notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 (owner: 10Mooeypoo) [18:18:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "Yes, please. @coversNothing is for situations where no production code is run, e.g. a test that checks if certain files exist. But the two" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440353 (https://phabricator.wikimedia.org/T195136) (owner: 10Kosta Harlan) [18:35:55] (03PS3) 10Hagar Shilo: Wrap thanks confirmation text when it is exceeds the available space [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/441078 (https://phabricator.wikimedia.org/T186254) [18:36:58] (03CR) 10Hagar Shilo: Wrap thanks confirmation text when it is exceeds the available space (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/441078 (https://phabricator.wikimedia.org/T186254) (owner: 10Hagar Shilo) [18:46:36] (03CR) 10jerkins-bot: [V: 04-1] Add timestamps to generated notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305669 (owner: 10Mooeypoo) [19:41:13] (03PS1) 10MaxSem: Remove deprecated profiling calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/442372 [20:00:39] (03CR) 10Jforrester: [C: 032] Remove deprecated profiling calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/442372 (owner: 10MaxSem) [20:44:26] (03CR) 10Hashar: "The Selenium test:" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440018 (https://phabricator.wikimedia.org/T195924) (owner: 10MusikAnimal) [20:48:56] (03CR) 10Mooeypoo: [C: 032] "The failure is unrelated, as per https://phabricator.wikimedia.org/T198201#4320467" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440018 (https://phabricator.wikimedia.org/T195924) (owner: 10MusikAnimal) [20:56:51] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Performance: Reduce number of times we apply highlights - https://phabricator.wikimedia.org/T198359#4320507 (10kostajh) p:05Triage>03Normal [21:06:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/442496 (owner: 10L10n-bot) [21:23:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/442513 (owner: 10L10n-bot) [21:27:37] 10Collaboration-Team-Triage, 10Notifications, 10Community-Tech, 10MediaWiki-Page-editing, and 4 others: [Epic] Ping/notify user when username used in an edit summary - https://phabricator.wikimedia.org/T32750#4320572 (10IKhitron) [21:28:45] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated profiling calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/442372 (owner: 10MaxSem) [21:43:58] 10Collaboration-Team-Triage, 10English-Wikipedia-New-Pages-Patrol: Investigation: benchmark Google and Turnitin for copyvio - https://phabricator.wikimedia.org/T198361#4320583 (10MMiller_WMF) [21:45:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442601 (owner: 10L10n-bot) [21:45:07] 10Collaboration-Team-Triage, 10English-Wikipedia-New-Pages-Patrol: New Pages Feed: ORES addition - https://phabricator.wikimedia.org/T196178#4320593 (10MMiller_WMF) [21:45:27] 10Collaboration-Team-Triage, 10English-Wikipedia-New-Pages-Patrol: New Pages Feed: filtering on ORES scores (3.2) - https://phabricator.wikimedia.org/T195927#4320594 (10MMiller_WMF) [21:45:39] 10Collaboration-Team-Triage, 10English-Wikipedia-New-Pages-Patrol: New Pages Feed: generate ORES scores (3.1) - https://phabricator.wikimedia.org/T195796#4320595 (10MMiller_WMF) [21:45:57] 10Collaboration-Team-Triage, 10English-Wikipedia-New-Pages-Patrol: [Timebox 12hr] Investigation: applying copyvio for page review prioritization - https://phabricator.wikimedia.org/T193809#4320596 (10MMiller_WMF) [21:49:35] (03Merged) 10jenkins-bot: Add AfC state filters for drafts [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440018 (https://phabricator.wikimedia.org/T195924) (owner: 10MusikAnimal) [22:34:17] (03CR) 10jenkins-bot: Add AfC state filters for drafts [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440018 (https://phabricator.wikimedia.org/T195924) (owner: 10MusikAnimal) [23:00:34] (03PS1) 10Jdlrobson: Confirm thanks before sending to users [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442748 [23:12:11] (03CR) 10jerkins-bot: [V: 04-1] Confirm thanks before sending to users [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442748 (owner: 10Jdlrobson) [23:12:46] (03PS6) 10Jdlrobson: Do not use png for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 [23:13:35] (03PS7) 10Jdlrobson: Do not use png for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) [23:16:08] (03PS1) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 [23:20:44] (03PS2) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 [23:22:26] (03PS3) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 [23:24:42] (03PS8) 10Jdlrobson: Do not use png for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) [23:26:55] (03PS9) 10Jdlrobson: Do not use png for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) [23:26:58] (03PS4) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 [23:27:23] (03CR) 10VolkerE: "So that's a different icon now. You intend to change it?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [23:28:53] 10Collaboration-Team-Triage, 10Thanks, 10Readers-Web-Backlog, 10Mobile: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737#4320714 (10Jdlrobson) [23:29:00] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech-Sprint: PageTriage with AfC option: Options removed from NPP option are incorrectly saved when switching to AfC - https://phabricator.wikimedia.org/T198364#4320715 (10Mooeypoo) [23:29:25] 10Collaboration-Team-Triage, 10Thanks, 10Readers-Web-Backlog, 10Mobile: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737#664657 (10Jdlrobson) [23:29:32] 10Collaboration-Team-Triage, 10Thanks, 10Readers-Web-Backlog, 10Mobile: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737#664657 (10Jdlrobson) I've made two patches that solve this problem. Ping @alexhollender what do you think? [23:29:37] (03PS5) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) [23:29:51] (03PS2) 10Jdlrobson: Confirm thanks before sending to users [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442748 (https://phabricator.wikimedia.org/T63737) [23:34:09] (03PS6) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 [23:39:59] (03CR) 10jerkins-bot: [V: 04-1] Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (owner: 10Jdlrobson) [23:40:03] 10Collaboration-Team-Triage, 10Thanks, 10Readers-Web-Backlog, 10Mobile, 10Patch-For-Review: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737#4320737 (10Jdlrobson) [23:40:41] 10Collaboration-Team-Triage, 10Thanks, 10Readers-Web-Backlog, 10Mobile, 10Patch-For-Review: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737#664657 (10Jdlrobson) [23:41:36] 10Collaboration-Team-Triage, 10Thanks, 10Patch-For-Review, 10Readers-Web-Backlog (Design), 10Technical-Debt: Upgrade Thanks icon - https://phabricator.wikimedia.org/T198151#4320739 (10Jdlrobson) [23:41:57] 10Collaboration-Team-Triage, 10Thanks, 10Patch-For-Review, 10Readers-Web-Backlog (Design), 10Technical-Debt: Upgrade Thanks icon - https://phabricator.wikimedia.org/T198151#4313691 (10Jdlrobson) @alexhollender can you and @Volker_E confirm you are happy with the asset change? [23:43:21] (03CR) 10jerkins-bot: [V: 04-1] Do not use png for thanks button [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [23:43:48] (03CR) 10jerkins-bot: [V: 04-1] Confirm thanks before sending to users [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442748 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [23:51:36] (03CR) 10jerkins-bot: [V: 04-1] Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (owner: 10Jdlrobson)