[00:20:57] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make filter options collapsible - https://phabricator.wikimedia.org/T177206#4266312 (10jmatazzoni) In T177206#4260345, @Pginer-WMF wrote: > Elements should have a prominence that is proportional to their relevance and frequency of us... [01:10:18] (03CR) 10MaxSem: Namespace classes and give each its own file (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/437660 (https://phabricator.wikimedia.org/T177810) (owner: 10MusikAnimal) [01:12:02] (03PS1) 10MaxSem: Add Phan config [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438130 [01:14:46] (03CR) 10MaxSem: "The standard location for stuff from cron/ and tools/ would be maintenance/." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/437660 (https://phabricator.wikimedia.org/T177810) (owner: 10MusikAnimal) [02:53:39] (03CR) 10Samwilson: [C: 031] "I guess if we move things in cron/ then we'll have to update cronjobs? Let's leave them be for now; this patch is big enough anyway." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/437660 (https://phabricator.wikimedia.org/T177810) (owner: 10MusikAnimal) [03:08:46] (03CR) 10MaxSem: "Agree. Can't leave them forever though because having code in non-standard directories messes with Phan, for example." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/437660 (https://phabricator.wikimedia.org/T177810) (owner: 10MusikAnimal) [03:18:12] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Move files from cron/ and tools/ directories to maintenance/ - https://phabricator.wikimedia.org/T196720#4266438 (10Samwilson) [03:18:40] (03CR) 10Samwilson: [C: 031] "I've created https://phabricator.wikimedia.org/T196720 to remind us." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/437660 (https://phabricator.wikimedia.org/T177810) (owner: 10MusikAnimal) [04:16:08] (03CR) 10Samwilson: [C: 031] Namespace classes and give each its own file (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/437660 (https://phabricator.wikimedia.org/T177810) (owner: 10MusikAnimal) [05:02:37] (03CR) 10Legoktm: Namespace classes and give each its own file (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/437660 (https://phabricator.wikimedia.org/T177810) (owner: 10MusikAnimal) [05:16:52] (03CR) 10Samwilson: [C: 031] Namespace classes and give each its own file (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/437660 (https://phabricator.wikimedia.org/T177810) (owner: 10MusikAnimal) [06:25:27] (03CR) 10Samwilson: [C: 032] Add Phan config [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438130 (owner: 10MaxSem) [06:31:47] (03Merged) 10jenkins-bot: Add Phan config [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438130 (owner: 10MaxSem) [06:31:51] (03CR) 10Legoktm: "check experimental" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438130 (owner: 10MaxSem) [06:33:17] (03CR) 10jenkins-bot: Add Phan config [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438130 (owner: 10MaxSem) [06:35:18] (03CR) 10Legoktm: "Doesn't pass yet..." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438130 (owner: 10MaxSem) [06:36:25] (03CR) 10jenkins-bot: Add Phan config [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438130 (owner: 10MaxSem) [06:39:23] (03PS26) 10Samwilson: Namespace classes and give each its own file [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/437660 (https://phabricator.wikimedia.org/T177810) (owner: 10MusikAnimal) [06:50:44] (03PS1) 10Samwilson: Remove deprecated 4th parameter from Database::delete() calls [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438153 [06:56:04] (03CR) 10Samwilson: [C: 032] "Oops, sorry. I thought that was the idea, to start with? That we didn't mind it failing for now, but we'd merge it so that we can use it t" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438130 (owner: 10MaxSem) [06:57:17] (03CR) 10Samwilson: "check experimental" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438153 (owner: 10Samwilson) [07:04:38] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Chinese-Sites, and 3 others: Coordinate with Tech Ambassadors for graduating New Filters on Watchlist out of beta - https://phabricator.wikimedia.org/T195993#4266600 (10Anooprao) https://meta... [07:37:53] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-phan-config to 0.3.0 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/438177 (owner: 10Libraryupgrader) [08:03:54] (03PS1) 10MaxSem: Get rid of call_user_func_array() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/438195 [08:04:29] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.3.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/438192 (owner: 10Libraryupgrader) [08:16:05] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Chinese-Sites, and 3 others: Coordinate with Tech Ambassadors for graduating New Filters on Watchlist out of beta - https://phabricator.wikimedia.org/T195993#4266672 (10IKhitron) Thank you, b... [09:11:07] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10User-notice: Graduate the New Filters UX on Watchlist out of beta on all wikis - https://phabricator.wikimedia.org/T181193#4266762 (10Trizek-WMF) New round on Tech News, to have i... [10:42:45] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/185163 (owner: 10Hashar) [10:42:50] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/185163 [10:43:03] (03CR) 10Hashar: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/185163 (owner: 10Hashar) [12:48:24] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make filter options collapsible - https://phabricator.wikimedia.org/T177206#4266985 (10Pginer-WMF) Thanks for the feedback, @jmatazzoni . I made some more explorations. Each has some pros and cons but all should make the expand-collaps... [12:56:13] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Chinese-Sites, and 3 others: Coordinate with Tech Ambassadors for graduating New Filters on Watchlist out of beta - https://phabricator.wikimedia.org/T195993#4266996 (10Kaartic) There seems t... [13:12:21] 10Collaboration-Team-Triage, 10Edit-Review-Improvements: Experiment with in-page edit review tools for smaller wikis - https://phabricator.wikimedia.org/T196739#4267010 (10Kaartic) [13:15:39] 10Collaboration-Team-Triage, 10Thanks, 10Wikimedia-Site-requests: Remove all logging for the Thanks extension - https://phabricator.wikimedia.org/T57428#4267038 (10matej_suchanek) [13:15:46] 10Collaboration-Team-Triage, 10Thanks, 10Pywikibot-Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#4267033 (10matej_suchanek) [14:19:05] 10Collaboration-Team-Triage, 10StructuredDiscussions: No JS: Unable to thank to a flow comment - https://phabricator.wikimedia.org/T196742#4267120 (10Kaartic) [14:43:51] 10Collaboration-Team-Triage, 10StructuredDiscussions: No JS: Unable to thank to a flow comment - https://phabricator.wikimedia.org/T196742#4267185 (10Aklapper) [14:43:54] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10StructuredDiscussions, 10Mobile: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set" - https://phabricator.wikimedia.org/T191442#4267188 (10Aklapper) [14:52:25] 10Collaboration-Team-Triage, 10Notifications, 10Community-Tech, 10MediaWiki-extensions-GlobalPreferences: Local exception for notifications does not work - https://phabricator.wikimedia.org/T195288#4222004 (10Epidosis) In my case I selected "Set a local exception for this global preference" and the box bec... [16:30:51] 10Collaboration-Team-Triage, 10Edit-Review-Improvements: Start a list of good examples of filter combinations - https://phabricator.wikimedia.org/T196678#4267508 (10Trizek-WMF) I'm happy to see someone else thinking about my old idea described on T167944. :) I think the 3 actions listed on {T174800} IMO suffi... [17:39:56] 10Collaboration-Team-Triage, 10Thanks, 10Easy, 10Mobile: Thanks button doesn't appear well on mobile - https://phabricator.wikimedia.org/T196758#4267663 (10kaldari) [17:40:14] 10Collaboration-Team-Triage, 10Thanks, 10Easy, 10Mobile: Thanks button icon doesn't appear well on mobile - https://phabricator.wikimedia.org/T196758#4267674 (10kaldari) [17:40:52] 10Collaboration-Team-Triage, 10Thanks, 10Easy, 10Mobile: Thanks button icon doesn't appear well on mobile - https://phabricator.wikimedia.org/T196758#4267663 (10kaldari) [17:47:35] mooeypoo: RoanKattouw https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Kartographer/+/433084/ [17:48:24] edsanders: What should the selector be instead? [17:49:04] scoped to your extension in some way? [17:49:53] .ve-ui-mwMapsDialog-geoJSONWidget .oo-ui-inputWidget-input, [17:49:53] .ve-ui-mwMapsDialog-geoJSONWidget .ve-ui-mwAceEditorWidget [17:50:05] if I had to guess, but I haven't looked at the DOM [17:50:27] currently it's affecting the layout of every ve-ui-mwAceEditorWidget [18:02:15] Oooh good point [18:02:39] mooeypoo: Could you deal with this since you're closer to being done with reviews than I am? [18:17:00] 10Collaboration-Team-Triage, 10Edit-Review-Improvements: Start a list of good examples of filter combinations - https://phabricator.wikimedia.org/T196678#4267767 (10Quiddity) >>! In T196678#4267508, @Trizek-WMF wrote: > I'm happy to see someone else thinking about my old idea described on T167944. :) > The "S... [18:21:51] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-phan-config to 0.3.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/438192 (owner: 10Libraryupgrader) [19:19:06] (03PS3) 10Umherirrender: Fix and add more PHPDoc types and make existing more specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/437196 (owner: 10Thiemo Kreuz (WMDE)) [19:19:10] (03CR) 10Umherirrender: [C: 032] Fix and add more PHPDoc types and make existing more specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/437196 (owner: 10Thiemo Kreuz (WMDE)) [19:21:42] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make filter options collapsible - https://phabricator.wikimedia.org/T177206#4267932 (10jmatazzoni) Thanks so much for putting these together Pau! I know it's not our usual process, but I want to move fast on this so I showed the mockup... [19:29:01] (03Merged) 10jenkins-bot: Fix and add more PHPDoc types and make existing more specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/437196 (owner: 10Thiemo Kreuz (WMDE)) [19:34:14] (03CR) 10jenkins-bot: Fix and add more PHPDoc types and make existing more specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/437196 (owner: 10Thiemo Kreuz (WMDE)) [19:39:26] (03CR) 10jenkins-bot: Fix and add more PHPDoc types and make existing more specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/437196 (owner: 10Thiemo Kreuz (WMDE)) [19:42:40] 10Collaboration-Team-Triage, 10StructuredDiscussions: LiquidThreads to Flow/StructuredDiscussions script has an exception due to Pimple. - https://phabricator.wikimedia.org/T196771#4268002 (10Rosencrantz) [19:46:26] (03PS1) 10Umherirrender: Remove [optional] from param docs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/439294 [20:41:24] 10Collaboration-Team-Triage, 10Thanks, 10Easy, 10Mobile: Thanks button icon doesn't appear well on mobile - https://phabricator.wikimedia.org/T196758#4268223 (10kaldari) [21:48:14] (03CR) 10MaxSem: [C: 032] Remove [optional] from param docs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/439294 (owner: 10Umherirrender) [22:02:50] (03Merged) 10jenkins-bot: Remove [optional] from param docs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/439294 (owner: 10Umherirrender) [22:10:35] (03CR) 10jenkins-bot: Remove [optional] from param docs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/439294 (owner: 10Umherirrender)