[00:00:28] (03CR) 10Krinkle: NotifUser: Redo caching strategy for multi-DC compatibility (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436205 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [00:06:35] (03CR) 10Krinkle: "Regarding the set(), I'd recommend against it. It's not part of the encouraged pattern and would imho be a risk going forward. It might wo" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436205 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [00:09:42] 10Collaboration-Team-Triage, 10Beta-Cluster-Infrastructure, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps): [betalabs] Uncaught TypeError: Cannot read property 'lat' of null - when 'Edit layer' option is used. - https://phabricator.wikimedia.org/T194440#4244740 (10Etonkovidova) [00:10:50] 10Collaboration-Team-Triage, 10Beta-Cluster-Infrastructure, 10Discovery, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps): [betalabs] Uncaught TypeError: Cannot read property 'lat' of null - when 'Edit layer' option is used. - https://phabricator.wikimedia.org/T194440#4244743 (10Etonkovidova... [00:16:46] (03CR) 10Catrope: NotifUser: Redo caching strategy for multi-DC compatibility (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436205 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [00:21:41] (03CR) 10Krinkle: [C: 031] NotifUser: Simplify timestamp comparisons in getForeignTimestamp() too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436206 (owner: 10Catrope) [00:21:48] (03CR) 10Krinkle: [C: 032] NotifUser: Add a doc comment for getForeignCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436418 (owner: 10Catrope) [00:21:56] (03CR) 10Krinkle: [C: 031] NotifUser: Remove $dbSource parameter from resetNotificationCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436419 (owner: 10Catrope) [00:43:15] (03CR) 10Catrope: "Thanks, I'll remove the set() call. One thing about your response though: you mention that set() doesn't update the in-process cache (whic" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436205 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [00:44:45] (03CR) 10Krinkle: [C: 04-1] "LGTM, and would land, but needs a merge conflict resolution." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/384300 (https://phabricator.wikimedia.org/T177825) (owner: 10Catrope) [00:49:26] (03PS5) 10Catrope: NotifUser: Redo caching strategy for multi-DC compatibility [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436205 (https://phabricator.wikimedia.org/T164860) [00:50:49] (03PS6) 10Catrope: NotifUser: Redo caching strategy for multi-DC compatibility [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436205 (https://phabricator.wikimedia.org/T164860) [00:50:51] (03CR) 10Krinkle: "Good point, pcTTL is opt-in. I can't think off-hand of other things that would go wrong if using set() on a key normally used by getWithSe" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436205 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [00:51:33] (03CR) 10Krinkle: [C: 031] NotifUser: Redo caching strategy for multi-DC compatibility [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436205 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [00:52:53] (03PS5) 10Catrope: NotifUser: Simplify timestamp comparisons in getForeignTimestamp() too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436206 [00:52:59] (03PS2) 10Catrope: NotifUser: Add a doc comment for getForeignCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436418 [00:53:06] (03PS3) 10Catrope: NotifUser: Remove $dbSource parameter from resetNotificationCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436419 [00:55:13] 10Collaboration-Team-Triage, 10Notifications, 10Availability (MediaWiki-MultiDC), 10MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10Patch-For-Review: Update Echo's caching strategy for multi-dc compatibility - https://phabricator.wikimedia.org/T164860#4244795 (10Catrope) These patches fix... [01:05:43] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2018), 10Tech-Ambassadors: Coordinate with Tech Ambassadors for graduating New Filters on Watchlist out of beta - https://phabricator.wikimedia.org/T195993#4244801... [01:07:24] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2018), 10Tech-Ambassadors: Coordinate with Tech Ambassadors for graduating New Filters on Watchlist out of beta - https://phabricator.wikimedia.org/T195993#4243604... [01:16:06] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Put an opt-out for the New Filters onto the Watchlist preferences page - https://phabricator.wikimedia.org/T195431#4244816 (10Catrope) >Main option text: Hide the improved version of... [01:21:34] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Clean up RCFilters preference tech debt once watchlist is out of beta - https://phabricator.wikimedia.org/T196033#4244825 (10Catrope) p:05Triage>03Normal [01:50:54] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Clean up RCFilters preference tech debt once watchlist is out of beta - https://phabricator.wikimedia.org/T196033#4244856 (10Catrope) [02:13:00] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Maps-Sprint: Unable to create source "v3"self._closeAsync is not a function error - https://phabricator.wikimedia.org/T195476#4244895 (10Pnorman) I've fixed all the font errors and now the only error left is this one ``` [2018-05-31T02:09:45.210Z] ERR... [04:43:28] (03Abandoned) 10Catrope: ContainmentSet: Work around unhelpful behavior of lookupCentralIds() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/384300 (https://phabricator.wikimedia.org/T177825) (owner: 10Catrope) [07:18:57] (03PS1) 10Samwilson: [WiP] Add Draft namespace pages to the queue. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/436472 [07:19:58] 10Collaboration-Team-Triage, 10StructuredDiscussions: Explore ideas for workflow support - https://phabricator.wikimedia.org/T103082#4245087 (10awight) I had a lightweight proposal for how to store workflows, documented here: https://www.mediawiki.org/wiki/Requests_for_comment/Workflow This format is pretty e... [07:22:16] (03CR) 10jerkins-bot: [V: 04-1] [WiP] Add Draft namespace pages to the queue. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/436472 (owner: 10Samwilson) [09:00:30] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Maps-Sprint, 10Regression: Unable to create source "v3"self._closeAsync is not a function error - https://phabricator.wikimedia.org/T195476#4245286 (10Pnorman) [10:06:02] 10Collaboration-Team-Triage, 10Discovery, 10Maps, 10VisualEditor-EditingTools, and 3 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4175631 (10Deskana) >>! In T193659#4244248, @jmatazzoni wrote: > So, I'm looking at the map and thinking this... [10:06:37] Why are all the map details missing on the beta cluster? [10:06:39] e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User:Deskana_(WMF)/sandbox [10:07:14] Is the regression, or is the beta cluster just weird? [10:39:02] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Technical-Debt: Clean up RCFilters preference tech debt once watchlist is out of beta - https://phabricator.wikimedia.org/T196033#4245535 (10Aklapper) [11:00:13] 10Collaboration-Team-Triage, 10Notifications, 10wikitech.wikimedia.org: Fatal exception at Special:Notifications on Wikitech - https://phabricator.wikimedia.org/T196035#4245582 (10Aklapper) Same here for https://wikitech.wikimedia.org/wiki/Special:Notifications ``` exception.file /srv/mediawiki/php-1... [11:02:20] 10Collaboration-Team-Triage, 10Notifications, 10wikitech.wikimedia.org: "InvalidArgumentException: The trash icon is not registered" for Special:Notifications on Wikitech - https://phabricator.wikimedia.org/T196035#4245586 (10Aklapper) [11:08:20] 10Collaboration-Team-Triage, 10Notifications, 10wikitech.wikimedia.org: "InvalidArgumentException: The trash icon is not registered" for Special:Notifications on Wikitech - https://phabricator.wikimedia.org/T196035#4245610 (10zhuyifei1999) [11:08:23] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Notifications, 10MediaWiki-extensions-OpenStackManager, 10wikitech.wikimedia.org, 10Wikimedia-log-errors: Special:Notifications gives a consistent PHP exception on load ("The trash icon is not regi... - https://phabricator.wikimedia.org/T195253#4245613 [12:36:25] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-ReviewStream, 10Analytics, 10ChangeProp, and 4 others: Set up the foundation for the ReviewStream feed - https://phabricator.wikimedia.org/T143743#4245792 (10Pchelolo) [13:01:59] 10Collaboration-Team-Triage, 10Discovery, 10Maps, 10VisualEditor-EditingTools, and 3 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4245828 (10Deskana) 05Open>03Resolved Oops, forgot to close this as resolved with my last comment. [15:39:52] RoanKattouw, mooeypoo, stephanebisson: ^ question up there about maps on the beta cluster [15:40:36] Believe it or not, the answer I really want is "No, that actually never worked" because then it means that nothing happened in the past week that broke it. [15:41:01] That's probably a [[Bash]]able comment... [15:42:43] https://office.wikimedia.org/w/index.php?title=Bash&diff=232293&oldid=232241&diffmode=source [15:49:06] Deskana: eek, where did you see the empty map? is this usual or a fluke? [15:49:21] mooeypoo: https://en.wikipedia.beta.wmflabs.org/wiki/User:Deskana_(WMF)/sandbox [15:49:48] Oh, it's beta [15:49:54] Deskana: if you zoom out, you'll see why you don't have labels [15:49:58] Yeah. [15:50:00] we only have a couple of countries rendered in beta [15:50:32] if you zoom all the way out you'll see the "spots" where labels exist -- those are the countries we made available on beta for testing, since putting the entire world was super expensive on the servers [15:50:52] And, of course, Israel is one of them. Bias! [15:51:05] Belgium, Switzerland, Greece, and Israel. [15:51:20] haha I wanted a country that had RTL **and** multiple languages [15:51:23] win ;) [15:51:41] :-D [15:51:47] Israel is the one where you have some cities in Arabic, some in Hebrew, and then you translate and get weird results where people translated stuff [15:52:03] Okay, so it never worked, and that means everything is fine. Good. [15:52:15] I love it when a task resolves itself [15:52:23] Come back any time, Deskana ! [15:52:48] Do I have to leave now? Did you just "Dismissed." me? [16:02:02] Deskana: If I dismiss you, I salute o7 [16:02:18] (This emoji always annoyed me for being the wrong hand, but whatever) [16:16:24] 10Collaboration-Team-Triage, 10Discovery, 10Maps, 10VisualEditor-EditingTools, and 3 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4246310 (10jmatazzoni) Oh, great. Thanks for adding the language in to VE! [16:35:54] 10Collaboration-Team-Triage, 10Discovery, 10Maps, 10VisualEditor-EditingTools, and 3 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4246401 (10Deskana) >>! In T193659#4246310, @jmatazzoni wrote: > Oh, great. Thanks for adding the language in... [19:16:05] (03CR) 10MusikAnimal: [C: 032] "Looks good, but note the live template is put in the hidden category https://en.wikipedia.org/wiki/Category:Redirects_for_discussion_from_" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/436082 (https://phabricator.wikimedia.org/T194826) (owner: 10Kaldari) [19:17:28] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Patch-For-Review: Page curation (rfd) creates an error message - https://phabricator.wikimedia.org/T194826#4210094 (10MusikAnimal) +2'd, but to repeat what I said there: The [[ https://en.wikipedia.org/wiki/Template:Rfd-NPF | live template ]... [19:23:31] (03Merged) 10jenkins-bot: Temporary fix for RfD template bug [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/436082 (https://phabricator.wikimedia.org/T194826) (owner: 10Kaldari) [19:24:28] (03CR) 10jenkins-bot: Temporary fix for RfD template bug [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/436082 (https://phabricator.wikimedia.org/T194826) (owner: 10Kaldari) [19:30:25] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Patch-For-Review: Page curation (rfd) creates an error message - https://phabricator.wikimedia.org/T194826#4246994 (10kaldari) @MusikAnimal: Thanks! Template fixed. [20:11:38] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Patch-For-Review: Put an opt-out for the New Filters onto the Watchlist preferences page - https://phabricator.wikimedia.org/T195431#4247165 (10jmatazzoni) In T195431#4244816, @Ca... [20:30:07] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Technical-Debt: Clean up RCFilters preference tech debt once watchlist is out of beta - https://phabricator.wikimedia.org/T196033#4247224 (10Catrope) [20:30:12] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10Patch-For-Review, 10Technical-Debt: Retire $wgStructuredChangeFiltersShowPreference - https://phabricator.wikimedia.org/T195029#4247223 (10Catrope) [20:52:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436645 (owner: 10L10n-bot) [20:55:19] 10Collaboration-Team-Triage, 10Discovery, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps): VE 'Edit layers' - Uncaught TypeError: Cannot read property 'lat' of null - https://phabricator.wikimedia.org/T194443#4247272 (10Etonkovidova) [20:56:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/436649 (owner: 10L10n-bot) [20:58:05] 10Collaboration-Team-Triage, 10Beta-Cluster-Infrastructure, 10Discovery, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps): [betalabs] Uncaught TypeError: Cannot read property 'lat' of null - when 'Edit layer' option is used. - https://phabricator.wikimedia.org/T194440#4247276 (10Etonkovidova) [20:58:07] 10Collaboration-Team-Triage, 10Discovery, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps): VE 'Edit layers' - Uncaught TypeError: Cannot read property 'lat' of null - https://phabricator.wikimedia.org/T194443#4247278 (10Etonkovidova) [21:13:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/436660 (owner: 10L10n-bot) [21:18:53] 10Collaboration-Team-Triage, 10StructuredDiscussions: Structured discussion - mapframe and maplink do not behave as expected - https://phabricator.wikimedia.org/T196112#4247316 (10Etonkovidova) [23:03:43] (03PS1) 10Catrope: NotifUser: Un-merge getMemcKey() and getGlobalMemcKey() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436688 [23:04:02] (03CR) 10Catrope: NotifUser: Redo caching strategy for multi-DC compatibility (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436205 (https://phabricator.wikimedia.org/T164860) (owner: 10Catrope) [23:14:44] (03PS1) 10Catrope: NotifUser: Simplify function signatures for getNotificationCount() and friends [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436692 [23:25:30] (03CR) 10Jforrester: [C: 032] NotifUser: Remove $dbSource parameter from resetNotificationCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436419 (owner: 10Catrope) [23:28:53] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2018), and 2 others: Coordinate with Tech Ambassadors for graduating New Filters on Watchlist out of beta - https://phabricator.wikimedia.org/T195993#4247551 (10Liu... [23:29:25] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Maps-Sprint, 10Regression: Unable to create source "v3"self._closeAsync is not a function error - https://phabricator.wikimedia.org/T195476#4247555 (10Pnorman) When Cassandra is running, this error goes away. It doesn't change the need to fix it, and... [23:35:41] (03PS1) 10Catrope: NotifUser: Remove basically-unused talk notification cache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436697 (https://phabricator.wikimedia.org/T164860) [23:41:02] (03CR) 10Catrope: [C: 032] Convert SpecialHelpMenuWidget to a customised DropdownWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/434486 (https://phabricator.wikimedia.org/T178387) (owner: 10Esanders) [23:49:29] (03CR) 10Jforrester: [C: 031] NotifUser: Simplify function signatures for getNotificationCount() and friends [extensions/Echo] - 10https://gerrit.wikimedia.org/r/436692 (owner: 10Catrope) [23:52:49] (03Merged) 10jenkins-bot: Convert SpecialHelpMenuWidget to a customised DropdownWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/434486 (https://phabricator.wikimedia.org/T178387) (owner: 10Esanders) [23:55:47] (03CR) 10jenkins-bot: Convert SpecialHelpMenuWidget to a customised DropdownWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/434486 (https://phabricator.wikimedia.org/T178387) (owner: 10Esanders)