[03:12:38] 10Collaboration-Team-Triage, 10WikiLove, 10MassMessage, 10MediaWiki-extensions-MultimediaViewer, and 3 others: Convert MediaWiki extensions WikiLove, MultimediaViewer and MassMessage to use OOUI - https://phabricator.wikimedia.org/T187992#4079627 (10Prtksxna) @ssaluja16, you might also want to try somethin... [07:18:42] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10StructuredDiscussions, 10Wikimedia-General-or-Unknown, 10User-notice-collaboration: Reply to a Structured discussion message is it displayed while it is visible in Notifications and Contributions - https://phabricator.wikimedia.org/T190429#4079731 (1... [07:50:06] (03PS1) 10VolkerE: build: Make SVGO indent with tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421829 [07:53:25] (03CR) 10Mooeypoo: [C: 032] build: Make SVGO indent with tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421829 (owner: 10VolkerE) [08:00:33] (03Merged) 10jenkins-bot: build: Make SVGO indent with tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421829 (owner: 10VolkerE) [08:03:36] (03CR) 10jenkins-bot: build: Make SVGO indent with tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421829 (owner: 10VolkerE) [08:05:57] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences, 10Patch-For-Review: Hide preference for 'Reload the watchlist automatically whenever a filter is changed' when New Filters a... - https://phabricator.wikimedia.org/T186277#4079792 [09:11:08] (03PS1) 10VolkerE: Align Notifications popup header/footer with OOUI's default size [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421840 (https://phabricator.wikimedia.org/T190397) [09:11:57] 10Collaboration-Team-Triage, 10Notifications, 10UI-Standardization, 10Design, and 2 others: Notifications popup: Remain with header/footer size or amend? - https://phabricator.wikimedia.org/T190397#4079860 (10Volker_E) [09:15:43] (03CR) 10Mooeypoo: [C: 04-1] Align Notifications popup header/footer with OOUI's default size (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421840 (https://phabricator.wikimedia.org/T190397) (owner: 10VolkerE) [09:16:02] (03PS1) 10VolkerE: NotificationsOptionWidget: Fix icon alignment [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421841 [09:20:49] (03CR) 10Mooeypoo: [C: 04-1] Align Notifications popup header/footer with OOUI's default size (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421840 (https://phabricator.wikimedia.org/T190397) (owner: 10VolkerE) [09:21:38] (03PS2) 10VolkerE: Align Notifications popup header/footer with OOUI's default size [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421840 (https://phabricator.wikimedia.org/T190397) [09:21:41] This is probably the best -1 review comment I've written [09:22:47] Volker_E, let's just put in 3em/7 and 4em/7 [09:23:03] RoanKattouw, backwardmath'ed it [09:23:08] I'm so amused [12:14:23] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Notifications, 10Easy, 10Patch-For-Review: [mobile-minor] Special:Notifications: Improve date format display - https://phabricator.wikimedia.org/T146288#4080309 (10Pginer-WMF) >>! In T146288#4079329, @Mooeypoo wrote: > Does that work for you @Pginer... [12:56:01] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartographer): Maps: Attribution of Wikidata is over-prominent and unreadable - https://phabricator.wikimedia.org/T187291#4080445 (10Pginer-WMF) >>! In T187291#4061820, @jmatazzoni wrote: >... [13:36:11] 10Collaboration-Team-Triage, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Enable Extension:StructuredDiscussions in Basque Wikipedia - https://phabricator.wikimedia.org/T190500#4080595 (10Urbanecm) [13:38:00] 10Collaboration-Team-Triage, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Enable Extension:StructuredDiscussions in Basque Wikipedia - https://phabricator.wikimedia.org/T190500#4075220 (10Urbanecm) @Trizek-WMF Maybe you know how to solve this. As I was told... [13:44:07] (03PS4) 10Mooeypoo: Conditionally rearrange date and button in notif list [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421790 (https://phabricator.wikimedia.org/T146288) [13:45:58] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Notifications, 10Easy, 10Patch-For-Review: [mobile-minor] Special:Notifications: Improve date format display - https://phabricator.wikimedia.org/T146288#4080611 (10Mooeypoo) >>! In T146288#4080309, @Pginer-WMF wrote: > The proposed change seems an i... [14:43:36] 10Collaboration-Team-Triage, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review, and 2 others: Enable Extension:StructuredDiscussions in Basque Wikipedia - https://phabricator.wikimedia.org/T190500#4080816 (10Trizek-WMF) >>! In T190500#4080595, @Urbanecm wrote: > @Trizek-WMF Maybe y... [14:47:50] (03CR) 10Mooeypoo: [C: 04-1] "Thanks for this! Overall looks good, small comments inline" (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421722 (owner: 10Esanders) [15:32:16] (03Abandoned) 10Mooeypoo: [wip] Load notification badges with the new 'notice' instead of 'message' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/297933 (https://phabricator.wikimedia.org/T139520) (owner: 10Mooeypoo) [15:44:40] (03CR) 10Mooeypoo: [C: 04-1] Align Notifications popup header/footer with OOUI's default size (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421840 (https://phabricator.wikimedia.org/T190397) (owner: 10VolkerE) [15:53:06] (03PS1) 10Jforrester: CancelConfirmDialog: Drop verbose option, ignored since v0.20.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/421927 [15:55:56] 10Collaboration-Team-Triage, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review, and 2 others: Enable Extension:StructuredDiscussions in Basque Wikipedia - https://phabricator.wikimedia.org/T190500#4080987 (10Theklan) @Trizek-WMF: here: https://eu.wikipedia.org/wiki/Wikipedia:Txokoa... [16:02:02] (03CR) 10Esanders: [C: 032] CancelConfirmDialog: Drop verbose option, ignored since v0.20.0 (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/421927 (owner: 10Jforrester) [16:05:50] stephanebisson: hi! a patch of mine is causing a flow test to fail. can you help my understand what triggers the failure? [16:06:39] here is the failure: https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/40450/console [16:06:53] it's triggered by https://gerrit.wikimedia.org/r/c/405015/ [16:07:24] that patch is big and incomplete. never mind understanding it. what i need to know is what expectation i'm breaking [16:07:40] the test is making some assumption which now failes - but what assumption? [16:08:24] it's asserting that no new value is set in the cache object, if i read the code right. now, a new value is set. but what triggers that? i don't even know what kind of thing is being cached there :) [16:18:54] (03Merged) 10jenkins-bot: CancelConfirmDialog: Drop verbose option, ignored since v0.20.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/421927 (owner: 10Jforrester) [16:30:52] 10Collaboration-Team-Triage, 10In-Context-Help-and-Onboarding, 10Community-Liaisons (Apr-Jun-2018): Consult with Korean and Czech new-user support and instructor types apropos 'In-Context Help' - https://phabricator.wikimedia.org/T189749#4081182 (10Trizek-WMF) [16:47:10] (03PS2) 10Jforrester: Fix DOM structure of mw.echo.ui.MenuItemWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421722 (owner: 10Esanders) [16:49:25] (03CR) 10jenkins-bot: CancelConfirmDialog: Drop verbose option, ignored since v0.20.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/421927 (owner: 10Jforrester) [16:51:06] (03PS3) 10Esanders: Fix DOM structure of mw.echo.ui.MenuItemWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421722 [16:51:56] (03CR) 10Esanders: Fix DOM structure of mw.echo.ui.MenuItemWidget (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421722 (owner: 10Esanders) [16:56:07] (03CR) 10Bartosz Dziewoński: Fix DOM structure of mw.echo.ui.MenuItemWidget (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421722 (owner: 10Esanders) [17:00:18] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Maps, 10Maps-Sprint, and 3 others: Add zoom level 19 - https://phabricator.wikimedia.org/T180907#4081395 (10Etonkovidova) [17:00:23] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Maps-Sprint, 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartotherian): Enable zoom 19 in tilerator / kartotherian UIs - https://phabricator.wikimedia.org/T186780#4081393 (10Etonkovidova) 05Open>03Resolved Check... [17:08:05] 10Collaboration-Team-Triage, 10WikiLove, 10MassMessage, 10MediaWiki-extensions-MultimediaViewer, and 2 others: GSoC'18 Proposal : Convert MediaWiki extensions WikiLove, MultimediaViewer and MassMessage to use OOUI - https://phabricator.wikimedia.org/T190668#4081442 (10Gopavasanth) [17:12:05] DanielK_WMDE_: I'll look at it in ~1h [17:12:28] stephanebisson: thanks! [17:12:38] i'f i'm no longer online, comment on gerrit or send me an email [17:12:44] 10Collab-Notifications-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-extensions-PageCuration, 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)): [minor] Page curation: 'Marked as reviewed' message should be truncate... - https://phabricator.wikimedia.org/T170347#4081465 [17:20:42] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), and 2 others: and/or : clickable marker area too... - https://phabricator.wikimedia.org/T141750#4081480 [19:26:29] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Implement 'User' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T167224#4082017 (10Trizek-WMF) [19:26:31] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Google-Summer-of-Code (2018): GSoC proposal: adding "user" search filter to Recent Changes Filters - https://phabricator.wikimedia.org/T190714#4081940 (10Trizek-WMF) [19:35:33] 10Collaboration-Team-Triage, 10WikiLove, 10MassMessage, 10MediaWiki-extensions-MultimediaViewer, and 3 others: Convert MediaWiki extensions WikiLove, MultimediaViewer and MassMessage to use OOUI - https://phabricator.wikimedia.org/T187992#4082028 (10ssaluja16) Hey, @Aklapper, sorry, I wanted to let you kno... [20:05:04] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters: Tag filters' titles and descriptions should be bidi isolated - https://phabricator.wikimedia.org/T190718#4082161 (10Mooeypoo) [20:25:13] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10I18n, 10Patch-For-Review: Tag filters' titles and descriptions should be bidi isolated - https://phabricator.wikimedia.org/T190718#4082260 (10Aklapper) [20:44:54] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/422013 (owner: 10L10n-bot) [20:51:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/422015 (owner: 10L10n-bot) [20:57:20] (03CR) 10Esanders: Align Notifications popup header/footer with OOUI's default size (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421840 (https://phabricator.wikimedia.org/T190397) (owner: 10VolkerE) [21:28:45] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10I18n, 10Maps (Map-Styles), 10Patch-For-Review: All map location names should be in the user's language - https://phabricator.wikimedia.org/T112948#4082448 (10jmatazzoni) @SBisson, I know this... [22:03:46] (03PS1) 10Jforrester: CancelConfirmDialog: Don't set to small size, which is the default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/422073 [22:34:27] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10Patch-For-Review: Hide preference for 'Reload the watch... - https://phabricator.wikimedia.org/T186277#4082847 [22:37:29] (03PS1) 10MaxSem: Revert my fix for summary pings in reverts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/422078 (https://phabricator.wikimedia.org/T190374) [22:37:31] (03PS1) 10MaxSem: Detect reverts differently [extensions/Echo] - 10https://gerrit.wikimedia.org/r/422079 (https://phabricator.wikimedia.org/T189819) [22:40:52] (03CR) 10Esanders: [C: 032] CancelConfirmDialog: Don't set to small size, which is the default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/422073 (owner: 10Jforrester) [22:52:33] (03Merged) 10jenkins-bot: CancelConfirmDialog: Don't set to small size, which is the default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/422073 (owner: 10Jforrester) [23:00:12] (03CR) 10jenkins-bot: CancelConfirmDialog: Don't set to small size, which is the default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/422073 (owner: 10Jforrester) [23:08:16] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartotherian): Kartotherian should accept (and propagate) a language parameter for tiles - https://phabricator.wikimedia.org/T187596#3980191 (10Etonkovidova) @SBisson - is the Console errors... [23:16:09] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Map-Styles): Add name_ column to style queries - https://phabricator.wikimedia.org/T187592#4082974 (10Etonkovidova) 05Open>03Resolved [23:16:18] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10I18n, 10Maps (Map-Styles), 10Patch-For-Review: All map location names should be in the user's language - https://phabricator.wikimedia.org/T112948#4082975 (10Etonkovidova)