[01:28:56] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking for the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10MusikAnimal) p:05Triage>03High [01:29:38] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking for the wrong edit - https://phabricator.wikimedia.org/T187757#3984593 (10MusikAnimal) [01:31:55] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking for the wrong edit - https://phabricator.wikimedia.org/T187757#3984597 (10MusikAnimal) Maybe this worthy as an Unbreak Now? [01:34:39] jmatazzoni_: is that an unbreak now? ^ [01:42:39] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking for the wrong edit - https://phabricator.wikimedia.org/T187757#3984614 (10MusikAnimal) [01:45:23] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking for the wrong edit - https://phabricator.wikimedia.org/T187757#3984615 (10MusikAnimal) [01:54:43] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking for the wrong edit - https://phabricator.wikimedia.org/T187757#3984616 (10MusikAnimal) Vector skin, Chrome on Windows 7 is also affected, according to Davey2010. [02:01:29] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking for the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10PrimeHunter) {F13892211} I got the same error in a test with Vector and Firefox. I made two screenshots (combined in one image) for documentation. I logged in as PrimeHunter3 and vie... [02:23:30] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking for the wrong edit - https://phabricator.wikimedia.org/T187757#3984621 (10MusikAnimal) p:05High>03Unbreak! We've discussed this and believe that this is pretty serious, so upping to UBN. Hope that is okay! We're also going to hide the Thanks link via C... [02:38:12] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984627 (10MusikAnimal) [02:52:35] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984640 (10PrimeHunter) MusikAnimal's "We're also going to hide the Thanks link via CSS" refers to [[ https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=826612112 | adding this ]]... [08:38:30] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984799 (10Coffee) Status update? This is extremely high priority. [08:49:40] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10Nick) Thanks appears to be working correctly on Commons, following a quick test with an edit and an upload. [10:58:23] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3985071 (10Trizek-WMF) All developers with experience about this feature are now sleeping. We need to wait a few hours for a fix. Very quick tests performed before on on the engineers goes to bed... [11:00:15] 10Collaboration-Team-Triage, 10Thanks: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10Vachovec1) I can confirm this bug for cs-wiki. The thanks notification goes to the last user who edited the page. Using Firefox 52.6.0 ESR. [11:05:35] 10Collaboration-Team-Triage, 10Thanks, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3985095 (10Trizek-WMF) [11:05:47] 10Collaboration-Team-Triage, 10Thanks, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10Trizek-WMF) >>! In T187757#3985076, @Vachovec1 wrote: > I can confirm this bug for cs-wiki. The thanks notification goes to the last user who edited the page. Using Fire... [11:18:11] 10Collaboration-Team-Triage, 10Thanks, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3985131 (10Vachovec1) >>! In T187757#3985071, @Trizek-WMF wrote: > All developers with experience about this feature are now sleeping. We need to wait a few hours for a fix. > > V... [11:23:55] 10Collaboration-Team-Triage, 10Thanks, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3985146 (10Trizek-WMF) [11:24:02] 10Collaboration-Team-Triage, 10Thanks, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3985147 (10TheDJ) [11:30:46] 10Collaboration-Team-Triage, 10Thanks, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3985154 (10Trizek-WMF) [12:18:57] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), and 4 others: Selenium tests for ORES - https://phabricator.wikimedia.org/T184451#3985212 (10Ladsgroup) 05Open>03Resol... [13:32:29] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10I18n, 10Maps (Map-Styles): All map location names should be shown in the user's language - https://phabricator.wikimedia.org/T112948#3985399 (10Pnorman) Just to add some documentation on 1c, eve... [13:51:38] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3985534 (10SBisson) [13:51:57] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10SBisson) a:03SBisson [14:04:04] (03PS1) 10Sbisson: Send thank for the light link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/412916 (https://phabricator.wikimedia.org/T187757) [14:12:04] (03CR) 10Sbisson: "Caused T187757" (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/405380 (https://phabricator.wikimedia.org/T159302) (owner: 10Catrope) [14:16:29] (03PS2) 10Sbisson: Send thank for the right link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/412916 (https://phabricator.wikimedia.org/T187757) [14:44:41] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), 10Patch-For-Review, 10Regression, 10User-notice-collaboration: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDat... - https://phabricator.wikimedia.org/T184670#3985695 [14:50:59] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10Patch-For-Review, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3985765 (10Trizek-WMF) [15:32:09] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10User-Urbanecm: Localize StucturedDiscussion namespace into lfn - https://phabricator.wikimedia.org/T184517#3985964 (10Katxis) [15:32:23] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10User-Urbanecm: Localize StucturedDiscussion namespace into lfn - https://phabricator.wikimedia.org/T184517#3886102 (10Katxis) Translated into Lingua Franca Nova [15:38:07] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10Patch-For-Review, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3986026 (10deryckchan) I have done a few tests by trying to thank lots of people on a page on yue.wp where I don't mind thanking ev... [16:06:36] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartotherian): Get kartotherian/kartotherian@master working with its dependencies (kartotherian/*) @master - https://phabricator.wikimedia.org/T187411#3986148 (10SBisson) | package | prod ve... [16:53:18] (03CR) 10Jforrester: "Bah. :-(" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/412916 (https://phabricator.wikimedia.org/T187757) (owner: 10Sbisson) [17:39:18] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10TechCom-RFC, 10VisualEditor, 10VisualEditor-MediaWiki-Plugins: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607#3986710 (10thiemowmde) Please consider the learnings from #articlefeedbackv5 (https://www.... [18:05:28] (03CR) 10Catrope: [C: 032] Send thank for the right link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/412916 (https://phabricator.wikimedia.org/T187757) (owner: 10Sbisson) [18:08:13] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), 10User-notice, 10User-notice-collaboration: Rephrase confusing "thanks" message on diff page - https://phabricator.wikimedia.org/T159302#3986863 (10Petar.petkovic) [18:12:59] (03Merged) 10jenkins-bot: Send thank for the right link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/412916 (https://phabricator.wikimedia.org/T187757) (owner: 10Sbisson) [18:15:28] (03PS1) 10Catrope: Send thank for the right link [extensions/Thanks] (wmf/1.31.0-wmf.21) - 10https://gerrit.wikimedia.org/r/412971 (https://phabricator.wikimedia.org/T187757) [18:23:01] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartotherian): mapframe no longer works - https://phabricator.wikimedia.org/T187741#3986894 (10Catrope) [18:23:20] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartotherian): mapframe no longer works - https://phabricator.wikimedia.org/T187741#3984080 (10Catrope) a:03Catrope [18:30:07] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartotherian): mapframe no longer works - https://phabricator.wikimedia.org/T187741#3986908 (10Catrope) It looks like Kartographer is [[https://github.com/wikimedia/mediawiki-... [18:32:30] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartotherian): mapframe no longer works - https://phabricator.wikimedia.org/T187741#3986909 (10Catrope) I can reproduce this bug locally by setting `$wgKartographerStaticMapfr... [19:08:30] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartotherian): mapframe no longer works - https://phabricator.wikimedia.org/T187741#3987031 (10Catrope) >>! In T187741#3986909, @Catrope wrote: > I can reproduce this bug loca... [19:09:00] 10Collaboration-Team-Triage, 10Collaboration-Community-Engagement, 10Community-Liaisons, 10StructuredDiscussions, and 2 others: Enable StructuredDiscussions on wikis that require it - https://phabricator.wikimedia.org/T117990#3987035 (10MarcoAurelio) [19:09:02] 10Collaboration-Team-Archive-2015-2016, 10Collaboration-Community-Engagement, 10StructuredDiscussions, 10Wikimedia-Site-requests, and 3 others: Enable Flow as a Beta feature on Polish Wikipedia - https://phabricator.wikimedia.org/T130009#3987033 (10MarcoAurelio) 05stalled>03declined If there's no commu... [19:24:20] (03CR) 10MaxSem: Ping users mentioned in edit summaries (038 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/405371 (https://phabricator.wikimedia.org/T32750) (owner: 10MaxSem) [19:24:55] (03PS9) 10MaxSem: Ping users mentioned in edit summaries [extensions/Echo] - 10https://gerrit.wikimedia.org/r/405371 (https://phabricator.wikimedia.org/T32750) [21:03:33] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks: ApiRevThankIntegrationTest broken - https://phabricator.wikimedia.org/T151878#3987368 (10matmarex) Again: https://gerrit.wikimedia.org/r/#/c/408326/ [21:44:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/413029 (owner: 10L10n-bot) [21:51:32] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), 10Patch-For-Review, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10Noah_Kastin) I'm glad that the button has been disabl... [22:03:04] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Page-editing, 10Community-Tech-Sprint: Create patch for detecting and processing pings in edit summaries & sending notification - https://phabricator.wikimedia.org/T186655#3987508 (10TBolliger) a:03MaxSem [22:04:08] 10Collaboration-Team-Triage, 10Notifications, 10Community-Tech, 10MediaWiki-Page-editing, 10Community-Wishlist-Survey-2017: Deploy 'Ping from edit summary' to CommTech wiki for testing - https://phabricator.wikimedia.org/T187835#3987513 (10TBolliger) p:05Triage>03Normal [22:04:38] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Discovery, 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Maps (Kartotherian): mapframe no longer works - https://phabricator.wikimedia.org/T187741#3987526 (10Catrope) It looks like dynamic (i.e. non-static) maps have a feature whereby the... [22:16:25] (03CR) 10Chad: [C: 032] Send thank for the right link [extensions/Thanks] (wmf/1.31.0-wmf.21) - 10https://gerrit.wikimedia.org/r/412971 (https://phabricator.wikimedia.org/T187757) (owner: 10Catrope) [22:17:20] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), 10Patch-For-Review, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10demon) This is fixed in master, just needs a backport... [22:23:35] (03Merged) 10jenkins-bot: Send thank for the right link [extensions/Thanks] (wmf/1.31.0-wmf.21) - 10https://gerrit.wikimedia.org/r/412971 (https://phabricator.wikimedia.org/T187757) (owner: 10Catrope) [22:29:27] 10Collaboration-Team-Triage, 10Thanks, 10Community-Tech-Sprint: Investigation: Thanks notification for log entry - https://phabricator.wikimedia.org/T184309#3987576 (10TBolliger) @Samwilson — Since this is now in development (T186855) can we close this investigation ticket and keep all future questions/disc... [22:30:21] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), 10Patch-For-Review, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3987581 (10demon) Ok, this is live now! [22:31:25] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), 10Patch-For-Review, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3987585 (10Jdforrester-WMF) 05Open>03Resolved Thanks, @demon! [22:54:32] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), 10Patch-For-Review, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3987626 (10Coffee) I've undone @MusikAnimal 's hiding of the tha... [23:04:29] 10Collaboration-Team-Triage, 10Thanks, 10Community-Tech-Sprint: Investigation: Thanks notification for log entry - https://phabricator.wikimedia.org/T184309#3987641 (10Samwilson) 05Open>03Resolved Good idea. [23:04:38] 10Collaboration-Team-Triage, 10Thanks, 10Community-Tech, 10Community-Wishlist-Survey-2017, and 2 others: [Epic] Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#3987644 (10Samwilson) [23:07:06] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), 10Patch-For-Review, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10Coffee) >>! In T187757#3987634, @revi wrote: > It was... [23:10:28] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Thanks, 10MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), 10Patch-For-Review, 10User-notice: Thanks thanking the wrong edit - https://phabricator.wikimedia.org/T187757#3984579 (10Davey2010) Not sure if I can or should comment here b... [23:42:26] 10Collaboration-Team-Triage, 10Thanks, 10Community-Tech: Add thanks link to log entries on Special:Log that are supported by the new log-thank API - https://phabricator.wikimedia.org/T187485#3987718 (10TBolliger) [23:56:43] 10MediaWiki-Recent-changes, 10MediaWiki-Maintenance-scripts: Rebuildrecentchanges.php should set the previous revision size for page creations to zero, not null - https://phabricator.wikimedia.org/T187842#3987773 (10GeoffreyT2000) [23:56:51] 10MediaWiki-Recent-changes, 10MediaWiki-Maintenance-scripts: Rebuildrecentchanges.php should set the previous revision size for page creations to zero, not null - https://phabricator.wikimedia.org/T187842#3987783 (10GeoffreyT2000) p:05Triage>03Low [23:58:04] 10MediaWiki-Recent-changes, 10CatWatch, 10MediaWiki-Maintenance-scripts, 10TCB-Team: Rebuildrecentchanges.php should regenerate CatWatch entries - https://phabricator.wikimedia.org/T178038#3987788 (10GeoffreyT2000) p:05Triage>03Low