[00:08:24] 10Collaboration-Team-Triage, 10StructuredDiscussions: Support set auto-close topic - https://phabricator.wikimedia.org/T182025#3811164 (10YFdyh000) Yes. Maybe it should be discussed somewhere? [00:40:52] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: [minor] invert=1 added to url if Namespace 'Exclude selected' button is clicked - https://phabricator.wikimedia.org/T182045#3811266 (10Catrope) a:03Mooeypoo [01:07:19] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-extensions-PageCuration, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: Add a 'Learners' (autoconfirmed) filter to New Pages Feed and rename the exist... - https://phabricator.wikimedia.org/T175225#3811302 [01:16:22] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: Small changes to "Other review tools" link - https://phabricator.wikimedia.org/T179539#3728016 (10Etonkovidova) The fol... [01:47:20] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10WorkType-NewFunctionality: Reconsider Flow's use of .mw-ui-hovericon (dropdown menu items that gain progressive/constructive/destructive styling on hover) - https://phabricator.wikimedia.org/T110051#3811366 (10Volker_E) a:03Pginer-WMF Given the extra... [01:47:41] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10UI-Standardization, 10UI-Standardization-Kanban, 10WorkType-NewFunctionality: Reconsider Flow's use of .mw-ui-hovericon (dropdown menu items that gain progressive/constructive/destructive styling on ... - https://phabricator.wikimedia.org/T110051#3811369 [02:03:03] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: Small changes to "Other review tools" link - https://phabricator.wikimedia.org/T179539#3811373 (10jmatazzoni) 05Open>... [02:03:56] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10MediaWiki-extensions-PageCuration, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: Add a 'Learners' (autoconfirmed) filter to New Pages Feed and rename the exist... - https://phabricator.wikimedia.org/T175225#3811377 [02:04:18] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), 10Patch-For-Review: Only add highlight/toggle states conditionally to the saved queries - https://phabricator.wikimedia.org/T177009#3811378 (... [02:06:19] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: Small changes to "Other review tools" link - https://phabricator.wikimedia.org/T179539#3811380 (10Volker_E) @jmatazzoni... [02:28:34] 10Collaboration-Team-Triage, 10Notifications, 10OOjs-UI, 10Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779#3811383 (10Volker_E) In order to get rid of badgeicons.json and use OOUI's icons, we'd also need to upstream 'double-check' ic... [02:30:55] 10Collaboration-Team-Triage, 10Notifications, 10OOjs-UI, 10Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779#3811387 (10Volker_E) [02:31:19] 10Collaboration-Team-Triage, 10Notifications, 10OOjs-UI, 10Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779#2442418 (10Volker_E) [08:51:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/395290 (owner: 10L10n-bot) [10:50:54] (03CR) 10Zfilipin: [C: 032] Delete Ruby Selenium tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393917 (https://phabricator.wikimedia.org/T174591) (owner: 10Jforrester) [10:57:56] (03Merged) 10jenkins-bot: Delete Ruby Selenium tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393917 (https://phabricator.wikimedia.org/T174591) (owner: 10Jforrester) [10:58:12] (03CR) 10jenkins-bot: Delete Ruby Selenium tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393917 (https://phabricator.wikimedia.org/T174591) (owner: 10Jforrester) [11:13:14] 10Collaboration-Team-Triage, 10Notifications, 10OOjs-UI, 10Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779#3812048 (10Pginer-WMF) >>! In T139779#3811383, @Volker_E wrote: > In order to get rid of badgeicons.json and use OOUI's icons,... [11:19:10] (03PS3) 10Zfilipin: build: Bump Ruby cruft to avoid security warnings for old rubocop [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393918 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [11:19:52] (03CR) 10Zfilipin: "PS #3 is a rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393918 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [11:20:08] (03CR) 10Zfilipin: [C: 032] build: Bump Ruby cruft to avoid security warnings for old rubocop [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393918 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [11:27:29] 10Collaboration-Team-Triage, 10StructuredDiscussions: Support set auto-close topic - https://phabricator.wikimedia.org/T182025#3812076 (10Aklapper) Which underlying problem do you want to solve by this proposal? Why is it a problem if topics stay open? [11:27:51] (03Merged) 10jenkins-bot: build: Bump Ruby cruft to avoid security warnings for old rubocop [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393918 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [11:28:06] (03CR) 10jenkins-bot: build: Bump Ruby cruft to avoid security warnings for old rubocop [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393918 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [11:47:00] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10UI-Standardization, 10UI-Standardization-Kanban, 10WorkType-NewFunctionality: Reconsider Flow's use of .mw-ui-hovericon (dropdown menu items that gain progressive/constructive/destructive styling on ... - https://phabricator.wikimedia.org/T110051#3812108 [12:12:17] (03PS1) 10Zfilipin: Update RuboCop Ruby gem [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/395509 (https://phabricator.wikimedia.org/T180878) [12:38:24] 10Collaboration-Team-Triage, 10StructuredDiscussions: Support set auto-close topic - https://phabricator.wikimedia.org/T182025#3812315 (10YFdyh000) I think keeping topic opens seems means that it still needs to be discussed. And, closing an old topic will update its last activity date, which may be a issue to... [17:26:03] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-RC-Page: "Legend" retains some space if "Group results by change" is enabled - https://phabricator.wikimedia.org/T174728#3813629 (10Petar.petkovic) [17:39:23] (03CR) 10Jforrester: [C: 032] Update RuboCop Ruby gem [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/395509 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [17:42:02] (03Merged) 10jenkins-bot: Update RuboCop Ruby gem [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/395509 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [17:43:54] 10Collaboration-Team-Triage, 10Notifications, 10OOjs-UI, 10Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779#3813695 (10Volker_E) @Pginer-WMF The best place would right now still be M229. It's not perfect from a process perspective com... [19:04:42] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10Chinese-Sites, and 2 others: "Related changes" can't work at zhwiki - https://phabricator.wikimedia.org/T178293#3813932 (10Catrope) The bug as originally reported should be mostly fixed this week, by T181100#3790... [19:24:36] 10Collaboration-Team-Triage, 10Notifications, 10StructuredDiscussions: Structured discussions email notification about a change on a page description: change "view page" to "view changes" as the primary link - https://phabricator.wikimedia.org/T177750#3814011 (10Trizek-WMF) @Pginer-WMF, an idea on how we can... [20:38:35] 10Collaboration-Team-Triage, 10Notifications, 10StructuredDiscussions: Structured discussions email notification about a change on a page description: change "view page" to "view changes" as the primary link - https://phabricator.wikimedia.org/T177750#3668691 (10Catrope) Some additional information/context:... [20:41:52] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: Integrate 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3814244 (10Etonkovidova) [21:07:19] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: Integrate 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3488227 (10Etonkovidova)... [21:27:05] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Adjust and secure spacing between New Filters tools and results areas - https://phabricator.wikimedia.org/T182149#3814361 (10jmatazzoni) [21:27:39] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters: Adjust and secure spacing between New Filters tools and results areas - https://phabricator.wikimedia.org/T182149#3814375 (10jmatazzoni) [21:28:58] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters: Adjust and secure spacing between New Filters tools and results areas - https://phabricator.wikimedia.org/T182149#3814361 (10jmatazzoni) [22:44:42] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: Integrate 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3814521 (10jmatazzoni) @S... [23:01:12] (03PS1) 10Mooeypoo: [EXPERIMENTAL] Using OOUI lazy-load for rudamentary reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/395664 [23:01:24] (03CR) 10jerkins-bot: [V: 04-1] [EXPERIMENTAL] Using OOUI lazy-load for rudamentary reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/395664 (owner: 10Mooeypoo) [23:08:21] 10MediaWiki-Recent-changes, 10Timeless: RecentChanges legend overlaps actual RecentChanges in Timeless skin - https://phabricator.wikimedia.org/T182156#3814578 (10Legoktm) [23:28:19] mooeypoo: or RoanKattouw: I'm currently looking at https://phabricator.wikimedia.org/T110051 [23:28:41] identified flow_moderation_actions_list.partial.handlebars as underlying location for overhaul [23:29:16] 10Collaboration-Team-Triage, 10Notifications: page level opt-in and opt-out for "a link was made" echo notification - https://phabricator.wikimedia.org/T179678#3814647 (10jmatazzoni) [23:29:18] 10Collaboration-Team-Triage, 10Notifications: Allow excluding pages from the page links notifications - https://phabricator.wikimedia.org/T46787#3814650 (10jmatazzoni) [23:30:13] I see that this partial.handlebar is used in 3 places: additionally to topic_titlebar in history line and post actions [23:30:30] where can I see those IRL? [23:32:58] in order to identify if it's safe to remove mw-ui- flages throughout the code or not…? [23:33:07] mooeypoo: RoanKattouw: ^ [23:36:18] Flow/handlebars [23:36:55] Volker_E, is this for the side menu per title/post ? [23:37:21] mooeypoo: the image in the task yes [23:37:38] but those actions are used in the two other handlebars mentioned above as well [23:38:05] and I couldn't find them when looking for example at https://www.mediawiki.org/wiki/Design/Link_colors [23:38:11] eh [23:38:14] eurgh sorry, wrong link [23:38:21] Flow frontend is a mess, hang on [23:38:27] https://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/CSS [23:40:12] flow_moderation_actions_list.handlebars [23:40:40] I'm not arguing, I'm trying to avoid sending you to the pit of despair that is the /handlebars folder [23:40:59] The structure of that menu is there ^ [23:41:53] mooeypoo: yup, that's already clear to me [23:42:08] mooeypoo: I need to see history line and post actions in action [23:42:49] mooeypoo: I've found a hilariously horrible bug as well, you'll like that one [23:43:26] What do you mean? You can't see them in Flow ? [23:43:49] mooeypoo: flow_history_line.partial.hb & flow_post_actions.partial.handlebars also use the same actions [23:44:25] if I'm going to throw away the -progressive/-destructive classes in the actions, I might negatively influence the two above [23:44:30] therefore I need to see them in action [23:44:35] before doing so [23:44:35] hm [23:44:41] but I don't find them [23:44:52] in GUI [23:44:54] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-RC-Page: [minor] Truncate/filter Tag filter descriptions - https://phabricator.wikimedia.org/T179626#3814717 (10jmatazzoni) [23:45:31] Volker_E, it's the (hide| delete|etc) line at the end of each history line [23:45:42] https://www.mediawiki.org/w/index.php?title=Talk:Structured_Discussions&action=history [23:46:14]
    {{ > flow_moderation_actions_list .... }}
[23:46:24] if you look inside that UL, these are the moderation links [23:46:53] they look different because the same partial should actually be 2 [23:47:14] see the partial has one rendering for topic, and one for history [23:47:32] mooeypoo: oh wow [23:47:44] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Special:Contributions/newbies should go to RC filters to provide more options - https://phabricator.wikimedia.org/T179137#3814730 (10jmatazzoni) The Triage team says that the problem here is that adding the New Filters UX to the Contri... [23:47:53] I'm eagerly looking forward to your rewrite here :P [23:48:20] So are we... [23:48:31] This is also why we're not "fixing", we're rewriting. [23:49:10] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter on age in new recent changes - https://phabricator.wikimedia.org/T178902#3814739 (10jmatazzoni) We wanted to do this but ran out of time. There are designs for how to implement—though we might have to go back to putting the # of days to se... [23:50:29] 10Collaboration-Team-Triage, 10Notifications: Text editing without new user notice creates notification - https://phabricator.wikimedia.org/T178887#3814743 (10jmatazzoni) [23:50:32] 10Collaboration-Team-Triage, 10Notifications: Double notification on the same text during section splitting - https://phabricator.wikimedia.org/T168435#3814746 (10jmatazzoni) [23:52:34] mooeypoo: yeah, seriously [23:54:31] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10UI-Standardization, 10UI-Standardization-Kanban, 10WorkType-NewFunctionality: Reconsider Flow's use of .mw-ui-hovericon (dropdown menu items that gain progressive/constructive/destructive styling on ... - https://phabricator.wikimedia.org/T110051#3814755