[03:27:29] (03PS1) 10Reedy: Update zordius/lightncandy v0.23 to v1.1.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 [03:31:15] (03CR) 10jerkins-bot: [V: 04-1] Update zordius/lightncandy v0.23 to v1.1.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 (owner: 10Reedy) [03:37:20] (03PS2) 10Reedy: Update zordius/lightncandy v0.23 to v1.1.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 [03:40:15] 10Collaboration-Team-Triage, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3807771 (10Reedy) Ok, so I noticed @Aleksey_WMDE actually did some work on the mw core patch, and made it work. Yay #st... [03:41:36] (03CR) 10jerkins-bot: [V: 04-1] Update zordius/lightncandy v0.23 to v1.1.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 (owner: 10Reedy) [03:42:59] (03PS3) 10Reedy: Update TemplateHelper for zordius/lightncandy upgrade [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 (https://phabricator.wikimedia.org/T121947) [03:46:52] 10Collaboration-Team-Triage, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3807773 (10Reedy) Handlebars recompiled, and the diffs look sane enough to the untrained eye Unit tests currently faili... [03:47:19] (03CR) 10jerkins-bot: [V: 04-1] Update TemplateHelper for zordius/lightncandy upgrade [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 (https://phabricator.wikimedia.org/T121947) (owner: 10Reedy) [03:57:19] 10Collaboration-Team-Triage, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3807775 (10Reedy) ``` 1) Flow\Tests\Collection\PostCollectionTest::testGetCollection Error: Function name must be a stri... [08:36:41] 10Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 10Documentation, 10Google-Code-in-2017: Create a documentation page about Thanks - https://phabricator.wikimedia.org/T181502#3807929 (10Trizek-WMF) No. The student hasn't used that feature and didn't took my advice into... [09:20:20] 10Collaboration-Team-Triage, 10StructuredDiscussions: Have Flow support __INDEX__ and __NOINDEX__ per-page directives - https://phabricator.wikimedia.org/T122252#3807987 (10Trizek-WMF) [[ https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Le_Bistro/1_d%C3%A9cembre_2017#Flow | New request ]]. [09:29:13] 10Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Epic: Graduate 'New filters for edit review' out of beta, making it standard on all wikis - https://phabricator.wikimedia.org/T170501#3807998 (10Aklapper) [09:34:48] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Notifications, 10New-Editor-Experiences: Surface the impact of the initial successful edits - https://phabricator.wikimedia.org/T180697#3808009 (10Aklapper) not #tracking by definition, hence removing that tag [09:35:21] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10User-notice-collaboration: Expose filter combinations for the main review activities - https://phabricator.wikimedia.org/T174800#3808011 (10Aklapper) not #tracking by definition, hence removing that tag [10:26:54] 10Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 10Documentation, 10Google-Code-in-2017: Create a documentation page about Thanks - https://phabricator.wikimedia.org/T181502#3808216 (10Aklapper) Meh, sorry. Followup task? :) [10:46:53] 10Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 10Documentation, 10Google-Code-in-2017: Create a documentation page about Thanks - https://phabricator.wikimedia.org/T181502#3808265 (10Trizek-WMF) I'm on it! :) [11:47:18] 10Collaboration-Team-Triage, 10Notifications, 10Collaboration-Community-Engagement, 10Documentation, 10Google-Code-in-2017: Create a documentation page about Thanks - https://phabricator.wikimedia.org/T181502#3808483 (10Trizek-WMF) Imported as https://codein.withgoogle.com/tasks/4948709894782976/ [14:18:26] 10Collaboration-Team-Triage, 10StructuredDiscussions: Integration of Structured discussions and mailing lists - https://phabricator.wikimedia.org/T181994#3809011 (10Trizek-WMF) [14:46:54] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10StructuredDiscussions, 10Browser-Tests, 10Patch-For-Review, and 2 others: Flow: Migrate browser tests from Ruby to node.js - https://phabricator.wikimedia.org/T174591#3809155 (10zeljkofilipin) a:05zeljkofilipin>03None [15:39:04] (03PS1) 10Zfilipin: Update RuboCop Ruby gem [extensions/Echo] - 10https://gerrit.wikimedia.org/r/395019 (https://phabricator.wikimedia.org/T180878) [15:56:19] (03PS1) 10Zfilipin: Update RuboCop Ruby gem [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/395026 (https://phabricator.wikimedia.org/T180878) [16:00:11] 10Collaboration-Team-Triage, 10StructuredDiscussions: A user cannot hide Structured Discussion topics despite having the "flow-hide" permission - https://phabricator.wikimedia.org/T181765#3809387 (10Kghbln) @Aklapper Thanks a lot for pinning down the issue. :) [16:02:09] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 2 others: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3809398 (10jmatazzoni) [16:02:13] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 3 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3809397 (10jmatazzoni) 05Open>03Resolved [16:52:24] (03CR) 10Hashar: [C: 032] Update RuboCop Ruby gem [extensions/Echo] - 10https://gerrit.wikimedia.org/r/395019 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [16:53:23] (03CR) 10Hashar: "The tests are being removed with https://gerrit.wikimedia.org/r/#/c/393917/ so I guess there is no need to update rubocop ?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393918 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [16:54:11] (03CR) 10Hashar: [C: 032] Update RuboCop Ruby gem [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/395026 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [16:54:49] (03CR) 10Jforrester: "> The tests are being removed with https://gerrit.wikimedia.org/r/#/c/393917/ so I guess there is no need to update rubocop ?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/393918 (https://phabricator.wikimedia.org/T180878) (owner: 10Jforrester) [17:00:55] (03Merged) 10jenkins-bot: Update RuboCop Ruby gem [extensions/Echo] - 10https://gerrit.wikimedia.org/r/395019 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [17:05:52] (03Merged) 10jenkins-bot: Update RuboCop Ruby gem [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/395026 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [17:17:02] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Recent changes don't show any results when it should - https://phabricator.wikimedia.org/T182010#3809843 (10Stryn) [17:40:39] 10Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10Easy, 10Patch-For-Review: Create a "Watching and notifications" tab in MediaWiki core - https://phabricator.wikimedia.org/T65577#3809951 (10Trizek-WMF) @Framawiki, if you are working on that task, please claim it. :) Otherwise, please move it bac... [18:09:40] 10Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10Easy, 10Patch-For-Review: Create a "Watching and notifications" tab in MediaWiki core - https://phabricator.wikimedia.org/T65577#3810056 (10Framawiki) >>! In T65577#3809951, @Trizek-WMF wrote: > @Framawiki, if you are working on that task, please... [19:32:45] 10Collaboration-Team-Triage, 10MediaWiki-extensions-LiquidThreads, 10StructuredDiscussions: Flow test failures locally with LQT enabled - https://phabricator.wikimedia.org/T182024#3810396 (10Reedy) [19:32:55] You're welcome. [19:34:45] 10Collaboration-Team-Triage, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3810415 (10Reedy) Other test failures seem to be fixable/unrelated, see T182024 [19:39:56] 10Collaboration-Team-Triage, 10StructuredDiscussions: Support set auto-close topic - https://phabricator.wikimedia.org/T182025#3810426 (10YFdyh000) [19:42:39] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Recent changes don't show any results when it should - https://phabricator.wikimedia.org/T182010#3809843 (10Catrope) The results appear at first, but are then eaten. That's usually caused by an unclosed or unopened HTML tag in a community-customi... [19:48:03] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Recent changes don't show any results when it should - https://phabricator.wikimedia.org/T182010#3810495 (10Catrope) 05Open>03Resolved a:03Catrope Fixed by https://fi.wiktionary.org/w/index.php?title=J%C3%A4rjestelm%C3%A4viesti%3ARecentchan... [19:48:31] 10Collaboration-Team-Triage, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3810501 (10Reedy) ``` #!/usr/bin/env php Using PHP 7.1.11-0ubuntu0.17.10.1 PHPUnit 4.8.36 by Sebastian Bergmann and cont... [19:55:01] 10Collaboration-Team-Triage, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3810522 (10Reedy) So on the new version `var_dump( $filenames ); die();` gives ``` /var/www/wiki/mediawiki/extensions/F... [20:09:43] 10Collaboration-Team-Triage, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3810600 (10Reedy) Ah. It's not being wrapped in a closure and stuff... [20:20:38] (03PS4) 10Reedy: Update TemplateHelper for zordius/lightncandy upgrade [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 (https://phabricator.wikimedia.org/T121947) [20:26:19] (03CR) 10jerkins-bot: [V: 04-1] Update TemplateHelper for zordius/lightncandy upgrade [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 (https://phabricator.wikimedia.org/T121947) (owner: 10Reedy) [20:27:45] (03PS5) 10Reedy: Update TemplateHelper for zordius/lightncandy upgrade [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 (https://phabricator.wikimedia.org/T121947) [20:29:50] (03PS6) 10Reedy: Update TemplateHelper for zordius/lightncandy upgrade [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 (https://phabricator.wikimedia.org/T121947) [20:33:55] (03CR) 10jerkins-bot: [V: 04-1] Update TemplateHelper for zordius/lightncandy upgrade [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394911 (https://phabricator.wikimedia.org/T121947) (owner: 10Reedy) [20:41:14] 10Collaboration-Team-Triage, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10StructuredDiscussions: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3810675 (10Reedy) So if we shove `" Anyone actually care about handlebars and lightncandy and stuff? :P [20:57:43] legoktm, can you re-verify that your concerns were addressed re https://gerrit.wikimedia.org/r/#/c/388264/23 [20:57:46] we want to merge it [20:58:47] I submitted the comments I had on the fix, but they're mostly "done"s [21:00:35] mooeypoo: yep, lgtm [21:05:25] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Integrate 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3810780 (10SBisson) I had to compromise with the TitleSearch component that already exist so... [21:33:04] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Add a pushpin icon to make the default filter status apparent in Active filter area - https://phabricator.wikimedia.org/T174501#3810858 (10Etonkovidova) [22:19:45] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Reading-Web-Local-Wiki-Issues: Recent changes don't show any results when it should - https://phabricator.wikimedia.org/T182010#3810930 (10Aklapper) [22:20:30] 10Collaboration-Team-Triage, 10StructuredDiscussions: Support set auto-close topic - https://phabricator.wikimedia.org/T182025#3810933 (10Aklapper) Is this a software feature request? [22:29:51] 10Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10Easy, 10Patch-For-Review: Create a "Watching and notifications" tab in MediaWiki core - https://phabricator.wikimedia.org/T65577#3810955 (10Aklapper) @Framawiki: A 3 year old patch that does not merge and needs manual rebasing does not mean that... [23:25:06] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] invert=1 added to url if Namespace 'Exclude selected' button is clicked - https://phabricator.wikimedia.org/T182045#3811051 (10Etonkovidova) [23:48:34] 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), 10Patch-For-Review: Only add highlight/toggle states conditionally to the saved queries - https://phabricator.wikimedia.org/T177009#3811090 (...